Date: Mon, 7 Apr 2014 15:45:04 -0700 From: <dteske@FreeBSD.org> To: <dteske@FreeBSD.org>, "'Hiroki Sato'" <hrs@FreeBSD.org> Cc: jhellenthal@dataix.net, rc@FreeBSD.org, dteske@freebsd.org Subject: RE: network.subr _aliasN handling Message-ID: <0d7c01cf52b3$05a02a40$10e07ec0$@FreeBSD.org> In-Reply-To: <069f01cf4d14$0ff03980$2fd0ac80$@FreeBSD.org> References: <04c901cf4c5d$a6a4a030$f3ede090$@FreeBSD.org> <0EBE3981-DC85-414D-85B8-7638F172040A@dataix.net> <04f701cf4c85$d1929680$74b7c380$@FreeBSD.org> <20140331.121757.1100840815853109946.hrs@allbsd.org> <069f01cf4d14$0ff03980$2fd0ac80$@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> -----Original Message-----
> From: dteske@FreeBSD.org [mailto:dteske@FreeBSD.org]
> Sent: Monday, March 31, 2014 12:05 PM
> To: 'Hiroki Sato'; dteske@FreeBSD.org
> Cc: jhellenthal@dataix.net; lists@jnielsen.net; rc@FreeBSD.org
> Subject: RE: network.subr _aliasN handling
>
> > -----Original Message-----
> > From: Hiroki Sato [mailto:hrs@FreeBSD.org]
> > Sent: Sunday, March 30, 2014 8:18 PM
> > To: dteske@FreeBSD.org
> > Cc: jhellenthal@dataix.net; lists@jnielsen.net; rc@FreeBSD.org
> > Subject: Re: network.subr _aliasN handling
> >
> > <dteske@FreeBSD.org> wrote
> > in <04f701cf4c85$d1929680$74b7c380$@FreeBSD.org>:
> >
> > dt> But that wouldn't have deterred me. 30+ days of silence is
> > dt> equivalent to acceptance -- just that I had noticed that the patch
> > dt> could be expanded to include mdconfig{,2} scripts. Was going to
> > dt> wait a full day to see if anyone balked at the expansion to
> > dt> include mdconfig{,2} and then move forward.
> >
> > I like the direction in general, but there are two more comments:
> >
Committed change:
http://svnweb.freebsd.org/changeset/base/264243
> > 1. sort(1) cannot be used [snip]
>
> Problem solved.
Ended up beefing up the internal sort function (sort_lite()).
Gave it some more options and regression tested it against
several inputs and flags to always produce the same output
as sort(1).
> > 2. Please put the normalization part into a function and use it in
> > get_if_var(), too. Adding another code for the same functionality
> > makes maintenance difficult.
Aforementioned enhancements to address that included
in mentioned SVN r264243.
--
Devin
_____________
The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0d7c01cf52b3$05a02a40$10e07ec0$>