Date: Sat, 10 May 2003 00:40:21 +0200 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Lukas Ertl <l.ertl@univie.ac.at> Cc: freebsd-fs@freebsd.org Subject: Re: newfs: useless/bogus check if new last block can be accessed? Message-ID: <15610.1052520021@critter.freebsd.dk> In-Reply-To: Your message of "Sat, 10 May 2003 00:31:15 %2B0200." <20030510002107.T638@korben.in.tern>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20030510002107.T638@korben.in.tern>, Lukas Ertl writes: >I don't think it does any harm to keep it (WRT to getting a working >filesystem), but since I don't see how it would signal an error (and this >is why I posted the question) I'd vote for removing the check. > >And while we're here: shouldn't wtfs() actually give a return value and >not be just static void? (In terms of: "be a good programmer and check the >return values of your syscalls...") I think it's called often enough in >newfs to qualify for a check :-) Get in touch with jmallett@freebsd.org who has been actively trying to improve the UFS/FFS tools for some time, it sounds like the two of you are on the same page :-) -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?15610.1052520021>