Date: Wed, 27 Jan 1999 20:24:30 -0700 From: "Justin T. Gibbs" <gibbs@plutotech.com> To: Matt Dillon <dillon@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/eisa ahb.c Message-ID: <199901280332.UAA25969@pluto.plutotech.com> In-Reply-To: Your message of "Wed, 27 Jan 1999 17:33:03 PST." <199901280133.RAA40079@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
>dillon 1999/01/27 17:33:03 PST > > Modified files: > sys/i386/eisa ahb.c > Log: > Fix parenthesization, but the code still looks wrong. > > Revision Changes Path > 1.5 +7 -2 src/sys/i386/eisa/ahb.c There certainly was a bug there, but your commit made the driver non-functional. Why not pass your concern on to the author/maintainer of the driver instead of committing something that does not address the problem? If I had missed your checkin mail, I would never have noticed the bug especially after you cleared the compiler warning without really fixing the problem. I've committed a proper fix. -- Justin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901280332.UAA25969>