Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 12 Mar 2001 11:21:49 +0100 (CET)
From:      Luigi Rizzo <luigi@info.iet.unipi.it>
To:        Jeroen Ruigrok/Asmodai <asmodai@wxs.nl>
Cc:        Josef Karthauser <joe@tao.org.uk>, Ian Dowse <iedowse@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/sys/netinet ip_output.c
Message-ID:  <200103121021.LAA87908@info.iet.unipi.it>
In-Reply-To: <20010312104538.B45619@daemon.ninth-circle.org> from Jeroen Ruigrok/Asmodai at "Mar 12, 2001 10:45:38 am"

next in thread | previous in thread | raw e-mail | index | archive | help
> >it is just another example that for some things the "commit to -current
> >first, wait at least 3 days before MFC" is totally useless and if
> >we want to have these things tested we need to commit them where
> >they are used.
> 
> No, it is not useless.  It used to work perfectly.

i said "for some things". I should have added "now".

You mention another example where broken code (with insufficient
protection for critical sections) can happily live untested in
-current for ages. As you point out, having two very different versions
of the system (one of which is at the moment hard to use)
is the main reason for the above. Once things will converge,
then the testing on -current will work perfectly
again. At the moment, it just does not in many cases, and 
I think it is better that committers realize this, in the interest
of code quality.

	cheers
	luigi


> However we are now in a phase, as with 3-STABLE and 4-CURRENT, that we
> have significant changes in the system which impose a rather heavy
> burden on the developers to keep both systems working the way it should.
> 
> For example, we now have the spls are worthless in CURRENT since they're
> no-ops, which means they might get overlooked easily when doing MFC's.
> I think someone already made that unfortunate mistake.
> 
> Furthermore, although I am happy to see the work on SMPng being done, we
> have had, or at least I, weeks in which I was chasing down bugs in the
> system itself before I could even start work on the things I wanted to
> work on.
> 
> Although I am still a bit reluctant to say it, I am starting to see more
> and more truth in Matthew Dillon's statement that for anything non-SMPng
> related 4-STABLE might be a more worthwhile development system at
> present.
> 
> And I am sure you all can follow all the lines of thought emerging from
> these statements in both the pro and con ways.
> 
> -- 
> Jeroen Ruigrok vd Werven/Asmodai    asmodai@[wxs.nl|bart.nl|freebsd.org]
> Documentation nutter/C-rated Coder BSD: Technical excellence at its best  
> 	  D78D D0AD 244D 1D12 C9CA  7152 035C 1138 546A B867
> I'm a child of the air, I'm a witch of the wind...
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe cvs-all" in the body of the message
> 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200103121021.LAA87908>