Date: Sun, 13 Jan 2002 02:39:34 +0000 From: Ian Dowse <iedowse@maths.tcd.ie> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Alfred Perlstein <bright@mu.org>, "Alan L. Cox" <alc@imimic.com>, FreeBSD-hackers@FreeBSD.ORG Subject: Re: Need review of NFS patch set for server .. missing/wrong vput() issues Message-ID: <200201130239.aa98693@salmon.maths.tcd.ie> In-Reply-To: Your message of "Sat, 12 Jan 2002 18:01:33 PST." <200201130201.g0D21Xh49451@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200201130201.g0D21Xh49451@apollo.backplane.com>, Matthew Dillon wri tes: > Ok, cool. I'll get the commit gears started for the > first part of the patch. FYI, I was able to reproduce this and confirm that the first part of your patch fixes it. All that it takes is for the mknod to fail because the name already exists, but normally this is masked by the client because it does an NFSPROC_ACCESS RPC first. Another nasty bug in nfsrv_mknod that I just spotted is that it doesn't override the S_IFMT bits of the file mode supplied by the client. It should be completely ignoring those bits, and using only the node-type it has in the `vtyp' variable. I just managed to create a node that makes ls say "Bad file descriptor" by passing in a type of NFFIFO and a mode of 0... Ian To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi? <200201130239.aa98693>