Date: Thu, 4 Apr 2002 15:20:29 -0800 From: "David O'Brien" <obrien@FreeBSD.org> To: Mikhail Teterin <mi@aldan.algebra.com> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/yacc main.c Message-ID: <20020404152029.A81900@dragon.nuxi.com> In-Reply-To: <200204042243.g34MhonF007316@aldan.algebra.com>; from mi@aldan.algebra.com on Thu, Apr 04, 2002 at 05:43:50PM -0500 References: <200204042215.g34MFDb67996@freefall.freebsd.org> <200204042243.g34MhonF007316@aldan.algebra.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 04, 2002 at 05:43:50PM -0500, Mikhail Teterin wrote: > > Use strlen() rather than magic number. > [...] > > Beware of strlen :) The magic number was just a ``sizeof temp_form'' -- > computed at the code-writing time. Your change moved the computation to > run-time, which, IMHO, is too far. There is nothing wrong with run-time checks. You are also missing the point which is to reduce differences with *BSD, not add more. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020404152029.A81900>