Date: Wed, 29 May 2002 15:22:00 -0700 From: "J. Mallett" <jmallett@FreeBSD.org> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: David O'Brien <obrien@FreeBSD.ORG>, Julian Elischer <julian@elischer.org>, John Baldwin <jhb@FreeBSD.ORG>, FreeBSD current users <current@FreeBSD.ORG> Subject: Re: Seeking OK to commit KSE MIII Message-ID: <20020529152159.A82752@FreeBSD.ORG> In-Reply-To: <200205292007.g4TK71YD062671@apollo.backplane.com>; from dillon@apollo.backplane.com on Wed, May 29, 2002 at 01:07:01PM -0700 References: <XFMail.20020529124710.jhb@FreeBSD.org> <Pine.BSF.4.21.0205291057020.12315-100000@InterJet.elischer.org> <20020529124434.A2156@dragon.nuxi.com> <200205292007.g4TK71YD062671@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
* From Matthew Dillon <dillon@apollo.backplane.com> > > No hold on a minute. Some of us believe that adding those extra > braces and parenthesis makes the code a whole lot more readable. they > are NOT gratuitous in the least, certainly not from my point of view! > When you make the code more readable, you introduce further diffs, and you leave no reference against the original code of where the functional changes are. Either make the "base" code cleaned up by committing non-functional changes first, or commit against the "base" code your functional changes, and then clean it up. Otherwise, it's a pain in the ass to sort things out. And for what it's worth, I'm all for readability improvements in our code, I just also like to go and view diffs sometimes and try to figure out what's changed. But I think you're also right on the rule of thumb thing, if someone does not want to do this favor to everyone who might want to read diffs or annotate changes to the code and get something meaningful, that's fine. I've done it plenty of times myself. However, I tend to do that locally first, and then commit the harmless things as I go. If you ever look through one of my WIP repos (~jmallett/cvs on Freefall currently holds one, my sccs repo, as I did and do believe others should have easy access to it), I tend to piggyback a lot of stylistic nits, etc. as I go... But I don't think it's fair to do the merge like you're saying... But back to where this started, it's just a rule of thumb. Furthermore, it'd be nice if as people made stylistic changes for outside projects they committed them to the central repository, where applicable. Anyway, I'm out of paint. Good day. -- J. Mallett <jmallett@FreeBSD.org> FreeBSD: The Power To Serve To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020529152159.A82752>