Date: Sat, 29 Jun 2002 11:12:03 -0700 From: Luigi Rizzo <luigi@FreeBSD.org> To: "David O'Brien" <obrien@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/ipfw Makefile ipfw2.c src/sys/netinet ip_dummynet.c ip_fw.h ip_fw2.c src/sys/conf files src/lib/libalias alias_db.c Message-ID: <20020629111203.B73787@iguana.icir.org> In-Reply-To: <20020629094456.C82957@dragon.nuxi.com>; from obrien@FreeBSD.org on Sat, Jun 29, 2002 at 09:44:56AM -0700 References: <200206272302.g5RN2IP5044770@freefall.freebsd.org> <20020629094456.C82957@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
For the kernel part i prefer to keep the new name (it is an entirely different beast) and nuke the old file. For the userland part, but i am considering moving most of the functionality into a library or something like that, which will accept a string and parse&translate it into an appropriate data structure to be passed to the setsockopt(), so that other programs (such as libalias) do not have to redo the same. This means a split of the code in at least 2 files, so let me wait a bit to decide on the naming issues. thanks luigi On Sat, Jun 29, 2002 at 09:44:56AM -0700, David O'Brien wrote: > On Thu, Jun 27, 2002 at 04:02:18PM -0700, Luigi Rizzo wrote: > > The code is almost entirely new (and I believe I have written the > > vast majority of those sections which were taken from the former > > ip_fw.c), so rather than modifying the old ip_fw.c I decided to > > create a new file, sys/netinet/ip_fw2.c . Same for the user > > interface, which is in sbin/ipfw/ipfw2.c (it still compiles to > > /sbin/ipfw). The old files are still there, and will be removed > > in due time. > > Please just repo copy the old files to ipfw-old.c if you need to keep > them around, and commit your new version on-top of the old. History is > much better preserved that way -- along with keeping with normal > conventions of source is named same as command as same as src directory. For the To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020629111203.B73787>