Date: Sat, 10 May 2003 00:47:26 +0200 (CEST) From: Lukas Ertl <l.ertl@univie.ac.at> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: jmallett@freebsd.org Subject: Re: newfs: useless/bogus check if new last block can be accessed? Message-ID: <20030510004537.H638@korben.in.tern> In-Reply-To: <15610.1052520021@critter.freebsd.dk> References: <15610.1052520021@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 10 May 2003, Poul-Henning Kamp wrote: > In message <20030510002107.T638@korben.in.tern>, Lukas Ertl writes: > > >I don't think it does any harm to keep it (WRT to getting a working > >filesystem), but since I don't see how it would signal an error (and thi= s > >is why I posted the question) I'd vote for removing the check. > > > >And while we're here: shouldn't wtfs() actually give a return value and > >not be just static void? (In terms of: "be a good programmer and check t= he > >return values of your syscalls...") I think it's called often enough in > >newfs to qualify for a check :-) > > Get in touch with jmallett@freebsd.org who has been actively trying to > improve the UFS/FFS tools for some time, it sounds like the two of you > are on the same page :-) :-) Ok, although I guess she's on this list anyway, I'm CC'ing her and hope she's interested if I can come up with some fixes... regards, le --=20 Lukas Ertl eMail: l.ertl@univie.ac.at UNIX-Systemadministrator Tel.: (+43 1) 4277-14073 Zentraler Informatikdienst (ZID) Fax.: (+43 1) 4277-9140 der Universit=E4t Wien http://mailbox.univie.ac.at/~le/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030510004537.H638>