Date: Tue, 8 Jul 2003 15:46:49 -0500 From: Sean Kelly <smkelly@FreeBSD.org> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: current@freebsd.org Subject: Re: GEOM panic Message-ID: <20030708204649.GA19571@edgemaster.zombie.org> In-Reply-To: <3339.1057696547@critter.freebsd.dk> References: <3F0B28F1.4060702@t-online.de> <3339.1057696547@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 08, 2003 at 10:35:47PM +0200, Poul-Henning Kamp wrote: > > Can you try this patch ? ... > diff -u -r1.28 geom_dump.c > --- geom_dump.c 11 Jun 2003 06:49:15 -0000 1.28 > +++ geom_dump.c 8 Jul 2003 20:00:45 -0000 ... > @@ -162,6 +164,8 @@ > sbuf_printf(sb, "\t <provider ref=\"%p\"/>\n", cp->provider); > sbuf_printf(sb, "\t <mode>r%dw%de%d</mode>\n", > cp->acr, cp->acw, cp->ace); > + if (cp->geom->flags & G_GEOM_WITHER) > + ; > if (cp->geom->dumpconf != NULL) { > sbuf_printf(sb, "\t <config>\n"); ... Should that be "else if ((cp->geom->dumpconf != NULL)"? I don't know the code, but I'm basing this question off of what is below in the patch: > @@ -182,7 +186,9 @@ > sbuf_printf(sb, "\t <mediasize>%jd</mediasize>\n", > (intmax_t)pp->mediasize); > sbuf_printf(sb, "\t <sectorsize>%u</sectorsize>\n", pp->sectorsize); > - if (pp->geom->dumpconf != NULL) { > + if (pp->geom->flags & G_GEOM_WITHER) > + ; > + else if (pp->geom->dumpconf != NULL) { // <---------- HERE > sbuf_printf(sb, "\t <config>\n"); > pp->geom->dumpconf(sb, "\t ", pp->geom, NULL, pp); > sbuf_printf(sb, "\t </config>\n"); -- Sean Kelly | PGP KeyID: D2E5E296 smkelly@FreeBSD.org | http://www.sean-kelly.org/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030708204649.GA19571>