Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 9 Feb 2004 13:24:16 -0500
From:      Andrew J Caines <A.J.Caines@halplant.com>
To:        freebsd-ports@freebsd.org
Cc:        Norikatsu Shigemura <nork@FreeBSD.org>
Subject:   Re: www/linux-plugginwrapper broken
Message-ID:  <20040209182416.GC2860@hal9000.halplant.com>
In-Reply-To: <4027A81D.6000808@comcast.net>
References:  <4027A81D.6000808@comcast.net>

next in thread | previous in thread | raw e-mail | index | archive | help
Keith,
> "Makefile", line 59: warning: String comparison operator should be 
> either == or !=
> "Makefile", line 59: Malformed conditional ((${OSVERSION} < 490102 || 
> ${OSVERSION} >= 500000 && ${OSVERSION} < 501107) && 
> !defined(PACKAGE_BUILDING))
> "Makefile", line 73: if-less endif
> "Makefile", line 73: Need an operator
> make: fatal errors encountered -- cannot continue

I get the same result for the 20040208 version.

> Would really appreciate if someone could fix this. Would greatly like to 
> use this port.

The maintainer has been responsive before, so I suspect he'll have it
fixed soon. Until then, I offer my weak make-fu fix which gets the build
going (though I've not tested it any further):

----8<----
--- Makefile.old        Mon Feb  9 13:17:24 2004
+++ Makefile    Mon Feb  9 13:17:18 2004
@@ -56,7 +56,8 @@
 CFLAGS+=       -DDEBUG=1
 .endif
 
-.if            (${OSVERSION} < 490102 || ${OSVERSION} >= 500000 && ${OSVERSION} < 501107) && !defined(PACKAGE_BUILDING)
+.if            ${OSVERSION} < 490102 || ${OSVERSION} >= 500000 && ${OSVERSION} < 501107
+.if            !defined(PACKAGE_BUILDING)
 pre-everything::
        @if ! strings ${RTLD} | ${GREP} libmap.conf > /dev/null 2>&1; then \
                ${ECHO_MSG} 'Please enable libmap.conf(5) feature for rtld(1).'; \
@@ -70,6 +71,7 @@
                ${ECHO_MSG} '   Please see /usr/src/libexec/rtld-elf/Makefile.'; \
                ${FALSE}; \
        fi
+.endif
 .endif
 
 post-build:
----8<----

This looks like a case of an int and string conparison in one ".if"
causing the problem, so I changed it to two ".if"s.


-Andrew-
-- 
 _______________________________________________________________________
| -Andrew J. Caines-   Unix Systems Engineer   A.J.Caines@halplant.com  |
| "They that can give up essential liberty to obtain a little temporary |
|  safety deserve neither liberty nor safety" - Benjamin Franklin, 1759 |



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040209182416.GC2860>