Date: Fri, 7 Dec 2007 00:04:18 +0100 From: Olivier Houchard <mlfbsd@ci0.org> To: Mark Tinguely <tinguely@casselton.net> Cc: freebsd-arm@freebsd.org Subject: Re: ARM pmap_enter_pv question Message-ID: <20071206230417.GA7366@ci0.org> In-Reply-To: <200712062158.lB6LwL1D089098@casselton.net> References: <200712062158.lB6LwL1D089098@casselton.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 06, 2007 at 03:58:21PM -0600, Mark Tinguely wrote:
>
> in pmap_enter_pv(), it seems to me there is an "else" missing:
>
> if (pm == pmap_kernel()) {
> if (flags & PVF_WRITE)
> pg->md.krw_mappings++;
> else
> pg->md.kro_mappings++;
> } <<<< is there a "else" missing?
> if (flags & PVF_WRITE)
> pg->md.urw_mappings++;
> else
> pg->md.uro_mappings++;
>
> I don't think it will effect any caching settings.
>
You're right, I wonder where this else went, it must have been there,
because this code comes from NetBSD, and NetBSD has it.
Thanks a lot !
Olivier
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071206230417.GA7366>