Date: Thu, 15 Jul 2010 22:01:48 +0200 (CEST) From: Oliver Fromme <olli@lurza.secnetix.de> To: jkim@FreeBSD.org (Jung-uk Kim) Cc: freebsd-stable@FreeBSD.org, Andriy Gapon <avg@icyb.net.ua> Subject: Re: 8.1-PRERELEASE: CPU packages not detected correctly Message-ID: <201007152001.o6FK1mGq088944@lurza.secnetix.de> In-Reply-To: <201007151507.33998.jkim@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Jung-uk Kim wrote: > On Thursday 15 July 2010 01:56 pm, Andriy Gapon wrote: > > on 15/07/2010 19:57 Oliver Fromme said the following: > > > I patched topo_probe() so it calls topo_probe_0x4() after > > > topo_probe_0xb() if cpu_cores is still 0. I think this > > > is a better fallback procedure. With this patch, cpu_cores > > > gets the value 4 which is the correct one, finally: > > [...] > > I think that your addition achieves this effect, perhaps just not > > as explicitly as I would preferred. > > > > Jung-uk, what do you think? > > Yes, you're right. Please try new patch: > > http://people.freebsd.org/~jkim/mp_machdep2.diff Thank you! I will have access to that particular machine on Monday again, so testing the new patch will have to wait until Monday. But from looking at your patch it should have the same result as my simpler patch, so it should work fine. Best regards Oliver -- Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. M. Handelsregister: Registergericht Muenchen, HRA 74606, Geschäftsfuehrung: secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht Mün- chen, HRB 125758, Geschäftsführer: Maik Bachmann, Olaf Erb, Ralf Gebhart FreeBSD-Dienstleistungen, -Produkte und mehr: http://www.secnetix.de/bsd "C++ is the only current language making COBOL look good." -- Bertrand Meyer
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201007152001.o6FK1mGq088944>