Date: Wed, 5 Jan 2011 09:34:49 -0500 From: John Baldwin <jhb@freebsd.org> To: freebsd-current@freebsd.org Cc: =?iso-8859-15?q?Sp=F6rlein?= <uqs@freebsd.org>, Erik Cederstrand <erik@cederstrand.dk>, Ulrich Subject: Re: FYI: clang static analyzer page has moved to http://scan.freebsd.your.org/freebsd-head/ Message-ID: <201101050934.49845.jhb@freebsd.org> In-Reply-To: <AD2AEFFB-37A4-4DAB-9094-7289C1C8B0DD@cederstrand.dk> References: <20110105131439.GN23329@acme.spoerlein.net> <4184C8F2-3C6D-46FB-8F10-DDEBA6DB1C35@cederstrand.dk> <AD2AEFFB-37A4-4DAB-9094-7289C1C8B0DD@cederstrand.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, January 05, 2011 9:11:50 am Erik Cederstrand wrote: > > Den 05/01/2011 kl. 14.56 skrev Erik Cederstrand: > > > Ignoring contrib code for the moment, I decided to look at usr.sbin.pw > > from 2011-01-05. There's one report (http://scan.freebsd.your.org/freebsd-head/usr.sbin.pw/2011-01-05-amd64/report-KkilQ3.html#EndPath) > > which turns out to be a false positive: > > > > * Step 6 calls cmdhelp() on line 168; > > * cmdhelp() ends with "exit(EXIT_FAILURE);" on line 432 which I assume > > is exit(3) from libc > > * The analyzer doesn't know that this function never returns and > > continues to flag a null dereference in step 8 > > The same is true of err(), verr(), errc(), verrc(), errx(), and verrx() > which is also causing false positive reports. They ultimately call exit(3). These are all marked as __dead2, so the compiler should "know" that these do not return. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201101050934.49845.jhb>