Date: Sun, 6 Oct 2013 18:20:28 GMT From: Andras Horvath <han@log69.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/182772: graphics/aaphoto cannot be built because of the default clang compiler Message-ID: <201310061820.r96IKSSK073625@oldred.freebsd.org> Resent-Message-ID: <201310061830.r96IU0LD043151@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 182772 >Category: ports >Synopsis: graphics/aaphoto cannot be built because of the default clang compiler >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Sun Oct 06 18:30:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Andras Horvath >Release: 10.0-CURRENT >Organization: >Environment: FreeBSD 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r255342: Sat Sep 7 07:34:47 UTC 2013 root@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64 >Description: Note: this is a modified PR request within a couple of days, because I changed my patch for the port. Since the other PR hasn't been accepted yet. Please consider this as correct one. The difference between the two is in the checking of what is the default compiler. Link to the other PR: http://www.freebsd.org/cgi/query-pr.cgi?pr=182649 The aaphoto software has the ability to scale on more processor cores by using the libgomp library. This is achieved by using the OpenMP pragma feature of the GCC (the Gnu Compiler Collection). Since the default C compiler has been replaced with Clang in the base system which doesn't know of OpenMP, the compiler cannot build this port. >How-To-Repeat: cd /usr/ports/graphics/aaphoto make >Fix: Removing the "-fopenmp -D__OPENMP__" C flags fixes the problem because the software will be built without this feature. Also, the active source code maintenance has been moved from the original site to its Github repo. The Makefile is updated according to this as well. This update brings a new version too which is a minor update with only tiny fixes and documentation update. Patch attached with submission follows: diff -ru aaphoto.orig/Makefile aaphoto/Makefile --- aaphoto.orig/Makefile 2013-09-20 18:35:44.000000000 +0000 +++ aaphoto/Makefile 2013-10-05 17:54:28.000000000 +0000 @@ -1,14 +1,16 @@ -# Created by: Andras Horvath <han@log69.com> +# Created by: Andras Horvath <mail@log69.com> # $FreeBSD: graphics/aaphoto/Makefile 327733 2013-09-20 18:35:44Z bapt $ PORTNAME= aaphoto -PORTVERSION= 0.41 -PORTREVISION= 1 +PORTVERSION= 0.43.1 +# PORTREVISION= 1 CATEGORIES= graphics -MASTER_SITES= http://log69.com/downloads/ -DISTNAME= ${PORTNAME}_sources_v${PORTVERSION} +USE_GITHUB= yes +MASTER_SITES= https://github.com/log69/aaphoto/archive/ +DISTNAME= v${PORTVERSION} +DIST_SUBDIR= ${PORTNAME} -MAINTAINER= han@log69.com +MAINTAINER= mail@log69.com COMMENT= Auto Adjust Photo, automatic color correction of photos LIB_DEPENDS= jasper:${PORTSDIR}/graphics/jasper \ @@ -31,7 +33,8 @@ NO_STAGE= yes .include <bsd.port.pre.mk> -.if (${ARCH} == "amd64" || ${ARCH} == "i386") && ${OSVERSION} >= 700000 +CCISCLANG!= ${CC} --version +.if (${ARCH} == "amd64" || ${ARCH} == "i386") && ${OSVERSION} >= 700000 && empty(CCISCLANG:M*clang*) CFLAGS+= -fopenmp -D__OPENMP__ .endif diff -ru aaphoto.orig/distinfo aaphoto/distinfo --- aaphoto.orig/distinfo 2012-07-14 13:54:48.000000000 +0000 +++ aaphoto/distinfo 2013-10-04 23:41:30.000000000 +0000 @@ -1,2 +1,2 @@ -SHA256 (aaphoto_sources_v0.41.tar.gz) = f101ff954bcca194550f35acdcaac8e4b36df072a1c5406e73f2d3bab30d38cb -SIZE (aaphoto_sources_v0.41.tar.gz) = 138407 +SHA256 (aaphoto/v0.43.1.tar.gz) = 35a21d075d297872e35f52c9e92ab8e7ee403f5ecf4927634f22b56bb401b5ca +SIZE (aaphoto/v0.43.1.tar.gz) = 135261 diff -ru aaphoto.orig/files/patch-Makefile.in aaphoto/files/patch-Makefile.in --- aaphoto.orig/files/patch-Makefile.in 2012-07-14 13:54:48.000000000 +0000 +++ aaphoto/files/patch-Makefile.in 2013-10-04 21:10:53.000000000 +0000 @@ -1,5 +1,5 @@ ---- Makefile.in.orig 2010-09-14 12:09:45.000000000 +0200 -+++ Makefile.in 2010-09-14 12:10:23.000000000 +0200 +--- Makefile.in.orig 2013-10-01 06:48:31.000000000 +0000 ++++ Makefile.in 2013-10-04 21:09:17.000000000 +0000 @@ -162,8 +162,8 @@ top_build_prefix = @top_build_prefix@ top_builddir = @top_builddir@ Only in aaphoto.orig/files: patch-aaphoto.c >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201310061820.r96IKSSK073625>