Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 17 Dec 2013 14:00:19 +0200
From:      Konstantin Belousov <kostikbel@gmail.com>
To:        sbruno@freebsd.org
Cc:        "freebsd-stable@freebsd.org" <freebsd-stable@freebsd.org>
Subject:   Re: 10.0 BETA 3 with redports kernel panic
Message-ID:  <20131217120019.GD59496@kib.kiev.ua>
In-Reply-To: <1387219558.1407.6.camel@powernoodle.corp.yahoo.com>
References:  <1384029731.1819.7.camel@powernoodle.corp.yahoo.com> <20131109205030.GF59496@kib.kiev.ua> <1387217065.1407.3.camel@powernoodle.corp.yahoo.com> <1387219558.1407.6.camel@powernoodle.corp.yahoo.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--sglkZ7RHCghPz49R
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 16, 2013 at 10:45:58AM -0800, Sean Bruno wrote:
> On Mon, 2013-12-16 at 10:04 -0800, Sean Bruno wrote:
> > > What is the source line for memrw+0x195 ?
> >=20
> > My apologies for the delay on this.  Its been frustrating getting a
> > crashdump on these machines due to their very large tmpfs usage.
> > Currently, I am dumping a crash of 13+GB to a third HD that we had
> > installed for this purpose.
> >=20
> > The machines are still running RC3 of 10.0r.
> >=20
> > I will attempt to get the requested information shortly.
> >=20
> > sean
> >=20
> >=20
>=20
> I've updated http://people.freebsd.org/~sbruno/redbuild_panic.txt
>=20
> It looks like its dying in uiomove() ?

I believe I already posted the following patch, with no feedback.

diff --git a/sys/amd64/amd64/mem.c b/sys/amd64/amd64/mem.c
index abbbb21..e371499 100644
--- a/sys/amd64/amd64/mem.c
+++ b/sys/amd64/amd64/mem.c
@@ -98,7 +98,11 @@ memrw(struct cdev *dev, struct uio *uio, int flags)
 kmemphys:
 			o =3D v & PAGE_MASK;
 			c =3D min(uio->uio_resid, (u_int)(PAGE_SIZE - o));
-			error =3D uiomove((void *)PHYS_TO_DMAP(v), (int)c, uio);
+			v =3D PHYS_TO_DMAP(v);
+			if (v < DMAP_MIN_ADDRESS || v >=3D DMAP_MAX_ADDRESS ||
+			    pmap_kextract(v) =3D=3D 0)
+				return (EFAULT);
+			error =3D uiomove((void *)v, (int)c, uio);
 			continue;
 		}
 		else if (dev2unit(dev) =3D=3D CDEV_MINOR_KMEM) {

--sglkZ7RHCghPz49R
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)

iQIcBAEBAgAGBQJSsDzSAAoJEJDCuSvBvK1B2KkP/39OwGmVABCfRx3bJPX3QUan
sYZHCagovcVYDm9vc8YnzCNfp9Wc8z5rw3PdctvnEnFeFEKpCorBie11WN5HpizE
AbWCixAmel7auMTr0dU5s3wecWP43KhoakUICcRA/AXery9L3vMIUa5X+wWEAc8c
Jn/QLxjn497aVWZwlatFiSL4H+y2cgc6pRtTYpbU1d65O5bhwGEobTQNukmxPkoD
ik2+ge5rgJSdW8cRRCG9JFoO2We+xKGpxgdxKV5Wm6wKgKjEHYTuWshiorjSiDN8
ALZRwEuHoTopQ9zQeybWiYdlIvlXR/M7xjwgvp+lqYxUxJh5rlPoiaCnX7lh4zHj
sksrsRyOrWSCIevXXxL/9GkDJ+YoEc+i6TG1Ctq7FeJocNuHulkVp/3L7ju4bu51
89GJEonkOa9y+2H2RrDgXSBeOGU2vZiwUFju1ubMDLycdBfL7m1IEb3Mo6YYIsp+
eR7zATTjq/sA5bIgmNx7nvYNXqUb/zPmo8aq+IdnHnXT8mko2yqjs87zAq7YBzFz
xovwuc9fVigYoakRuanhClqJyGwM2/uufCby6OyV2lzJmBoIEd8g0J+kwAtlsod9
6HvZvqeTL+a4z2kLC70kjKGQOrsbNlDUpug0/xH6s+utk92g/XkwiIOEX0e2Jnto
oZUuCtSsrSvIsTiknuMH
=3HtW
-----END PGP SIGNATURE-----

--sglkZ7RHCghPz49R--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131217120019.GD59496>