Date: Thu, 27 Mar 2014 12:21:29 -0400 From: John Baldwin <jhb@freebsd.org> To: Kevin Lo <kevlo@freebsd.org> Cc: Joe Nosay <superbisquit@gmail.com>, freebsd-current@freebsd.org, d@delphij.net, Brooks Davis <brooks@freebsd.org> Subject: Re: UDP Lite support Message-ID: <201403271221.29864.jhb@freebsd.org> In-Reply-To: <5333F020.8000200@FreeBSD.org> References: <CA%2BWntOugdnjM1SvFcEtWb8=heQCOBs2-c97EUKsfEHSmi1HRSw@mail.gmail.com> <201403261122.43541.jhb@freebsd.org> <5333F020.8000200@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, March 27, 2014 5:32:16 am Kevin Lo wrote: > >>> Are you interested in working on these and report back? > >> The revised patch is available at: > >> http://people.freebsd.org/~kevlo/udplite.diff > > Thank you for your suggestions. > > > A few suggestions: > > > > - I would just drop the INP lock and return EOPNOTSUPP directly rather > > than using goto's to 'bad_setoptname' and 'bad_getoptname' so the > > UDP-lite options are self-contained. > > Fixed. Thanks. > > - I'm not a super big fan of all the udp_common_* macros only because > > I think it obfuscates things. At the very least, please move these > > things out of the header and into udp_usrreq.c so they are closer > > to the implementation. I would even suggest making them inline > > functions instead of macros. > > Okay, I removed two udp_common_* macros. I also renamed udp_common_init() > to udp_udplite_init() and moved it into udp_usrreq.c. Using a macro here > to follow the style used in SCTP (sctp_os_bsd.h). > > Here's a third version of the udp-lite patch: > http://people.freebsd.org/~kevlo/udplite.diff Ok, I would say that udp_common_init() is actually a better name if you keep the macro (which I think is fine) rather than udp_udplite_init() as the macro is not specific to UDP Lite. However, thanks for moving the macros out of the header. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201403271221.29864.jhb>