Date: Sat, 7 Jun 2014 06:33:35 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Julio Merino <jmmv@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: Turning TESTS on by default Message-ID: <20140607033334.GO3991@kib.kiev.ua> In-Reply-To: <CAFY7cWB=BOKWh4gK=wwgvhnAoVUuVBOEqk08nXeo7eWwMguZzw@mail.gmail.com> References: <CAFY7cWB=BOKWh4gK=wwgvhnAoVUuVBOEqk08nXeo7eWwMguZzw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--mWXp4lmU9bb5aCfX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 06, 2014 at 03:14:52PM -0400, Julio Merino wrote: > Hello all, >=20 >=20 > TL;DR > ----- >=20 > I plan to turn the TESTS src.conf knob ON by default on Tuesday once I > have been able to perform enough sanity-checks of the build and all of > them pass. >=20 > The impact of this is that the FreeBSD Test Suite (see tests(7)) will > be built and installed by default under /usr/tests/ along with the > private atf libraries and binaries. There should be no other changes > and this should be transparent to everyone. >=20 > If this happens to break the world in any way, we can trivially roll > the change back to fix the fallout. >=20 >=20 > Some details > ------------ >=20 > TESTS was never intended to be disabled by default. However, the > original patches that were committed months ago related to this > feature broke the build and the easiest way out (instead of reverting > the commits) was to set the knob to disabled. Unfortunately, it stayed > that way even after the discovered problems were fixed. >=20 > I am confident enough now that we have ironed out all major issues > that this might introduce, so it is about time to enable TESTS by > default again in HEAD. >=20 > The benefits of this are that 1) we allow end users (especially > consumers of binary releases!) to run the tests out of the box, as it > has always been intended; and 2) we will be able to run the official > release builds through testing via Jenkins, instead of having to issue > custom builds. This is very weird and unprobable. Users cannot care less about running the test suite, they use OS to run applications. IMO enabling installation= =20 of the stuff that bloats the system but have no practical use for the system consumer should not be allowed by default. It is the same as the debugging kernel. The INVARIANTS, WITNESS, DEBUG and DIAGNOSTIC options are not enabled for the user consumption. There was a similar argument to disable compiling the profiling static libraries, which probably should be reconsidered since lib*_p.a is absolutely useless on current toolchain and hardware. >=20 > Actual change: https://phabric.freebsd.org/D188 >=20 >=20 > I will update this thread when the change is committed and/or with any up= dates. >=20 > Please let me know if I'm missing anything. >=20 > Cheers > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" --mWXp4lmU9bb5aCfX Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJTkogOAAoJEJDCuSvBvK1BjQUP/19IoawCVtbv+fRf4x5i81Mq j+k3rwm4GwUjaiYtusNcMSvERJ39i9ZaMewXQU8GUpX8kvdsqideBnE8JAS9MhX5 Z2T519fc/t/UiPKBtNSzOtWMTty7+5B/FWdq6MBVczMedRk/nOHCvxgj8QkmH067 Fm1R/Ga3MxbVGeYCGGJC1qq2BTmVQWAjicnQehZQYrtM1RCmbAOhctMOZKJSFa0J G5mG/Qeu+V30CBeLAGtrzdKuE9IXRIlZ3WBu73aKxzzVP99ufSSf/JnUDvleTW/y 8B/wyL4SvO9fzysqPIY4S0VekvPFHB8kLoxAvNId9CLlbO31UagnGG8Ujzy7V4Lb spuRQ7Uv+x6WJBgC6eirWFsJq7HzRpRsUbY4C8kqjL/SvlKF+q8tn6z4K43gkRqe BMFPtZwe3ZWutjjctF3N+aOX3t66c7uuJ+E4ij88NNTGhS0ZbBk56ex6WlOB8xoI c98f41+ecgHkX9BlVoWlvjae3/54SIl513qIkSJGQvZ778CiFyCalfWRIBTNHWc1 1wMapMg2+XzFHOj2UvDi0Ygm8QZ8MDTzztKfUbfOkB+EBwrQks/Tkj7tDaqXmM7I BAF0LHA4xKpqVGr20SdJgqP0c+g4bSHuqbFDwBWZ3SJ8ZMpTewcrpdM6sfuqw74O iKi9eFdMMFxYkrb6u8kw =ec/E -----END PGP SIGNATURE----- --mWXp4lmU9bb5aCfX--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140607033334.GO3991>