Date: Sun, 25 Jan 2015 16:55:26 +0100 From: Matthias Apitz <guru@unixarea.de> To: Dimitry Andric <dim@FreeBSD.org> Cc: freebsd-ports@freebsd.org, zeising@FreeBSD.org Subject: Re: head/graphics/svgalib does not build in poudriere Message-ID: <20150125155526.GA2744@c720-r276659> In-Reply-To: <FBA4BAED-9EE7-4EFA-8EA0-5D4FE9ED0590@FreeBSD.org> References: <20150125075122.GA1377@c720-r276659> <20150125101145.GA1906@c720-r276659> <FBA4BAED-9EE7-4EFA-8EA0-5D4FE9ED0590@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
El día Sunday, January 25, 2015 a las 04:44:39PM +0100, Dimitry Andric escribió:
> On 25 Jan 2015, at 11:11, Matthias Apitz <guru@unixarea.de> wrote:
> >
> > El día Sunday, January 25, 2015 a las 08:51:22AM +0100, Matthias Apitz escribió:
> ...
> >> This is in head r276659, ports r377801 and with poudriere 3.1.1 on
> >> amd64; the port graphics/svgalib fails to build (only) in poudriere with:
> >>
> >> ...
> >> clang -Wall -Wstrict-prototypes -Wall -Wstrict-prototypes -fPIC
> >> -I/wrkdirs/usr/ports/graphics/svgalib/work/svgalib-1.4.3/include -I.
> >> -fstack-protector -fno-strict-aliasing -I../include -L../sharedlib -o
> >> restorefont restorefont.o -lvga -lm
> >> ../sharedlib/libvga.so: undefined reference to `_outb'
> >> clang: error: linker command failed with exit code 1 (use -v to see
> >> invocation)
> ...
> >> the offending code is in src/paradise.c:
> >>
> >> ...
> >> void inline _outb(unsigned port,unsigned value)
> >> {
> >> #ifdef DEBUG
> >> printf ("0x%x, 0x%x\n",port,value);
> >> #endif
> >> outb(port,value);
> >> }
>
> Try compiling the port with USE_CSTD=gnu89, or change the function
> signature to:
>
> static inline void _outb(unsigned port,unsigned value)
>
> -Dimitry
Dimitry,
The port compiles fine the normal way:
# cd graphics/svgalib
# make package
without your proposed change; it does not compile in poudriere.
And to incorporate your change it would need an additional patch file,
is this what you want me to do?
Thanks
matthias
--
Matthias Apitz, guru@unixarea.de, http://www.unixarea.de/ +49-170-4527211
1989-2014: The Wall was torn down so that we go to war together again.
El Muro ha sido derribado para que nos unimos en ir a la guerra otra vez.
Diese Grenze wurde aufgehoben damit wir gemeinsam wieder in den Krieg ziehen.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150125155526.GA2744>