Date: Tue, 07 Jan 2014 07:34:43 +0100 From: Hans Petter Selasky <hps@bitfrost.no> To: huanghwh@gmail.com Cc: Adrian Chadd <adrian@freebsd.org>, freebsd-current <freebsd-current@freebsd.org> Subject: Re: Install 10.0-RC3 on MacBookPro Late 2013 Message-ID: <52CBA003.2080100@bitfrost.no> In-Reply-To: <CAB8uncYnbto=vavyWEWjwPtYqn4Uthb-V6YHXeqd3G01=f8UbQ@mail.gmail.com> References: <CAB8uncZO19Aen%2BuQRgO3whSOTVM%2BftcsGrJuGZZd4Qbd1Zf5mw@mail.gmail.com> <CAJ-Vmo=g-iVjNjygY93MVinptkA7HazJ3FRu1PsfKZtj-fubgg@mail.gmail.com> <CAB8unca6XZSEa8=c21yDJ=ueuUiW=D4v2PcLEzgt_sfTgsuzqA@mail.gmail.com> <CAB8unca8G32qcz67EaRdqrSBuO0YiBV4zL7fV3EfMozdeSsBQA@mail.gmail.com> <52CA56E5.8030101@bitfrost.no> <CAJ-Vmo=AxbQ9MMtkB_W3YW0s9QwmR8qWzgprOM_66MQqcgmdNQ@mail.gmail.com> <CAB8uncbjhzG-9BYbYH6skhnf-O24hDeX644aEpz162C-FHWTFA@mail.gmail.com> <52CA6E3F.9000301@bitfrost.no> <CAB8uncah%2BCOOptDmOiaKseqfDyeVd3veg2RLREOzfYtaJhfLYA@mail.gmail.com> <52CA7CE0.7070202@bitfrost.no> <CAJ-Vmok16O0hR9G9rhVeO6Ki3yn4DZgjj4s65ddhQS5MZXVeXw@mail.gmail.com> <52CACBB8.1020905@bitfrost.no> <52CB2591.9050401@bitfrost.no> <CAB8uncYnbto=vavyWEWjwPtYqn4Uthb-V6YHXeqd3G01=f8UbQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------070109040904060903090909 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 01/07/14 03:30, Huang Wen Hui wrote: > Hans, > > This wild guess do NOT works. > I binary sect xhci.c in SVN, found that *r245732 > *<http://svnweb.freebsd.org/base?view=revision&revision=245732>* > introduce the bug.* > <http://svnweb.freebsd.org/base?view=revision&revision=245732>; > revert to r345731 fixed this USB problem in 9.2R > > I also copy xhci_interrupt(struct xhci_softc *sc) from 9.1R to CURRENT, > CURRENT also works! > > Cheers, > Huang Wen Hui. Hi, We need to take this step by step. Thanks for tracing this down! Can you test the attached patch towards -current. Thank you! --HPS --------------070109040904060903090909 Content-Type: text/x-patch; name="xhci.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="xhci.diff" === ./xhci.c ================================================================== --- ./xhci.c (revision 260319) +++ ./xhci.c (local) @@ -1582,8 +1582,6 @@ USB_BUS_LOCK(&sc->sc_bus); status = XREAD4(sc, oper, XHCI_USBSTS); - if (status == 0) - goto done; /* acknowledge interrupts */ @@ -1591,10 +1589,8 @@ DPRINTFN(16, "real interrupt (status=0x%08x)\n", status); - if (status & XHCI_STS_EINT) { - /* check for event(s) */ - xhci_interrupt_poll(sc); - } + /* check for event(s) */ + xhci_interrupt_poll(sc); if (status & (XHCI_STS_PCD | XHCI_STS_HCH | XHCI_STS_HSE | XHCI_STS_HCE)) { @@ -1618,7 +1614,6 @@ __FUNCTION__); } } -done: USB_BUS_UNLOCK(&sc->sc_bus); } --------------070109040904060903090909--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52CBA003.2080100>