Date: Tue, 08 Jul 2014 12:19:37 +0200 From: Michelle Sullivan <michelle@sorbs.net> To: Matthew Seaman <matthew@FreeBSD.org> Cc: ports@freebsd.org, demon@FreeBSD.org Subject: Re: Patch (not perfect but half way there) for DBIx::SearchBuilder... [Bug: 191734] Message-ID: <53BBC5B9.60004@sorbs.net> In-Reply-To: <53B67F53.9000903@sorbs.net> References: <53B4C581.5060508@sorbs.net> <53B4F7DE.9090300@FreeBSD.org> <53B67F53.9000903@sorbs.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Michelle Sullivan wrote: > First, > > Thanks Matthew and Dimitry, and indeed Jesse is still listed as the > maintainer - however I have had no reply from him over the last few > weeks, I could be wrong but I think he no longer works for Best Practical. > > Matthew Seaman wrote: > >> On 03/07/2014 03:52, Michelle Sullivan wrote: >> >> >>> Matthew, "Demon" (cc'd you two specifically because the patch affects >>> ports you maintain directly) >>> >>> I created a patch a while ago and sent it off to Jesse and the RT-Users >>> mailing list to fix extremely slow loading of tickets for Request-Tracker. >>> >>> The patch is for DBIx::Searchbuilder->Fields() and you can see it here: >>> https://rt.cpan.org/Public/Ticket/Attachment/WithHeaders/733854 (bug: >>> https://rt.cpan.org/Public/Bug/Display.html?id=96902 ) >>> >>> If it were to be shipped as an 'option' in FreeBSD ports would it be >>> attached to DBIx::SearchBuilder or RT 4.x? (the patch is against >>> DBIx::SearchBuilder, but very specifically affects RT) >>> >>> >> The rt4x ports can't patch files belonging to DBIx::Searchbuilder -- >> >> > > Thought so but thought I'd check... would be a bit complex to do a slave > port... > > >> that's not allowed. The options are: >> >> * Unconditionally patch DBIx::Searchbuilder >> >> -- given the patch hasn't been accepted upstream and it looks >> like it could have a deleterious impact in some setups, this >> doesn't seem a good idea to me >> >> > > Well actually I could dix it to make it case sensitive, (which would be > the correct thing to do) As I haven't had any response from Best Practical or Jesse I created this patch, I did make it completely case-sensitive, and logged a bug in Bugzilla: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191734 (I also patched the docs with the warning about breakage as the Makefile is space limited) Thoughts, comments, welcome. Regards, -- Michelle Sullivan http://www.mhix.org/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53BBC5B9.60004>