Date: Tue, 25 Nov 2008 09:54:37 +0200 From: Giorgos Keramidas <keramida@freebsd.org> To: Manolis Kiagias <sonic2000gr@gmail.com> Cc: trhodes@freebsd.org, doc@freebsd.org, pgj@freebsd.org, gabor@kovesdan.org, remko@freebsd.org Subject: Re: A patch for the 'geom' chapter Message-ID: <873ahggs02.fsf@kobe.laptop> In-Reply-To: <492B7E8E.4070508@gmail.com> (Manolis Kiagias's message of "Tue, 25 Nov 2008 06:26:54 %2B0200") References: <e890cae60811241157p520238a2k4403f13cf340e403@mail.gmail.com> <20081124153358.7a539e67.trhodes@FreeBSD.org> <492B2D8C.4090807@gmail.com> <20081125.102512.193370295.hrs@allbsd.org> <492B7E8E.4070508@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 25 Nov 2008 06:26:54 +0200, Manolis Kiagias <sonic2000gr@gmail.com> wrote: > Hiroki Sato wrote: >> Manolis Kiagias <sonic2000gr@gmail.com> wrote >> in <492B2D8C.4090807@gmail.com>: >> >> so> After our discussion, here again is the "second take" of this patch: >> so> >> so> http://people.freebsd.org/~manolis/geom.txt >> >> One thing: >> >> + Permanent labels can be created with the <command>tunefs</command> >> + or <command>newfs</command> commands. They will then be created >> >> I think the &man.tunefs.8; and &man.newfs.8; are better than >> <command>foo</command> here. > > True, will change these. I just finished reading the new patch. Excellent work :) Just a minor point that may make the gjournal parts friendlier to mirror admins. You don't have to hardcode `www.freebsd.org' or the path to the gjournal article into the Handbook. This part: + Please refer to the article <ulink + url="http://www.freebsd.org/doc/en_US.ISO8859-1/articles/gjournal-desktop">Implementing UFS Journaling on a Desktop PC</ulink> + for detailed instructions on this task.</para> Can be written as: + Please refer to the article <ulink + url="&url.articles.gjournal-desktop;">Implementing UFS Journaling on + a Desktop PC</ulink> for detailed instructions on this task.</para> I have updated `doc/share/sgml/urls.ent' to include URL entities for our current set of articles, including gjournal-desktop, so if you update from CVS the patch should build fine either way. Patch approved by me too.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?873ahggs02.fsf>