Date: Sat, 24 Aug 2013 23:24:53 +0100 From: "Steven Hartland" <killing@multiplay.co.uk> To: "Will Andrews" <will@firepipe.net>, <scsi@freebsd.org> Subject: Re: 8K quirks & making quirk table more structured Message-ID: <B0201D260A3B424B98AC36C27B8C0A71@multiplay.co.uk> References: <CADBaqmibnA95T7x7UKZLYp3xZfgj0pLH00f1f%2BPEwcQbnBagmQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
That currently breaks the main reason for the output of
quirks in xpt_announce_quirks
Also it appears that the new method of setting lbppbe
in scsi would make the result dependent on block_len
which makes it potentially hard to predict the value
needed to set a drive to 4 etc.
In ata you use a different method entirely which its
not good for consistency as ideally we should have just
one set of quirks which work for scsi and ata.
Also in ata you appear to have lost the output of quirks.
Regards
Steve
----- Original Message -----
From: "Will Andrews" <will@firepipe.net>
To: <scsi@freebsd.org>
Sent: Saturday, August 24, 2013 12:32 AM
Subject: 8K quirks & making quirk table more structured
> Hi,
>
> We have seen 8K blocksize devices in our lab, which require quirks to
> behave properly. Rather than simply add another quirk for a different
> size, we made the quirk entries more structured, and changed blocksize
> to be a fixed-size integer element.
>
> Please review: http://people.freebsd.org/~will/head-convert-cam-quirk-tables-to-structs.diff
>
> The naming isn't particularly intuitive, but I'd like to check this in
> as primarily a structural change, and follow up with other
> improvements later.
>
> Thanks!
> --Will.
> _______________________________________________
> freebsd-scsi@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-scsi
> To unsubscribe, send any mail to "freebsd-scsi-unsubscribe@freebsd.org"
>
================================================
This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it.
In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337
or return the E.mail to postmaster@multiplay.co.uk.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B0201D260A3B424B98AC36C27B8C0A71>