Date: Wed, 17 Oct 2012 17:00:31 -0700 From: Jim Harris <jim.harris@gmail.com> To: hiren panchasara <hiren.panchasara@gmail.com> Cc: Davide Italiano <davide.italiano@gmail.com>, freebsd-current <freebsd-current@freebsd.org>, Fabien Thomas <fabien.thomas@netasq.com> Subject: Re: [CFT]hwpmc update for sandybridge-e Message-ID: <CAJP=Hc_rLHkmagvHW0m3pq0kb-=ShTvG3sGhvJoh9pcVREcJDg@mail.gmail.com> In-Reply-To: <CALCpEUE_NcH9AsSuq5r1eQ-nPU5z3KOa2LKvJYRFvsGQ2hRajQ@mail.gmail.com> References: <1349390777.5234.9.camel@powernoodle.corp.yahoo.com> <E62FEDB0-2DB8-408F-8D2B-3A40526035AB@netasq.com> <D67C86BC-B139-4472-9FE0-E09725D1CB55@netasq.com> <CALCpEUGNRzWgmaj2KDj8VkHMjw_6uGvcjSiWT-t%2B63iUUsh64g@mail.gmail.com> <D0A99DA2-8348-441F-ACD1-BAF79AC89D14@netasq.com> <CALCpEUGdQ3ex_zopmBY_Xmf1dsB_2crZXUhnuCmYpNVTmpHF_Q@mail.gmail.com> <CAJP=Hc9YdQC5jz3H8aEdsT7xtTTWTFGyiDou1LVwLD8ROxC7Lw@mail.gmail.com> <CALCpEUE_NcH9AsSuq5r1eQ-nPU5z3KOa2LKvJYRFvsGQ2hRajQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 17, 2012 at 3:57 PM, hiren panchasara <hiren.panchasara@gmail.com> wrote: > <snip> > > > Thanks for the pointers Jim! > > It seems that everything works now with: > > http://www.strugglingcoder.info/patches/hwpmc_sbx_3.txt > http://www.strugglingcoder.info/patches/pmccontrol_3.txt > http://www.strugglingcoder.info/patches/pmctestpy_3.txt > > As it can be seen, I do not see any errors with the test script. > I've also tried to take care of the sorting issues Fabien mentioned. > > Can you please give this a whirl? Looks good! Version 3 passes pmctest.py on my system. <snip> > > > I have a few questions regarding this. For my testing I am using hwpmc as a > module. > Problem is that any change to pmc_events.h is not reflected when I do: > 1) rebuild /sys/modules/hwpmc - unload/load new module > 2) rebuild /lib/libpmc/ > 3) rebuild /usr.sbin/pmccontrol and pmcstat > > I have to do buildworld for changes in pmc_events.h to take effect. (which > kind of explains my delayed responses :D ) > I know I am missing something here and there should be a better way to do > this. Any other changes (other than pmc_events.h) > can be tested with above 3 steps. You forgot to mention sys/pmc.h, but that was a simple change so you probably haven't had to touch it since your initial patch. The quick and dirty way is to just copy sys/dev/hwpmc/pmc_events.h to /usr/include/dev/hwpmc. Also sys/sys/pmc.h to /usr/include/sys. Thanks, -Jim >> >> Thanks for working on this! > > Entirely my pleasure :-) > > Thanks, > Hiren >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJP=Hc_rLHkmagvHW0m3pq0kb-=ShTvG3sGhvJoh9pcVREcJDg>