Date: Thu, 20 Jan 2000 17:50:09 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Alfred Perlstein <bright@wintelcom.net> Cc: Jason Evans <jasone@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_aio.c Message-ID: <Pine.BSF.4.21.0001201741580.2347-100000@alphplex.bde.org> In-Reply-To: <20000119210539.F20191@fw.wintelcom.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 19 Jan 2000, Alfred Perlstein wrote: > * Jason Evans <jasone@FreeBSD.org> [000119 18:23] wrote: > > jasone 2000/01/19 18:00:00 PST > > > > Modified files: > > sys/kern vfs_aio.c > > Log: > > Don't tsleep() while at splbio(). > > Unless it fixes some other bug, sleeping with spl raised is perfectly valid. And usually necessary to avoid races (Locking 101, part 3: an spl is not a lock...). However, it may not be necessary in vfs_aio.c, since the wakeups may only come from other processes and not from interrupt handlers. vfs_aio.c sleeps outside of an spl'ed section in about 6 other places, including 2 in very similar code. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0001201741580.2347-100000>