Date: Tue, 04 Sep 2001 09:40:46 -0700 (PDT) From: John Baldwin <jhb@FreeBSD.org> To: Peter Wemm <peter@wemm.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_shutdown.c Message-ID: <XFMail.010904094046.jhb@FreeBSD.org> In-Reply-To: <20010904055510.050A4380C@overcee.netplex.com.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04-Sep-01 Peter Wemm wrote: > John Baldwin wrote: >> >> On 02-Sep-01 Peter Wemm wrote: >> > peter 2001/09/02 05:24:38 PDT >> > >> > Modified files: >> > sys/kern kern_shutdown.c >> > Log: >> > The !RESTARTABLE_PANICS code has some loose ends. >> >> What is holding_giant for? Oh, and you do know that you are truly evil >> incarnate now, right? > > I'm not sure. Matt added it in rev 1.107, but the code that sets it is >#if 0'ed out. It is a real mess. Except the code to release it isn't #if 0'd out. > The other part of the diff was an accident that leaked from a local change. > I've been meaning to back it out but just couldn't quite do it. Ian Dowse > flagged it yesterday evening I think. I am amused at how few people had > noticed it, and of those most had read the diff. Heh. We could leave it on in -current for all I care, except that it does make all the useful messages scroll off the screen during a panic. :) \\|/ ____ \\|/ \"@'/ .. \\`@\ /_| \\__/ |_\\ \\__U_/ Oh, and you forgot the Obtained from: Linux in the commit log. :-P > Cheers, > -Peter -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010904094046.jhb>