Date: Tue, 19 Mar 2002 15:00:24 -0500 (EST) From: John Baldwin <jhb@FreeBSD.org> To: Peter Wemm <peter@wemm.org> Cc: Perforce Change Reviews <perforce@FreeBSD.org> Subject: Re: PERFORCE change 7933 for review Message-ID: <XFMail.20020319150024.jhb@FreeBSD.org> In-Reply-To: <20020319194600.B2BB33810@overcee.wemm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 19-Mar-2002 Peter Wemm wrote: > John Baldwin wrote: >> >> On 19-Mar-2002 Peter Wemm wrote: >> > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=7933 >> > >> > Change 7933 by peter@peter_overcee on 2002/03/19 01:29:12 >> > >> > add the ia64 IO tag, and add a #error to catch this in future. >> > >> > Affected files ... >> > >> > ... //depot/projects/ia64/sys/dev/kbd/atkbdc.c#2 edit >> > >> > Differences ... >> > >> > ==== //depot/projects/ia64/sys/dev/kbd/atkbdc.c#2 (text+ko) ==== >> > >> > @@ -159,6 +159,10 @@ >> > tag = I386_BUS_SPACE_IO; >> > #elif defined(__alpha__) >> > tag = busspace_isa_io; >> > +#elif defined(__ia64__) >> > + tag = IA64_BUS_SPACE_IO; >> > +#else >> > +#error "define tag!" >> > #endif >> > >> > #if notyet >> >> Maybe there should be a MD macro to define what the appropriate bus tag is? > > Actually, this should use the proper API's instead of hacking around like > this. Fair enough, wasn't sure if it could be using bus_alloc_resource() like a Good Little Device Driver or not. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020319150024.jhb>