Date: Wed, 18 Aug 2004 11:24:51 -0700 (PDT) From: John Polstra <jdp@polstra.com> To: Julian Elischer <julian@elischer.org> Cc: re@freebsd.org Subject: Re: netgraph only on i386/ia64 - why ? Message-ID: <XFMail.20040818112451.jdp@polstra.com> In-Reply-To: <41239E0A.30508@elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 18-Aug-2004 Julian Elischer wrote: > John Polstra wrote: >> >> There is one problem with netgraph on 64-bit platforms. The ng_msghdr >> struct is 52 bytes / 4-byte aligned (see ng_message.h). That means >> the message payload is not well-aligned for 64-bit platforms. It >> would be nice to fix that (and bump NG_VERSION, of course). Nobody >> ever guaranteed that the message payload would be aligned, but it >> makes things a lot more convenient. > > if we do this we should do it now so that we have a consistent ABI from 5.3 on.. > > scott (et al), should we pad an extra 4 bytes in this now? > it's low/no risk, but better now than after 5.3 has been released.. I'd really like to see this change happen. Julian, would it require bumping just NG_VERSION, or should NG_ABI_VERSION change too? John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20040818112451.jdp>