Date: Wed, 27 Jan 1999 21:45:11 -0800 (PST) From: John Polstra <jdp@polstra.com> To: Bruce Evans <bde@zeta.org.au> Cc: current@FreeBSD.ORG Subject: Re: btokup() macro in sys/malloc.h Message-ID: <XFMail.990127214511.jdp@polstra.com> In-Reply-To: <199901280503.QAA05872@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On 28-Jan-99 Bruce Evans wrote:
>>The added parentheses don't make any difference, semantically. This
>>change probably wouldn't meet the criteria spelled out in style(9):
>>
>> Unary operators don't require spaces, binary operators do. Don't use
>> parentheses unless they're required for precedence, or the statement is
>> really confusing without them.
>>
>> a = b->c[0] + ~d == (e || f) || g && h ? i : j >> 1;
>> k = !(l & FLAGS);
>
> Nah, style(9), not to mention the example of btokup() in Lite1 and Lite2,
> requires paretheses here (in btokup(), and probably in the bad example in
> style(9), because the expression would be really confusing without them :-).
Hear ye, hear ye! Be it here noted and archived for all eternity that
on January 27, 1999 Pacific Time, John Polstra was, for one fleeting
moment, purer than Bruce! :-)
John
---
John Polstra jdp@polstra.com
John D. Polstra & Co., Inc. Seattle, Washington USA
"Nobody ever went broke underestimating the taste of the American public."
-- H. L. Mencken
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.990127214511.jdp>