Date: Thu, 8 Jul 2010 15:12:39 -0700 (PDT) From: Doug Barton <dougb@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: ports@freebsd.org Subject: Re: Review request for new port: sysutils/etcupdate Message-ID: <alpine.BSF.2.00.1007081505550.48494@yncgbc.qbhto.arg> In-Reply-To: <201007081750.00871.jhb@freebsd.org> References: <201007081750.00871.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 8 Jul 2010, John Baldwin wrote: > This is a port for yet-another-/etc-merging tool that I wrote recently. It > passes portlint -N with one bogus warning because /etc is in the comment. I didn't try installing/deinstalling but you seem to have the right stuff in the Makefile for that. Overall it looks good, just a couple comments: 1. I don't think textproc is right for CATEGORIES, although sysutils is of course. 2. I don't think the do-fetch target is necessary, but if it is needed when you test it that's fine. 3. You have a pkg-descr~ file in the shar that should be deleted before you commit it. Assuming it passes all the tests in the porter's handbook for install, deinstall, package, etc. I'd say go ahead. :) Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ Computers are useless. They can only give you answers. -- Pablo Picasso
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1007081505550.48494>