Date: Tue, 16 Oct 2001 09:49:04 -0700 From: Mark Peek <mark@whistle.com> To: Robert Drehmel <robert@ferrari-ag.de> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/boot/ofw/libofw disklabel.h ofw_disk.c Message-ID: <p05101000b7f1fa762349@[207.76.207.129]> In-Reply-To: <20011016111942.A1133@obelix.develop.ferrari.net> References: <200110150935.f9F9Ze696851@freefall.freebsd.org> <p05101001b7f0ac7e9440@[10.1.10.118]> <20011016111942.A1133@obelix.develop.ferrari.net>
next in thread | previous in thread | raw e-mail | index | archive | help
At 11:19 AM +0200 10/16/01, Robert Drehmel wrote: >On Mon, Oct 15, 2001 at 08:11:46AM -0700, Mark Peek wrote: >> Should this be conditional for just the sparc64? > >Of course not. So you're telling me it is OK to check in "temporary" code for booting off a non-FreeBSD partition for all consumers of the "portable" Open Firmware boot code? I doubt this would work correctly on my iMac that doesn't have NetBSD installed on it. This code should have some form of conditional around it. > > The PowerPC port uses the Open Firmware boot code as well. In fact, >> it might be good to have Benno review your changes to ensure it is >> portable to both. > >I asked him to report any difficulties with these changes. >Additionally, some of the Open Firmware changes were tested by him >a few months ago. In the future, please include "Tested by: benno" or "Reviewed by: benno" in the commits where appropriate. Thanks, Mark To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p05101000b7f1fa762349>