From owner-cvs-libexec Mon Sep 5 13:38:03 1994 Return-Path: cvs-libexec-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id NAA23564 for cvs-libexec-outgoing; Mon, 5 Sep 1994 13:38:03 -0700 Received: (from csgr@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id NAA23536; Mon, 5 Sep 1994 13:36:35 -0700 Date: Mon, 5 Sep 1994 13:36:35 -0700 From: Geoff Rehmet Message-Id: <199409052036.NAA23536@freefall.cdrom.com> To: ache, adam, alm, ats, bde, csgr, cvs-libexec, davidg, dyson, gpalmer, guido, hsu, jkh, joerg, julian, jvh, karl, martin, nate, paul, phk, proven, pst, rgrimes, rich, se, sean, sef, smace, sos, torstenb, wollman Subject: cvs commit: src/libexec/telnetd Makefile Sender: cvs-libexec-owner@freefall.cdrom.com Precedence: bulk csgr 94/09/05 13:36:35 Modified: libexec/telnetd Makefile Log: Don't define KLUDGELINEMODE. (If you do, you will have problems trying to telnet into a FreeBSD-2.0 box from a Sun, and I WANT TO DO THAT.) Submitted by: Geoff From owner-cvs-libexec Mon Sep 5 19:15:11 1994 Return-Path: cvs-libexec-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id TAA04670 for cvs-libexec-outgoing; Mon, 5 Sep 1994 19:15:11 -0700 Received: from halloran-eldar.lcs.mit.edu (halloran-eldar.lcs.mit.edu [18.26.0.159]) by freefall.cdrom.com (8.6.8/8.6.6) with SMTP id TAA04657; Mon, 5 Sep 1994 19:14:55 -0700 Received: by halloran-eldar.lcs.mit.edu; id AA04131; Mon, 5 Sep 1994 22:15:05 -0400 Date: Mon, 5 Sep 1994 22:15:05 -0400 From: Garrett Wollman Message-Id: <9409060215.AA04131@halloran-eldar.lcs.mit.edu> To: Geoff Rehmet Cc: ache@freefall.cdrom.com, adam@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, bde@freefall.cdrom.com, cvs-libexec@freefall.cdrom.com, davidg@freefall.cdrom.com, dyson@freefall.cdrom.com, gpalmer@freefall.cdrom.com, guido@freefall.cdrom.com, hsu@freefall.cdrom.com, jkh@freefall.cdrom.com, joerg@freefall.cdrom.com, julian@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, martin@freefall.cdrom.com, nate@freefall.cdrom.com, paul@freefall.cdrom.com, phk@freefall.cdrom.com, proven@freefall.cdrom.com, pst@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, se@freefall.cdrom.com, sean@freefall.cdrom.com, sef@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, torstenb@freefall.cdrom.com, wollman@freefall.cdrom.com Subject: cvs commit: src/libexec/telnetd Makefile In-Reply-To: <199409052036.NAA23536@freefall.cdrom.com> References: <199409052036.NAA23536@freefall.cdrom.com> Sender: cvs-libexec-owner@freefall.cdrom.com Precedence: bulk < said: > csgr 94/09/05 13:36:35 > Modified: libexec/telnetd Makefile > Log: > Don't define KLUDGELINEMODE. I believe that the problems which you have noticed (as have I) are actually manifestations of bugs in either the generic TTY code, or the PTY driver. -GAWollman -- Garrett A. Wollman | Shashish is simple, it's discreet, it's brief. ... wollman@lcs.mit.edu | Shashish is the bonding of hearts in spite of distance. Opinions not those of| It is a bond more powerful than absence. We like people MIT, LCS, ANA, or NSA| who like Shashish. - Claude McKenzie + Florent Vollant From owner-cvs-libexec Fri Sep 9 08:23:14 1994 Return-Path: cvs-libexec-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id IAA09289 for cvs-libexec-outgoing; Fri, 9 Sep 1994 08:23:14 -0700 Received: (from paul@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id IAA09278; Fri, 9 Sep 1994 08:23:09 -0700 Date: Fri, 9 Sep 1994 08:23:09 -0700 From: Paul Richards Message-Id: <199409091523.IAA09278@freefall.cdrom.com> To: ache, adam, alm, ats, bde, csgr, cvs-libexec, davidg, dfr, dyson, gclarkii, gpalmer, guido, hsu, jkh, joerg, julian, jvh, karl, martin, nate, paul, phk, proven, pst, rgrimes, rich, se, sean, sef, smace, sos, torstenb, wollman Subject: cvs commit: src/libexec/bugfiler Makefile bug.h bugfiler.8 bugfiler.c bugformat error.c extern.h gethead.c pathnames.h process.c redist.c reply.c sendbug.1 sendbug.sh Sender: cvs-libexec-owner@freefall.cdrom.com Precedence: bulk paul 94/09/09 08:23:08 Removed: libexec/bugfiler Makefile bug.h bugfiler.8 bugfiler.c bugformat error.c extern.h gethead.c pathnames.h process.c redist.c reply.c sendbug.1 sendbug.sh Log: Removed bugfiler -- we don't want people trying to use this anymore. Submitted by: Paul Richards From owner-cvs-libexec Fri Sep 9 09:40:35 1994 Return-Path: cvs-libexec-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id JAA12149 for cvs-libexec-outgoing; Fri, 9 Sep 1994 09:40:35 -0700 Received: (from paul@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id JAA12132; Fri, 9 Sep 1994 09:40:29 -0700 Date: Fri, 9 Sep 1994 09:40:29 -0700 From: Paul Richards Message-Id: <199409091640.JAA12132@freefall.cdrom.com> To: ache, adam, alm, ats, bde, csgr, cvs-libexec, davidg, dfr, dyson, gclarkii, gpalmer, guido, hsu, jkh, joerg, julian, jvh, karl, martin, nate, paul, phk, proven, pst, rgrimes, rich, se, sean, sef, smace, sos, torstenb, wollman Subject: cvs commit: src/libexec Makefile Sender: cvs-libexec-owner@freefall.cdrom.com Precedence: bulk paul 94/09/09 09:40:29 Modified: libexec Makefile Log: Removed bugfiler. Submitted by: Paul Richards From owner-cvs-libexec Fri Sep 9 09:58:20 1994 Return-Path: cvs-libexec-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id JAA13517 for cvs-libexec-outgoing; Fri, 9 Sep 1994 09:58:20 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.8/8.6.6) with ESMTP id JAA13457; Fri, 9 Sep 1994 09:57:36 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.8/8.6.6) id JAA11625; Fri, 9 Sep 1994 09:57:35 -0700 From: "Rodney W. Grimes" Message-Id: <199409091657.JAA11625@gndrsh.aac.dev.com> Subject: Re: cvs commit: src/libexec Makefile To: paul@freefall.cdrom.com (Paul Richards) Date: Fri, 9 Sep 1994 09:57:34 -0700 (PDT) Cc: ache@freefall.cdrom.com, adam@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, bde@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-libexec@freefall.cdrom.com, davidg@freefall.cdrom.com, dfr@freefall.cdrom.com, dyson@freefall.cdrom.com, gclarkii@freefall.cdrom.com, gpalmer@freefall.cdrom.com, guido@freefall.cdrom.com, hsu@freefall.cdrom.com, jkh@freefall.cdrom.com, joerg@freefall.cdrom.com, julian@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, martin@freefall.cdrom.com, nate@freefall.cdrom.com, paul@freefall.cdrom.com, phk@freefall.cdrom.com, proven@freefall.cdrom.com, pst@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, se@freefall.cdrom.com, sean@freefall.cdrom.com, sef@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, torstenb@freefall.cdrom.com, wollman@freefall.cdrom.com In-Reply-To: <199409091640.JAA12132@freefall.cdrom.com> from "Paul Richards" at Sep 9, 94 09:40:29 am X-Mailer: ELM [version 2.4 PL23] Content-Type: text Content-Length: 2818 Sender: cvs-libexec-owner@freefall.cdrom.com Precedence: bulk I am not picking on paul here, even I was guilty of it this last night in my rush to get some things done... but we need to clean this act up, the log files are getting cluttered to death, and no one is getting reviews :-(. > paul 94/09/09 09:40:29 ^^^^^^ > > Modified: libexec Makefile > Log: > Removed bugfiler. > Submitted by: Paul Richards ^^^^^^^^^^^^ Reviewed by: Submitted by: CVS: ---------------------------------------------------------------------- CVS: Delete the ``Reviewed by'' line if this is somebody else's work CVS: (you are the reviewer). CVS: Delete the ``Submitted by'' line if this is NOT somebody else's ^^^^^^^^^^^^^^ CVS: work (you are the author). ^^^^^^^^^^^^^^^^^^^ And from /usr/src/CVS-INFO This file really doesn't belong here, but I wanted to elicit comment without starting a discussion as to where it really does belong. Anyway, here goes... When the new CVS tree was set up back in May, I wanted to ensure that everybody at least gave some thought to asking other people to look at code before it is committed. Since we have had a number of rancorous discussions in the past about both committing code prematurely, and committing code that was written by someone else, I decided to use the `template' function of CVS to give people a chance to think about it. The template looks like this: Reviewed by: Submitted by: CVS: ---------------------------------------------------------------------- CVS: Delete the ``Reviewed by'' line if this is somebody else's work CVS: (you are the reviewer). CVS: Delete the ``Submitted by'' line if this is NOT somebody else's CVS: work (you are the author). If you are making substantial or possibly controversial changes to the code, please talk to someone else who either has commit authority, or who is recognized as an expert in the BSD community. This latter category includes the author of the program or subsystem you're modifying, like Rick Macklem for the NFS code, or Keith Bostic for `vi'. If the changes are insubstantial and noncontroversial (e.g., fixing spelling errors, or most Makefile changes) there is no need for review. Please delete the ``Reviewed by:'' line, though, so that the logs look cleaner. If you are committing code or modifications which were originally done by some other person or group, them please please please make sure to credit them in the ``Submitted by'' line. In this case, you are considered to be the reviewer. If it is your own code, or that of another team member, then you should delete the ``Submitted by'' line, so that the logs look cleaner. -GAWollman -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD From owner-cvs-libexec Fri Sep 9 10:29:39 1994 Return-Path: cvs-libexec-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id KAA15430 for cvs-libexec-outgoing; Fri, 9 Sep 1994 10:29:39 -0700 Received: from precipice.Shockwave.COM (precipice.shockwave.com [131.108.142.18]) by freefall.cdrom.com (8.6.8/8.6.6) with ESMTP id KAA15416; Fri, 9 Sep 1994 10:29:16 -0700 Received: from localhost (localhost [127.0.0.1]) by precipice.Shockwave.COM (8.6.8/8.6.5) with SMTP id KAA20169; Fri, 9 Sep 1994 10:28:51 -0700 Message-Id: <199409091728.KAA20169@precipice.Shockwave.COM> X-Authentication-Warning: precipice.Shockwave.COM: Host localhost didn't use HELO protocol To: Paul Richards cc: ache@freefall.cdrom.com, adam@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, bde@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-libexec@freefall.cdrom.com, davidg@freefall.cdrom.com, dfr@freefall.cdrom.com, dyson@freefall.cdrom.com, gclarkii@freefall.cdrom.com, gpalmer@freefall.cdrom.com, guido@freefall.cdrom.com, hsu@freefall.cdrom.com, jkh@freefall.cdrom.com, joerg@freefall.cdrom.com, julian@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, martin@freefall.cdrom.com, nate@freefall.cdrom.com, phk@freefall.cdrom.com, proven@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, se@freefall.cdrom.com, sean@freefall.cdrom.com, sef@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, torstenb@freefall.cdrom.com, wollman@freefall.cdrom.com Subject: Re: cvs commit: src/libexec/bugfiler Makefile bug.h bugfiler.8 bugfiler.c bugformat error.c extern.h gethead.c pathnames.h process.c redist.c reply.c sendbug.1 sendbug.sh In-reply-to: Your message of "Fri, 09 Sep 1994 08:23:09 PDT." <199409091523.IAA09278@freefall.cdrom.com> Date: Fri, 09 Sep 1994 10:28:51 -0700 From: Paul Traina Sender: cvs-libexec-owner@freefall.cdrom.com Precedence: bulk Then you should probably nuke, or at least fix sendbug to point to the right place (right now it points to cs.berkeley.edu!) From: Paul Richards Subject: cvs commit: src/libexec/bugfiler Makefile bug.h bugfiler.8 bugfiler. >>c bugformat error.c extern.h gethead.c pathnames.h process.c redist.c reply.c >> sendbug.1 sendbug.sh paul 94/09/09 08:23:08 Removed: libexec/bugfiler Makefile bug.h bugfiler.8 bugfiler.c bugformat error.c extern.h gethead.c pathnames.h process.c redist.c reply.c sendbug.1 sendbug.sh Log: Removed bugfiler -- we don't want people trying to use this anymore. Submitted by: Paul Richards From owner-cvs-libexec Fri Sep 9 10:50:24 1994 Return-Path: cvs-libexec-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id KAA16325 for cvs-libexec-outgoing; Fri, 9 Sep 1994 10:50:24 -0700 Received: from precipice.Shockwave.COM (precipice.shockwave.com [131.108.142.18]) by freefall.cdrom.com (8.6.8/8.6.6) with ESMTP id KAA16305; Fri, 9 Sep 1994 10:50:07 -0700 Received: from localhost (localhost [127.0.0.1]) by precipice.Shockwave.COM (8.6.8/8.6.5) with SMTP id KAA20243; Fri, 9 Sep 1994 10:49:04 -0700 Message-Id: <199409091749.KAA20243@precipice.Shockwave.COM> X-Authentication-Warning: precipice.Shockwave.COM: Host localhost didn't use HELO protocol To: paul@isl.cf.ac.uk (Paul Richards) cc: paul@freefall.cdrom.com, ache@freefall.cdrom.com, adam@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, bde@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-libexec@freefall.cdrom.com, davidg@freefall.cdrom.com, dfr@freefall.cdrom.com, dyson@freefall.cdrom.com, gclarkii@freefall.cdrom.com, gpalmer@freefall.cdrom.com, guido@freefall.cdrom.com, hsu@freefall.cdrom.com, jkh@freefall.cdrom.com, joerg@freefall.cdrom.com, julian@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, martin@freefall.cdrom.com, nate@freefall.cdrom.com, phk@freefall.cdrom.com, proven@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, se@freefall.cdrom.com, sean@freefall.cdrom.com, sef@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, torstenb@freefall.cdrom.com, wollman@freefall.cdrom.com Subject: Re: cvs commit: src/libexec/bugfiler Makefile bug.h bugfiler.8 bugfiler.c bugformat error.c extern.h gethead.c pathnames.h proce In-reply-to: Your message of "Fri, 09 Sep 1994 19:04:45 BST." <199409091804.TAA06162@isl-gate.elsy.cf.ac.uk> Date: Fri, 09 Sep 1994 10:49:03 -0700 From: Paul Traina Sender: cvs-libexec-owner@freefall.cdrom.com Precedence: bulk OK, sorry... running too fast these days. From: paul@isl.cf.ac.uk (Paul Richards) Subject: Re: cvs commit: src/libexec/bugfiler Makefile bug.h bugfiler.8 bugfi >>ler.c bugformat error.c extern.h gethead.c pathnames.h proce In reply to Paul Traina who said > > Then you should probably nuke, or at least fix sendbug to point to the righ >>t > place (right now it points to cs.berkeley.edu!) > Maybe you should have looked more carefully :-) sendbug lives in the bugfiler directory, its died the same death as bugfiler. -- Paul Richards, FreeBSD core team member. Intelligent Systems Laboratory, ELSYM ,University of Wales, College Cardiff Internet: paul@isl.cf.ac.uk, JANET(UK): RICHARDSDP@CARDIFF.AC.UK From owner-cvs-libexec Fri Sep 9 11:14:57 1994 Return-Path: cvs-libexec-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id LAA17523 for cvs-libexec-outgoing; Fri, 9 Sep 1994 11:14:57 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.8/8.6.6) with ESMTP id LAA17451; Fri, 9 Sep 1994 11:14:07 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.8/8.6.6) id LAA11979; Fri, 9 Sep 1994 11:13:52 -0700 From: "Rodney W. Grimes" Message-Id: <199409091813.LAA11979@gndrsh.aac.dev.com> Subject: Re: cvs commit: src/libexec Makefile To: paul@isl.cf.ac.uk (Paul Richards) Date: Fri, 9 Sep 1994 11:13:51 -0700 (PDT) Cc: paul@freefall.cdrom.com, ache@freefall.cdrom.com, adam@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, bde@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-libexec@freefall.cdrom.com, davidg@freefall.cdrom.com, dfr@freefall.cdrom.com, dyson@freefall.cdrom.com, gclarkii@freefall.cdrom.com, gpalmer@freefall.cdrom.com, guido@freefall.cdrom.com, hsu@freefall.cdrom.com, jkh@freefall.cdrom.com, joerg@freefall.cdrom.com, julian@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, martin@freefall.cdrom.com, nate@freefall.cdrom.com, phk@freefall.cdrom.com, proven@freefall.cdrom.com, pst@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, se@freefall.cdrom.com, sean@freefall.cdrom.com, sef@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, torstenb@freefall.cdrom.com, wollman@freefall.cdrom.com In-Reply-To: <199409091755.SAA06000@isl-gate.elsy.cf.ac.uk> from "Paul Richards" at Sep 9, 94 06:55:51 pm X-Mailer: ELM [version 2.4 PL23] Content-Type: text Content-Length: 4691 Sender: cvs-libexec-owner@freefall.cdrom.com Precedence: bulk > > In reply to Rodney W. Grimes who said > > > > I am not picking on paul here, even I was guilty of it this last night > > in my rush to get some things done... but we need to clean this act up, > > the log files are getting cluttered to death, and no one is getting > > reviews :-(. > > I think you picked a particularly bad example since I comply with ALL the > requirements here. Nope, again ``Delete the ``Submitted by'' line if this is NOT somebody else's work''. This was NOT some elses work, YOU may the decision to delete it, thus you are the author of this change, thus there should be no submitted by: line. We know who submitted it in this case by the person that commited it. > > > paul 94/09/09 09:40:29 > > ^^^^^^ > > > > > > Modified: libexec Makefile > > > Log: > > > Removed bugfiler. > > > Submitted by: Paul Richards > > ^^^^^^^^^^^^ > > > > > > > Reviewed by: > > Submitted by: > > CVS: ---------------------------------------------------------------------- > > CVS: Delete the ``Reviewed by'' line if this is somebody else's work > > CVS: (you are the reviewer). > > CVS: Delete the ``Submitted by'' line if this is NOT somebody else's > > ^^^^^^^^^^^^^^ > > CVS: work (you are the author). > > The above comments just don't make sense. The reviewed by line should > be deleted if this is NOT somebody else's work. If it IS somebody else's > work then you are the reviewer. The submitted line should never be deleted. > It should always be the originator of the code whether yourself or someone > who sent it to you for review. No, if the work is someone elses they are the submitter, YOU are the reviewer, inwich case you only need the Submitted line:, when know from the commit originator that you reviewed this before committing it. I will agree the english in rcstemplate could be made to read better if a few of the negatives where removed. > > If the changes are insubstantial and noncontroversial (e.g., fixing > > spelling errors, or most Makefile changes) there is no need for > > review. Please delete the ``Reviewed by:'' line, though, so that the > > logs look cleaner. > > This is the relevant paragraph for the above commit, what did I do wrong? You did that paragraph correctly, you failed to follow the next one though: If you are committing code or modifications which were originally done by some other person or group, them please please please make sure to credit them in the ``Submitted by'' line. In this case, you are considered to be the reviewer. If it is your own code, or that of ^^^^^^^^^^^^^^ another team member, then you should delete the ``Submitted by'' line, so that the logs look cleaner. The ^^^ above should really read ``your own code, or modification''. The whole idea of these is that we have been pretty relaxed about having others look at our work before commiting it. Well, 5 of my last 10 commits where cleaning up where others had failed to do an adaquate job. This is not productive, and it is one of the issues that almost drove me to go do my own thing... and may do that yet. Now, onto another thing about this particual commit and why a review should have been done. You set up gnats, great, wonderfull THANKS!! But no one, nata, zippo, in -core, or else where has ever even done a test filling of a bug report. Nor is it currently possible for anyone to have a working send-pr even on a system build 4 hours ago from -current. Currently send-pr is going to fail install on anyones box who enables it in gnu/usr.bin/Makefile (or did you do that alread): skyrsh:rgrimes {116} make install install -c -o bin -g bin -m 555 /usr/src/gnu/usr.bin/send-pr/send-pr /usr/bin/send-pr install: /usr/src/gnu/usr.bin/send-pr/send-pr: No such file or directory *** Error code 1 Stop. skyrsh:rgrimes {117} It needs an update to etc/mtree before it can install. The previos user base does have some knowledge of and occasionally does use the old bugfiller. In 2.0 this is now just going to dis appear with no pointer to the new tool. I suggest you add a MLINKS= bugfiler send-pr or is that send-pr bugfiler. If you had submitted this change for review, these facts would have been uncovered before the commit and possible have saved me the above debug. Nough said. > -- > Paul Richards, FreeBSD core team member. > Intelligent Systems Laboratory, ELSYM ,University of Wales, College Cardiff > Internet: paul@isl.cf.ac.uk, JANET(UK): RICHARDSDP@CARDIFF.AC.UK > -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD From owner-cvs-libexec Fri Sep 9 11:33:52 1994 Return-Path: cvs-libexec-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id LAA18597 for cvs-libexec-outgoing; Fri, 9 Sep 1994 11:33:52 -0700 Received: from isl-gate.elsy.cf.ac.uk (isl-gate.elsy.cf.ac.uk [131.251.22.1]) by freefall.cdrom.com (8.6.8/8.6.6) with ESMTP id LAA18559; Fri, 9 Sep 1994 11:33:02 -0700 Received: by isl-gate.elsy.cf.ac.uk (8.6.9/1.34) id TAA06162; Fri, 9 Sep 1994 19:04:46 +0100 From: paul@isl.cf.ac.uk (Paul Richards) Message-Id: <199409091804.TAA06162@isl-gate.elsy.cf.ac.uk> Subject: Re: cvs commit: src/libexec/bugfiler Makefile bug.h bugfiler.8 bugfiler.c bugformat error.c extern.h gethead.c pathnames.h proce To: pst@shockwave.com (Paul Traina) Date: Fri, 9 Sep 1994 19:04:45 +0100 (BST) Cc: paul@freefall.cdrom.com, ache@freefall.cdrom.com, adam@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, bde@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-libexec@freefall.cdrom.com, davidg@freefall.cdrom.com, dfr@freefall.cdrom.com, dyson@freefall.cdrom.com, gclarkii@freefall.cdrom.com, gpalmer@freefall.cdrom.com, guido@freefall.cdrom.com, hsu@freefall.cdrom.com, jkh@freefall.cdrom.com, joerg@freefall.cdrom.com, julian@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, martin@freefall.cdrom.com, nate@freefall.cdrom.com, phk@freefall.cdrom.com, proven@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, se@freefall.cdrom.com, sean@freefall.cdrom.com, sef@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, torstenb@freefall.cdrom.com, wollman@freefall.cdrom.com In-Reply-To: <199409091728.KAA20169@precipice.Shockwave.COM> from "Paul Traina" at Sep 9, 94 10:28:51 am X-Mailer: ELM [version 2.4 PL23] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 490 Sender: cvs-libexec-owner@freefall.cdrom.com Precedence: bulk In reply to Paul Traina who said > > Then you should probably nuke, or at least fix sendbug to point to the right > place (right now it points to cs.berkeley.edu!) > Maybe you should have looked more carefully :-) sendbug lives in the bugfiler directory, its died the same death as bugfiler. -- Paul Richards, FreeBSD core team member. Intelligent Systems Laboratory, ELSYM ,University of Wales, College Cardiff Internet: paul@isl.cf.ac.uk, JANET(UK): RICHARDSDP@CARDIFF.AC.UK From owner-cvs-libexec Fri Sep 9 11:35:15 1994 Return-Path: cvs-libexec-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id LAA18677 for cvs-libexec-outgoing; Fri, 9 Sep 1994 11:35:15 -0700 Received: from isl-gate.elsy.cf.ac.uk (isl-gate.elsy.cf.ac.uk [131.251.22.1]) by freefall.cdrom.com (8.6.8/8.6.6) with ESMTP id LAA18619; Fri, 9 Sep 1994 11:34:17 -0700 Received: by isl-gate.elsy.cf.ac.uk (8.6.9/1.34) id SAA06000; Fri, 9 Sep 1994 18:55:52 +0100 From: paul@isl.cf.ac.uk (Paul Richards) Message-Id: <199409091755.SAA06000@isl-gate.elsy.cf.ac.uk> Subject: Re: cvs commit: src/libexec Makefile To: rgrimes@gndrsh.aac.dev.com (Rodney W. Grimes) Date: Fri, 9 Sep 1994 18:55:51 +0100 (BST) Cc: paul@freefall.cdrom.com, ache@freefall.cdrom.com, adam@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, bde@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-libexec@freefall.cdrom.com, davidg@freefall.cdrom.com, dfr@freefall.cdrom.com, dyson@freefall.cdrom.com, gclarkii@freefall.cdrom.com, gpalmer@freefall.cdrom.com, guido@freefall.cdrom.com, hsu@freefall.cdrom.com, jkh@freefall.cdrom.com, joerg@freefall.cdrom.com, julian@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, martin@freefall.cdrom.com, nate@freefall.cdrom.com, phk@freefall.cdrom.com, proven@freefall.cdrom.com, pst@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, se@freefall.cdrom.com, sean@freefall.cdrom.com, sef@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, torstenb@freefall.cdrom.com, wollman@freefall.cdrom.com In-Reply-To: <199409091657.JAA11625@gndrsh.aac.dev.com> from "Rodney W. Grimes" at Sep 9, 94 09:57:34 am X-Mailer: ELM [version 2.4 PL23] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 1745 Sender: cvs-libexec-owner@freefall.cdrom.com Precedence: bulk In reply to Rodney W. Grimes who said > > I am not picking on paul here, even I was guilty of it this last night > in my rush to get some things done... but we need to clean this act up, > the log files are getting cluttered to death, and no one is getting > reviews :-(. I think you picked a particularly bad example since I comply with ALL the requirements here. > > paul 94/09/09 09:40:29 > ^^^^^^ > > > > Modified: libexec Makefile > > Log: > > Removed bugfiler. > > Submitted by: Paul Richards > ^^^^^^^^^^^^ > > > Reviewed by: > Submitted by: > CVS: ---------------------------------------------------------------------- > CVS: Delete the ``Reviewed by'' line if this is somebody else's work > CVS: (you are the reviewer). > CVS: Delete the ``Submitted by'' line if this is NOT somebody else's > ^^^^^^^^^^^^^^ > CVS: work (you are the author). The above comments just don't make sense. The reviewed by line should be deleted if this is NOT somebody else's work. If it IS somebody else's work then you are the reviewer. The submitted line should never be deleted. It should always be the originator of the code whether yourself or someone who sent it to you for review. > If the changes are insubstantial and noncontroversial (e.g., fixing > spelling errors, or most Makefile changes) there is no need for > review. Please delete the ``Reviewed by:'' line, though, so that the > logs look cleaner. This is the relevant paragraph for the above commit, what did I do wrong? -- Paul Richards, FreeBSD core team member. Intelligent Systems Laboratory, ELSYM ,University of Wales, College Cardiff Internet: paul@isl.cf.ac.uk, JANET(UK): RICHARDSDP@CARDIFF.AC.UK From owner-cvs-libexec Fri Sep 9 11:47:10 1994 Return-Path: cvs-libexec-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id LAA19910 for cvs-libexec-outgoing; Fri, 9 Sep 1994 11:47:10 -0700 Received: from isl-gate.elsy.cf.ac.uk (isl-gate.elsy.cf.ac.uk [131.251.22.1]) by freefall.cdrom.com (8.6.8/8.6.6) with ESMTP id LAA19718; Fri, 9 Sep 1994 11:46:22 -0700 Received: by isl-gate.elsy.cf.ac.uk (8.6.9/1.34) id UAA07408; Fri, 9 Sep 1994 20:05:32 +0100 From: paul@isl.cf.ac.uk (Paul Richards) Message-Id: <199409091905.UAA07408@isl-gate.elsy.cf.ac.uk> Subject: Re: cvs commit: src/libexec Makefile To: rgrimes@gndrsh.aac.dev.com (Rodney W. Grimes) Date: Fri, 9 Sep 1994 20:05:32 +0100 (BST) Cc: paul@isl.cf.ac.uk, paul@freefall.cdrom.com, ache@freefall.cdrom.com, adam@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, bde@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-libexec@freefall.cdrom.com, davidg@freefall.cdrom.com, dfr@freefall.cdrom.com, dyson@freefall.cdrom.com, gclarkii@freefall.cdrom.com, gpalmer@freefall.cdrom.com, guido@freefall.cdrom.com, hsu@freefall.cdrom.com, jkh@freefall.cdrom.com, joerg@freefall.cdrom.com, julian@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, martin@freefall.cdrom.com, nate@freefall.cdrom.com, phk@freefall.cdrom.com, proven@freefall.cdrom.com, pst@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, se@freefall.cdrom.com, sean@freefall.cdrom.com, sef@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, torstenb@freefall.cdrom.com, wollman@freefall.cdrom.com In-Reply-To: <199409091813.LAA11979@gndrsh.aac.dev.com> from "Rodney W. Grimes" at Sep 9, 94 11:13:51 am X-Mailer: ELM [version 2.4 PL23] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 4043 Sender: cvs-libexec-owner@freefall.cdrom.com Precedence: bulk In reply to Rodney W. Grimes who said > > Now, onto another thing about this particual commit and why a review should > have been done. You set up gnats, great, wonderfull THANKS!! But no one, > nata, zippo, in -core, or else where has ever even done a test filling of > a bug report. Nor is it currently possible for anyone to have a working > send-pr even on a system build 4 hours ago from -current. This is just completely and utterly untrue. If you're going to make criticisms I suggest you get your facts straight. I have submitted numerous reports to ensure it's all working. If you did not see any of these then I would like to know why since that is possibly a bug. You won't find any of the test reports in the database because I reset everything since I didn't see any value in having them clutter it up. > > Currently send-pr is going to fail install on anyones box who enables it > in gnu/usr.bin/Makefile (or did you do that alread): > skyrsh:rgrimes {116} make install > install -c -o bin -g bin -m 555 /usr/src/gnu/usr.bin/send-pr/send-pr /usr/bin/send-pr > install: /usr/src/gnu/usr.bin/send-pr/send-pr: No such file or directory > *** Error code 1 > > Stop. > skyrsh:rgrimes {117} I haven't enabled send-pr in the /usr/src/gnu/Makefile, I will do that immediately. This was an oversight, I thought I'd done that already. I don't know what you've done but it works fine on my box. isl-gate:gnu/usr.bin# make ===> send-pr sed -e 's,@DATADIR@,/etc,g' -e 's/@DEFAULT_RELEASE@/`uname -rsm`/g' send-pr.sh > send-pr sed -e 's,@DATADIR@,/etc,g' -e 's/@DEFAULT_RELEASE@/`uname -rsm`/g' send-pr-el.in > send-pr.el sed -e 's,@BINDIR@,/usr/bin,g' install-sid.sh > install-sid isl-gate:gnu/usr.bin# make install ===> send-pr install -c -o bin -g bin -m 555 /FreeBSD-2.0/src/gnu/usr.bin/send-pr/send-pr /usr/bin/send-pr install -c -o bin -g bin -m 0644 /FreeBSD-2.0/src/gnu/usr.bin/send-pr/categories /etc/gnats/freefall sh /FreeBSD-2.0/src/gnu/usr.bin/send-pr/install-sid current-users install-sid: `current-users' is now the default submitter ID for send-pr (cd /FreeBSD-2.0/src/gnu/usr.bin/send-pr; install -c -o bin -g bin -m 444 send-pr.1 /usr/share/man/man1) > > It needs an update to etc/mtree before it can install. I have made the necessary changes to the mtree templates. send-pr is only going to work if you have a 2.0 system. We haven't released any upgrade intructions yet but I assume they're going to include running mtree. On a correctly setup 2.0 system send-pr will work fine. > > The previos user base does have some knowledge of and occasionally does use > the old bugfiller. In 2.0 this is now just going to dis appear with no > pointer to the new tool. I suggest you add a MLINKS= bugfiler send-pr or > is that send-pr bugfiler. I have posted a detailed explanation of send-pr to -current who are the only people who should be running 2.0 for the moment. I am continuing to look at the most effective way to get the userbase using send-pr as the user base gets broadened out. It wouldn't be bugfiler anything since that's what you run on the server to log the reports. I don't want to link sendbug to send-pr since I want people to be aware that we've changed the mechanism. In addition, sendbug will still be used on pre-2.0 systems since send-pr just doesn't exist on them. The whole issue is rather irrelevant since no-ones actually submitting reports using sendbug anyway and I'm going to actively encourage the submission of reports from now on so I'll be making a lot of noise about send-pr. > > If you had submitted this change for review, these facts would have been > uncovered before the commit and possible have saved me the above debug. > The only fact that needed to be uncovered was that I hadn't enabled send-pr in the Makefile. The rest of the criticisms are inaccurate. -- Paul Richards, FreeBSD core team member. Intelligent Systems Laboratory, ELSYM ,University of Wales, College Cardiff Internet: paul@isl.cf.ac.uk, JANET(UK): RICHARDSDP@CARDIFF.AC.UK