From owner-cvs-lib Sun Mar 26 02:22:16 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id CAA08905 for cvs-lib-outgoing; Sun, 26 Mar 1995 02:22:16 -0800 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id CAA08886; Sun, 26 Mar 1995 02:22:05 -0800 Received: (from root@localhost) by time.cdrom.com (8.6.11/8.6.9) id CAA06866; Sun, 26 Mar 1995 02:21:59 -0800 Date: Sun, 26 Mar 1995 02:21:59 -0800 From: "Jordan K. Hubbard" Message-Id: <199503261021.CAA06866@time.cdrom.com> To: CVS-commiters@time.cdrom.com, cvs-lib@time.cdrom.com Subject: cvs commit: src/lib/libc/stdlib strhash.c Makefile.inc Sender: cvs-lib-owner@freebsd.org Precedence: bulk jkh 95/03/26 02:21:58 Modified: lib/libc/stdlib Makefile.inc Added: lib/libc/stdlib strhash.c Log: Add the strhash family of routines. They provide a number of features that the db/hash functions don't, and they're much simpler to use for low-overhead string hashing. From owner-cvs-lib Sun Mar 26 02:25:22 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id CAA09049 for cvs-lib-outgoing; Sun, 26 Mar 1995 02:25:22 -0800 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id CAA09025; Sun, 26 Mar 1995 02:25:11 -0800 Received: (from root@localhost) by time.cdrom.com (8.6.11/8.6.9) id CAA07180; Sun, 26 Mar 1995 02:25:03 -0800 Date: Sun, 26 Mar 1995 02:25:03 -0800 From: "Jordan K. Hubbard" Message-Id: <199503261025.CAA07180@time.cdrom.com> To: CVS-commiters@time.cdrom.com, cvs-lib@time.cdrom.com Subject: cvs commit: src/lib/libforms fields.c forms.c menu.c parser.y Sender: cvs-lib-owner@freebsd.org Precedence: bulk jkh 95/03/26 02:25:02 Modified: lib/libforms fields.c forms.c menu.c parser.y Log: change hash.h to strhash.h to match new convention. Manpage for strhash functions to follow tomorrow. From owner-cvs-lib Sun Mar 26 10:57:24 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id KAA21972 for cvs-lib-outgoing; Sun, 26 Mar 1995 10:57:24 -0800 Received: (from ache@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id KAA21961; Sun, 26 Mar 1995 10:57:21 -0800 Date: Sun, 26 Mar 1995 10:57:21 -0800 From: "Andrey A. Chernov" Message-Id: <199503261857.KAA21961@freefall.cdrom.com> To: CVS-commiters, cvs-lib Subject: cvs commit: src/lib/libc/locale setlocale.3 Sender: cvs-lib-owner@freebsd.org Precedence: bulk ache 95/03/26 10:57:20 Modified: lib/libc/locale setlocale.3 Log: Update info about LC_COLLATE implementation From owner-cvs-lib Sun Mar 26 11:32:31 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id LAA22713 for cvs-lib-outgoing; Sun, 26 Mar 1995 11:32:31 -0800 Received: (from ache@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id LAA22703; Sun, 26 Mar 1995 11:32:27 -0800 Date: Sun, 26 Mar 1995 11:32:27 -0800 From: "Andrey A. Chernov" Message-Id: <199503261932.LAA22703@freefall.cdrom.com> To: CVS-commiters, cvs-lib Subject: cvs commit: src/lib/libc/stdlib strhash.c Sender: cvs-lib-owner@freebsd.org Precedence: bulk ache 95/03/26 11:32:26 Modified: lib/libc/stdlib strhash.c Log: Hash 8bit chars without sign extension From owner-cvs-lib Sun Mar 26 17:19:19 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id RAA28914 for cvs-lib-outgoing; Sun, 26 Mar 1995 17:19:19 -0800 Received: (from ache@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id RAA28903; Sun, 26 Mar 1995 17:19:16 -0800 Date: Sun, 26 Mar 1995 17:19:16 -0800 From: "Andrey A. Chernov" Message-Id: <199503270119.RAA28903@freefall.cdrom.com> To: CVS-commiters, cvs-lib Subject: cvs commit: src/lib/libncurses lib_scroll.c Sender: cvs-lib-owner@freebsd.org Precedence: bulk ache 95/03/26 17:19:15 Modified: lib/libncurses lib_scroll.c Log: Fix bug using CSR for partial scrolling From owner-cvs-lib Sun Mar 26 21:13:35 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id VAA04082 for cvs-lib-outgoing; Sun, 26 Mar 1995 21:13:35 -0800 Received: (from ache@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id VAA04072; Sun, 26 Mar 1995 21:13:33 -0800 Date: Sun, 26 Mar 1995 21:13:33 -0800 From: "Andrey A. Chernov" Message-Id: <199503270513.VAA04072@freefall.cdrom.com> To: CVS-commiters, cvs-lib Subject: cvs commit: src/lib/libmytinfo cap_list Sender: cvs-lib-owner@freebsd.org Precedence: bulk ache 95/03/26 21:13:32 Modified: lib/libmytinfo cap_list Log: Remove duplicates: parm rindex & scroll right From owner-cvs-lib Mon Mar 27 12:23:17 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id MAA06533 for cvs-lib-outgoing; Mon, 27 Mar 1995 12:23:17 -0800 Received: (from nate@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id MAA06523; Mon, 27 Mar 1995 12:23:13 -0800 Date: Mon, 27 Mar 1995 12:23:13 -0800 From: Nate Williams Message-Id: <199503272023.MAA06523@freefall.cdrom.com> To: CVS-commiters, cvs-lib Subject: cvs commit: src/lib/libc Makefile Sender: cvs-lib-owner@freebsd.org Precedence: bulk nate 95/03/27 12:23:13 Modified: lib/libc Makefile Log: Bump the shared library minor # because of the additions of the strhash() functions. From owner-cvs-lib Mon Mar 27 12:46:47 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id MAA06990 for cvs-lib-outgoing; Mon, 27 Mar 1995 12:46:47 -0800 Received: (from wpaul@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id MAA06980; Mon, 27 Mar 1995 12:46:42 -0800 Date: Mon, 27 Mar 1995 12:46:42 -0800 From: Bill Paul Message-Id: <199503272046.MAA06980@freefall.cdrom.com> To: CVS-commiters, cvs-lib Subject: cvs commit: src/lib/libc/gen getpwent.c Sender: cvs-lib-owner@freebsd.org Precedence: bulk wpaul 95/03/27 12:46:42 Modified: lib/libc/gen getpwent.c Log: Use yp_order() instead of yp_first() in _havemaster() to check for the presence of the master.passwd.byname map, and remember to free the returned order value before exiting. From owner-cvs-lib Tue Mar 28 00:41:18 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id AAA02707 for cvs-lib-outgoing; Tue, 28 Mar 1995 00:41:18 -0800 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id AAA02700; Tue, 28 Mar 1995 00:41:06 -0800 Received: (from root@localhost) by time.cdrom.com (8.6.11/8.6.9) id AAA18142; Tue, 28 Mar 1995 00:41:04 -0800 Date: Tue, 28 Mar 1995 00:41:04 -0800 From: "Jordan K. Hubbard" Message-Id: <199503280841.AAA18142@time.cdrom.com> To: CVS-commiters@time.cdrom.com, cvs-lib@time.cdrom.com Subject: cvs commit: src/lib/libc/stdlib strhash.c Sender: cvs-lib-owner@freebsd.org Precedence: bulk jkh 95/03/28 00:41:03 Modified: lib/libc/stdlib strhash.c Log: Fix a missing _hash() to prevent namespace pollution with the db/hash routines. Grrr. If the dbhash routines weren't grossly overengineered I wouldn't even need to do this! :-( Also now export the hash_stats routine. Manpage coming RSN - I promise. From owner-cvs-lib Tue Mar 28 02:09:09 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id CAA05681 for cvs-lib-outgoing; Tue, 28 Mar 1995 02:09:09 -0800 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id CAA05664; Tue, 28 Mar 1995 02:09:01 -0800 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.34]) by time.cdrom.com (8.6.11/8.6.9) with ESMTP id CAA18347; Tue, 28 Mar 1995 02:08:33 -0800 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id UAA18620; Tue, 28 Mar 1995 20:05:49 +1000 Date: Tue, 28 Mar 1995 20:05:49 +1000 From: Bruce Evans Message-Id: <199503281005.UAA18620@godzilla.zeta.org.au> To: CVS-commiters@time.cdrom.com, cvs-lib@time.cdrom.com, jkh@freebsd.org Subject: Re: cvs commit: src/lib/libc/stdlib strhash.c Sender: cvs-lib-owner@freebsd.org Precedence: bulk > Modified: lib/libc/stdlib strhash.c > Log: > Fix a missing _hash() to prevent namespace pollution with the db/hash routines. > Grrr. If the dbhash routines weren't grossly overengineered I wouldn't > even need to do this! :-( You never needed to rename hash() to _hash(). It is static so it doesn't contribute to namespace pollution. Adding a leading underscore just moves it into the implementation's namespace and might cause problems if the implementation uses it for some other purpose. Since you control the implementation, this is not much of a problem in practice. In the current implementation, you just have to check that there are no declarations for globals named `_hash' in scope. However, for debugging it is convenient to make even the names of internal static objects and functions unique. Names in the `foohash' module could be distinguished from names in the `barhash' module by prefixing them with `foo'. `strhash' is a bad name for a module because names starting with `str' are reserved. Bruce From owner-cvs-lib Tue Mar 28 02:25:33 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id CAA06328 for cvs-lib-outgoing; Tue, 28 Mar 1995 02:25:33 -0800 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id CAA06322; Tue, 28 Mar 1995 02:25:18 -0800 Received: (from root@localhost) by time.cdrom.com (8.6.11/8.6.9) id CAA18588; Tue, 28 Mar 1995 02:25:16 -0800 Date: Tue, 28 Mar 1995 02:25:16 -0800 From: "Jordan K. Hubbard" Message-Id: <199503281025.CAA18588@time.cdrom.com> To: CVS-commiters@time.cdrom.com, cvs-lib@time.cdrom.com Subject: cvs commit: src/lib/libforms/examples example.c Sender: cvs-lib-owner@freebsd.org Precedence: bulk jkh 95/03/28 02:25:15 Modified: lib/libforms/examples example.c Log: Include instead now. From owner-cvs-lib Tue Mar 28 02:25:53 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id CAA06356 for cvs-lib-outgoing; Tue, 28 Mar 1995 02:25:53 -0800 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id CAA06350; Tue, 28 Mar 1995 02:25:51 -0800 Received: from freefall.cdrom.com (freefall.cdrom.com [192.216.222.4]) by time.cdrom.com (8.6.11/8.6.9) with ESMTP id CAA18676; Tue, 28 Mar 1995 02:25:48 -0800 Received: from localhost (localhost [127.0.0.1]) by freefall.cdrom.com (8.6.10/8.6.6) with SMTP id CAA06299; Tue, 28 Mar 1995 02:23:10 -0800 X-Authentication-Warning: freefall.cdrom.com: Host localhost didn't use HELO protocol To: Bruce Evans cc: CVS-commiters@time.cdrom.com, cvs-lib@time.cdrom.com, jkh@freebsd.org Subject: Re: cvs commit: src/lib/libc/stdlib strhash.c In-reply-to: Your message of "Tue, 28 Mar 95 20:05:49 +1000." <199503281005.UAA18620@godzilla.zeta.org.au> Date: Tue, 28 Mar 1995 02:23:10 -0800 Message-ID: <6298.796386190@freefall.cdrom.com> From: "Jordan K. Hubbard" Sender: cvs-lib-owner@freebsd.org Precedence: bulk > You never needed to rename hash() to _hash(). It is static so it doesn't > contribute to namespace pollution. Adding a leading underscore just moves > it into the implementation's namespace and might cause problems if the Well, then we have a problem because the friggin' thing DOES clash when you try to link anything with it otherwise! :-( :-( Give it a try. Perhaps Nate should look into this too, since it's possibly something suspicious with the new ld stuff. > be distinguished from names in the `barhash' module by prefixing them with > `foo'. `strhash' is a bad name for a module because names starting with > `str' are reserved. Well, again, I was just trying to avoid clashing with the existing hash stuff. I'd be more than happy to rename it to hash.c, but when I had it that way originally it clashed with db/hash.c's include of hash.h and I didn't want to rename the header and not the implementation file - that would have been even more confusing. I'll concur that the name strhash was rather deeply uninspired, but I didn't expect the clash in the first place and when it happened I was rather desperate to fix things again quickly. Suggestions? Jordan From owner-cvs-lib Tue Mar 28 02:42:15 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id CAA07009 for cvs-lib-outgoing; Tue, 28 Mar 1995 02:42:15 -0800 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id CAA06999; Tue, 28 Mar 1995 02:42:13 -0800 Received: (from root@localhost) by time.cdrom.com (8.6.11/8.6.9) id CAA22061; Tue, 28 Mar 1995 02:42:10 -0800 Date: Tue, 28 Mar 1995 02:42:10 -0800 From: "Jordan K. Hubbard" Message-Id: <199503281042.CAA22061@time.cdrom.com> To: CVS-commiters@time.cdrom.com, cvs-lib@time.cdrom.com Subject: cvs commit: src/lib/libforms/examples example.c example.frm Sender: cvs-lib-owner@freebsd.org Precedence: bulk jkh 95/03/28 02:42:10 Modified: lib/libforms/examples example.c example.frm Log: Tweak a few things just to show how form traversal might work fully. Fix some spelling errors in the example.c file and make error handling a little more explanatory. From owner-cvs-lib Tue Mar 28 04:01:55 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id EAA10158 for cvs-lib-outgoing; Tue, 28 Mar 1995 04:01:55 -0800 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id EAA10142; Tue, 28 Mar 1995 04:01:51 -0800 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.34]) by time.cdrom.com (8.6.11/8.6.9) with ESMTP id EAA22133; Tue, 28 Mar 1995 04:01:11 -0800 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id VAA21587; Tue, 28 Mar 1995 21:51:24 +1000 Date: Tue, 28 Mar 1995 21:51:24 +1000 From: Bruce Evans Message-Id: <199503281151.VAA21587@godzilla.zeta.org.au> To: bde@zeta.org.au, jkh@freefall.cdrom.com Subject: Re: cvs commit: src/lib/libc/stdlib strhash.c Cc: CVS-commiters@time.cdrom.com, cvs-lib@time.cdrom.com, jkh@freebsd.org Sender: cvs-lib-owner@freebsd.org Precedence: bulk >> You never needed to rename hash() to _hash(). It is static so it doesn't >> contribute to namespace pollution. Adding a leading underscore just moves >> it into the implementation's namespace and might cause problems if the >Well, then we have a problem because the friggin' thing DOES clash when >you try to link anything with it otherwise! :-( :-( What was the problem exactly? `nm *.so' in libc/obj shows no definition of `_hash', so I don't see how dmenu could have linked. (I used nm on *.so instead of on *.o because the `ld -r -x' step removes static names so that you can't debug them :-(. We don't do this for shared libraries where the time savings _might_ be much larger. Hmmm, there must be a lot of missed optimizations for static functions. Their caller can be expected to load the GOT pointer...) >Well, again, I was just trying to avoid clashing with the existing >hash stuff. I'd be more than happy to rename it to hash.c, but when I >had it that way originally it clashed with db/hash.c's include of >hash.h and I didn't want to rename the header and not the >implementation file - that would have been even more confusing. I'll You had to rename the implementation file because the hash.o's would have clashed. >Suggestions? YAhash? :-) Bruce From owner-cvs-lib Tue Mar 28 07:52:22 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id HAA16789 for cvs-lib-outgoing; Tue, 28 Mar 1995 07:52:22 -0800 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id HAA16779; Tue, 28 Mar 1995 07:52:09 -0800 Received: from trout.sri.MT.net (trout.sri.MT.net [204.182.243.12]) by time.cdrom.com (8.6.11/8.6.9) with ESMTP id HAA22315; Tue, 28 Mar 1995 07:52:02 -0800 Received: (from nate@localhost) by trout.sri.MT.net (8.6.9/8.6.9) id IAA06964; Tue, 28 Mar 1995 08:56:00 -0700 Date: Tue, 28 Mar 1995 08:56:00 -0700 Message-Id: <199503281556.IAA06964@trout.sri.MT.net> To: "Jordan K. Hubbard" Cc: Bruce Evans , CVS-commiters@time.cdrom.com, cvs-lib@time.cdrom.com, jkh@freebsd.org Subject: Re: cvs commit: src/lib/libc/stdlib strhash.c In-Reply-To: <6298.796386190@freefall.cdrom.com> References: <199503281005.UAA18620@godzilla.zeta.org.au> <6298.796386190@freefall.cdrom.com> Reply-To: nate@sneezy.sri.com (Nate Williams) From: nate@sneezy.sri.com (Nate Williams) Sender: cvs-lib-owner@freebsd.org Precedence: bulk > > You never needed to rename hash() to _hash(). It is static so it doesn't > > contribute to namespace pollution. Adding a leading underscore just moves > > it into the implementation's namespace and might cause problems if the > > Well, then we have a problem because the friggin' thing DOES clash when > you try to link anything with it otherwise! :-( :-( > > Give it a try. Perhaps Nate should look into this too, since it's > possibly something suspicious with the new ld stuff. I'll look into it this evening. However, it shouldn't be a ld issue, but it may be a compiler/strip issue. If the routine is declared static, it's symbol should never be seen in the symbol table. That feature is a function of the compiler, not of the linker/loader. (Except when it was compiled with debugging I believe, though I'm not positive on that account) Nate From owner-cvs-lib Tue Mar 28 08:28:58 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id IAA20125 for cvs-lib-outgoing; Tue, 28 Mar 1995 08:28:58 -0800 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id IAA20118; Tue, 28 Mar 1995 08:28:55 -0800 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.34]) by time.cdrom.com (8.6.11/8.6.9) with ESMTP id IAA22345; Tue, 28 Mar 1995 08:28:41 -0800 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id CAA28769; Wed, 29 Mar 1995 02:23:53 +1000 Date: Wed, 29 Mar 1995 02:23:53 +1000 From: Bruce Evans Message-Id: <199503281623.CAA28769@godzilla.zeta.org.au> To: jkh@freefall.cdrom.com, nate@sneezy.sri.com Subject: Re: cvs commit: src/lib/libc/stdlib strhash.c Cc: CVS-commiters@time.cdrom.com, bde@zeta.org.au, cvs-lib@time.cdrom.com, jkh@freebsd.org Sender: cvs-lib-owner@freebsd.org Precedence: bulk >but it may be a compiler/strip issue. If the routine is declared >static, it's symbol should never be seen in the symbol table. That It need not be, but gcc is a friendly compiler and puts useful info about static functions in the symbol table. Our bsd.lib.mk strips it from *.o but not from *.so. >feature is a function of the compiler, not of the linker/loader. >(Except when it was compiled with debugging I believe, though I'm not >positive on that account) It's essential to have static symbols for things compiled with -g and useful to have them for things compiled without -g (e.g., /kernel). Bruce From owner-cvs-lib Tue Mar 28 08:50:42 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id IAA20657 for cvs-lib-outgoing; Tue, 28 Mar 1995 08:50:42 -0800 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id IAA20651; Tue, 28 Mar 1995 08:50:39 -0800 Received: from trout.sri.MT.net (trout.sri.MT.net [204.182.243.12]) by time.cdrom.com (8.6.11/8.6.9) with ESMTP id IAA22366; Tue, 28 Mar 1995 08:50:21 -0800 Received: (from nate@localhost) by trout.sri.MT.net (8.6.9/8.6.9) id JAA13496; Tue, 28 Mar 1995 09:53:28 -0700 Date: Tue, 28 Mar 1995 09:53:28 -0700 From: Nate Williams Message-Id: <199503281653.JAA13496@trout.sri.MT.net> In-Reply-To: Bruce Evans "Re: cvs commit: src/lib/libc/stdlib strhash.c" (Mar 29, 2:23am) X-Mailer: Mail User's Shell (7.2.5 10/14/92) To: Bruce Evans , jkh@freefall.cdrom.com Subject: Re: cvs commit: src/lib/libc/stdlib strhash.c Cc: CVS-commiters@time.cdrom.com, cvs-lib@time.cdrom.com Sender: cvs-lib-owner@freebsd.org Precedence: bulk > >but it may be a compiler/strip issue. If the routine is declared > >static, it's symbol should never be seen in the symbol table. That > > It need not be, but gcc is a friendly compiler and puts useful info > about static functions in the symbol table. Our bsd.lib.mk strips > it from *.o but not from *.so. What good things come from the info from static functions in non-debuggable libraries? I think we should be stripping that info. from the shared .o's as well. > >feature is a function of the compiler, not of the linker/loader. > >(Except when it was compiled with debugging I believe, though I'm not > >positive on that account) > > It's essential to have static symbols for things compiled with -g and > useful to have them for things compiled without -g (e.g., /kernel). Agreed, but I think the usefulness of the symbols being in w/out -g is not enough to justify the symbol being in the default libraries. The libraries are the issue here, and not the kernel. Generally speaking most people don't want to debug binaries w/out the debugging information in (the poor unwashed never needed to use non-symbolic debuggers :), so I propose that we strip out the static symbols from the standard shared libraries. Nate From owner-cvs-lib Tue Mar 28 09:49:26 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id JAA22263 for cvs-lib-outgoing; Tue, 28 Mar 1995 09:49:26 -0800 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id JAA22257; Tue, 28 Mar 1995 09:49:23 -0800 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.34]) by time.cdrom.com (8.6.11/8.6.9) with ESMTP id JAA22412; Tue, 28 Mar 1995 09:49:08 -0800 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id DAA30539; Wed, 29 Mar 1995 03:46:17 +1000 Date: Wed, 29 Mar 1995 03:46:17 +1000 From: Bruce Evans Message-Id: <199503281746.DAA30539@godzilla.zeta.org.au> To: bde@zeta.org.au, jkh@freefall.cdrom.com, nate@trout.sri.MT.net Subject: Re: cvs commit: src/lib/libc/stdlib strhash.c Cc: CVS-commiters@time.cdrom.com, cvs-lib@time.cdrom.com Sender: cvs-lib-owner@freebsd.org Precedence: bulk >What good things come from the info from static functions in >non-debuggable libraries? I think we should be stripping that info. from >the shared .o's as well. All libraries are debuggable :-). >Generally speaking most people don't want to debug binaries w/out the >debugging information in (the poor unwashed never needed to use >non-symbolic debuggers :), so I propose that we strip out the static >symbols from the standard shared libraries. We don't supply libraries compiled with -g so the static symbols are more important than they should be. `ld -r -x' on libc/obj/*.so saves a whole 21K out of 535K. Many static symbols with long names are not removed. In fact, they become longer: for the object yplib.so, yplib.so.L179 becomes yplib.so.yplib.so.L179. I think there is a linker bug or two here. Shared objects are "stripped" using `ld -r -X'. The label for yplib.so was originally L179 and "stripping" turned it into yplib.so.L179 instead of removing it like the -X flag says to. Bruce From owner-cvs-lib Tue Mar 28 10:00:12 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id KAA22668 for cvs-lib-outgoing; Tue, 28 Mar 1995 10:00:12 -0800 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id KAA22662; Tue, 28 Mar 1995 10:00:11 -0800 Received: from trout.sri.MT.net (trout.sri.MT.net [204.182.243.12]) by time.cdrom.com (8.6.11/8.6.9) with ESMTP id KAA22425; Tue, 28 Mar 1995 10:00:00 -0800 Received: (from nate@localhost) by trout.sri.MT.net (8.6.9/8.6.9) id LAA19382; Tue, 28 Mar 1995 11:03:36 -0700 Date: Tue, 28 Mar 1995 11:03:36 -0700 From: Nate Williams Message-Id: <199503281803.LAA19382@trout.sri.MT.net> In-Reply-To: Bruce Evans "Re: cvs commit: src/lib/libc/stdlib strhash.c" (Mar 29, 3:46am) X-Mailer: Mail User's Shell (7.2.5 10/14/92) To: Bruce Evans , jkh@freefall.cdrom.com Subject: Re: cvs commit: src/lib/libc/stdlib strhash.c Cc: CVS-commiters@time.cdrom.com, cvs-lib@time.cdrom.com Sender: cvs-lib-owner@freebsd.org Precedence: bulk > >Generally speaking most people don't want to debug binaries w/out the > >debugging information in (the poor unwashed never needed to use > >non-symbolic debuggers :), so I propose that we strip out the static > >symbols from the standard shared libraries. > > We don't supply libraries compiled with -g so the static symbols are > more important than they should be. Except that the majority of the users can't debug them w/out the debugging information in them. If users need debuggable libraries, they will have to compile them w/debugging information. IMHO, most users assume that the libraries don't need to be debugged. > `ld -r -x' on libc/obj/*.so saves a whole 21K out of 535K. Many static > symbols with long names are not removed. In fact, they become longer: > for the object yplib.so, yplib.so.L179 becomes yplib.so.yplib.so.L179. > I think there is a linker bug or two here. I'll look into it. > Shared objects are > "stripped" using `ld -r -X'. See my recent commit message. This was a mistake I made when I brought in the strip changes from NetBSD. There may be bugs in the stripping function in ld, but at least we are depending on the same ones as the NetBSD folks. :-) > The label for yplib.so was originally > L179 and "stripping" turned it into yplib.so.L179 instead of removing > it like the -X flag says to. Another 'ld/strip' bug I suspect. Nate From owner-cvs-lib Tue Mar 28 11:27:42 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id LAA24787 for cvs-lib-outgoing; Tue, 28 Mar 1995 11:27:42 -0800 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id LAA24779; Tue, 28 Mar 1995 11:27:36 -0800 Received: from freefall.cdrom.com (freefall.cdrom.com [192.216.222.4]) by time.cdrom.com (8.6.11/8.6.9) with ESMTP id LAA22493; Tue, 28 Mar 1995 11:27:32 -0800 Received: from localhost (localhost [127.0.0.1]) by freefall.cdrom.com (8.6.10/8.6.6) with SMTP id LAA24718; Tue, 28 Mar 1995 11:25:15 -0800 X-Authentication-Warning: freefall.cdrom.com: Host localhost didn't use HELO protocol To: Bruce Evans cc: CVS-commiters@time.cdrom.com, cvs-lib@time.cdrom.com, jkh@freebsd.org Subject: Re: cvs commit: src/lib/libc/stdlib strhash.c In-reply-to: Your message of "Tue, 28 Mar 95 21:51:24 +1000." <199503281151.VAA21587@godzilla.zeta.org.au> Date: Tue, 28 Mar 1995 11:25:14 -0800 Message-ID: <24717.796418714@freefall.cdrom.com> From: "Jordan K. Hubbard" Sender: cvs-lib-owner@freebsd.org Precedence: bulk > What was the problem exactly? `nm *.so' in libc/obj shows no definition > of `_hash', so I don't see how dmenu could have linked. (I used nm on > *.so instead of on *.o because the `ld -r -x' step removes static names Easier for you to just rename _hash() to hash() in strhash.c and then try to link something like dmenu against it. You'll see the failure mode. Jordan From owner-cvs-lib Tue Mar 28 14:20:23 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id OAA29680 for cvs-lib-outgoing; Tue, 28 Mar 1995 14:20:23 -0800 Received: (from dfr@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id OAA29670; Tue, 28 Mar 1995 14:20:21 -0800 Date: Tue, 28 Mar 1995 14:20:21 -0800 From: Doug Rabson Message-Id: <199503282220.OAA29670@freefall.cdrom.com> To: CVS-commiters, cvs-lib Subject: cvs commit: src/lib/libcurses setterm.c Sender: cvs-lib-owner@freebsd.org Precedence: bulk dfr 95/03/28 14:20:20 Modified: lib/libcurses setterm.c Log: Use __tty_fileno instead of STDERR_FILENO when detecting window size changes Reviewed by: Bob Willcox From owner-cvs-lib Wed Mar 29 11:28:44 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id LAA26839 for cvs-lib-outgoing; Wed, 29 Mar 1995 11:28:44 -0800 Received: (from ache@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id LAA26823; Wed, 29 Mar 1995 11:28:40 -0800 Date: Wed, 29 Mar 1995 11:28:40 -0800 From: "Andrey A. Chernov" Message-Id: <199503291928.LAA26823@freefall.cdrom.com> To: CVS-commiters, cvs-lib Subject: cvs commit: src/lib/libc/gen termios.c Sender: cvs-lib-owner@freebsd.org Precedence: bulk ache 95/03/29 11:28:39 Modified: lib/libc/gen termios.c Log: Clear IGNPAR in cfmakeraw() instead of set it. From owner-cvs-lib Wed Mar 29 22:40:34 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id WAA16790 for cvs-lib-outgoing; Wed, 29 Mar 1995 22:40:34 -0800 Received: (from phk@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id WAA16780; Wed, 29 Mar 1995 22:40:33 -0800 Date: Wed, 29 Mar 1995 22:40:33 -0800 From: Poul-Henning Kamp Message-Id: <199503300640.WAA16780@freefall.cdrom.com> To: CVS-commiters, cvs-lib Subject: cvs commit: src/lib/csu/i386 Makefile Sender: cvs-lib-owner@freebsd.org Precedence: bulk phk 95/03/29 22:40:32 Modified: lib/csu/i386 Makefile Log: Install the dlopen.3 manpage. From owner-cvs-lib Thu Mar 30 04:37:21 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id EAA25793 for cvs-lib-outgoing; Thu, 30 Mar 1995 04:37:21 -0800 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id EAA25787; Thu, 30 Mar 1995 04:37:18 -0800 Received: (from root@localhost) by time.cdrom.com (8.6.11/8.6.9) id EAA07051; Thu, 30 Mar 1995 04:37:06 -0800 Date: Thu, 30 Mar 1995 04:37:06 -0800 From: "Jordan K. Hubbard" Message-Id: <199503301237.EAA07051@time.cdrom.com> To: CVS-commiters@time.cdrom.com, cvs-lib@time.cdrom.com Subject: cvs commit: src/lib/libc/nls - New directory Sender: cvs-lib-owner@freebsd.org Precedence: bulk jkh 95/03/30 04:37:05 src/lib/libc/nls - New directory From owner-cvs-lib Thu Mar 30 04:46:55 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id EAA26032 for cvs-lib-outgoing; Thu, 30 Mar 1995 04:46:55 -0800 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id EAA26025; Thu, 30 Mar 1995 04:46:51 -0800 Received: (from root@localhost) by time.cdrom.com (8.6.11/8.6.9) id EAA07192; Thu, 30 Mar 1995 04:46:39 -0800 Date: Thu, 30 Mar 1995 04:46:39 -0800 From: "Jordan K. Hubbard" Message-Id: <199503301246.EAA07192@time.cdrom.com> To: CVS-commiters@time.cdrom.com, cvs-lib@time.cdrom.com Subject: cvs commit: src/lib/libc Makefile Sender: cvs-lib-owner@freebsd.org Precedence: bulk jkh 95/03/30 04:46:38 Modified: lib/libc Makefile Log: Add nls include to Makefile. From owner-cvs-lib Thu Mar 30 04:47:43 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id EAA26062 for cvs-lib-outgoing; Thu, 30 Mar 1995 04:47:43 -0800 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id EAA26056; Thu, 30 Mar 1995 04:47:41 -0800 Received: (from root@localhost) by time.cdrom.com (8.6.11/8.6.9) id EAA07241; Thu, 30 Mar 1995 04:47:29 -0800 Date: Thu, 30 Mar 1995 04:47:29 -0800 From: "Jordan K. Hubbard" Message-Id: <199503301247.EAA07241@time.cdrom.com> To: CVS-commiters@time.cdrom.com, cvs-lib@time.cdrom.com Subject: cvs commit: src/lib/libc/nls Makefile.inc catclose.3 catclose.c catgets.3 catgets.c catopen.3 catopen.c msgcat.c msgcat.h Sender: cvs-lib-owner@freebsd.org Precedence: bulk jkh 95/03/30 04:47:28 Added: lib/libc/nls Makefile.inc catclose.3 catclose.c catgets.3 catgets.c catopen.3 catopen.c msgcat.c msgcat.h Log: Add the nls code for XPG3-style message catalogs to libc. Obtained from: NetBSD From owner-cvs-lib Sat Apr 1 17:03:48 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id RAA14283 for cvs-lib-outgoing; Sat, 1 Apr 1995 17:03:48 -0800 Received: (from wpaul@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id RAA14201; Sat, 1 Apr 1995 17:02:19 -0800 Date: Sat, 1 Apr 1995 17:02:19 -0800 From: Bill Paul Message-Id: <199504020102.RAA14201@freefall.cdrom.com> To: CVS-commiters, cvs-lib Subject: cvs commit: src/lib/libc/yp xdryp.c Sender: cvs-lib-owner@freebsd.org Precedence: bulk wpaul 95/04/01 17:02:18 Modified: lib/libc/yp xdryp.c Log: Add some missing xdr functions needed for server-side implementations. (This is to help me reduce yppush a bit: it has its own copy of yp_xdr.c right now, but I can get rid of it now that this stuff is here.) From owner-cvs-lib Sat Apr 1 17:32:44 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id RAA17910 for cvs-lib-outgoing; Sat, 1 Apr 1995 17:32:44 -0800 Received: (from wpaul@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id RAA17745; Sat, 1 Apr 1995 17:31:20 -0800 Date: Sat, 1 Apr 1995 17:31:20 -0800 From: Bill Paul Message-Id: <199504020131.RAA17745@freefall.cdrom.com> To: CVS-commiters, cvs-lib Subject: cvs commit: src/lib/libc/net ether_addr.c Makefile.inc Sender: cvs-lib-owner@freebsd.org Precedence: bulk wpaul 95/04/01 17:31:19 Modified: lib/libc/net Makefile.inc Added: lib/libc/net ether_addr.c Log: Add ether_addr functions to libc. This seems to be the logical place to put them. A man page is in the works.