From owner-cvs-lib Mon Jun 26 08:00:01 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id IAA16258 for cvs-lib-outgoing; Mon, 26 Jun 1995 08:00:01 -0700 Received: (from wpaul@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id HAA16244 ; Mon, 26 Jun 1995 07:59:50 -0700 Date: Mon, 26 Jun 1995 07:59:50 -0700 From: Bill Paul Message-Id: <199506261459.HAA16244@freefall.cdrom.com> To: CVS-commiters, cvs-lib Subject: cvs commit: src/lib/libc/gen getgrent.c Sender: cvs-lib-owner@freebsd.org Precedence: bulk wpaul 95/06/26 07:59:49 Modified: lib/libc/gen getgrent.c Log: Fix for a potential problem reported by a user I bumped into on IRC last night: _gr_breakout_yp() doesn't check for badly formatted NIS group entries. For example, a bogus entry like this: bootp::user1,user2,user3 will lead to a null pointer dereference and a SEGV (note that the GID field is missing -- this results in one of the strsep(&result, ":") returning NULL). The symtpom of this problem is programs dumping core left and right the moment you add a + entry to /etc/group. Note that while this is similar to an earlier bug, it's caused by a different set of circumstances. The fix is to check for the NULL pointers and have _gr_breakout_yp() punt and return a failure code if it catches one. This is more or less the behavior of SunOS: if a bad NIS group entry is encountered, it's silently ignored. I don't think our standard (non-NIS) group parsing code behaves the same way. It doesn't crash though, so I'm citing the 'it ain't broken, don't fix it' rule and leaving it alone. I'll probably have to add similar checks to _pw_breakout_yp() in getpwent.c to ward off the same problems. It's rare that bad NIS map entries like this occur, but we should handle them gracefully when they do. From owner-cvs-lib Mon Jun 26 09:05:06 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id JAA20543 for cvs-lib-outgoing; Mon, 26 Jun 1995 09:05:06 -0700 Received: (from wpaul@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id JAA20529 ; Mon, 26 Jun 1995 09:04:59 -0700 Date: Mon, 26 Jun 1995 09:04:59 -0700 From: Bill Paul Message-Id: <199506261604.JAA20529@freefall.cdrom.com> To: CVS-commiters, cvs-lib Subject: cvs commit: src/lib/libc/gen getpwent.c Sender: cvs-lib-owner@freebsd.org Precedence: bulk wpaul 95/06/26 09:04:59 Modified: lib/libc/gen getpwent.c Log: Do the same sanity checking in _pw_breakout_yp() that we do in _gr_breakout_yp(): if we encounter a NULL pointer generated as the result of a badly formatted NIS passwd entry (e.g. missing fields), we punt and return an error code, thereby silently skipping the bad entry. From owner-cvs-lib Tue Jun 27 02:53:47 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id CAA22536 for cvs-lib-outgoing; Tue, 27 Jun 1995 02:53:47 -0700 Received: (from dfr@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id CAA22501 ; Tue, 27 Jun 1995 02:53:31 -0700 Date: Tue, 27 Jun 1995 02:53:31 -0700 From: Doug Rabson Message-Id: <199506270953.CAA22501@freefall.cdrom.com> To: CVS-commiters, cvs-lib Subject: cvs commit: src/lib/csu/i386 c++rt0.c crt0.c Sender: cvs-lib-owner@freebsd.org Precedence: bulk dfr 95/06/27 02:53:29 Modified: include link.h gnu/usr.bin/ld/rtld rtld.c lib/csu/i386 c++rt0.c crt0.c Log: Change ld.so to correctly load dependant libraries for dlopen and unload them on dlclose. Also correctly call constructors and destructors for libraries linked with /usr/lib/c++rt0.o. Change interpretation of dlopen manpage to call _init() rather than init() for dlopened objects. Change c++rt0.o to avoid using atexit to call destructors, allowing dlclose to call destructors when an object is unloaded. Change interface between crt0 and ld.so to allow crt0 to call a function on exit to call destructors for shared libraries explicitly. These changes are backwards compatible. Old binaries will work with the new ld.so and new binaries will work with the old ld.so. A version number has been introduced in the crt0-ld.so interface to allow for future changes. Reviewed by: GAWollman, Craig Struble From owner-cvs-lib Tue Jun 27 23:26:15 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id XAA23838 for cvs-lib-outgoing; Tue, 27 Jun 1995 23:26:15 -0700 Received: (from davidg@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id XAA23824 ; Tue, 27 Jun 1995 23:26:12 -0700 Date: Tue, 27 Jun 1995 23:26:12 -0700 From: David Greenman Message-Id: <199506280626.XAA23824@freefall.cdrom.com> To: CVS-commiters, cvs-lib Subject: cvs commit: src/lib/libkvm kvm_getprocs.3 Sender: cvs-lib-owner@freebsd.org Precedence: bulk davidg 95/06/27 23:26:11 Modified: lib/libkvm kvm_getprocs.3 Log: (2.1.0 branch) Bring in changes from 1.2 - fix manual page to reflect sysctl-based kvm_getprocs(). Submitted by: Jeorg Wunsch From owner-cvs-lib Fri Jun 30 08:30:49 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id IAA05496 for cvs-lib-outgoing; Fri, 30 Jun 1995 08:30:49 -0700 Received: (from wollman@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id IAA05460 ; Fri, 30 Jun 1995 08:30:38 -0700 Date: Fri, 30 Jun 1995 08:30:38 -0700 From: "Garrett A. Wollman" Message-Id: <199506301530.IAA05460@freefall.cdrom.com> To: CVS-commiters, cvs-lib Subject: cvs commit: src/lib/csu/i386 Makefile Sender: cvs-lib-owner@freebsd.org Precedence: bulk wollman 95/06/30 08:30:37 Modified: lib/csu/i386 Makefile Log: Numerous Makefile fixes: 1) Do dependencies. 2) Install all appropriate links to manual pages. 3) Install header file in `beforeinstall' like all the rest. 4) Install header file only if changed. 5) Install object files only if changed. From owner-cvs-lib Fri Jun 30 11:37:07 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id LAA11735 for cvs-lib-outgoing; Fri, 30 Jun 1995 11:37:07 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id LAA11719 ; Fri, 30 Jun 1995 11:36:55 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id LAA13484; Fri, 30 Jun 1995 11:36:48 -0700 From: "Rodney W. Grimes" Message-Id: <199506301836.LAA13484@gndrsh.aac.dev.com> Subject: Re: cvs commit: src/lib/csu/i386 Makefile To: wollman@freefall.cdrom.com (Garrett A. Wollman) Date: Fri, 30 Jun 1995 11:36:47 -0700 (PDT) Cc: CVS-commiters@freefall.cdrom.com, cvs-lib@freefall.cdrom.com In-Reply-To: <199506301530.IAA05460@freefall.cdrom.com> from "Garrett A. Wollman" at Jun 30, 95 08:30:38 am X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 819 Sender: cvs-lib-owner@freebsd.org Precedence: bulk > > wollman 95/06/30 08:30:37 > > Modified: lib/csu/i386 Makefile > Log: > Numerous Makefile fixes: > > 1) Do dependencies. Thanks! > 2) Install all appropriate links to manual pages. Thanks! > 3) Install header file in `beforeinstall' like all the rest. Thanks! > 4) Install header file only if changed. Thanks! > 5) Install object files only if changed. No thanks, no place else in the tree do we check for object file change an do the install based on that. Please, drop this one piece out as it makes a ``special case'' of it :-(. If this is a desired function it should be handled in the .mk files, not in the Makefile files. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Reliable computers for FreeBSD From owner-cvs-lib Fri Jun 30 11:44:56 1995 Return-Path: cvs-lib-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id LAA12754 for cvs-lib-outgoing; Fri, 30 Jun 1995 11:44:56 -0700 Received: from halloran-eldar.lcs.mit.edu (halloran-eldar.lcs.mit.edu [18.26.0.159]) by freefall.cdrom.com (8.6.10/8.6.6) with SMTP id LAA12699 ; Fri, 30 Jun 1995 11:44:40 -0700 Received: by halloran-eldar.lcs.mit.edu; (5.65/1.1.3.6) id AA03974; Fri, 30 Jun 1995 14:44:21 -0400 Date: Fri, 30 Jun 1995 14:44:21 -0400 From: Garrett Wollman Message-Id: <9506301844.AA03974@halloran-eldar.lcs.mit.edu> To: "Rodney W. Grimes" Cc: CVS-commiters@freefall.cdrom.com, cvs-lib@freefall.cdrom.com Subject: Re: cvs commit: src/lib/csu/i386 Makefile In-Reply-To: <199506301836.LAA13484@gndrsh.aac.dev.com> References: <199506301530.IAA05460@freefall.cdrom.com> <199506301836.LAA13484@gndrsh.aac.dev.com> Sender: cvs-lib-owner@freebsd.org Precedence: bulk < said: >> 5) Install object files only if changed. > No thanks, no place else in the tree do we check for object file change > an do the install based on that. No place else in the tree do we install object files. -GAWollman -- Garrett A. Wollman | Shashish is simple, it's discreet, it's brief. ... wollman@lcs.mit.edu | Shashish is the bonding of hearts in spite of distance. Opinions not those of| It is a bond more powerful than absence. We like people MIT, LCS, ANA, or NSA| who like Shashish. - Claude McKenzie + Florent Vollant