From owner-freebsd-bugs Sun Dec 3 03:38:39 1995 Return-Path: owner-bugs Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id DAA16982 for bugs-outgoing; Sun, 3 Dec 1995 03:38:39 -0800 Received: from silvia.HIP.Berkeley.EDU (silvia.HIP.Berkeley.EDU [136.152.64.181]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id DAA16973 for ; Sun, 3 Dec 1995 03:38:27 -0800 Received: (from asami@localhost) by silvia.HIP.Berkeley.EDU (8.6.12/8.6.9) id DAA00798; Sun, 3 Dec 1995 03:38:12 -0800 Date: Sun, 3 Dec 1995 03:38:12 -0800 Message-Id: <199512031138.DAA00798@silvia.HIP.Berkeley.EDU> To: davidg@Root.COM CC: gavin@spider.co.uk, freebsd-bugs@freebsd.org In-reply-to: <199511221743.JAA00412@corbin.Root.COM> (message from David Greenman on Wed, 22 Nov 1995 09:43:14 -0800) Subject: Re: Problem of '=' instead of '==' in if_ed.c version 1.87 From: asami@cs.berkeley.edu (Satoshi Asami) Sender: owner-bugs@freebsd.org Precedence: bulk * > if (sc->type = ED_TYPE_SMC8216C) { * > if (sc->type == ED_TYPE_SMC8216C) { * Yikes! That slipped past my review. Fortunately the effect of this is only Doesn't gcc catch this (well warn about it anyway) sort of thing with -Wall (or -Wparentheses to be more exact)? I've found this feature extremely helpful.... Satoshi