From owner-cvs-bin Sun Jan 14 10:55:41 1996 Return-Path: owner-cvs-bin Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id KAA16332 for cvs-bin-outgoing; Sun, 14 Jan 1996 10:55:41 -0800 (PST) Received: (from bde@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id KAA16279 Sun, 14 Jan 1996 10:55:21 -0800 (PST) Date: Sun, 14 Jan 1996 10:55:21 -0800 (PST) From: Bruce Evans Message-Id: <199601141855.KAA16279@freefall.freebsd.org> To: cvs-bin, CVS-committers Subject: cvs commit: src/bin/df df.c Sender: owner-cvs-bin@FreeBSD.ORG Precedence: bulk bde 96/01/14 10:55:10 Modified: sys/ufs/ffs ffs_vfsops.c bin/df df.c Log: Partially fixed negative and truncated "Avail" counts in df output. This fixes PR943. ffs/ffs_vfsops.c: ffs_statfs() multiplied by (100 - minfree) as part of calculating the minfree percentage (complemented in 100%), so with the standard minfree of 8, it was broken for file systems of size >= 1TB/92 = 11GB. Use the standard freespace() macro instead. This also fixes a rounding bug (the "Avail" count was sometimes 1 too small). ffs/* (not fixed): The freespace() macro multiplies by minfree, so with the standard minfree of 8, it is broken for file systems of size >= 1TB/8 = 128GB. This bug is more serious since it affects block allocation. ffs/ffs_alloc.c (not fixed): Ordinary users are sometimes allowed to allocate 1 (partial) block too many so that the "Avail" count goes negative. E.g., if there is 1 fragment available and the file is fairly large, one more full block is allocated. df/df.c: ufs_df() used/uses essentially the same code as ffs_statfs(), so it had/has the same bugs. ufs_df() gratuitously replaced "Avail" counts of < 0 by 0, so it gave different results for non-mounted file systems in this case. Revision Changes Path 1.34 +2 -3 src/sys/ufs/ffs/ffs_vfsops.c 1.8 +2 -5 src/bin/df/df.c From owner-cvs-bin Mon Jan 15 03:45:12 1996 Return-Path: owner-cvs-bin Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id DAA08608 for cvs-bin-outgoing; Mon, 15 Jan 1996 03:45:12 -0800 (PST) Received: from silvia.HIP.Berkeley.EDU (silvia.HIP.Berkeley.EDU [136.152.64.181]) by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id DAA08603 Mon, 15 Jan 1996 03:45:08 -0800 (PST) Received: (from asami@localhost) by silvia.HIP.Berkeley.EDU (8.7.3/8.6.9) id DAA01670; Mon, 15 Jan 1996 03:45:04 -0800 (PST) Date: Mon, 15 Jan 1996 03:45:04 -0800 (PST) Message-Id: <199601151145.DAA01670@silvia.HIP.Berkeley.EDU> To: bde@freefall.freebsd.org CC: cvs-bin@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, nisha@cs.berkeley.edu In-reply-to: <199601141855.KAA16279@freefall.freebsd.org> (message from Bruce Evans on Sun, 14 Jan 1996 10:55:21 -0800 (PST)) Subject: Re: cvs commit: src/bin/df df.c From: asami@cs.berkeley.edu (Satoshi Asami) Sender: owner-cvs-bin@FreeBSD.ORG Precedence: bulk * Log: * Partially fixed negative and truncated "Avail" counts in df output. * This fixes PR943. Thanks, df works fine now! Satoshi From owner-cvs-bin Sat Jan 20 02:31:37 1996 Return-Path: owner-cvs-bin Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id CAA01927 for cvs-bin-outgoing; Sat, 20 Jan 1996 02:31:37 -0800 (PST) Received: (from mpp@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id CAA01877 Sat, 20 Jan 1996 02:31:20 -0800 (PST) Date: Sat, 20 Jan 1996 02:31:20 -0800 (PST) From: Mike Pritchard Message-Id: <199601201031.CAA01877@freefall.freebsd.org> To: cvs-bin, CVS-committers Subject: cvs commit: src/bin/ls print.c Sender: owner-cvs-bin@FreeBSD.ORG Precedence: bulk mpp 96/01/20 02:31:18 Modified: bin/ls print.c Log: Remove unused include of utmp.h from print.c. Closes PR# 486. Submitted by: Tom Samplonius Revision Changes Path 1.8 +1 -2 src/bin/ls/print.c From owner-cvs-bin Sat Jan 20 02:44:20 1996 Return-Path: owner-cvs-bin Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id CAA08842 for cvs-bin-outgoing; Sat, 20 Jan 1996 02:44:20 -0800 (PST) Received: (from mpp@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id CAA08686 Sat, 20 Jan 1996 02:43:58 -0800 (PST) Date: Sat, 20 Jan 1996 02:43:58 -0800 (PST) From: Mike Pritchard Message-Id: <199601201043.CAA08686@freefall.freebsd.org> To: cvs-bin, CVS-committers Subject: cvs commit: src/bin/ps ps.c Sender: owner-cvs-bin@FreeBSD.ORG Precedence: bulk mpp 96/01/20 02:43:57 Modified: bin/ps ps.c Log: Use the correct buffer size from limits.h for the error buffer passed to kvm_open. Closes PR# 476. Submitted by: Jeffrey Hsu Revision Changes Path 1.12 +3 -2 src/bin/ps/ps.c