From owner-cvs-include Wed Dec 4 03:30:31 1996 Return-Path: owner-cvs-include Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA25622 for cvs-include-outgoing; Wed, 4 Dec 1996 03:30:31 -0800 (PST) Received: (from jkh@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA25553; Wed, 4 Dec 1996 03:30:18 -0800 (PST) Date: Wed, 4 Dec 1996 03:30:18 -0800 (PST) From: "Jordan K. Hubbard" Message-Id: <199612041130.DAA25553@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-include Subject: cvs commit: src/include utmp.h Sender: owner-cvs-include@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 96/12/04 03:30:17 Modified: include utmp.h Log: Bump maximum username length to 16 characters. This brings us into line with BSD/OS and Linux's username limits, making transitioning from either operating system a lot easier than it is now. I'm currently running with this change on my system, as are several others, and have experienced no ill effects. This is not for 2.2! This needs to get shaken out longer term in 3.0. Previously-approved-by: davidg Revision Changes Path 1.3 +2 -2 src/include/utmp.h From owner-cvs-include Thu Dec 5 06:34:48 1996 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id GAA10405 for cvs-include-outgoing; Thu, 5 Dec 1996 06:34:48 -0800 (PST) Received: (from ache@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id GAA10379; Thu, 5 Dec 1996 06:34:27 -0800 (PST) From: "Andrey A. Chernov" Message-Id: <199612051434.GAA10379@freefall.freebsd.org> Subject: Re: cvs commit: src/include utmp.h To: jkh@freefall.freebsd.org (Jordan K. Hubbard) Date: Thu, 5 Dec 1996 06:34:26 -0800 (PST) Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-include@freefall.freebsd.org In-Reply-To: <199612041130.DAA25553@freefall.freebsd.org> from "Jordan K. Hubbard" at Dec 4, 96 03:30:18 am X-Mailer: ELM [version 2.4 PL24] Content-Type: text Sender: owner-cvs-include@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > > jkh 96/12/04 03:30:17 > > Modified: include utmp.h > Log: > Bump maximum username length to 16 characters. This brings us into > line with BSD/OS and Linux's username limits, making transitioning from > either operating system a lot easier than it is now. I'm currently > running with this change on my system, as are several others, and have > experienced no ill effects. I hear BSDI increase UT_HOSTSIZE to 32, do we plan to make similar change? (I don't have BSDI box to be shure) From owner-cvs-include Thu Dec 5 06:47:01 1996 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id GAA11049 for cvs-include-outgoing; Thu, 5 Dec 1996 06:47:01 -0800 (PST) Received: (from ache@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id GAA11040; Thu, 5 Dec 1996 06:46:59 -0800 (PST) Date: Thu, 5 Dec 1996 06:46:59 -0800 (PST) From: "Andrey A. Chernov" Message-Id: <199612051446.GAA11040@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-include Subject: cvs commit: src/include fnmatch.h Sender: owner-cvs-include@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 96/12/05 06:46:59 Modified: include fnmatch.h Log: Fix compiler warning: /* inside comment 2.2 candidate Revision Changes Path 1.5 +1 -1 src/include/fnmatch.h From owner-cvs-include Thu Dec 5 07:03:41 1996 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id HAA12045 for cvs-include-outgoing; Thu, 5 Dec 1996 07:03:41 -0800 (PST) Received: from spinner.DIALix.COM (root@spinner.DIALix.COM [192.203.228.67]) by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id GAA11502; Thu, 5 Dec 1996 06:58:30 -0800 (PST) Received: from spinner.DIALix.COM (peter@localhost.DIALix.oz.au [127.0.0.1]) by spinner.DIALix.COM (8.8.4/8.8.4) with ESMTP id WAA08975; Thu, 5 Dec 1996 22:58:27 +0800 (WST) Message-Id: <199612051458.WAA08975@spinner.DIALix.COM> To: "Andrey A. Chernov" cc: jkh@freefall.freebsd.org (Jordan K. Hubbard), CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-include@freefall.freebsd.org Subject: Re: cvs commit: src/include utmp.h In-reply-to: Your message of "Thu, 05 Dec 1996 06:34:26 PST." <199612051434.GAA10379@freefall.freebsd.org> Date: Thu, 05 Dec 1996 22:58:26 +0800 From: Peter Wemm Sender: owner-cvs-include@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk "Andrey A. Chernov" wrote: > > jkh 96/12/04 03:30:17 > > > > Modified: include utmp.h > > Log: > > Bump maximum username length to 16 characters. This brings us into > > line with BSD/OS and Linux's username limits, making transitioning from > > either operating system a lot easier than it is now. I'm currently > > running with this change on my system, as are several others, and have > > experienced no ill effects. > > I hear BSDI increase UT_HOSTSIZE to 32, do we plan to make similar change? > (I don't have BSDI box to be shure) Yes, BSDI have gone to user=16,line=8,host=32. I would very much like this as well, but I'd also like to suggest we pluck a leaf from the SunOS/SYSV/Linux book and take a couple of extra fields as well. I would like to see: ut_pid (pid of session. This is painful to work around not having!) ut_type (some sort of type-of-record code to replace the "magic" characters in some of the username or tty fields.) ut_hostid (normally an in_addr type of entry so that we can always find the originating host without having to bogusly interpret or convert ut_host to/from hostnames and dotted-quad IP addresses.) ut_host (increased to pad out the record size to a convenient power of 2) I don't see a mirror image of the BSDI file format as particularly important, in all my travels, I've never seen an application (read: non-system) binary that uses the utmp file, except on my SVR3 days. I think Garrett expressed a desire to have a 'version' field somewhere. Cheers, -Peter From owner-cvs-include Thu Dec 5 08:19:23 1996 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id IAA17042 for cvs-include-outgoing; Thu, 5 Dec 1996 08:19:23 -0800 (PST) Received: from time.cdrom.com (time.cdrom.com [204.216.27.226]) by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id IAA17030; Thu, 5 Dec 1996 08:18:57 -0800 (PST) Received: from time.cdrom.com (localhost [127.0.0.1]) by time.cdrom.com (8.8.4/8.6.9) with ESMTP id IAA11282; Thu, 5 Dec 1996 08:18:57 -0800 (PST) To: "Andrey A. Chernov" cc: jkh@freefall.freebsd.org (Jordan K. Hubbard), CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-include@freefall.freebsd.org Subject: Re: cvs commit: src/include utmp.h In-reply-to: Your message of "Thu, 05 Dec 1996 06:34:26 PST." <199612051434.GAA10379@freefall.freebsd.org> Date: Thu, 05 Dec 1996 08:18:57 -0800 Message-ID: <11278.849802737@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-include@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > I hear BSDI increase UT_HOSTSIZE to 32, do we plan to make similar change? > (I don't have BSDI box to be shure) I haven't had anyone even raise the issue (until just now), so I'm not sure how much demand there is for this. Any other opinions? Something we should do just for consistency's sake? Jordan From owner-cvs-include Thu Dec 5 10:31:30 1996 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id KAA22476 for cvs-include-outgoing; Thu, 5 Dec 1996 10:31:30 -0800 (PST) Received: from precipice.shockwave.com (ppp-206-170-5-91.rdcy01.pacbell.net [206.170.5.91]) by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id KAA22453; Thu, 5 Dec 1996 10:31:18 -0800 (PST) Received: from shockwave.com (localhost.shockwave.com [127.0.0.1]) by precipice.shockwave.com (8.8.3/8.7.3) with ESMTP id KAA03742; Thu, 5 Dec 1996 10:30:55 -0800 (PST) Message-Id: <199612051830.KAA03742@precipice.shockwave.com> To: Peter Wemm cc: "Andrey A. Chernov" , jkh@freefall.freebsd.org (Jordan K. Hubbard), CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-include@freefall.freebsd.org Subject: Re: cvs commit: src/include utmp.h In-reply-to: Your message of "Thu, 05 Dec 1996 22:58:26 +0800." <199612051458.WAA08975@spinner.DIALix.COM> Date: Thu, 05 Dec 1996 10:30:55 -0800 From: Paul Traina Sender: owner-cvs-include@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk From: Peter Wemm Subject: Re: cvs commit: src/include utmp.h "Andrey A. Chernov" wrote: > > jkh 96/12/04 03:30:17 > > > > Modified: include utmp.h > > Log: > > Bump maximum username length to 16 characters. This brings us into > > line with BSD/OS and Linux's username limits, making transitioning from > > either operating system a lot easier than it is now. I'm currently > > running with this change on my system, as are several others, and have > > experienced no ill effects. > > I hear BSDI increase UT_HOSTSIZE to 32, do we plan to make similar change? > (I don't have BSDI box to be shure) Yes, BSDI have gone to user=16,line=8,host=32. I would very much like this as well, but I'd also like to suggest we pluck a leaf from the SunOS/SYSV/Linux book and take a couple of extra fields as well. I would like to see: ut_pid (pid of session. This is painful to work around not having!) ut_type (some sort of type-of-record code to replace the "magic" characters in some of the username or tty fields.) ut_hostid (normally an in_addr type of entry so that we can always find the originating host without having to bogusly interpret or convert ut_host to/from hostnames and dotted-quad IP addresses.) ut_host (increased to pad out the record size to a convenient power of 2) PHK was also suggesting a field for remoute user (when available) for use with things like ssh and kerberos (and, for that matter, rlogind). If we're going to change utmp (and break binaries in the process), then let's do it ONCE. I don't see a mirror image of the BSDI file format as particularly important, in all my travels, I've never seen an application (read: non-system) binary that uses the utmp file, except on my SVR3 days. I think Garrett expressed a desire to have a 'version' field somewhere. Yes, please (tm) ! Cheers, -Peter From owner-cvs-include Thu Dec 5 10:49:35 1996 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id KAA23545 for cvs-include-outgoing; Thu, 5 Dec 1996 10:49:35 -0800 (PST) Received: from sovcom.kiae.su (sovcom.kiae.su [193.125.152.1]) by freefall.freebsd.org (8.8.4/8.8.4) with SMTP id KAA23511; Thu, 5 Dec 1996 10:49:27 -0800 (PST) Received: by sovcom.kiae.su id AA16770 (5.65.kiae-1 ); Thu, 5 Dec 1996 21:21:04 +0300 Received: by sovcom.KIAE.su (UUMAIL/2.0); Thu, 5 Dec 96 21:21:04 +0300 Received: from localhost (ache@nagual.ru [127.0.0.1]) by nagual.ru (8.8.4/8.8.4) with SMTP id VAA00253; Thu, 5 Dec 1996 21:11:26 +0300 (MSK) Date: Thu, 5 Dec 1996 21:11:26 +0300 (MSK) From: =?KOI8-R?Q?Andrey_Chernov=2C_=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= To: Peter Wemm Cc: "Jordan K. Hubbard" , CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-include@freefall.freebsd.org Subject: Re: cvs commit: src/include utmp.h In-Reply-To: <199612051458.WAA08975@spinner.DIALix.COM> Message-Id: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-include@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Thu, 5 Dec 1996, Peter Wemm wrote: > "Andrey A. Chernov" wrote: > > > jkh 96/12/04 03:30:17 > > > > > > Modified: include utmp.h > > > Log: > > > Bump maximum username length to 16 characters. This brings us into > > > line with BSD/OS and Linux's username limits, making transitioning from > > > either operating system a lot easier than it is now. I'm currently > > > running with this change on my system, as are several others, and have > > > experienced no ill effects. > > > > I hear BSDI increase UT_HOSTSIZE to 32, do we plan to make similar change? > > (I don't have BSDI box to be shure) > > Yes, BSDI have gone to user=16,line=8,host=32. > > I would very much like this as well, but I'd also like to suggest we pluck > a leaf from the SunOS/SYSV/Linux book and take a couple of extra fields > as well. We already change UT_NAMESIZE, lets change UT_HOSTSIZE in the same round :-) Usually bigger UT_HOSTSIZE gives much better statistics, because too many of hosts now exceedes 16 char limit. > ut_hostid (normally an in_addr type of entry so that we can always find the > originating host without having to bogusly interpret or convert > ut_host to/from hostnames and dotted-quad IP addresses.) Yes, it will be nice to have. Many systems already have it. > ut_host (increased to pad out the record size to a convenient power of 2) IMHO even 32 isn't enough now, we need at least 64 > I don't see a mirror image of the BSDI file format as particularly > important, in all my travels, I've never seen an application (read: > non-system) binary that uses the utmp file, except on my SVR3 days. I agree. -- Andrey A. Chernov http://www.nagual.ru/~ache/ From owner-cvs-include Thu Dec 5 11:06:51 1996 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id LAA24825 for cvs-include-outgoing; Thu, 5 Dec 1996 11:06:51 -0800 (PST) Received: from time.cdrom.com (time.cdrom.com [204.216.27.226]) by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id LAA24815; Thu, 5 Dec 1996 11:06:45 -0800 (PST) Received: from time.cdrom.com (localhost [127.0.0.1]) by time.cdrom.com (8.8.4/8.6.9) with ESMTP id LAA09897; Thu, 5 Dec 1996 11:06:14 -0800 (PST) To: =?KOI8-R?Q?Andrey_Chernov=2C_=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= cc: Peter Wemm , "Jordan K. Hubbard" , CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-include@freefall.freebsd.org Subject: Re: cvs commit: src/include utmp.h In-reply-to: Your message of "Thu, 05 Dec 1996 21:11:26 +0300." Date: Thu, 05 Dec 1996 11:06:14 -0800 Message-ID: <9893.849812774@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-include@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > We already change UT_NAMESIZE, lets change UT_HOSTSIZE in the same round > :-) I agree that we should batch all these changes, and quickly before people start firing at us for breaking their utmp logs multiple times in a row. Simple questions: Is there concensus for bumping UT_HOSTSIZE to the next increment? 32 or 64? What about the other fields that Peter suggested? Assuming that we can reach a quick consensus on this, I'd be happy to see Peter go ahead and Just Do It. Jordan From owner-cvs-include Thu Dec 5 11:11:31 1996 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id LAA25087 for cvs-include-outgoing; Thu, 5 Dec 1996 11:11:31 -0800 (PST) Received: from precipice.shockwave.com (ppp-206-170-5-91.rdcy01.pacbell.net [206.170.5.91]) by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id LAA25052; Thu, 5 Dec 1996 11:10:40 -0800 (PST) Received: from shockwave.com (localhost.shockwave.com [127.0.0.1]) by precipice.shockwave.com (8.8.3/8.7.3) with ESMTP id LAA04245; Thu, 5 Dec 1996 11:07:37 -0800 (PST) Message-Id: <199612051907.LAA04245@precipice.shockwave.com> To: =?KOI8-R?Q?Andrey_Chernov=2C_=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= cc: Peter Wemm , "Jordan K. Hubbard" , CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-include@freefall.freebsd.org Subject: Re: cvs commit: src/include utmp.h In-reply-to: Your message of "Thu, 05 Dec 1996 21:11:26 +0300." Date: Thu, 05 Dec 1996 11:07:37 -0800 From: Paul Traina Sender: owner-cvs-include@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk We already change UT_NAMESIZE, lets change UT_HOSTSIZE in the same round Or change it back. :-) Usually bigger UT_HOSTSIZE gives much better statistics, because too many of hosts now exceedes 16 char limit. I agree, 64 isn't bad, as you suggest. One other "cautionary note" (I'm full of 'em today). A lot of stuff assumes that wtmp records are the same as utmp records. Make sure we check for programs that access wtmp as well as utmp. We're not totally screwed if we have a shared libutil() because many updated programs use logwtmp(), but nonetheless, it's something that need be checked for lossage. Just don't break my xterms please. :-( From owner-cvs-include Thu Dec 5 11:45:44 1996 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id LAA27740 for cvs-include-outgoing; Thu, 5 Dec 1996 11:45:44 -0800 (PST) Received: from sovcom.kiae.su (sovcom.kiae.su [193.125.152.1]) by freefall.freebsd.org (8.8.4/8.8.4) with SMTP id LAA27730; Thu, 5 Dec 1996 11:45:36 -0800 (PST) Received: by sovcom.kiae.su id AA05827 (5.65.kiae-1 ); Thu, 5 Dec 1996 22:26:53 +0300 Received: by sovcom.KIAE.su (UUMAIL/2.0); Thu, 5 Dec 96 22:26:52 +0300 Received: from localhost (ache@nagual.ru [127.0.0.1]) by nagual.ru (8.8.4/8.8.4) with SMTP id WAA01648; Thu, 5 Dec 1996 22:26:36 +0300 (MSK) Date: Thu, 5 Dec 1996 22:26:35 +0300 (MSK) From: =?KOI8-R?Q?Andrey_Chernov=2C_=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= To: "Jordan K. Hubbard" Cc: Peter Wemm , "Jordan K. Hubbard" , CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-include@freefall.freebsd.org Subject: Re: cvs commit: src/include utmp.h In-Reply-To: <9893.849812774@time.cdrom.com> Message-Id: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-include@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Thu, 5 Dec 1996, Jordan K. Hubbard wrote: > Simple questions: Is there concensus for bumping UT_HOSTSIZE to the > next increment? 32 or 64? What about the other fields that Peter > suggested? I like 64 and ut_hostid. I see to many hosts in nowdays which breaks 32. -- Andrey A. Chernov http://www.nagual.ru/~ache/ From owner-cvs-include Fri Dec 6 09:46:03 1996 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id JAA02327 for cvs-include-outgoing; Fri, 6 Dec 1996 09:46:03 -0800 (PST) Received: from alpha.xerox.com (alpha.Xerox.COM [13.1.64.93]) by freefall.freebsd.org (8.8.4/8.8.4) with SMTP id JAA02300; Fri, 6 Dec 1996 09:45:44 -0800 (PST) Received: from crevenia.parc.xerox.com ([13.2.116.11]) by alpha.xerox.com with SMTP id <23142(1)>; Fri, 6 Dec 1996 09:44:24 PST Received: from localhost by crevenia.parc.xerox.com with SMTP id <177711>; Fri, 6 Dec 1996 09:10:46 -0800 To: "Jordan K. Hubbard" cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-include@freefall.freebsd.org Subject: Re: cvs commit: src/include utmp.h In-reply-to: Your message of "Thu, 05 Dec 96 11:06:14 PST." <9893.849812774@time.cdrom.com> Date: Fri, 6 Dec 1996 09:10:31 PST From: Bill Fenner Message-Id: <96Dec6.091046pst.177711@crevenia.parc.xerox.com> Sender: owner-cvs-include@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk In message <9893.849812774@time.cdrom.com> you write: >Simple questions: Is there concensus for bumping UT_HOSTSIZE to the >next increment? 32 or 64? What about the other fields that Peter >suggested? I think that the host address would be extremely useful, so that there's a uniform representation of the host address that a program can get to. I don't think it should be a struct in_addr, though, since we don't want to have to change again when IPv6 comes around, so perhaps it should be an (ugh) 20-byte sockaddr. A bigger UT_HOSTSIZE makes some sense, but given the host address field it's not necessarily critical. Bill From owner-cvs-include Fri Dec 6 09:57:12 1996 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id JAA02684 for cvs-include-outgoing; Fri, 6 Dec 1996 09:57:12 -0800 (PST) Received: from alpha.xerox.com (alpha.Xerox.COM [13.1.64.93]) by freefall.freebsd.org (8.8.4/8.8.4) with SMTP id JAA02661; Fri, 6 Dec 1996 09:57:01 -0800 (PST) Received: from crevenia.parc.xerox.com ([13.2.116.11]) by alpha.xerox.com with SMTP id <19984(1)>; Fri, 6 Dec 1996 09:55:56 PST Received: from localhost by crevenia.parc.xerox.com with SMTP id <177711>; Fri, 6 Dec 1996 09:38:48 -0800 To: "Jordan K. Hubbard" cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-include@freefall.freebsd.org Subject: Re: cvs commit: src/include utmp.h In-reply-to: Your message of "Thu, 05 Dec 96 11:06:14 PST." <9893.849812774@time.cdrom.com> Date: Fri, 6 Dec 1996 09:38:46 PST From: Bill Fenner Message-Id: <96Dec6.093848pst.177711@crevenia.parc.xerox.com> Sender: owner-cvs-include@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk In message <9893.849812774@time.cdrom.com> you write: >Simple questions: Is there concensus for bumping UT_HOSTSIZE to the >next increment? 32 or 64? Oh, and UT_HOSTSIZE should be at least 40 (the size of a maximum-length numerically represented IPv6 address) and doesn't have any real need to be a power of 2; it might be more appropriate to make it the right length to make a "struct utmp" a power of 2 long. Bill