From owner-cvs-lib Mon Oct 14 01:34:46 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id BAA12525 for cvs-lib-outgoing; Mon, 14 Oct 1996 01:34:46 -0700 (PDT) Received: (from phk@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id BAA12465; Mon, 14 Oct 1996 01:34:12 -0700 (PDT) Date: Mon, 14 Oct 1996 01:34:12 -0700 (PDT) From: Poul-Henning Kamp Message-Id: <199610140834.BAA12465@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libcrypt crypt.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk phk 96/10/14 01:34:11 Modified: lib/libcrypt crypt.c Log: A couple of minor nits. Submitted by: Craig Leres Submitted by: Theo Deraadt Revision Changes Path 1.5 +10 -5 src/lib/libcrypt/crypt.c From owner-cvs-lib Tue Oct 15 14:53:48 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id OAA11445 for cvs-lib-outgoing; Tue, 15 Oct 1996 14:53:48 -0700 (PDT) Received: (from ache@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id OAA11413; Tue, 15 Oct 1996 14:53:28 -0700 (PDT) Date: Tue, 15 Oct 1996 14:53:28 -0700 (PDT) From: "Andrey A. Chernov" Message-Id: <199610152153.OAA11413@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/locale collate.c collate.h Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 96/10/15 14:53:27 Modified: lib/libc/locale collate.c collate.h Log: Save half of space in LC_COLLATE and remove unneded code. This change is not compatible with previous variant, however proper error code returned in both cases. Colldef changes will follows. Revision Changes Path 1.7 +7 -28 src/lib/libc/locale/collate.c 1.4 +3 -7 src/lib/libc/locale/collate.h From owner-cvs-lib Wed Oct 16 12:38:58 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id MAA29324 for cvs-lib-outgoing; Wed, 16 Oct 1996 12:38:58 -0700 (PDT) Received: (from jkh@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id MAA29307; Wed, 16 Oct 1996 12:38:54 -0700 (PDT) Date: Wed, 16 Oct 1996 12:38:54 -0700 (PDT) From: "Jordan K. Hubbard" Message-Id: <199610161938.MAA29307@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/net Makefile.inc Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 96/10/16 12:38:53 Modified: lib/libc/net Makefile.inc Log: Bring back ns_* routines; we need them for ifconfig and route. Revision Changes Path 1.19 +1 -2 src/lib/libc/net/Makefile.inc From owner-cvs-lib Wed Oct 16 17:40:18 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id RAA18935 for cvs-lib-outgoing; Wed, 16 Oct 1996 17:40:18 -0700 (PDT) Received: (from peter@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id RAA18918; Wed, 16 Oct 1996 17:40:07 -0700 (PDT) Date: Wed, 16 Oct 1996 17:40:07 -0700 (PDT) From: Peter Wemm Message-Id: <199610170040.RAA18918@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/gen getcwd.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 96/10/16 17:40:06 Modified: lib/libc/gen getcwd.c Log: Corrently null-terminate the path being passed to the opendir() calls, malloc() does is not defined to return a zeroed buffer leading to "strange" problems. Submitted by: Karl Denninger , PR#1826 Revision Changes Path 1.7 +1 -0 src/lib/libc/gen/getcwd.c From owner-cvs-lib Wed Oct 16 17:55:30 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id RAA19599 for cvs-lib-outgoing; Wed, 16 Oct 1996 17:55:30 -0700 (PDT) Received: from root.com (implode.root.com [198.145.90.17]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id RAA19594; Wed, 16 Oct 1996 17:55:27 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by root.com (8.7.6/8.6.5) with SMTP id RAA10128; Wed, 16 Oct 1996 17:56:40 -0700 (PDT) Message-Id: <199610170056.RAA10128@root.com> X-Authentication-Warning: implode.root.com: Host localhost [127.0.0.1] didn't use HELO protocol To: Peter Wemm cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libc/gen getcwd.c In-reply-to: Your message of "Wed, 16 Oct 1996 17:40:07 PDT." <199610170040.RAA18918@freefall.freebsd.org> From: David Greenman Reply-To: dg@root.com Date: Wed, 16 Oct 1996 17:56:40 -0700 Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >peter 96/10/16 17:40:06 > > Modified: lib/libc/gen getcwd.c > Log: > Corrently null-terminate the path being passed to the opendir() calls, > malloc() does is not defined to return a zeroed buffer leading to > "strange" problems. > > Submitted by: Karl Denninger , PR#1826 I think the assignment at the bottom of the loop: /* Truncate any file name. */ *bup = '\0'; } ...is now redundant since *bup isn't modified again. So the real fix was probably to simply move the above assignment up a couple dozen lines. -DG David Greenman Core-team/Principal Architect, The FreeBSD Project From owner-cvs-lib Thu Oct 17 04:07:29 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id EAA24391 for cvs-lib-outgoing; Thu, 17 Oct 1996 04:07:29 -0700 (PDT) Received: from pillar.elsevier.co.uk (root@pillar.elsevier.co.uk [193.131.222.35]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id EAA24274; Thu, 17 Oct 1996 04:05:39 -0700 (PDT) Received: from snowdon.elsevier.co.uk (snowdon.elsevier.co.uk [193.131.197.164]) by pillar.elsevier.co.uk (8.8.0/8.8.0) with ESMTP id MAA19415; Thu, 17 Oct 1996 12:02:43 +0100 (BST) Received: from cadair.elsevier.co.uk by snowdon.elsevier.co.uk with SMTP (PP); Thu, 17 Oct 1996 12:04:58 +0100 Received: from tees.elsevier.co.uk (tees.elsevier.co.uk [193.131.197.60]) by cadair.elsevier.co.uk (8.8.0/8.8.0) with ESMTP id MAA13297; Thu, 17 Oct 1996 12:04:53 +0100 (BST) Received: (from dpr@localhost) by tees.elsevier.co.uk (8.8.0/8.8.0) id MAA10585; Thu, 17 Oct 1996 12:03:54 +0100 (BST) To: "Jordan K. Hubbard" Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libc/net Makefile.inc References: <199610161938.MAA29307@freefall.freebsd.org> From: Paul Richards Date: 17 Oct 1996 12:03:53 +0100 In-Reply-To: "Jordan K. Hubbard"'s message of Wed, 16 Oct 1996 12:38:54 -0700 (PDT) Message-ID: <57d8yhsvhi.fsf@tees.elsevier.co.uk> Lines: 22 X-Mailer: Gnus v5.3/Emacs 19.30 Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk "Jordan K. Hubbard" writes: > Modified: lib/libc/net Makefile.inc > Log: > Bring back ns_* routines; we need them for ifconfig and route. > > Revision Changes Path > 1.19 +1 -2 src/lib/libc/net/Makefile.inc I haven't seen a commit that brings back /sys/netns, libc won't build without the ns related header files. Make world failed on me last night because of this, I bet you still have the header files in your tree even though they've been removed from the sources. Make world doesn't look like it clears the include files (not at a FreeBSD box now to look myself). -- Paul Richards. Originative Solutions Ltd. (Netcraft Ltd. contractor) Elsevier Science TIS online journal project. Email: p.richards@elsevier.co.uk Phone: 0370 462071 (Mobile), +44 (0)1865 843155 From owner-cvs-lib Thu Oct 17 05:45:52 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id FAA28055 for cvs-lib-outgoing; Thu, 17 Oct 1996 05:45:52 -0700 (PDT) Received: (from ache@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id FAA28036; Thu, 17 Oct 1996 05:45:40 -0700 (PDT) Date: Thu, 17 Oct 1996 05:45:40 -0700 (PDT) From: "Andrey A. Chernov" Message-Id: <199610171245.FAA28036@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libskey skeylogin.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 96/10/17 05:45:40 Modified: lib/libskey skeylogin.c Log: Make it work in localized environment, replace strftime's %b which can be in national form with months names table Revision Changes Path 1.9 +9 -2 src/lib/libskey/skeylogin.c From owner-cvs-lib Thu Oct 17 06:44:06 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id GAA00630 for cvs-lib-outgoing; Thu, 17 Oct 1996 06:44:06 -0700 (PDT) Received: (from ache@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id GAA00566; Thu, 17 Oct 1996 06:44:00 -0700 (PDT) Date: Thu, 17 Oct 1996 06:44:00 -0700 (PDT) From: "Andrey A. Chernov" Message-Id: <199610171344.GAA00566@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libskey skey_getpass.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 96/10/17 06:43:59 Modified: lib/libskey skey_getpass.c Log: If 1) regular Unix passwords not permitted and 2) skey database for this user not activated, there no correct password exist, so don't bother ask for it and return "" immediately Revision Changes Path 1.4 +5 -2 src/lib/libskey/skey_getpass.c From owner-cvs-lib Thu Oct 17 08:23:05 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id IAA06520 for cvs-lib-outgoing; Thu, 17 Oct 1996 08:23:05 -0700 (PDT) Received: (from ache@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id IAA06500; Thu, 17 Oct 1996 08:22:49 -0700 (PDT) Date: Thu, 17 Oct 1996 08:22:49 -0700 (PDT) From: "Andrey A. Chernov" Message-Id: <199610171522.IAA06500@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libskey Makefile put.c skey.h skeylogin.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 96/10/17 08:22:49 Modified: lib/libskey Makefile put.c skey.h skeylogin.c Log: Prevent namespace pollution cause by this library by splitting to API and non-API functions and giving _sk_ prefix for all non-API functions. Old names will be available by _SKEY_INTERNAL define it allows not change anything in keyinit & key, only -D_SKEY_INTERNAL required. Staticise some things. Revision Changes Path 1.7 +1 -1 src/lib/libskey/Makefile 1.6 +1 -1 src/lib/libskey/put.c 1.4 +19 -4 src/lib/libskey/skey.h 1.10 +2 -2 src/lib/libskey/skeylogin.c From owner-cvs-lib Thu Oct 17 09:12:13 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id JAA09194 for cvs-lib-outgoing; Thu, 17 Oct 1996 09:12:13 -0700 (PDT) Received: (from jkh@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id JAA09141; Thu, 17 Oct 1996 09:11:53 -0700 (PDT) Date: Thu, 17 Oct 1996 09:11:53 -0700 (PDT) From: "Jordan K. Hubbard" Message-Id: <199610171611.JAA09141@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/stdio Makefile.inc Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 96/10/17 09:11:51 Branch: lib/libc/stdio RELENG_2_1_0 Modified: lib/libc/stdio Makefile.inc Log: Bring in the *asprintf() family of routines. Revision Changes Path 1.3.4.4 +7 -6 src/lib/libc/stdio/Makefile.inc From owner-cvs-lib Thu Oct 17 09:24:22 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id JAA09782 for cvs-lib-outgoing; Thu, 17 Oct 1996 09:24:22 -0700 (PDT) Received: from time.cdrom.com (time.cdrom.com [204.216.27.226]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id JAA09777; Thu, 17 Oct 1996 09:24:18 -0700 (PDT) Received: from time.cdrom.com (localhost [127.0.0.1]) by time.cdrom.com (8.7.6/8.6.9) with ESMTP id JAA03560; Thu, 17 Oct 1996 09:23:08 -0700 (PDT) To: Paul Richards cc: "Jordan K. Hubbard" , CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libc/net Makefile.inc In-reply-to: Your message of "17 Oct 1996 12:03:53 BST." <57d8yhsvhi.fsf@tees.elsevier.co.uk> Date: Thu, 17 Oct 1996 09:23:08 -0700 Message-ID: <3558.845569388@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > I haven't seen a commit that brings back /sys/netns, libc won't build > without the ns related header files. Make world failed on me last > night because of this, I bet you still have the header files in your > tree even though they've been removed from the sources. Sorry, the work sort of froze-up midway as Garrett and I got into an exchange about the wisdom of bringing this back, and I was giving him a chance to contact Netcon himself if he so decided. After spending another chunk of $$$ on the phone to Netcon in Florida, it's pretty clear to me that we need to bring it back and unless Garrett suddenly comes forward with an effective compromise that doesn't have Netcon re-writing lots of code (and pushing their 2.2 product release into late next year sometime), I'll be bringing it all back today. Jordan From owner-cvs-lib Thu Oct 17 09:47:36 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id JAA11468 for cvs-lib-outgoing; Thu, 17 Oct 1996 09:47:36 -0700 (PDT) Received: (from ache@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id JAA11446; Thu, 17 Oct 1996 09:47:25 -0700 (PDT) Date: Thu, 17 Oct 1996 09:47:25 -0700 (PDT) From: "Andrey A. Chernov" Message-Id: <199610171647.JAA11446@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libskey skey_getpass.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 96/10/17 09:47:25 Modified: lib/libskey skey_getpass.c Log: Change "nope" to ":" Previous variant not work well, if you have a user with name nope Revision Changes Path 1.5 +1 -1 src/lib/libskey/skey_getpass.c From owner-cvs-lib Thu Oct 17 10:04:51 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id KAA12337 for cvs-lib-outgoing; Thu, 17 Oct 1996 10:04:51 -0700 (PDT) Received: from precipice.shockwave.com (ppp-206-170-5-49.rdcy01.pacbell.net [206.170.5.49]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id KAA12331; Thu, 17 Oct 1996 10:04:47 -0700 (PDT) Received: from shockwave.com (localhost.shockwave.com [127.0.0.1]) by precipice.shockwave.com (8.7.6/8.7.3) with ESMTP id KAA17144; Thu, 17 Oct 1996 10:04:20 -0700 (PDT) Message-Id: <199610171704.KAA17144@precipice.shockwave.com> To: "Andrey A. Chernov" cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libskey skey_getpass.c In-reply-to: Your message of "Thu, 17 Oct 1996 06:44:00 PDT." <199610171344.GAA00566@freefall.freebsd.org> Date: Thu, 17 Oct 1996 10:04:20 -0700 From: Paul Traina Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk I'm not sure this is a good idea. You want to keep things "stealthy" From: "Andrey A. Chernov" Subject: cvs commit: src/lib/libskey skey_getpass.c ache 96/10/17 06:43:59 Modified: lib/libskey skey_getpass.c Log: If 1) regular Unix passwords not permitted and 2) skey database for this user not activated, there no correct password exist, so don't bother ask for it and return "" immediately Revision Changes Path 1.4 +5 -2 src/lib/libskey/skey_getpass.c From owner-cvs-lib Thu Oct 17 11:27:12 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA18851 for cvs-lib-outgoing; Thu, 17 Oct 1996 11:27:12 -0700 (PDT) Received: (from guido@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA18832; Thu, 17 Oct 1996 11:27:00 -0700 (PDT) Date: Thu, 17 Oct 1996 11:27:00 -0700 (PDT) From: Guido van Rooij Message-Id: <199610171827.LAA18832@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/db/hash hash_buf.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk guido 96/10/17 11:26:59 Modified: lib/libc/db/hash hash_buf.c Log: When freeing buffers in the db routines, also zeroize them This should solve the bug where a coredumping ftpd reveals encrypted passwords. Obtained from: OpenBSD Revision Changes Path 1.2 +21 -11 src/lib/libc/db/hash/hash_buf.c From owner-cvs-lib Thu Oct 17 11:28:10 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA18992 for cvs-lib-outgoing; Thu, 17 Oct 1996 11:28:10 -0700 (PDT) Received: (from guido@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA18910; Thu, 17 Oct 1996 11:28:00 -0700 (PDT) Date: Thu, 17 Oct 1996 11:28:00 -0700 (PDT) From: Guido van Rooij Message-Id: <199610171828.LAA18910@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/db/hash hash_buf.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk guido 96/10/17 11:27:59 Branch: lib/libc/db/hash RELENG_2_1_0 Modified: lib/libc/db/hash hash_buf.c Log: When freeing buffers in the db routines, also zeroize them This should solve the bug where a coredumping ftpd reveals encrypted passwords. Obtained from: OpenBSD Revision Changes Path 1.1.1.1.6.3 +3 -1 src/lib/libc/db/hash/hash_buf.c From owner-cvs-lib Thu Oct 17 11:34:57 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA19435 for cvs-lib-outgoing; Thu, 17 Oct 1996 11:34:57 -0700 (PDT) Received: from sovcom.kiae.su (sovcom.kiae.su [193.125.152.1]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id LAA19400; Thu, 17 Oct 1996 11:34:43 -0700 (PDT) Received: by sovcom.kiae.su id AA25781 (5.65.kiae-1 ); Thu, 17 Oct 1996 21:25:39 +0300 Received: by sovcom.KIAE.su (UUMAIL/2.0); Thu, 17 Oct 96 21:25:38 +0300 Received: (from ache@localhost) by nagual.ru (8.7.6/8.7.3) id WAA02128; Thu, 17 Oct 1996 22:25:14 +0400 (MSD) Message-Id: <199610171825.WAA02128@nagual.ru> Subject: Re: cvs commit: src/lib/libskey skey_getpass.c In-Reply-To: <199610171704.KAA17144@precipice.shockwave.com> from "Paul Traina" at "Oct 17, 96 10:04:20 am" To: pst@shockwave.com (Paul Traina) Date: Thu, 17 Oct 1996 22:25:14 +0400 (MSD) Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org From: "=?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?=" (Andrey A. Chernov) Organization: self X-Class: Fast X-Mailer: ELM [version 2.4ME+ PL28 (25)] Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > I'm not sure this is a good idea. You want to keep things "stealthy" I already think about it. It very is different from 'don't ask password for nonexisten user' case, because you can even visually detect situation when any password will be incorrect. You'll see following picture if you can't match with _any_ password: login: user (s/key required) Password: It is a bit different from normal case: login: user s/key 99 xx1234 (s/key required) Password: I.e. if "s/key ..." line is missing, it is pretty clear that it is impossible to enter, so removing password asking not makes it less "stealthy". For FTP case the same thing: 331 S/key password required for user. Is a bit different from normal 331 s/key 99 xx1234 response. -------------------------------------------------------------------- BTW, as alternate solution another way is possible, I mean: o Remove "(s/key required)" line if user can't specify any password and still ask for them. o Change 'S/key password..." to usual "Password required..." for FTP responce in the same case and still ask for password. This method makes even your s/key system to be undetected for 1) wrong user names or 2) users not in skey database. It is clearly good for 1) but not so good for 2), so I not decide yet. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Making it for 1) but not for 2) is bad way because allows to determine which user name is valid. S/key already introduce some flaw in this direction, I mean that you receive "s/key 99 xx1234" responce for users from skey database and NOT receive it for users not in the database. So, it can be possible to determine it from outside. We can produce fake "s/key xx" response, but it pretty well detected for repeatable access to the same name. Any ideas? -- Andrey A. Chernov http://www.nagual.ru/~ache/ From owner-cvs-lib Thu Oct 17 11:42:32 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA20346 for cvs-lib-outgoing; Thu, 17 Oct 1996 11:42:32 -0700 (PDT) Received: from critter.tfs.com ([140.145.230.177]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id LAA20273; Thu, 17 Oct 1996 11:42:03 -0700 (PDT) Received: from critter.tfs.com (localhost.tfs.com [127.0.0.1]) by critter.tfs.com (8.7.5/8.7.3) with ESMTP id UAA04133; Thu, 17 Oct 1996 20:41:14 +0200 (MET DST) To: Guido van Rooij cc: CVS-committers@freebsd.org, cvs-all@freebsd.org, cvs-lib@freebsd.org Subject: Re: cvs commit: src/lib/libc/db/hash hash_buf.c In-reply-to: Your message of "Thu, 17 Oct 1996 11:27:00 PDT." <199610171827.LAA18832@freefall.freebsd.org> Date: Thu, 17 Oct 1996 20:41:14 +0200 Message-ID: <4131.845577674@critter.tfs.com> From: Poul-Henning Kamp Sender: owner-cvs-lib@freebsd.org X-Loop: FreeBSD.org Precedence: bulk In message <199610171827.LAA18832@freefall.freebsd.org>, Guido van Rooij writes : >guido 96/10/17 11:26:59 > > Modified: lib/libc/db/hash hash_buf.c > Log: > When freeing buffers in the db routines, also zeroize them > This should solve the bug where a coredumping ftpd reveals > encrypted passwords. > Obtained from: OpenBSD Isn't this a pezzimization of rank ? I mean there are many uses of this that do not need this... -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@ref.tfs.com TRW Financial Systems, Inc. Future will arrive by its own means, progress not so. From owner-cvs-lib Thu Oct 17 11:42:59 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA20407 for cvs-lib-outgoing; Thu, 17 Oct 1996 11:42:59 -0700 (PDT) Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id LAA20397; Thu, 17 Oct 1996 11:42:53 -0700 (PDT) Received: from current1.whistle.com (current1.whistle.com [207.76.205.22]) by alpo.whistle.com (8.7.6/8.7.3) with SMTP id LAA01320; Thu, 17 Oct 1996 11:38:56 -0700 (PDT) Message-ID: <32667CBE.2781E494@whistle.com> Date: Thu, 17 Oct 1996 11:36:46 -0700 From: Julian Elischer Organization: Whistle Communications X-Mailer: Mozilla 3.0b6 (X11; I; FreeBSD 2.2-CURRENT i386) MIME-Version: 1.0 To: "Jordan K. Hubbard" CC: Paul Richards , "Jordan K. Hubbard" , CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libc/net Makefile.inc References: <3558.845569388@time.cdrom.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Jordan K. Hubbard wrote: it's pretty > clear to me that we need to bring it back and unless Garrett suddenly > comes forward with an effective compromise that doesn't have Netcon > re-writing lots of code (and pushing their 2.2 product release into > late next year sometime), I'll be bringing it all back today. I thought they did a novel filesystem, in which case I thought they'd be using the XNS stuff rather than the raw NS stuff.. julian From owner-cvs-lib Thu Oct 17 11:49:47 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA21101 for cvs-lib-outgoing; Thu, 17 Oct 1996 11:49:47 -0700 (PDT) Received: from gvr.win.tue.nl (root@gvr.win.tue.nl [131.155.210.19]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id LAA21087; Thu, 17 Oct 1996 11:49:32 -0700 (PDT) Received: by gvr.win.tue.nl (8.6.13/1.53) id UAA11306; Thu, 17 Oct 1996 20:48:59 +0200 From: guido@gvr.win.tue.nl (Guido van Rooij) Message-Id: <199610171848.UAA11306@gvr.win.tue.nl> Subject: Re: cvs commit: src/lib/libc/db/hash hash_buf.c To: phk@critter.tfs.com (Poul-Henning Kamp) Date: Thu, 17 Oct 1996 20:48:59 +0200 (MET DST) Cc: guido@freebsd.org, CVS-committers@freebsd.org, cvs-all@freebsd.org, cvs-lib@freebsd.org In-Reply-To: <4131.845577674@critter.tfs.com> from Poul-Henning Kamp at "Oct 17, 96 08:41:14 pm" X-Mailer: ELM [version 2.4ME+ PL17 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-lib@freebsd.org X-Loop: FreeBSD.org Precedence: bulk Poul-Henning Kamp wrote: > > Isn't this a pezzimization of rank ? I mean there are many uses of this > that do not need this... I do agree, but I do agree with the OpenBSD guys here in that it is the only real correct fix for this problem and it only does minimal damage to all other applications. Of course, if we all feel the performance degradation is not wanted, we should coe up with something better, though I wouldn't quickly see a better fix. -Guido From owner-cvs-lib Thu Oct 17 12:05:35 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id MAA22189 for cvs-lib-outgoing; Thu, 17 Oct 1996 12:05:35 -0700 (PDT) Received: from time.cdrom.com (time.cdrom.com [204.216.27.226]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id MAA22181; Thu, 17 Oct 1996 12:05:32 -0700 (PDT) Received: from time.cdrom.com (localhost [127.0.0.1]) by time.cdrom.com (8.7.6/8.6.9) with ESMTP id MAA04766; Thu, 17 Oct 1996 12:04:06 -0700 (PDT) To: Julian Elischer cc: Paul Richards , "Jordan K. Hubbard" , CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libc/net Makefile.inc In-reply-to: Your message of "Thu, 17 Oct 1996 11:36:46 PDT." <32667CBE.2781E494@whistle.com> Date: Thu, 17 Oct 1996 12:04:06 -0700 Message-ID: <4764.845579046@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > I thought they did a novel filesystem, > in which case I thought they'd be using the XNS stuff rather > than the raw NS stuff.. Nope, they extended the "raw NS" stuff into something far more. It supports SPX II, multiple ethernet types, some hundred-odd weird ioctls, etc etc. Now that netns is back, work will begin on bringing in their changes - Netcon has formally adopted the code and apologises for dropping the ball earlier when Garrett called out for supporters and noone raised their hand. Jordan From owner-cvs-lib Thu Oct 17 13:39:28 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id NAA28123 for cvs-lib-outgoing; Thu, 17 Oct 1996 13:39:28 -0700 (PDT) Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id NAA28108; Thu, 17 Oct 1996 13:39:21 -0700 (PDT) Received: from current1.whistle.com (current1.whistle.com [207.76.205.22]) by alpo.whistle.com (8.7.6/8.7.3) with SMTP id NAA02884; Thu, 17 Oct 1996 13:36:09 -0700 (PDT) Message-ID: <32669832.1CFBAE39@whistle.com> Date: Thu, 17 Oct 1996 13:33:54 -0700 From: Julian Elischer Organization: Whistle Communications X-Mailer: Mozilla 3.0b6 (X11; I; FreeBSD 2.2-CURRENT i386) MIME-Version: 1.0 To: "Jordan K. Hubbard" CC: Paul Richards , "Jordan K. Hubbard" , CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libc/net Makefile.inc References: <4764.845579046@time.cdrom.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Jordan K. Hubbard wrote: > > > I thought they did a novel filesystem, > > in which case I thought they'd be using the XNS stuff rather > > than the raw NS stuff.. > > Nope, they extended the "raw NS" stuff into something far more. It > supports SPX II, multiple ethernet types, some hundred-odd weird > ioctls, etc etc. Now that netns is back, work will begin on bringing > in their changes - Netcon has formally adopted the code and apologises > for dropping the ball earlier when Garrett called out for supporters > and noone raised their hand. well then might it be a worthwhile thing to ask them to look at intgrating teh XNS functionallity i to the original NS tree so that we don't need both? > From owner-cvs-lib Thu Oct 17 14:49:59 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id OAA02495 for cvs-lib-outgoing; Thu, 17 Oct 1996 14:49:59 -0700 (PDT) Received: (from ache@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id OAA02477; Thu, 17 Oct 1996 14:49:39 -0700 (PDT) Date: Thu, 17 Oct 1996 14:49:39 -0700 (PDT) From: "Andrey A. Chernov" Message-Id: <199610172149.OAA02477@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libskey skeyaccess.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 96/10/17 14:49:38 Modified: lib/libskey skeyaccess.c Log: Make PERMIT_CONSOLE to work not only from /dev/console, but from syscons vty's too Revision Changes Path 1.7 +8 -1 src/lib/libskey/skeyaccess.c From owner-cvs-lib Fri Oct 18 09:53:00 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id JAA06973 for cvs-lib-outgoing; Fri, 18 Oct 1996 09:53:00 -0700 (PDT) Received: (from ache@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id JAA06943; Fri, 18 Oct 1996 09:52:34 -0700 (PDT) Date: Fri, 18 Oct 1996 09:52:34 -0700 (PDT) From: "Andrey A. Chernov" Message-Id: <199610181652.JAA06943@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libskey skey_getpass.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 96/10/18 09:52:34 Modified: lib/libskey skey_getpass.c Log: After some thinking implement alternative way:if it is impossible to confirm password, don't tell that s/key required, but ask for password in anycase. It looks like non-s/key system from outside. Revision Changes Path 1.6 +5 -9 src/lib/libskey/skey_getpass.c From owner-cvs-lib Fri Oct 18 12:57:01 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id MAA19743 for cvs-lib-outgoing; Fri, 18 Oct 1996 12:57:01 -0700 (PDT) Received: (from guido@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id MAA19725; Fri, 18 Oct 1996 12:56:53 -0700 (PDT) Date: Fri, 18 Oct 1996 12:56:53 -0700 (PDT) From: Guido van Rooij Message-Id: <199610181956.MAA19725@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/db/hash hash_buf.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk guido 96/10/18 12:56:53 Modified: lib/libc/db/hash hash_buf.c Log: Backout bzero patch. Somehow, I also managed to get quite some other changes in this file at the same time. All I did was checkout the file and made a single change. If someone has an explanation how these PURIFFY defines got in... Revision Changes Path 1.3 +11 -21 src/lib/libc/db/hash/hash_buf.c From owner-cvs-lib Fri Oct 18 12:57:34 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id MAA19811 for cvs-lib-outgoing; Fri, 18 Oct 1996 12:57:34 -0700 (PDT) Received: (from guido@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id MAA19789; Fri, 18 Oct 1996 12:57:29 -0700 (PDT) Date: Fri, 18 Oct 1996 12:57:29 -0700 (PDT) From: Guido van Rooij Message-Id: <199610181957.MAA19789@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/db/hash hash_buf.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk guido 96/10/18 12:57:29 Branch: lib/libc/db/hash RELENG_2_1_0 Modified: lib/libc/db/hash hash_buf.c Log: Backout bzero patch. Revision Changes Path 1.1.1.1.6.4 +1 -3 src/lib/libc/db/hash/hash_buf.c From owner-cvs-lib Fri Oct 18 13:26:05 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id NAA21735 for cvs-lib-outgoing; Fri, 18 Oct 1996 13:26:05 -0700 (PDT) Received: from rocky.mt.sri.com (rocky.mt.sri.com [206.127.76.100]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id NAA21709; Fri, 18 Oct 1996 13:25:36 -0700 (PDT) Received: (from nate@localhost) by rocky.mt.sri.com (8.7.5/8.7.3) id OAA04292; Fri, 18 Oct 1996 14:25:33 -0600 (MDT) Date: Fri, 18 Oct 1996 14:25:33 -0600 (MDT) Message-Id: <199610182025.OAA04292@rocky.mt.sri.com> From: Nate Williams To: Guido van Rooij Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libc/db/hash hash_buf.c In-Reply-To: <199610181956.MAA19725@freefall.freebsd.org> References: <199610181956.MAA19725@freefall.freebsd.org> Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Guido van Rooij writes: > guido 96/10/18 12:56:53 > > Modified: lib/libc/db/hash hash_buf.c > Log: > Backout bzero patch. > > Somehow, I also managed to get quite some other changes in this file at > the same time. All I did was checkout the file and made a single change. > If someone has an explanation how these PURIFFY defines got in... Are you confused with CVS here? The version you modified against was 1.1.12: revision 1.1.1.2 date: 1996/02/27 01:58:50; author: pst; state: Exp; lines: +18 -10 Import updated Berkeley DB into CSRG branch And, the diffs you made are: (cut-paste, so white space is screwed up) nec:/usr/src/lib/libc/db/hash % cvs diff -u -r1.1.1.2 -r1.2 hash_buf.c Index: hash_buf.c =================================================================== RCS file: /home/CVS/src/lib/libc/db/hash/hash_buf.c,v retrieving revision 1.1.1.2 retrieving revision 1.2 diff -u -r1.1.1.2 -r1.2 --- hash_buf.c 1996/02/27 01:58:50 1.1.1.2 +++ hash_buf.c 1996/10/17 18:26:55 1.2 @@ -331,8 +331,10 @@ } /* Check if we are freeing stuff */ if (do_free) { - if (bp->page) + if (bp->page) { + (void)memset(bp->page, 0, hashp->BSIZE); free(bp->page); + } BUF_REMOVE(bp); free(bp); bp = LRU; > > Revision Changes Path > 1.3 +11 -21 src/lib/libc/db/hash/hash_buf.c From owner-cvs-lib Fri Oct 18 13:36:04 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id NAA22394 for cvs-lib-outgoing; Fri, 18 Oct 1996 13:36:04 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id NAA22354; Fri, 18 Oct 1996 13:35:57 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.7.6/8.6.9) id GAA19961; Sat, 19 Oct 1996 06:33:04 +1000 Date: Sat, 19 Oct 1996 06:33:04 +1000 From: Bruce Evans Message-Id: <199610182033.GAA19961@godzilla.zeta.org.au> To: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-lib@freefall.freebsd.org, guido@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libc/db/hash hash_buf.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > Modified: lib/libc/db/hash hash_buf.c > Log: > Backout bzero patch. > > Somehow, I also managed to get quite some other changes in this file at > the same time. All I did was checkout the file and made a single change. > If someone has an explanation how these PURIFFY defines got in... They were already in -current, but not in -stable, because -current was still on the vendor branch so 1.1 was not the latest version. > Revision Changes Path > 1.3 +11 -21 src/lib/libc/db/hash/hash_buf.c Better put them back. Bruce From owner-cvs-lib Fri Oct 18 18:34:41 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id SAA08643 for cvs-lib-outgoing; Fri, 18 Oct 1996 18:34:41 -0700 (PDT) Received: (from peter@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id SAA08616; Fri, 18 Oct 1996 18:34:27 -0700 (PDT) Date: Fri, 18 Oct 1996 18:34:27 -0700 (PDT) From: Peter Wemm Message-Id: <199610190134.SAA08616@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/db/hash hash_buf.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 96/10/18 18:34:26 Modified: lib/libc/db/hash hash_buf.c Log: Back out most of the last backout. :-) Guido removed the 1.1.1.1->1.1.1.2 changes from the vendor branch as well, backing the db-1.82 changes. This file should now be the same as it was in rev 1.1.1.2. Revision Changes Path 1.4 +18 -10 src/lib/libc/db/hash/hash_buf.c From owner-cvs-lib Sat Oct 19 09:29:41 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id JAA20976 for cvs-lib-outgoing; Sat, 19 Oct 1996 09From owner-cvs-lib Sun Oct 20 06:21:08 1996 Return-Path: owner-cvs-lib Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id GAA16940 for cvs-lib-outgoing; Sun, 20 Oct 1996 06:21:08 -0700 (PDT) Received: (from phk@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id GAA16912; Sun, 20 Oct 1996 06:20:59 -0700 (PDT) Date: Sun, 20 Oct 1996 06:20:59 -0700 (PDT) From: Poul-Henning Kamp Message-Id: <199610201320.GAA16912@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib Subject: cvs commit: src/lib/libc/stdlib malloc.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk phk 96/10/20 06:20:58 Modified: lib/libc/stdlib malloc.c Log: malloc_pages should be static. Add progname to warning/error message layout. (joerg) Remove inline assembler, no speed impact, not need for the obfuscation (bde) Remove on the fly calculation of parameters, no longer critical. Make D & U flags valid even if we don't support them. Don't call imalloc until we're done initializing. Zap contents on free() if we have "Junk" set. [*] Various nitpicking. [*] As a sideeffect of this change, if you are worried about sensitive data lingering in memory, you can use the 'Junk' option now to make sure phkmalloc zaps memory when it is returned. add char * malloc_options = "J"; to your source. Obviously there is a performance impact. Revision Changes Path 1.16 +103 -187 src/lib/libc/stdlib/malloc.c