From owner-cvs-sbin Sun Oct 13 11:12:37 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA28734 for cvs-sbin-outgoing; Sun, 13 Oct 1996 11:12:37 -0700 (PDT) Received: (from fenner@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA28692; Sun, 13 Oct 1996 11:12:22 -0700 (PDT) Date: Sun, 13 Oct 1996 11:12:22 -0700 (PDT) From: Bill Fenner Message-Id: <199610131812.LAA28692@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/savecore savecore.8 savecore.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk fenner 96/10/13 11:12:22 Modified: sbin/savecore savecore.8 savecore.c Log: Make the savecore command work like the man page says: - make minfree work by getting the dump size before checking to see if the dump will fit on the filesystem - also fail to dump if no minfree is specified but there are not enough free blocks. Fix a typo in the man page. Fixes PR bin/1322 Submitted by: "Philippe C." Revision Changes Path 1.4 +2 -2 src/sbin/savecore/savecore.8 1.15 +19 -8 src/sbin/savecore/savecore.c From owner-cvs-sbin Sun Oct 13 11:18:57 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA29002 for cvs-sbin-outgoing; Sun, 13 Oct 1996 11:18:57 -0700 (PDT) Received: (from bde@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA28987; Sun, 13 Oct 1996 11:18:51 -0700 (PDT) Date: Sun, 13 Oct 1996 11:18:51 -0700 (PDT) From: Bruce Evans Message-Id: <199610131818.LAA28987@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/i386/fdisk fdisk.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk bde 96/10/13 11:18:51 Modified: sbin/i386/fdisk fdisk.c Log: The dos() function needs a new second argument, containing the size of the partition. Only if the size is 0 should the special handling of 0 as first argument be triggered. [This bug caused offset 0 to give C/H/S = 0/0/0 instead of 0/0/1.] The init_sector0 function needs to decrease the first argument to the second call to dos() by one to be consistent with the calls to dos() in change_part(). [This bug caused fdisk -i to create bogus partition tables with the ending C/H/S value 1 too high. This usually gives S = 1 instead of S = maximum, so the geometry guessing in the slice code and perhaps in SCSI BIOSes was defeated.] Submitted by: Tor Egge Revision Changes Path 1.11 +13 -10 src/sbin/i386/fdisk/fdisk.c From owner-cvs-sbin Sun Oct 13 13:56:11 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id NAA05485 for cvs-sbin-outgoing; Sun, 13 Oct 1996 13:56:11 -0700 (PDT) Received: (from joerg@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id NAA05442; Sun, 13 Oct 1996 13:55:50 -0700 (PDT) Date: Sun, 13 Oct 1996 13:55:50 -0700 (PDT) From: Joerg Wunsch Message-Id: <199610132055.NAA05442@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/savecore savecore.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk joerg 96/10/13 13:55:49 Modified: sbin/savecore savecore.c Log: Yikes! Originally, i intended to apply the patch from PR # 1322, but Bill has beaten me on this. ;-) However, he missed the part to compute the kernelsize in kilobytes, so the minfree consideration was now overcautious. (I've also changed the return type of dump_size() to void since int was useless.) Being here, the fact that `vmcore' was written world-readable was just a plain security hole: everybody who was able to crash a kernel could later read any confidential information out of it at his will. Create it with umask 077 instead. Revision Changes Path 1.16 +6 -5 src/sbin/savecore/savecore.c From owner-cvs-sbin Sun Oct 13 14:04:08 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id OAA06046 for cvs-sbin-outgoing; Sun, 13 Oct 1996 14:04:08 -0700 (PDT) Received: (from joerg@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id OAA05989; Sun, 13 Oct 1996 14:03:53 -0700 (PDT) Date: Sun, 13 Oct 1996 14:03:53 -0700 (PDT) From: Joerg Wunsch Message-Id: <199610132103.OAA05989@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/savecore savecore.8 savecore.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk joerg 96/10/13 14:03:53 Branch: sbin/savecore RELENG_2_1_0 Modified: sbin/savecore savecore.8 savecore.c Log: Bring in the fixes from rev 1.14 and 1.15 of savecore.c and 1.4 of savecore.8: obey minfree constraints, restrict access permission on vmcore, and correct a typo. Revision Changes Path 1.3.6.1 +2 -2 src/sbin/savecore/savecore.8 1.7.4.3 +22 -10 src/sbin/savecore/savecore.c From owner-cvs-sbin Sun Oct 13 14:51:13 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id OAA07739 for cvs-sbin-outgoing; Sun, 13 Oct 1996 14:51:13 -0700 (PDT) Received: from alpha.xerox.com (alpha.Xerox.COM [13.1.64.93]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id OAA07637; Sun, 13 Oct 1996 14:49:33 -0700 (PDT) Received: from crevenia.parc.xerox.com ([13.2.116.11]) by alpha.xerox.com with SMTP id <14736(1)>; Sun, 13 Oct 1996 14:48:57 PDT Received: from localhost by crevenia.parc.xerox.com with SMTP id <177477>; Sun, 13 Oct 1996 14:48:50 -0700 To: Joerg Wunsch cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/savecore savecore.c In-reply-to: Your message of "Sun, 13 Oct 96 13:55:50 PDT." <199610132055.NAA05442@freefall.freebsd.org> Date: Sun, 13 Oct 1996 14:48:37 PDT From: Bill Fenner Message-Id: <96Oct13.144850pdt.177477@crevenia.parc.xerox.com> Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk In message <199610132055.NAA05442@freefall.freebsd.org> you write: > However, he missed the part to compute the kernelsize in kilobytes, > so the minfree consideration was now overcautious. (I've also > changed the return type of dump_size() to void since int was useless.) Sorry, I thought I had made sure that everything was in K. Unless I missed something, the patch in the PR causes minfree to be specified in bytes, which is not what the man page says. In fact, if I re-read my patch, it looks like spacefree and totfree are kept in units of K-bytes, kernelsize and dumpsize are kept in units of bytes but needed = (dumpsize + kernelsize) / 1024, so needed is in units of K-bytes, and minfree is specified in the file as being specified in K-bytes. What am I missing? Bill From owner-cvs-sbin Mon Oct 14 13:56:08 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id NAA24977 for cvs-sbin-outgoing; Mon, 14 Oct 1996 13:56:08 -0700 (PDT) Received: from irz301.inf.tu-dresden.de (irz301.inf.tu-dresden.de [141.76.1.11]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id NAA24820; Mon, 14 Oct 1996 13:52:48 -0700 (PDT) Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by irz301.inf.tu-dresden.de (8.6.12/8.6.12-s1) with ESMTP id WAA16045; Mon, 14 Oct 1996 22:51:40 +0200 Received: (from uucp@localhost) by sax.sax.de (8.6.12/8.6.12-s1) with UUCP id WAA21036; Mon, 14 Oct 1996 22:51:33 +0200 Received: (from j@localhost) by uriah.heep.sax.de (8.7.6/8.6.9) id WAA07535; Mon, 14 Oct 1996 22:25:24 +0200 (MET DST) From: J Wunsch Message-Id: <199610142025.WAA07535@uriah.heep.sax.de> Subject: Re: cvs commit: src/sbin/savecore savecore.c To: fenner@parc.xerox.com (Bill Fenner) Date: Mon, 14 Oct 1996 22:25:24 +0200 (MET DST) Cc: joerg@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) In-Reply-To: <96Oct13.144850pdt.177477@crevenia.parc.xerox.com> from Bill Fenner at "Oct 13, 96 02:48:37 pm" X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E X-Mailer: ELM [version 2.4ME+ PL17 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk As Bill Fenner wrote: > > However, he missed the part to compute the kernelsize in kilobytes, > > so the minfree consideration was now overcautious. > Sorry, I thought I had made sure that everything was in K. Unless I > missed something, the patch in the PR causes minfree to be specified in > bytes, which is not what the man page says. Yep, the patch in the PR broke with the tradition. My own (not committed) version also used byte values for everything (with `dumpsize' also enlarged to off_t), to avoid the implicit truncation to the lower kilobyte value. However, i multiplied the value from the minfree file with 1024 when reading it, in order to comply with the man page and the historic behaviour. > In fact, if I re-read my patch, it looks like spacefree and totfree are > kept in units of K-bytes, kernelsize and dumpsize are kept in units of > bytes but needed = (dumpsize + kernelsize) / 1024, so needed is in units > of K-bytes, and minfree is specified in the file as being specified in > K-bytes. What am I missing? Nothing. I think my brain has already been turned off last night... Who's got the pointing hat these days? Pass it on to me! <:-) -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-) From owner-cvs-sbin Mon Oct 14 14:42:51 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id OAA27589 for cvs-sbin-outgoing; Mon, 14 Oct 1996 14:42:51 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id OAA27582; Mon, 14 Oct 1996 14:42:45 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.7.6/8.6.9) id HAA13903; Tue, 15 Oct 1996 07:38:13 +1000 Date: Tue, 15 Oct 1996 07:38:13 +1000 From: Bruce Evans Message-Id: <199610142138.HAA13903@godzilla.zeta.org.au> To: fenner@parc.xerox.com, j@uriah.heep.sax.de Subject: Re: cvs commit: src/sbin/savecore savecore.c Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org, joerg@freefall.freebsd.org Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >> Sorry, I thought I had made sure that everything was in K. Unless I >> missed something, the patch in the PR causes minfree to be specified in >> bytes, which is not what the man page says. > >Yep, the patch in the PR broke with the tradition. My own (not >committed) version also used byte values for everything (with >`dumpsize' also enlarged to off_t), to avoid the implicit truncation I think the committed version has some rounding problems from not using bytes for everything and rounding up as late as possible. However, writing the last K is unlikely to work anyway because statfs can't report the exact amount free in advance (it can't know how many indirect blocks there will be in advance). Thus setting minfree to 0 is bogus. Bruce From owner-cvs-sbin Mon Oct 14 15:24:59 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id PAA00522 for cvs-sbin-outgoing; Mon, 14 Oct 1996 15:24:59 -0700 (PDT) Received: from alpha.xerox.com (alpha.Xerox.COM [13.1.64.93]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id PAA00471; Mon, 14 Oct 1996 15:24:26 -0700 (PDT) Received: from crevenia.parc.xerox.com ([13.2.116.11]) by alpha.xerox.com with SMTP id <14760(3)>; Mon, 14 Oct 1996 15:23:54 PDT Received: from localhost ([127.0.0.1]) by crevenia.parc.xerox.com with SMTP id <177480>; Mon, 14 Oct 1996 15:23:47 -0700 X-Mailer: exmh version 1.6.7 5/3/96 To: Bruce Evans cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/savecore savecore.c In-reply-to: Your message of "Mon, 14 Oct 1996 14:38:13 PDT." <199610142138.HAA13903@godzilla.zeta.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 14 Oct 1996 15:23:35 PDT From: Bill Fenner Message-Id: <96Oct14.152347pdt.177480@crevenia.parc.xerox.com> Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk In message <199610142138.HAA13903@godzilla.zeta.org.au>you write: >However, >writing the last K is unlikely to work anyway because statfs can't >report the exact amount free in advance (it can't know how many >indirect blocks there will be in advance). Thus setting minfree to >0 is bogus. But savecore could make a pretty good guess about the number of indirect blocks, right? needed = kernelsize + dumpsize; needed += fudge(needed); Bill From owner-cvs-sbin Mon Oct 14 15:53:57 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id PAA03161 for cvs-sbin-outgoing; Mon, 14 Oct 1996 15:53:57 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id PAA03124; Mon, 14 Oct 1996 15:53:27 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.7.6/8.6.9) id IAA16019; Tue, 15 Oct 1996 08:45:23 +1000 Date: Tue, 15 Oct 1996 08:45:23 +1000 From: Bruce Evans Message-Id: <199610142245.IAA16019@godzilla.zeta.org.au> To: bde@zeta.org.au, fenner@parc.xerox.com Subject: Re: cvs commit: src/sbin/savecore savecore.c Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >But savecore could make a pretty good guess about the number of indirect blocks, right? > needed = kernelsize + dumpsize; > needed += fudge(needed); Only if it knows too much about the file system :-). Bruce From owner-cvs-sbin Mon Oct 14 15:56:13 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id PAA03427 for cvs-sbin-outgoing; Mon, 14 Oct 1996 15:56:13 -0700 (PDT) Received: (from joerg@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id PAA03347; Mon, 14 Oct 1996 15:56:04 -0700 (PDT) Date: Mon, 14 Oct 1996 15:56:04 -0700 (PDT) From: Joerg Wunsch Message-Id: <199610142256.PAA03347@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/savecore savecore.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk joerg 96/10/14 15:56:03 Modified: sbin/savecore savecore.c Log: Fix my yesterday's brain-o: don't account for the kilobytes twice. Revision Changes Path 1.17 +1 -1 src/sbin/savecore/savecore.c From owner-cvs-sbin Mon Oct 14 15:56:59 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id PAA03496 for cvs-sbin-outgoing; Mon, 14 Oct 1996 15:56:59 -0700 (PDT) Received: (from joerg@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id PAA03482; Mon, 14 Oct 1996 15:56:52 -0700 (PDT) Date: Mon, 14 Oct 1996 15:56:52 -0700 (PDT) From: Joerg Wunsch Message-Id: <199610142256.PAA03482@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/savecore savecore.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk joerg 96/10/14 15:56:51 Branch: sbin/savecore RELENG_2_1_0 Modified: sbin/savecore savecore.c Log: Merge the rev 1.17 fix. Revision Changes Path 1.7.4.4 +1 -1 src/sbin/savecore/savecore.c From owner-cvs-sbin Tue Oct 15 01:41:18 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id BAA14277 for cvs-sbin-outgoing; Tue, 15 Oct 1996 01:41:18 -0700 (PDT) Received: (from bde@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id BAA14256; Tue, 15 Oct 1996 01:41:01 -0700 (PDT) Date: Tue, 15 Oct 1996 01:41:01 -0700 (PDT) From: Bruce Evans Message-Id: <199610150841.BAA14256@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/newfs - Imported sources Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk bde 96/10/15 01:41:00 src/sbin/newfs - Imported sources Update of /home/ncvs/src/sbin/newfs In directory freefall.freebsd.org:/a/bde/src/newfs Revision/Branch: 1.1.1 Log Message: Second try: attempt to import Lite2's newfs. Status: Vendor Tag: CSRG Release Tags: bsd_44_lite_2 I src/sbin/newfs/CVS U src/sbin/newfs/Makefile C src/sbin/newfs/mkfs.c C src/sbin/newfs/newfs.8 C src/sbin/newfs/newfs.c 3 conflicts created by this import. Use the following command to help the merge: cvs checkout -jCSRG:yesterday -jCSRG src/sbin/newfs From owner-cvs-sbin Wed Oct 16 12:37:34 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id MAA29185 for cvs-sbin-outgoing; Wed, 16 Oct 1996 12:37:34 -0700 (PDT) Received: (from jkh@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id MAA29166; Wed, 16 Oct 1996 12:37:23 -0700 (PDT) Date: Wed, 16 Oct 1996 12:37:23 -0700 (PDT) From: "Jordan K. Hubbard" Message-Id: <199610161937.MAA29166@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/route Makefile Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 96/10/16 12:37:22 Modified: sbin/route Makefile Log: Bring back NS support for this utility - we need it for the commercial Novell server software. Revision Changes Path 1.7 +1 -1 src/sbin/route/Makefile From owner-cvs-sbin Wed Oct 16 12:38:09 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id MAA29257 for cvs-sbin-outgoing; Wed, 16 Oct 1996 12:38:09 -0700 (PDT) Received: (from jkh@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id MAA29235; Wed, 16 Oct 1996 12:38:02 -0700 (PDT) Date: Wed, 16 Oct 1996 12:38:02 -0700 (PDT) From: "Jordan K. Hubbard" Message-Id: <199610161938.MAA29235@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/ifconfig Makefile Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 96/10/16 12:38:02 Modified: sbin/ifconfig Makefile Log: Bring back NS support for this utility - we need it for the commercial Novell server software. Revision Changes Path 1.6 +1 -0 src/sbin/ifconfig/Makefile From owner-cvs-sbin Wed Oct 16 18:05:16 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id SAA20071 for cvs-sbin-outgoing; Wed, 16 Oct 1996 18:05:16 -0700 (PDT) Received: (from alex@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id SAA20054; Wed, 16 Oct 1996 18:05:06 -0700 (PDT) Date: Wed, 16 Oct 1996 18:05:06 -0700 (PDT) From: Alex Nash Message-Id: <199610170105.SAA20054@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/ipfw ipfw.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk alex 96/10/16 18:05:05 Modified: sbin/ipfw ipfw.c Log: Issue a warning if the user specifies an invalid interface in a rule. The rule is still added to the chain since the interface may get created later on after loading an LKM. Revision Changes Path 1.34 +25 -1 src/sbin/ipfw/ipfw.c