From owner-cvs-sys Sun Sep 29 03:19:33 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA17044 for cvs-sys-outgoing; Sun, 29 Sep 1996 03:19:33 -0700 (PDT) Received: from sovcom.kiae.su (sovcom.kiae.su [193.125.152.1]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id DAA16985; Sun, 29 Sep 1996 03:19:27 -0700 (PDT) Received: by sovcom.kiae.su id AA29229 (5.65.kiae-1 ); Sun, 29 Sep 1996 13:05:22 +0300 Received: by sovcom.KIAE.su (UUMAIL/2.0); Sun, 29 Sep 96 13:05:22 +0300 Received: (from ache@localhost) by nagual.ru (8.7.6/8.7.3) id NAA00769; Sun, 29 Sep 1996 13:00:51 +0300 (MSK) Message-Id: <199609291000.NAA00769@nagual.ru> Subject: Re: cvs commit: src/sys/vm vm_object.c vm_object.h vm_page.c vm_pageout.c In-Reply-To: <199609280342.WAA03366@dyson.iquest.net> from "John S. Dyson" at "Sep 27, 96 10:42:30 pm" To: dyson@freebsd.org Date: Sun, 29 Sep 1996 13:00:51 +0300 (MSK) Cc: dyson@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org From: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= (Andrey A. Chernov) Organization: self X-Class: Fast X-Mailer: ELM [version 2.4ME+ PL26 (25)] Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-sys@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > Fix some redundancy in the page coloring code. Also, support > contiguous allocation of memory in objects (if the system doesn't > have to do anything special), if all else is equal. BTW, what is "page coloring"? Do you know any papers (URLs) available? -- Andrey A. Chernov http://www.nagual.ru/~ache/ From owner-cvs-sys Sun Sep 29 03:21:16 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA18037 for cvs-sys-outgoing; Sun, 29 Sep 1996 03:21:16 -0700 (PDT) Received: (from davidg@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA17835; Sun, 29 Sep 1996 03:20:55 -0700 (PDT) Date: Sun, 29 Sep 1996 03:20:55 -0700 (PDT) From: David Greenman Message-Id: <199609291020.DAA17835@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/pci if_fxp.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk davidg 96/09/29 03:20:53 Modified: sys/pci if_fxp.c Log: Backed out one of my "performance optimizations" as it results in sometimes not resuming the NIC as required for transmit. Thanks to Alan Cox for noticing this. Added another performance optimization to compensate. :-) Changed crscdt to 1...strange, but this seems to be needed for some reason despite what the manual says. Revision Changes Path 1.20 +13 -9 src/sys/pci/if_fxp.c From owner-cvs-sys Sun Sep 29 03:22:11 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA18570 for cvs-sys-outgoing; Sun, 29 Sep 1996 03:22:11 -0700 (PDT) Received: (from davidg@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA18370; Sun, 29 Sep 1996 03:21:50 -0700 (PDT) Date: Sun, 29 Sep 1996 03:21:50 -0700 (PDT) From: David Greenman Message-Id: <199609291021.DAA18370@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/pci if_fxp.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk davidg 96/09/29 03:21:47 Branch: sys/pci RELENG_2_1_0 Modified: sys/pci if_fxp.c Log: Brought in fixes from rev 1.20. Revision Changes Path 1.8.2.10 +13 -9 src/sys/pci/if_fxp.c From owner-cvs-sys Sun Sep 29 08:01:10 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id IAA08298 for cvs-sys-outgoing; Sun, 29 Sep 1996 08:01:10 -0700 (PDT) Received: (from bde@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id IAA08100; Sun, 29 Sep 1996 08:00:48 -0700 (PDT) Date: Sun, 29 Sep 1996 08:00:48 -0700 (PDT) From: Bruce Evans Message-Id: <199609291500.IAA08100@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/sys systm.h src/sys/miscfs/devfs devfs_tree.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk bde 96/09/29 08:00:46 Modified: sys/sys systm.h sys/miscfs/devfs devfs_tree.c Log: Started unspamming . Don't include to get the declaration of va_list; just use _BSD_VA_LIST. Fixed the 2 places that need but didn't include it explicitly. Revision Changes Path 1.45 +4 -4 src/sys/sys/systm.h 1.31 +3 -1 src/sys/miscfs/devfs/devfs_tree.c From owner-cvs-sys Sun Sep 29 11:35:42 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA10363 for cvs-sys-outgoing; Sun, 29 Sep 1996 11:35:42 -0700 (PDT) Received: (from bde@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA10070; Sun, 29 Sep 1996 11:35:18 -0700 (PDT) Date: Sun, 29 Sep 1996 11:35:18 -0700 (PDT) From: Bruce Evans Message-Id: <199609291835.LAA10070@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/i386/include cpufunc.h Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk bde 96/09/29 11:35:16 Modified: sys/i386/include cpufunc.h Log: Added "memory" to clobber list in invlpg(). It needs it if invltlb() needs it. Fixed style in invlpg(). Sorted recently renamed functions. Added prototypes in the non-gcc section for recently added/renamed functions. Revision Changes Path 1.59 +21 -20 src/sys/i386/include/cpufunc.h From owner-cvs-sys Sun Sep 29 11:41:25 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA14934 for cvs-sys-outgoing; Sun, 29 Sep 1996 11:41:25 -0700 (PDT) Received: from dyson.iquest.net (dyson.iquest.net [198.70.144.127]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id LAA14882; Sun, 29 Sep 1996 11:41:21 -0700 (PDT) Received: (from root@localhost) by dyson.iquest.net (8.7.5/8.6.9) id NAA07712; Sun, 29 Sep 1996 13:40:56 -0500 (EST) From: "John S. Dyson" Message-Id: <199609291840.NAA07712@dyson.iquest.net> Subject: Re: cvs commit: src/sys/vm vm_object.c vm_object.h vm_page.c vm_pageout.c To: ache@nagual.ru (=?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?=) Date: Sun, 29 Sep 1996 13:40:56 -0500 (EST) Cc: dyson@freebsd.org, dyson@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org In-Reply-To: <199609291000.NAA00769@nagual.ru> from "=?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?=" at Sep 29, 96 01:00:51 pm Reply-To: dyson@freebsd.org X-Mailer: ELM [version 2.4 PL24 ME8] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-sys@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > > Fix some redundancy in the page coloring code. Also, support > > contiguous allocation of memory in objects (if the system doesn't > > have to do anything special), if all else is equal. > > BTW, what is "page coloring"? Do you know any papers (URLs) available? > I have some TR pointers handy: Stanford University (Online): CSL-TR-90-454, CSL-TR-91-492 ACM Transactions on Computer Systems (Can't find online): Vol 10, No 4, Nov 1992 Page Placement Alogrithms for Large Real-Indexed Caches A good place to search for TRs: www.ncstrl.org John From owner-cvs-sys Sun Sep 29 13:00:58 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id NAA14705 for cvs-sys-outgoing; Sun, 29 Sep 1996 13:00:58 -0700 (PDT) Received: from dyson.iquest.net (dyson.iquest.net [198.70.144.127]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id NAA14655; Sun, 29 Sep 1996 13:00:51 -0700 (PDT) Received: (from root@localhost) by dyson.iquest.net (8.7.5/8.6.9) id PAA10815; Sun, 29 Sep 1996 15:00:33 -0500 (EST) From: "John S. Dyson" Message-Id: <199609292000.PAA10815@dyson.iquest.net> Subject: Re: cvs commit: src/sys/vm vm_object.c vm_object.h vm_page.c vm_pageout.c To: dyson@freebsd.org Date: Sun, 29 Sep 1996 15:00:33 -0500 (EST) Cc: ache@nagual.ru, dyson@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org In-Reply-To: <199609291840.NAA07712@dyson.iquest.net> from "John S. Dyson" at Sep 29, 96 01:40:56 pm Reply-To: dyson@freebsd.org X-Mailer: ELM [version 2.4 PL24 ME8] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-sys@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > > > Fix some redundancy in the page coloring code. Also, support > > > contiguous allocation of memory in objects (if the system doesn't > > > have to do anything special), if all else is equal. > > > > BTW, what is "page coloring"? Do you know any papers (URLs) available? > > I just realized that I might have been a bit rude by not answering your initial question as to what "page coloring" is. It is a way of choosing pages more carefully so that a direct mapped cache is used more effectively. It is a way of making a direct mapped cache look more like an associative cache. Unfortunately, our inclusion of page coloring has exacted a small performance hit for certain low level benchmarks (it is because we have optimizations to reuse recently used pages so that they are more likely in the cache.) In the long run, the performance is higher. Specifically, you might try running multiple copies of the heapsort/nsieve benchmark(s) in ftp.nosc.mil:/pub/aburto. John From owner-cvs-sys Mon Sep 30 04:25:53 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id EAA13019 for cvs-sys-outgoing; Mon, 30 Sep 1996 04:25:53 -0700 (PDT) Received: (from bde@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id EAA12675; Mon, 30 Sep 1996 04:25:26 -0700 (PDT) Date: Mon, 30 Sep 1996 04:25:26 -0700 (PDT) From: Bruce Evans Message-Id: <199609301125.EAA12675@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/i386/i386 userconfig.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk bde 96/09/30 04:25:24 Modified: sys/i386/i386 userconfig.c Log: Whaddya know, visual userconfig sort of supports pci, but the support was always disabled because "pci.h" wasn't included. Now the configured pci devices are listed and you can edit bogus flags for them. Fixed bitrot in the disabled code. A used #include was removed and const poisoning wasn't fixed. Removed unused #include. Revision Changes Path 1.48 +6 -5 src/sys/i386/i386/userconfig.c From owner-cvs-sys Mon Sep 30 05:42:02 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id FAA04033 for cvs-sys-outgoing; Mon, 30 Sep 1996 05:23:11 -0700 (PDT) Received: (from bde@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id FAA03697; Mon, 30 Sep 1996 05:22:37 -0700 (PDT) Date: Mon, 30 Sep 1996 05:22:37 -0700 (PDT) From: Bruce Evans Message-Id: <199609301222.FAA03697@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/i386/isa sio.c Sender: owner-cvs-sys@freebsd.org X-Loop: FreeBSD.org Precedence: bulk bde 96/09/30 05:22:34 Modified: sys/i386/isa sio.c Log: Work around UMC8669F and Startech UART bugs by not writing to the divisor latch registers if the registers wouldn't change. Use the default console cfcr setting while setting the divisor latch registers for console i/o. Input may be messed up by transiently changing the cfcr. Use a usual cfcr setting while setting the divisor latch registers in the probe. This shouldn't matter, but this is not the place to test the UART's handling of 5 bit words. Removed a stale devfs comment. Revision Changes Path 1.147 +36 -11 src/sys/i386/isa/sio.c From owner-cvs-sys Mon Sep 30 13:15:38 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id MAA11350 for cvs-sys-outgoing; Mon, 30 Sep 1996 12:29:53 -0700 (PDT) Received: (from julian@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id MAA10861; Mon, 30 Sep 1996 12:29:02 -0700 (PDT) Date: Mon, 30 Sep 1996 12:29:02 -0700 (PDT) From: Julian Elischer Message-Id: <199609301929.MAA10861@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/kern kern_time.c Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk julian 96/09/30 12:28:58 Modified: sys/kern kern_time.c Log: if we jump the time, we need to check all the process real interval timers. Revision Changes Path 1.18 +5 -2 src/sys/kern/kern_time.c From owner-cvs-sys Mon Sep 30 16:02:10 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id QAA27572 for cvs-sys-outgoing; Mon, 30 Sep 1996 16:02:10 -0700 (PDT) Received: (from sos@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id QAA27085; Mon, 30 Sep 1996 16:01:20 -0700 (PDT) Date: Mon, 30 Sep 1996 16:01:20 -0700 (PDT) From: Soren Schmidt Message-Id: <199609302301.QAA27085@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/i386/isa syscons.c syscons.h src/sys/i386/include console.h Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk sos 96/09/30 16:01:13 Modified: sys/i386/include console.h sys/i386/isa syscons.c syscons.h Log: Fix a couble of nasties regarding mouse pointer and different resolutions. Allow middle mouse button to be used for pasting. Also added the beginnings of support for a splash page. Revision Changes Path 1.25 +3 -1 src/sys/i386/include/console.h 1.172 +175 -100 src/sys/i386/isa/syscons.c 1.21 +5 -3 src/sys/i386/isa/syscons.h From owner-cvs-sys Mon Sep 30 16:11:31 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id QAA04074 for cvs-sys-outgoing; Mon, 30 Sep 1996 16:11:31 -0700 (PDT) Received: (from sos@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id QAA03633; Mon, 30 Sep 1996 16:10:51 -0700 (PDT) Date: Mon, 30 Sep 1996 16:10:51 -0700 (PDT) From: Soren Schmidt Message-Id: <199609302310.QAA03633@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/i386/isa syscons.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk sos 96/09/30 16:10:47 Modified: sys/i386/isa syscons.c Log: Dont make splash screen the default :) Revision Changes Path 1.173 +1 -2 src/sys/i386/isa/syscons.c From owner-cvs-sys Mon Sep 30 17:13:15 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id RAA23369 for cvs-sys-outgoing; Mon, 30 Sep 1996 17:13:15 -0700 (PDT) Received: from parkplace.cet.co.jp (parkplace.cet.co.jp [202.32.64.1]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id RAA23291 for ; Mon, 30 Sep 1996 17:13:10 -0700 (PDT) Received: from localhost (michaelh@localhost) by parkplace.cet.co.jp (8.8.0/CET-v2.1) with SMTP id AAA21199; Tue, 1 Oct 1996 00:12:54 GMT Date: Tue, 1 Oct 1996 09:12:54 +0900 (JST) From: Michael Hancock To: dyson@freebsd.org cc: ache@nagual.ru, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/vm vm_object.c vm_object.h vm_page.c vm_pageout.c In-Reply-To: <199609292000.PAA10815@dyson.iquest.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-sys@freebsd.org X-Loop: FreeBSD.org Precedence: bulk On Sun, 29 Sep 1996, John S. Dyson wrote: > > > BTW, what is "page coloring"? Do you know any papers (URLs) available? > > > > I just realized that I might have been a bit rude by not answering your > initial question as to what "page coloring" is. It is a way of choosing > pages more carefully so that a direct mapped cache is used more effectively. > It is a way of making a direct mapped cache look more like an associative > cache. Unfortunately, our inclusion of page coloring has exacted a small > performance hit for certain low level benchmarks (it is because we have > optimizations to reuse recently used pages so that they are more likely > in the cache.) In the long run, the performance is higher. Specifically, > you might try running multiple copies of the heapsort/nsieve benchmark(s) > in ftp.nosc.mil:/pub/aburto. It might be interesting to note that Solaris does it's coloring in it's slab memory allocator. +-------------+-------+-------+--- ---+-----------------------+ |Coloring area|Object1|Object2|... ...|Link to next slab, etc.| +-------------+-------+-------+--- ---+-----------------------+ Regards, Mike Hancock From owner-cvs-sys Mon Sep 30 20:02:55 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id UAA20445 for cvs-sys-outgoing; Mon, 30 Sep 1996 20:02:55 -0700 (PDT) Received: (from pst@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id UAA20250; Mon, 30 Sep 1996 20:01:15 -0700 (PDT) Date: Mon, 30 Sep 1996 20:01:15 -0700 (PDT) From: Paul Traina Message-Id: <199610010301.UAA20250@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/i386/conf LINT options.i386 src/sys/i386/scsi aic7xxx.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk pst 96/09/30 20:01:12 Modified: sys/i386/conf LINT options.i386 sys/i386/scsi aic7xxx.c Log: Document the Adaptec driver options for tagged command queueing and SCB paging (with a warning not to use SCB paging) and create an opt_aic7xxx.h file for these options. Revision Changes Path 1.281 +10 -1 src/sys/i386/conf/LINT 1.19 +4 -1 src/sys/i386/conf/options.i386 1.76 +2 -1 src/sys/i386/scsi/aic7xxx.c From owner-cvs-sys Tue Oct 1 00:38:33 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA03680 for cvs-sys-outgoing; Tue, 1 Oct 1996 00:38:33 -0700 (PDT) Received: (from jkh@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA03658; Tue, 1 Oct 1996 00:38:16 -0700 (PDT) Date: Tue, 1 Oct 1996 00:38:16 -0700 (PDT) From: "Jordan K. Hubbard" Message-Id: <199610010738.AAA03658@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/i386/isa syscons.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 96/10/01 00:38:16 Modified: sys/i386/isa syscons.c Log: #ifdef another instance of toggle_splash_screen() which Soren missed. Revision Changes Path 1.174 +5 -1 src/sys/i386/isa/syscons.c From owner-cvs-sys Tue Oct 1 16:24:21 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id QAA09181 for cvs-sys-outgoing; Tue, 1 Oct 1996 16:24:21 -0700 (PDT) Received: (from sos@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id QAA09145; Tue, 1 Oct 1996 16:24:12 -0700 (PDT) Date: Tue, 1 Oct 1996 16:24:12 -0700 (PDT) From: Soren Schmidt Message-Id: <199610012324.QAA09145@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/i386/isa syscons.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk sos 96/10/01 16:24:12 Modified: sys/i386/isa syscons.c Log: Fixed the "missing updates" reported by ache. Moved a little closer to having a splash page capability. Revision Changes Path 1.175 +37 -29 src/sys/i386/isa/syscons.c From owner-cvs-sys Tue Oct 1 20:48:24 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id UAA27330 for cvs-sys-outgoing; Tue, 1 Oct 1996 20:48:24 -0700 (PDT) Received: (from pst@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id UAA27311; Tue, 1 Oct 1996 20:48:12 -0700 (PDT) Date: Tue, 1 Oct 1996 20:48:12 -0700 (PDT) From: Paul Traina Message-Id: <199610020348.UAA27311@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/i386/conf options.i386 Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk pst 96/10/01 20:48:11 Modified: sys/i386/conf options.i386 Log: add SC_SPLASH_SCREEN to opt_syscons.h (sigh) Revision Changes Path 1.20 +2 -1 src/sys/i386/conf/options.i386 From owner-cvs-sys Tue Oct 1 22:02:49 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id WAA02986 for cvs-sys-outgoing; Tue, 1 Oct 1996 22:02:49 -0700 (PDT) Received: (from dyson@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id WAA02830; Tue, 1 Oct 1996 22:01:20 -0700 (PDT) Date: Tue, 1 Oct 1996 22:01:20 -0700 (PDT) From: John Dyson Message-Id: <199610020501.WAA02830@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/msdosfs msdosfs_vnops.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk dyson 96/10/01 22:01:19 Modified: sys/msdosfs msdosfs_vnops.c Log: MSDOS FS used to allocate a buffer before extending the VM object. In certain error conditions, it is possible for pages to be left allocated in the object beyond it's end. It is generally bad practice to allocate pages beyond the end of an object. Revision Changes Path 1.34 +9 -7 src/sys/msdosfs/msdosfs_vnops.c From owner-cvs-sys Tue Oct 1 23:30:40 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id XAA11302 for cvs-sys-outgoing; Tue, 1 Oct 1996 23:30:40 -0700 (PDT) Received: from ra.dkuug.dk (ra.dkuug.dk [193.88.44.193]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id XAA11286; Tue, 1 Oct 1996 23:30:35 -0700 (PDT) Received: (from sos@localhost) by ra.dkuug.dk (8.6.12/8.6.12) id IAA01408; Wed, 2 Oct 1996 08:30:33 +0200 Message-Id: <199610020630.IAA01408@ra.dkuug.dk> Subject: Re: cvs commit: src/sys/i386/conf options.i386 To: pst@freefall.freebsd.org (Paul Traina) Date: Wed, 2 Oct 1996 08:30:33 +0200 (MET DST) Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org In-Reply-To: <199610020348.UAA27311@freefall.freebsd.org> from "Paul Traina" at Oct 1, 96 08:48:12 pm From: sos@FreeBSD.org Reply-to: sos@FreeBSD.org X-Mailer: ELM [version 2.4 PL24] Content-Type: text Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk In reply to Paul Traina who wrote: > > pst 96/10/01 20:48:11 > > Modified: sys/i386/conf options.i386 > Log: > add SC_SPLASH_SCREEN to opt_syscons.h (sigh) Boy, are you fast, this doesn't even work yet !! I wont advise anybody to define this, or be prepared for a surprise... (you know, there was a reason I didn't add this myself)... -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Soren Schmidt (sos@FreeBSD.org) FreeBSD Core Team So much code to hack -- so little time. From owner-cvs-sys Wed Oct 2 01:10:51 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id BAA19383 for cvs-sys-outgoing; Wed, 2 Oct 1996 01:10:51 -0700 (PDT) Received: (from jkh@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id BAA19282; Wed, 2 Oct 1996 01:09:13 -0700 (PDT) Date: Wed, 2 Oct 1996 01:09:13 -0700 (PDT) From: "Jordan K. Hubbard" Message-Id: <199610020809.BAA19282@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/i386/i386 userconfig.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 96/10/02 01:09:13 Modified: sys/i386/i386 userconfig.c Log: New support for displaying PCI devices without making you insane. Submitted-by: msmith [bless his heart] Revision Changes Path 1.49 +74 -46 src/sys/i386/i386/userconfig.c From owner-cvs-sys Wed Oct 2 07:10:27 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id HAA09878 for cvs-sys-outgoing; Wed, 2 Oct 1996 07:10:27 -0700 (PDT) Received: from precipice.shockwave.com (ppp-206-170-5-84.rdcy01.pacbell.net [206.170.5.84]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id HAA09842; Wed, 2 Oct 1996 07:10:09 -0700 (PDT) Received: from shockwave.com (localhost.shockwave.com [127.0.0.1]) by precipice.shockwave.com (8.7.6/8.7.3) with ESMTP id HAA05264; Wed, 2 Oct 1996 07:09:19 -0700 (PDT) Message-Id: <199610021409.HAA05264@precipice.shockwave.com> To: sos@FreeBSD.org cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/conf options.i386 In-reply-to: Your message of "Wed, 02 Oct 1996 08:30:33 +0200." <199610020630.IAA01408@ra.dkuug.dk> Date: Wed, 02 Oct 1996 07:09:19 -0700 From: Paul Traina Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk The problem is that people are getting into the habit of defining global options. It's fine to put it in and just warn people not to use it. global options are EVIL From: sos@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/conf options.i386 In reply to Paul Traina who wrote: > > pst 96/10/01 20:48:11 > > Modified: sys/i386/conf options.i386 > Log: > add SC_SPLASH_SCREEN to opt_syscons.h (sigh) Boy, are you fast, this doesn't even work yet !! I wont advise anybody to define this, or be prepared for a surprise... (you know, there was a reason I didn't add this myself)... -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Soren Schmidt (sos@FreeBSD.org) FreeBSD Core Team So much code to hack -- so little time. From owner-cvs-sys Wed Oct 2 15:01:03 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id PAA10142 for cvs-sys-outgoing; Wed, 2 Oct 1996 15:01:03 -0700 (PDT) Received: (from sos@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id PAA10121; Wed, 2 Oct 1996 15:00:45 -0700 (PDT) Date: Wed, 2 Oct 1996 15:00:45 -0700 (PDT) From: Soren Schmidt Message-Id: <199610022200.PAA10121@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/i386/isa syscons.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk sos 96/10/02 15:00:43 Modified: sys/i386/isa syscons.c Log: Fixed the userconfig problem (and one with ddb as well). The rudimentary support for a splash page is there, and works, it just needs a splash page... Revision Changes Path 1.176 +157 -153 src/sys/i386/isa/syscons.c From owner-cvs-sys Wed Oct 2 17:44:07 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id RAA17600 for cvs-sys-outgoing; Wed, 2 Oct 1996 17:44:07 -0700 (PDT) Received: (from jkh@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id RAA17524; Wed, 2 Oct 1996 17:42:30 -0700 (PDT) Date: Wed, 2 Oct 1996 17:42:30 -0700 (PDT) From: "Jordan K. Hubbard" Message-Id: <199610030042.RAA17524@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/i386/isa syscons.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 96/10/02 17:42:29 Modified: sys/i386/isa syscons.c Log: scresume erroneously used before declared. Move the function rather than add another APM ifdef just for the forward decl. [Boy, sure a lot of warnings in here!] Revision Changes Path 1.177 +10 -10 src/sys/i386/isa/syscons.c From owner-cvs-sys Wed Oct 2 18:02:42 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id SAA18551 for cvs-sys-outgoing; Wed, 2 Oct 1996 18:02:42 -0700 (PDT) Received: (from jkh@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id SAA18483; Wed, 2 Oct 1996 18:01:07 -0700 (PDT) Date: Wed, 2 Oct 1996 18:01:07 -0700 (PDT) From: "Jordan K. Hubbard" Message-Id: <199610030101.SAA18483@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/i386/i386 userconfig.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 96/10/02 18:01:06 Modified: sys/i386/i386 userconfig.c Log: Add fxp and vx to list of known device types. Revision Changes Path 1.50 +4 -2 src/sys/i386/i386/userconfig.c From owner-cvs-sys Wed Oct 2 18:23:54 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id SAA19844 for cvs-sys-outgoing; Wed, 2 Oct 1996 18:23:54 -0700 (PDT) Received: (from jkh@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id SAA19765; Wed, 2 Oct 1996 18:22:25 -0700 (PDT) Date: Wed, 2 Oct 1996 18:22:25 -0700 (PDT) From: "Jordan K. Hubbard" Message-Id: <199610030122.SAA19765@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/i386/i386 userconfig.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 96/10/02 18:22:25 Modified: sys/i386/i386 userconfig.c Log: Fix stupid typo. Revision Changes Path 1.51 +3 -3 src/sys/i386/i386/userconfig.c From owner-cvs-sys Wed Oct 2 23:15:00 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id XAA04136 for cvs-sys-outgoing; Wed, 2 Oct 1996 23:15:00 -0700 (PDT) Received: (from peter@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id XAA04113; Wed, 2 Oct 1996 23:14:50 -0700 (PDT) Date: Wed, 2 Oct 1996 23:14:50 -0700 (PDT) From: Peter Wemm Message-Id: <199610030614.XAA04113@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/kern imgact_elf.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 96/10/02 23:14:50 Modified: sys/kern imgact_elf.c Log: Drop an unused param to unmap_pages(). Revision Changes Path 1.9 +7 -7 src/sys/kern/imgact_elf.c From owner-cvs-sys Wed Oct 2 23:26:55 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id XAA04751 for cvs-sys-outgoing; Wed, 2 Oct 1996 23:26:55 -0700 (PDT) Received: from ra.dkuug.dk (ra.dkuug.dk [193.88.44.193]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id XAA04744; Wed, 2 Oct 1996 23:26:50 -0700 (PDT) Received: (from sos@localhost) by ra.dkuug.dk (8.6.12/8.6.12) id IAA07626; Thu, 3 Oct 1996 08:26:48 +0200 Message-Id: <199610030626.IAA07626@ra.dkuug.dk> Subject: Re: cvs commit: src/sys/i386/isa syscons.c To: jkh@freefall.freebsd.org (Jordan K. Hubbard) Date: Thu, 3 Oct 1996 08:26:48 +0200 (MET DST) Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org In-Reply-To: <199610030042.RAA17524@freefall.freebsd.org> from "Jordan K. Hubbard" at Oct 2, 96 05:42:30 pm From: sos@FreeBSD.org Reply-to: sos@FreeBSD.org X-Mailer: ELM [version 2.4 PL24] Content-Type: text Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk In reply to Jordan K. Hubbard who wrote: > > jkh 96/10/02 17:42:29 > > Modified: sys/i386/isa syscons.c > Log: > scresume erroneously used before declared. Move the function > rather than add another APM ifdef just for the forward decl. Ahh, I dont use APM so.... thanks. > [Boy, sure a lot of warnings in here!] Yep, but they are all of the type (but two) that says you have a function with X parameters, but you use only X-n I'm not really sure what to do with them, they are bogus IMHO. Then there are two warning say that the sizeof operator is unsigned... -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Soren Schmidt (sos@FreeBSD.org) FreeBSD Core Team So much code to hack -- so little time. From owner-cvs-sys Wed Oct 2 23:43:13 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id XAA05661 for cvs-sys-outgoing; Wed, 2 Oct 1996 23:43:13 -0700 (PDT) Received: from spinner.DIALix.COM (root@spinner.DIALix.COM [192.203.228.67]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id XAA05644; Wed, 2 Oct 1996 23:43:03 -0700 (PDT) Received: from spinner.DIALix.COM (peter@localhost.DIALix.oz.au [127.0.0.1]) by spinner.DIALix.COM (8.8.0/8.8.0) with ESMTP id OAA03239; Thu, 3 Oct 1996 14:42:50 +0800 (WST) Message-Id: <199610030642.OAA03239@spinner.DIALix.COM> To: sos@FreeBSD.org cc: jkh@freefall.freebsd.org (Jordan K. Hubbard), CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c In-reply-to: Your message of "Thu, 03 Oct 1996 08:26:48 +0200." <199610030626.IAA07626@ra.dkuug.dk> Date: Thu, 03 Oct 1996 14:42:49 +0800 From: Peter Wemm Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk sos@FreeBSD.org wrote: > In reply to Jordan K. Hubbard who wrote: > > [Boy, sure a lot of warnings in here!] > > Yep, but they are all of the type (but two) that says you > have a function with X parameters, but you use only X-n > I'm not really sure what to do with them, they are bogus > IMHO. Then there are two warning say that the sizeof > operator is unsigned... In theory, it can be written: void func(x, y) int x __unused; char *y __unused; { return (1); } or (in ANSI-style) void func(int x __unused, char *y __unused) { return (1); } That should be enough to shut up gcc. Althought what to do about the SYSCTL macro for declaring functions where you don't get the chance to do this, I'm not sure about. Cheers, -Peter From owner-cvs-sys Wed Oct 2 23:58:01 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id XAA06405 for cvs-sys-outgoing; Wed, 2 Oct 1996 23:58:01 -0700 (PDT) Received: from ra.dkuug.dk (ra.dkuug.dk [193.88.44.193]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id XAA06398; Wed, 2 Oct 1996 23:57:57 -0700 (PDT) Received: (from sos@localhost) by ra.dkuug.dk (8.6.12/8.6.12) id IAA07715; Thu, 3 Oct 1996 08:57:43 +0200 Message-Id: <199610030657.IAA07715@ra.dkuug.dk> Subject: Re: cvs commit: src/sys/i386/isa syscons.c To: peter@spinner.DIALix.COM (Peter Wemm) Date: Thu, 3 Oct 1996 08:57:42 +0200 (MET DST) Cc: sos@FreeBSD.org, jkh@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org In-Reply-To: <199610030642.OAA03239@spinner.DIALix.COM> from "Peter Wemm" at Oct 3, 96 02:42:49 pm From: sos@FreeBSD.org Reply-to: sos@FreeBSD.org X-Mailer: ELM [version 2.4 PL24] Content-Type: text Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk In reply to Peter Wemm who wrote: > > sos@FreeBSD.org wrote: > > In reply to Jordan K. Hubbard who wrote: > > > [Boy, sure a lot of warnings in here!] > > > > Yep, but they are all of the type (but two) that says you > > have a function with X parameters, but you use only X-n > > I'm not really sure what to do with them, they are bogus > > IMHO. Then there are two warning say that the sizeof > > operator is unsigned... > > In theory, it can be written: > void > func(x, y) > int x __unused; > char *y __unused; > { > return (1); > } > > or (in ANSI-style) > void > func(int x __unused, char *y __unused) > { > return (1); > } > > That should be enough to shut up gcc. Althought what to do about the > SYSCTL macro for declaring functions where you don't get the chance to > do this, I'm not sure about. Excuse me, but I tend to think that the compiler should be fixed here... -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Soren Schmidt (sos@FreeBSD.org) FreeBSD Core Team So much code to hack -- so little time. From owner-cvs-sys Thu Oct 3 00:01:56 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA06701 for cvs-sys-outgoing; Thu, 3 Oct 1996 00:01:56 -0700 (PDT) Received: from time.cdrom.com (time.cdrom.com [204.216.27.226]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id AAA06696; Thu, 3 Oct 1996 00:01:53 -0700 (PDT) Received: from time.cdrom.com (localhost [127.0.0.1]) by time.cdrom.com (8.7.6/8.6.9) with ESMTP id AAA08030; Thu, 3 Oct 1996 00:01:40 -0700 (PDT) To: Peter Wemm cc: sos@FreeBSD.org, jkh@freefall.freebsd.org (Jordan K. Hubbard), CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c In-reply-to: Your message of "Thu, 03 Oct 1996 14:42:49 +0800." <199610030642.OAA03239@spinner.DIALix.COM> Date: Thu, 03 Oct 1996 00:01:40 -0700 Message-ID: <8024.844326100@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk > or (in ANSI-style) > void > func(int x __unused, char *y __unused) Hmmm. I don't remember __unused from my last reading of the ANSI spec, and if this is a gcc-ism then using it anywhere will cause Bruce to squawk at you about making it harder to use a non-gcc compiler in general principle. :-) Jordan From owner-cvs-sys Thu Oct 3 00:03:00 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA06792 for cvs-sys-outgoing; Thu, 3 Oct 1996 00:03:00 -0700 (PDT) Received: from genesis.atrad.adelaide.edu.au (genesis.atrad.adelaide.edu.au [129.127.96.120]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id AAA06783; Thu, 3 Oct 1996 00:02:56 -0700 (PDT) Received: from msmith@localhost by genesis.atrad.adelaide.edu.au (8.6.12/8.6.9) id QAA28719; Thu, 3 Oct 1996 16:32:37 +0930 From: Michael Smith Message-Id: <199610030702.QAA28719@genesis.atrad.adelaide.edu.au> Subject: Re: cvs commit: src/sys/i386/isa syscons.c To: peter@spinner.dialix.com (Peter Wemm) Date: Thu, 3 Oct 1996 16:32:36 +0930 (CST) Cc: sos@FreeBSD.org, jkh@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org In-Reply-To: <199610030642.OAA03239@spinner.DIALix.COM> from "Peter Wemm" at Oct 3, 96 02:42:49 pm MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk Peter Wemm stands accused of saying: > > That should be enough to shut up gcc. Althought what to do about the > SYSCTL macro for declaring functions where you don't get the chance to > do this, I'm not sure about. Does gcc honour /* ARGSUSED */ ?? > -Peter -- ]] Mike Smith, Software Engineer msmith@atrad.adelaide.edu.au [[ ]] Genesis Software genesis@atrad.adelaide.edu.au [[ ]] High-speed data acquisition and (GSM mobile) 0411-222-496 [[ ]] realtime instrument control (ph/fax) +61-8-267-3039 [[ ]] Collector of old Unix hardware. "Where are your PEZ?" The Tick [[ From owner-cvs-sys Thu Oct 3 00:07:24 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA07142 for cvs-sys-outgoing; Thu, 3 Oct 1996 00:07:24 -0700 (PDT) Received: from spinner.DIALix.COM (root@spinner.DIALix.COM [192.203.228.67]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id AAA07121; Thu, 3 Oct 1996 00:07:13 -0700 (PDT) Received: from spinner.DIALix.COM (peter@localhost.DIALix.oz.au [127.0.0.1]) by spinner.DIALix.COM (8.8.0/8.8.0) with ESMTP id PAA03418; Thu, 3 Oct 1996 15:06:54 +0800 (WST) Message-Id: <199610030706.PAA03418@spinner.DIALix.COM> To: Michael Smith cc: sos@FreeBSD.org, jkh@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c In-reply-to: Your message of "Thu, 03 Oct 1996 16:32:36 +0930." <199610030702.QAA28719@genesis.atrad.adelaide.edu.au> Date: Thu, 03 Oct 1996 15:06:54 +0800 From: Peter Wemm Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk Michael Smith wrote: > Peter Wemm stands accused of saying: > > > > That should be enough to shut up gcc. Althought what to do about the > > SYSCTL macro for declaring functions where you don't get the chance to > > do this, I'm not sure about. > > Does gcc honour /* ARGSUSED */ ?? No, that's for lint. With the C compiler, cpp removes those... -Peter From owner-cvs-sys Thu Oct 3 00:08:52 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA07283 for cvs-sys-outgoing; Thu, 3 Oct 1996 00:08:52 -0700 (PDT) Received: from time.cdrom.com (time.cdrom.com [204.216.27.226]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id AAA07275; Thu, 3 Oct 1996 00:08:50 -0700 (PDT) Received: from time.cdrom.com (localhost [127.0.0.1]) by time.cdrom.com (8.7.6/8.6.9) with ESMTP id AAA10557; Thu, 3 Oct 1996 00:08:34 -0700 (PDT) To: sos@FreeBSD.org cc: peter@spinner.DIALix.COM (Peter Wemm), jkh@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c In-reply-to: Your message of "Thu, 03 Oct 1996 08:57:42 +0200." <199610030657.IAA07715@ra.dkuug.dk> Date: Thu, 03 Oct 1996 00:08:34 -0700 Message-ID: <10555.844326514@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk > Excuse me, but I tend to think that the compiler should be fixed here... Fixed how? It's not broken. :-) We're compiling syscons.c with -Wunused and gcc, faithfully according to instruction, is warning you about unused variables. __unused sounds kinda gross, but it's still worlds better than the /* WUNUSED*/ comments which were "magically understood" by lint, along with /* NOTREACHED */. It's just not possible to make the verifier flag these cases in a "DWIM" fashion, since an intentional omission is indistinguishable from a bug at that level, so you either don't ask for -Wunused warnings or you give the compiler hints. Seems reasonable to me! Jordan From owner-cvs-sys Thu Oct 3 00:09:28 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA07343 for cvs-sys-outgoing; Thu, 3 Oct 1996 00:09:28 -0700 (PDT) Received: from spinner.DIALix.COM (root@spinner.DIALix.COM [192.203.228.67]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id AAA07329; Thu, 3 Oct 1996 00:09:21 -0700 (PDT) Received: from spinner.DIALix.COM (peter@localhost.DIALix.oz.au [127.0.0.1]) by spinner.DIALix.COM (8.8.0/8.8.0) with ESMTP id PAA03448; Thu, 3 Oct 1996 15:08:58 +0800 (WST) Message-Id: <199610030708.PAA03448@spinner.DIALix.COM> To: "Jordan K. Hubbard" cc: sos@FreeBSD.org, jkh@freefall.freebsd.org (Jordan K. Hubbard), CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c In-reply-to: Your message of "Thu, 03 Oct 1996 00:01:40 MST." <8024.844326100@time.cdrom.com> Date: Thu, 03 Oct 1996 15:08:58 +0800 From: Peter Wemm Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk "Jordan K. Hubbard" wrote: > > or (in ANSI-style) > > void > > func(int x __unused, char *y __unused) > > Hmmm. I don't remember __unused from my last reading of the ANSI > spec, and if this is a gcc-ism then using it anywhere will cause Bruce > to squawk at you about making it harder to use a non-gcc compiler in > general principle. :-) > > Jordan Check .. For gcc-2.7.x and above, it's a #define __unused __attribute__((__unused__)) For everything else, it does nothing. It should not be a portability issue, since we compile the kernel with -Wunused on gcc, and it's telling us exactly what we asked for.. Unused variables.. Cheers, -Peter From owner-cvs-sys Thu Oct 3 00:09:53 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA07395 for cvs-sys-outgoing; Thu, 3 Oct 1996 00:09:53 -0700 (PDT) Received: from time.cdrom.com (time.cdrom.com [204.216.27.226]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id AAA07390; Thu, 3 Oct 1996 00:09:51 -0700 (PDT) Received: from time.cdrom.com (localhost [127.0.0.1]) by time.cdrom.com (8.7.6/8.6.9) with ESMTP id AAA10573; Thu, 3 Oct 1996 00:09:03 -0700 (PDT) To: Michael Smith cc: peter@spinner.dialix.com (Peter Wemm), sos@FreeBSD.org, jkh@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c In-reply-to: Your message of "Thu, 03 Oct 1996 16:32:36 +0930." <199610030702.QAA28719@genesis.atrad.adelaide.edu.au> Date: Thu, 03 Oct 1996 00:09:03 -0700 Message-ID: <10570.844326543@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk > Does gcc honour /* ARGSUSED */ ?? Gee, I sure hope not - comments should stay comments. :-) Jordan From owner-cvs-sys Thu Oct 3 00:11:04 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA07529 for cvs-sys-outgoing; Thu, 3 Oct 1996 00:11:04 -0700 (PDT) Received: from spinner.DIALix.COM (root@spinner.DIALix.COM [192.203.228.67]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id AAA07505; Thu, 3 Oct 1996 00:10:53 -0700 (PDT) Received: from spinner.DIALix.COM (peter@localhost.DIALix.oz.au [127.0.0.1]) by spinner.DIALix.COM (8.8.0/8.8.0) with ESMTP id PAA03486; Thu, 3 Oct 1996 15:10:19 +0800 (WST) Message-Id: <199610030710.PAA03486@spinner.DIALix.COM> To: sos@FreeBSD.org cc: jkh@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c In-reply-to: Your message of "Thu, 03 Oct 1996 08:57:42 +0200." <199610030657.IAA07715@ra.dkuug.dk> Date: Thu, 03 Oct 1996 15:10:19 +0800 From: Peter Wemm Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk sos@FreeBSD.org wrote: > Excuse me, but I tend to think that the compiler should be fixed here... No, the compiler is doing it's job better, that's all. We *ask* for these with -Wunused when compiling the kernel. Cheers, -Peter From owner-cvs-sys Thu Oct 3 00:13:54 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA07754 for cvs-sys-outgoing; Thu, 3 Oct 1996 00:13:54 -0700 (PDT) Received: from genesis.atrad.adelaide.edu.au (genesis.atrad.adelaide.edu.au [129.127.96.120]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id AAA07737; Thu, 3 Oct 1996 00:13:43 -0700 (PDT) Received: from msmith@localhost by genesis.atrad.adelaide.edu.au (8.6.12/8.6.9) id QAA28842; Thu, 3 Oct 1996 16:43:31 +0930 From: Michael Smith Message-Id: <199610030713.QAA28842@genesis.atrad.adelaide.edu.au> Subject: Re: cvs commit: src/sys/i386/isa syscons.c To: sos@FreeBSD.org Date: Thu, 3 Oct 1996 16:43:30 +0930 (CST) Cc: peter@spinner.dialix.com, jkh@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org In-Reply-To: <199610030657.IAA07715@ra.dkuug.dk> from "sos@FreeBSD.org" at Oct 3, 96 08:57:42 am MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk sos@FreeBSD.org stands accused of saying: > > That should be enough to shut up gcc. Althought what to do about the > > SYSCTL macro for declaring functions where you don't get the chance to > > do this, I'm not sure about. > > Excuse me, but I tend to think that the compiler should be fixed here... Huh? Nothing wrong with a compiler that tells you that you've screwed up. > Soren Schmidt (sos@FreeBSD.org) FreeBSD Core Team -- ]] Mike Smith, Software Engineer msmith@atrad.adelaide.edu.au [[ ]] Genesis Software genesis@atrad.adelaide.edu.au [[ ]] High-speed data acquisition and (GSM mobile) 0411-222-496 [[ ]] realtime instrument control (ph/fax) +61-8-267-3039 [[ ]] Collector of old Unix hardware. "Where are your PEZ?" The Tick [[ From owner-cvs-sys Thu Oct 3 00:15:01 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA07860 for cvs-sys-outgoing; Thu, 3 Oct 1996 00:15:01 -0700 (PDT) Received: from spinner.DIALix.COM (root@spinner.DIALix.COM [192.203.228.67]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id AAA07839; Thu, 3 Oct 1996 00:14:54 -0700 (PDT) Received: from spinner.DIALix.COM (peter@localhost.DIALix.oz.au [127.0.0.1]) by spinner.DIALix.COM (8.8.0/8.8.0) with ESMTP id PAA03540; Thu, 3 Oct 1996 15:14:31 +0800 (WST) Message-Id: <199610030714.PAA03540@spinner.DIALix.COM> To: "Jordan K. Hubbard" cc: Michael Smith , sos@FreeBSD.org, jkh@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c In-reply-to: Your message of "Thu, 03 Oct 1996 00:09:03 MST." <10570.844326543@time.cdrom.com> Date: Thu, 03 Oct 1996 15:14:31 +0800 From: Peter Wemm Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk "Jordan K. Hubbard" wrote: > > Does gcc honour /* ARGSUSED */ ?? > > Gee, I sure hope not - comments should stay comments. :-) > > Jordan BTW, since these warnings are only really useful for the developers, I'd suggest we turn *off* the *extra* warnings for the kernel by default on release branches just before rolling it. It doesn't help to scare the natives by having thousands of warnings that only have meaning for developers. Cheers, -Peter From owner-cvs-sys Thu Oct 3 00:50:19 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA09970 for cvs-sys-outgoing; Thu, 3 Oct 1996 00:50:19 -0700 (PDT) Received: from ra.dkuug.dk (ra.dkuug.dk [193.88.44.193]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id AAA09960; Thu, 3 Oct 1996 00:50:15 -0700 (PDT) Received: (from sos@localhost) by ra.dkuug.dk (8.6.12/8.6.12) id JAA08022; Thu, 3 Oct 1996 09:49:41 +0200 Message-Id: <199610030749.JAA08022@ra.dkuug.dk> Subject: Re: cvs commit: src/sys/i386/isa syscons.c To: msmith@atrad.adelaide.edu.au (Michael Smith) Date: Thu, 3 Oct 1996 09:49:41 +0200 (MET DST) Cc: sos@FreeBSD.org, peter@spinner.dialix.com, jkh@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org In-Reply-To: <199610030713.QAA28842@genesis.atrad.adelaide.edu.au> from "Michael Smith" at Oct 3, 96 04:43:30 pm From: sos@FreeBSD.org Reply-to: sos@FreeBSD.org X-Mailer: ELM [version 2.4 PL24] Content-Type: text Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk In reply to Michael Smith who wrote: > > sos@FreeBSD.org stands accused of saying: > > > That should be enough to shut up gcc. Althought what to do about the > > > SYSCTL macro for declaring functions where you don't get the chance to > > > do this, I'm not sure about. > > > > Excuse me, but I tend to think that the compiler should be fixed here... > > Huh? Nothing wrong with a compiler that tells you that you've screwed up. EXCUSE ME, but I didn't screw up, I just dont use all the vars thats declared for a system wide std, for char devices, its just that some of those vars isn't used here, but they should still be declared to conform to the char device calling convention. I guess we'll have to go fix hordes of files with another gcc'ism __unused, *SIGH*, as if we had nothing to do... If the GNU folks ever did go to a scheme where we would have to *pay* to use it, or other more nasty ideas for that matter, we are now so wrapped in, its almost impossible to switch compiler. (I've tried, its NOT fun) -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Soren Schmidt (sos@FreeBSD.org) FreeBSD Core Team So much code to hack -- so little time. From owner-cvs-sys Thu Oct 3 00:51:46 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA10102 for cvs-sys-outgoing; Thu, 3 Oct 1996 00:51:46 -0700 (PDT) Received: (from jkh@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA10087; Thu, 3 Oct 1996 00:51:42 -0700 (PDT) Date: Thu, 3 Oct 1996 00:51:42 -0700 (PDT) From: "Jordan K. Hubbard" Message-Id: <199610030751.AAA10087@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/i386/i386 userconfig.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 96/10/03 00:51:42 Modified: sys/i386/i386 userconfig.c Log: Make return or newline synonymous with down-arrow in the value editor. It's a lot easier to whap through multiple changes if you can use the return key. Revision Changes Path 1.52 +5 -3 src/sys/i386/i386/userconfig.c From owner-cvs-sys Thu Oct 3 01:12:39 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id BAA11725 for cvs-sys-outgoing; Thu, 3 Oct 1996 01:12:39 -0700 (PDT) Received: from critter.tfs.com ([140.145.230.177]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id BAA11718; Thu, 3 Oct 1996 01:12:31 -0700 (PDT) Received: from critter.tfs.com (localhost.tfs.com [127.0.0.1]) by critter.tfs.com (8.7.5/8.7.3) with ESMTP id KAA05308; Thu, 3 Oct 1996 10:11:55 +0200 (MET DST) To: sos@FreeBSD.org cc: peter@spinner.dialix.com (Peter Wemm), jkh@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c In-reply-to: Your message of "Thu, 03 Oct 1996 08:57:42 +0200." <199610030657.IAA07715@ra.dkuug.dk> Date: Thu, 03 Oct 1996 10:11:54 +0200 Message-ID: <5306.844330314@critter.tfs.com> From: Poul-Henning Kamp Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk >> That should be enough to shut up gcc. Althought what to do about the >> SYSCTL macro for declaring functions where you don't get the chance to >> do this, I'm not sure about. Stick the __unused gunk in the SYSCTL_HANDLER_ARGS macro in /sys/sys/sysctl.h -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@ref.tfs.com TRW Financial Systems, Inc. Future will arrive by its own means, progress not so. From owner-cvs-sys Thu Oct 3 01:19:55 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id BAA12329 for cvs-sys-outgoing; Thu, 3 Oct 1996 01:19:55 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id BAA12322; Thu, 3 Oct 1996 01:19:46 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.7.6/8.6.9) id SAA06864; Thu, 3 Oct 1996 18:16:22 +1000 Date: Thu, 3 Oct 1996 18:16:22 +1000 From: Bruce Evans Message-Id: <199610030816.SAA06864@godzilla.zeta.org.au> To: peter@spinner.dialix.com, sos@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, jkh@freefall.freebsd.org Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk >In theory, it can be written: practice >void >func(x, y) >int x __unused; >char *y __unused; >{ > return (1); >} >... >That should be enough to shut up gcc. Althought what to do about the >SYSCTL macro for declaring functions where you don't get the chance to >do this, I'm not sure about. The macro cases are easier. You just add __unused once to each arg in the macro instead of to thousands of args in scattered functions. This works because the `unused' attribute doesn't mean that the thing that it is attached to is unused - it means that the thing is possibly unused and so the -Wunused warning should be suppressed. I don't want to add non-C to thousands of args in scattered functions. The unused attribute doesn't work right in typedefs. Otherwise we could use /* Args to switch functions are often unused, so don't warn about them. */ typedef int sy_call_t __P((struct proc *p __unused, void *uap __unused, int *retval __unused)); The unused attribute is silently ignored here :-(. Bruce From owner-cvs-sys Thu Oct 3 01:22:26 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id BAA12572 for cvs-sys-outgoing; Thu, 3 Oct 1996 01:22:26 -0700 (PDT) Received: from spinner.DIALix.COM (root@spinner.DIALix.COM [192.203.228.67]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id BAA12550; Thu, 3 Oct 1996 01:22:14 -0700 (PDT) Received: from spinner.DIALix.COM (peter@localhost.DIALix.oz.au [127.0.0.1]) by spinner.DIALix.COM (8.8.0/8.8.0) with ESMTP id QAA04002; Thu, 3 Oct 1996 16:21:27 +0800 (WST) Message-Id: <199610030821.QAA04002@spinner.DIALix.COM> To: Poul-Henning Kamp cc: sos@FreeBSD.org, jkh@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c In-reply-to: Your message of "Thu, 03 Oct 1996 10:11:54 +0200." <5306.844330314@critter.tfs.com> Date: Thu, 03 Oct 1996 16:21:27 +0800 From: Peter Wemm Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk Poul-Henning Kamp wrote: > >> That should be enough to shut up gcc. Althought what to do about the > >> SYSCTL macro for declaring functions where you don't get the chance to > >> do this, I'm not sure about. > > Stick the __unused gunk in the SYSCTL_HANDLER_ARGS macro in /sys/sys/sysctl.h Heh, silly me. I assumed that gcc would bitch if we used a variable that was explicitly declared unused... It seems not... Cheers, -Peter From owner-cvs-sys Thu Oct 3 01:23:22 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id BAA12767 for cvs-sys-outgoing; Thu, 3 Oct 1996 01:23:22 -0700 (PDT) Received: from time.cdrom.com (time.cdrom.com [204.216.27.226]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id BAA12757; Thu, 3 Oct 1996 01:23:18 -0700 (PDT) Received: from time.cdrom.com (localhost [127.0.0.1]) by time.cdrom.com (8.7.6/8.6.9) with ESMTP id BAA14875; Thu, 3 Oct 1996 01:22:42 -0700 (PDT) To: sos@FreeBSD.org cc: msmith@atrad.adelaide.edu.au (Michael Smith), peter@spinner.dialix.com, jkh@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c In-reply-to: Your message of "Thu, 03 Oct 1996 09:49:41 +0200." <199610030749.JAA08022@ra.dkuug.dk> Date: Thu, 03 Oct 1996 01:22:42 -0700 Message-ID: <14872.844330962@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk > I guess we'll have to go fix hordes of files with another gcc'ism Or just turn -Wunused off. Jordan From owner-cvs-sys Thu Oct 3 01:32:10 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id BAA13947 for cvs-sys-outgoing; Thu, 3 Oct 1996 01:32:10 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id BAA13872; Thu, 3 Oct 1996 01:31:31 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.7.6/8.6.9) id SAA07209; Thu, 3 Oct 1996 18:27:32 +1000 Date: Thu, 3 Oct 1996 18:27:32 +1000 From: Bruce Evans Message-Id: <199610030827.SAA07209@godzilla.zeta.org.au> To: jkh@time.cdrom.com, peter@spinner.dialix.com Subject: Re: cvs commit: src/sys/i386/isa syscons.c Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, jkh@freefall.freebsd.org, sos@FreeBSD.org Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk >Hmmm. I don't remember __unused from my last reading of the ANSI >spec, and if this is a gcc-ism then using it anywhere will cause Bruce >to squawk at you about making it harder to use a non-gcc compiler in >general principle. :-) It's not harder provided our is included. __unused is a macro. It is harder if you don't control the system headers. Have a look at the lbl stuff in contrib. Each module now carries its own definitions of __dead and __attribute in case the system doesn't define them. __dead still works for it here although I removed __dead from my . Bruce From owner-cvs-sys Thu Oct 3 01:33:52 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id BAA14073 for cvs-sys-outgoing; Thu, 3 Oct 1996 01:33:52 -0700 (PDT) Received: from ra.dkuug.dk (ra.dkuug.dk [193.88.44.193]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id BAA14063; Thu, 3 Oct 1996 01:33:47 -0700 (PDT) Received: (from sos@localhost) by ra.dkuug.dk (8.6.12/8.6.12) id KAA08361; Thu, 3 Oct 1996 10:33:32 +0200 Message-Id: <199610030833.KAA08361@ra.dkuug.dk> Subject: Re: cvs commit: src/sys/i386/isa syscons.c To: peter@spinner.dialix.com (Peter Wemm) Date: Thu, 3 Oct 1996 10:33:31 +0200 (MET DST) Cc: phk@critter.tfs.com, sos@FreeBSD.org, jkh@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org In-Reply-To: <199610030821.QAA04002@spinner.DIALix.COM> from "Peter Wemm" at Oct 3, 96 04:21:27 pm From: sos@FreeBSD.org Reply-to: sos@FreeBSD.org X-Mailer: ELM [version 2.4 PL24] Content-Type: text Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk In reply to Peter Wemm who wrote: > > Poul-Henning Kamp wrote: > > >> That should be enough to shut up gcc. Althought what to do about the > > >> SYSCTL macro for declaring functions where you don't get the chance to > > >> do this, I'm not sure about. > > > > Stick the __unused gunk in the SYSCTL_HANDLER_ARGS macro in /sys/sys/sysctl.h > > Heh, silly me. I assumed that gcc would bitch if we used a variable that > was explicitly declared unused... It seems not... So, now we stick __unused all over the place to shut up gcc, and effectively reduces the -Wunused to the same state it has in 2.6.3, REAL progress and lots of work :( -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Soren Schmidt (sos@FreeBSD.org) FreeBSD Core Team So much code to hack -- so little time. From owner-cvs-sys Thu Oct 3 01:35:12 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id BAA14284 for cvs-sys-outgoing; Thu, 3 Oct 1996 01:35:12 -0700 (PDT) Received: from critter.tfs.com ([140.145.230.177]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id BAA14261; Thu, 3 Oct 1996 01:35:01 -0700 (PDT) Received: from critter.tfs.com (localhost.tfs.com [127.0.0.1]) by critter.tfs.com (8.7.5/8.7.3) with ESMTP id KAA05422; Thu, 3 Oct 1996 10:34:23 +0200 (MET DST) To: Bruce Evans cc: peter@spinner.dialix.com, sos@FreeBSD.org, cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, jkh@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c In-reply-to: Your message of "Thu, 03 Oct 1996 18:16:22 +1000." <199610030816.SAA06864@godzilla.zeta.org.au> Date: Thu, 03 Oct 1996 10:34:22 +0200 Message-ID: <5420.844331662@critter.tfs.com> From: Poul-Henning Kamp Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk In message <199610030816.SAA06864@godzilla.zeta.org.au>, Bruce Evans writes: >I don't want to add non-C to thousands of args in scattered functions. I agree. One "semi-clean" way of doing it would have been to add a hack to gcc so that args named __unused_* wasn't complained about, then you could: int foo (char * _unused_1) { } to suppress it. >The unused attribute doesn't work right in typedefs. Otherwise we >could use > >/* Args to switch functions are often unused, so don't warn about them. */ >typedef int sy_call_t __P((struct proc *p __unused, void *uap __unused, > int *retval __unused)); > >The unused attribute is silently ignored here :-(. But that's because you cannot say sy_call_t read { if (proc != curproc) ... } (Which I think is a bug in C btw.) You don't use the typedef when you declare the function. That's why I have used the SYSCTL_HANDLER_ARGS solution for sysctl. We could do the same for syscalls I guess. -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@ref.tfs.com TRW Financial Systems, Inc. Future will arrive by its own means, progress not so. From owner-cvs-sys Thu Oct 3 01:39:54 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id BAA14670 for cvs-sys-outgoing; Thu, 3 Oct 1996 01:39:54 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id BAA14632; Thu, 3 Oct 1996 01:39:40 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.7.6/8.6.9) id SAA07566; Thu, 3 Oct 1996 18:36:50 +1000 Date: Thu, 3 Oct 1996 18:36:50 +1000 From: Bruce Evans Message-Id: <199610030836.SAA07566@godzilla.zeta.org.au> To: jkh@time.cdrom.com, peter@spinner.dialix.com Subject: Re: cvs commit: src/sys/i386/isa syscons.c Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, jkh@freefall.freebsd.org, msmith@atrad.adelaide.edu.au, sos@FreeBSD.org Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk >BTW, since these warnings are only really useful for the developers, I'd >suggest we turn *off* the *extra* warnings for the kernel by default on >release branches just before rolling it. It doesn't help to scare the >natives by having thousands of warnings that only have meaning for >developers. An easy task, since -Wunused has never been in a release. Very few warnings are enabled in 2.1.5R; I guess there would be about 20000 lines of warnings instead of only 7000 if it were compiled with the -current gcc and warning flags. Bruce From owner-cvs-sys Thu Oct 3 02:10:29 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id CAA16680 for cvs-sys-outgoing; Thu, 3 Oct 1996 02:10:29 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id CAA16664; Thu, 3 Oct 1996 02:10:23 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.7.6/8.6.9) id TAA08440; Thu, 3 Oct 1996 19:04:51 +1000 Date: Thu, 3 Oct 1996 19:04:51 +1000 From: Bruce Evans Message-Id: <199610030904.TAA08440@godzilla.zeta.org.au> To: bde@zeta.org.au, phk@critter.tfs.com Subject: Re: cvs commit: src/sys/i386/isa syscons.c Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, jkh@freefall.freebsd.org, peter@spinner.dialix.com, sos@FreeBSD.org Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk >One "semi-clean" way of doing it would have been to add a hack to >gcc so that args named __unused_* wasn't complained about, then you >could: > int foo (char * _unused_1) > { > } >to suppress it. This would still require changing thosands of functions. >>The unused attribute doesn't work right in typedefs. Otherwise we >But that's because you cannot say > > sy_call_t > read > { > if (proc != curproc) > ... > } > >(Which I think is a bug in C btw.) That's because the names in prototypes are unused :-). The attributes could be used. >You don't use the typedef when you declare the function. Yes you do. The above is a definition, not a declaration :-). >That's why I have used the SYSCTL_HANDLER_ARGS solution for sysctl. I don't like macros like these, although I introduced similar ones for ddb functions. Bruce From owner-cvs-sys Thu Oct 3 03:36:05 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA19871 for cvs-sys-outgoing; Thu, 3 Oct 1996 03:36:05 -0700 (PDT) Received: from spinner.DIALix.COM (root@spinner.DIALix.COM [192.203.228.67]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id DAA19814; Thu, 3 Oct 1996 03:35:41 -0700 (PDT) Received: from spinner.DIALix.COM (peter@localhost.DIALix.oz.au [127.0.0.1]) by spinner.DIALix.COM (8.8.0/8.8.0) with ESMTP id SAA04326; Thu, 3 Oct 1996 18:35:19 +0800 (WST) Message-Id: <199610031035.SAA04326@spinner.DIALix.COM> To: sos@FreeBSD.org cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c In-reply-to: Your message of "Thu, 03 Oct 1996 10:33:31 +0200." <199610030833.KAA08361@ra.dkuug.dk> Date: Thu, 03 Oct 1996 18:35:19 +0800 From: Peter Wemm Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk sos@FreeBSD.org wrote: > So, now we stick __unused all over the place to shut up gcc, and > effectively reduces the -Wunused to the same state it has in > 2.6.3, REAL progress and lots of work :( No, not at all. In the process we find and eliminate the code that passes *unneccesary* parameters to functions. The problem is that gcc cannot tell the difference between functions that are called from uniform interface vectors. Things like the sysctl definitions, syscall handlers, ddb handlers etc are masking the *useful* warnings by sheer weight of numbers. Cheers, -Peter From owner-cvs-sys Thu Oct 3 03:41:50 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA20137 for cvs-sys-outgoing; Thu, 3 Oct 1996 03:41:50 -0700 (PDT) Received: from ra.dkuug.dk (ra.dkuug.dk [193.88.44.193]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id DAA20120; Thu, 3 Oct 1996 03:41:33 -0700 (PDT) Received: (from sos@localhost) by ra.dkuug.dk (8.6.12/8.6.12) id MAA08888; Thu, 3 Oct 1996 12:41:22 +0200 Message-Id: <199610031041.MAA08888@ra.dkuug.dk> Subject: Re: cvs commit: src/sys/i386/isa syscons.c To: peter@spinner.DIALix.COM (Peter Wemm) Date: Thu, 3 Oct 1996 12:41:22 +0200 (MET DST) Cc: sos@FreeBSD.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org In-Reply-To: <199610031035.SAA04326@spinner.DIALix.COM> from "Peter Wemm" at Oct 3, 96 06:35:19 pm From: sos@FreeBSD.org Reply-to: sos@FreeBSD.org X-Mailer: ELM [version 2.4 PL24] Content-Type: text Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk In reply to Peter Wemm who wrote: > > sos@FreeBSD.org wrote: > > So, now we stick __unused all over the place to shut up gcc, and > > effectively reduces the -Wunused to the same state it has in > > 2.6.3, REAL progress and lots of work :( > > No, not at all. In the process we find and eliminate the code that > passes *unneccesary* parameters to functions. The problem is that gcc > cannot tell the difference between functions that are called from > uniform interface vectors. Things like the sysctl definitions, syscall > handlers, ddb handlers etc are masking the *useful* warnings by sheer > weight of numbers. Hmm, I dont think we live in the same ideal virtual world then :) -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Soren Schmidt (sos@FreeBSD.org) FreeBSD Core Team So much code to hack -- so little time. From owner-cvs-sys Thu Oct 3 03:47:30 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA20430 for cvs-sys-outgoing; Thu, 3 Oct 1996 03:47:30 -0700 (PDT) Received: (from davidg@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA20405; Thu, 3 Oct 1996 03:47:12 -0700 (PDT) Date: Thu, 3 Oct 1996 03:47:12 -0700 (PDT) From: David Greenman Message-Id: <199610031047.DAA20405@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/pci if_vx.c if_vxreg.h Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk davidg 96/10/03 03:47:10 Modified: sys/pci if_vx.c if_vxreg.h Log: Added multicast support (BPF cookie bug was already fixed). Submitted by: Steven McCanne Revision Changes Path 1.12 +42 -4 src/sys/pci/if_vx.c 1.6 +1 -0 src/sys/pci/if_vxreg.h From owner-cvs-sys Thu Oct 3 04:01:36 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id EAA21052 for cvs-sys-outgoing; Thu, 3 Oct 1996 04:01:36 -0700 (PDT) Received: (from davidg@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id EAA21031; Thu, 3 Oct 1996 04:01:24 -0700 (PDT) Date: Thu, 3 Oct 1996 04:01:24 -0700 (PDT) From: David Greenman Message-Id: <199610031101.EAA21031@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/pci if_vx.c if_vxreg.h Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk davidg 96/10/03 04:01:24 Branch: sys/pci RELENG_2_1_0 Modified: sys/pci if_vx.c if_vxreg.h Log: Added multicast support and fixed BPF cookie bug. Submitted by: Steven McCanne Revision Changes Path 1.10.2.2 +44 -6 src/sys/pci/if_vx.c 1.4.4.2 +1 -0 src/sys/pci/if_vxreg.h From owner-cvs-sys Thu Oct 3 04:12:20 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id EAA21532 for cvs-sys-outgoing; Thu, 3 Oct 1996 04:12:20 -0700 (PDT) Received: from critter.tfs.com ([140.145.230.177]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id EAA21527; Thu, 3 Oct 1996 04:12:14 -0700 (PDT) Received: from critter.tfs.com (localhost.tfs.com [127.0.0.1]) by critter.tfs.com (8.7.5/8.7.3) with ESMTP id NAA05701; Thu, 3 Oct 1996 13:11:39 +0200 (MET DST) To: Bruce Evans cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, jkh@freefall.freebsd.org, peter@spinner.dialix.com, sos@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c In-reply-to: Your message of "Thu, 03 Oct 1996 19:04:51 +1000." <199610030904.TAA08440@godzilla.zeta.org.au> Date: Thu, 03 Oct 1996 13:11:38 +0200 Message-ID: <5699.844341098@critter.tfs.com> From: Poul-Henning Kamp Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk In message <199610030904.TAA08440@godzilla.zeta.org.au>, Bruce Evans writes: >>But that's because you cannot say >> >> sy_call_t >> read >> { >> if (proc != curproc) >> ... >> } >> >>(Which I think is a bug in C btw.) > >That's because the names in prototypes are unused :-). The attributes >could be used. > >>You don't use the typedef when you declare the function. > >Yes you do. The above is a definition, not a declaration :-). Sorry, I always swap those two. >>That's why I have used the SYSCTL_HANDLER_ARGS solution for sysctl. > >I don't like macros like these, although I introduced similar ones >for ddb functions. I don't like them either, but they are the least horrible solution. -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@ref.tfs.com TRW Financial Systems, Inc. Future will arrive by its own means, progress not so. From owner-cvs-sys Thu Oct 3 07:14:42 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id HAA29152 for cvs-sys-outgoing; Thu, 3 Oct 1996 07:14:42 -0700 (PDT) Received: from agora.rdrop.com (root@agora.rdrop.com [199.2.210.241]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id HAA29122; Thu, 3 Oct 1996 07:14:20 -0700 (PDT) Received: from relay.xlink.net by agora.rdrop.com with smtp (Smail3.1.29.1 #17) id m0v8oXZ-00092rC; Thu, 3 Oct 96 07:14 PDT Received: from gate.fzi.de by relay.xlink.net id <29347-0@relay.xlink.net>; Thu, 3 Oct 1996 15:02:14 +0000 Received: from PROST1.fzi.de by gate.fzi.de with SMTP (PP) id <03615-0@gate.fzi.de>; Thu, 3 Oct 1996 16:02:05 +0100 Received: from delhi by prost1.fzi.de with SMTP (PP); Thu, 3 Oct 1996 16:00:58 +0100 Message-ID: <3253D55A.2429@fzi.de> Date: Thu, 03 Oct 1996 17:01:46 +0200 From: Guenther Grau Organization: Forschungszentrum Informatik (FZI), Karlsruhe, Germany X-Mailer: Mozilla 3.0 (X11; I; SunOS 5.5 sun4u) MIME-Version: 1.0 To: "Jordan K. Hubbard" CC: sos@FreeBSD.org, Michael Smith , peter@spinner.dialix.com, jkh@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c References: <14872.844330962@time.cdrom.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk Jordan K. Hubbard wrote: > > > I guess we'll have to go fix hordes of files with another gcc'ism > > Or just turn -Wunused off. This seems reasonable. Another, maybe stupid, as I don't know how many changes this will involve, suggestion is, to a define a macro that actually uses these variables, like #define _USE(x) (x=x) A good compiler schould be able to optimize this away. the use of this macro in the right places would eliminate the warnings, and still have gcc issue warnings when variables are not used in other functions. Guenther From owner-cvs-sys Fri Oct 4 03:33:43 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA08867 for cvs-sys-outgoing; Fri, 4 Oct 1996 03:33:43 -0700 (PDT) Received: (from davidg@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA08850; Fri, 4 Oct 1996 03:33:27 -0700 (PDT) Date: Fri, 4 Oct 1996 03:33:27 -0700 (PDT) From: David Greenman Message-Id: <199610041033.DAA08850@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/i386/isa cy.c cyreg.h Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk davidg 96/10/04 03:33:25 Modified: sys/i386/isa cy.c cyreg.h Log: Implemented a more sophisticated mechanism for finding the chip iobase so that 32Y boards will work. Fixed bogus indenting and added a pair of parens. Revision Changes Path 1.36 +72 -62 src/sys/i386/isa/cy.c 1.2 +2 -2 src/sys/i386/isa/cyreg.h From owner-cvs-sys Fri Oct 4 07:18:46 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id HAA21290 for cvs-sys-outgoing; Fri, 4 Oct 1996 07:18:46 -0700 (PDT) Received: (from davidg@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id HAA21188; Fri, 4 Oct 1996 07:17:36 -0700 (PDT) Date: Fri, 4 Oct 1996 07:17:36 -0700 (PDT) From: David Greenman Message-Id: <199610041417.HAA21188@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/i386/isa cy.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk davidg 96/10/04 07:17:34 Modified: sys/i386/isa cy.c Log: Oops, missed a chunk in that last commit. Revision Changes Path 1.37 +3 -3 src/sys/i386/isa/cy.c From owner-cvs-sys Fri Oct 4 16:43:27 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id QAA03469 for cvs-sys-outgoing; Fri, 4 Oct 1996 16:43:27 -0700 (PDT) Received: (from julian@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id QAA03437; Fri, 4 Oct 1996 16:43:14 -0700 (PDT) Date: Fri, 4 Oct 1996 16:43:14 -0700 (PDT) From: Julian Elischer Message-Id: <199610042343.QAA03437@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/kern kern_exit.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk julian 96/10/04 16:43:14 Modified: sys/kern kern_exit.c Log: If we have no console device it is possible to be 1/ session leader 2/ Have a console device vnode (/dev/console) 3/ have NULL pointer for a consoel tty struct. fix the only case where the tty struct is referenced without a prior check for existance. Revision Changes Path 1.40 +2 -2 src/sys/kern/kern_exit.c From owner-cvs-sys Sat Oct 5 01:40:29 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id BAA03646 for cvs-sys-outgoing; Sat, 5 Oct 1996 01:40:29 -0700 (PDT) Received: from sovcom.kiae.su (sovcom.kiae.su [193.125.152.1]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id BAA03638; Sat, 5 Oct 1996 01:40:23 -0700 (PDT) Received: by sovcom.kiae.su id AA27510 (5.65.kiae-1 ); Sat, 5 Oct 1996 11:34:39 +0300 Received: by sovcom.KIAE.su (UUMAIL/2.0); Sat, 5 Oct 96 11:34:39 +0300 Received: (from ache@localhost) by nagual.ru (8.7.6/8.7.3) id MAA00616; Sat, 5 Oct 1996 12:14:28 +0400 (MSD) Message-Id: <199610050814.MAA00616@nagual.ru> Subject: Re: cvs commit: src/sys/kern kern_exit.c In-Reply-To: <199610042343.QAA03437@freefall.freebsd.org> from "Julian Elischer" at "Oct 4, 96 04:43:14 pm" To: julian@freefall.freebsd.org (Julian Elischer) Date: Sat, 5 Oct 1996 12:14:28 +0400 (MSD) Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org From: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= (Andrey A. Chernov) Organization: self X-Class: Fast X-Mailer: ELM [version 2.4ME+ PL28 (25)] Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > julian 96/10/04 16:43:14 > > Modified: sys/kern kern_exit.c > Log: > If we have no console device it is possible to be > 1/ session leader > 2/ Have a console device vnode (/dev/console) > 3/ have NULL pointer for a consoel tty struct. > > fix the only case where the tty struct is referenced without a prior > check for existance. In which situations this bug hits? -- Andrey A. Chernov http://www.nagual.ru/~ache/ From owner-cvs-sys Sat Oct 5 03:44:23 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA07797 for cvs-sys-outgoing; Sat, 5 Oct 1996 03:44:23 -0700 (PDT) Received: (from jkh@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA07780; Sat, 5 Oct 1996 03:44:11 -0700 (PDT) Date: Sat, 5 Oct 1996 03:44:11 -0700 (PDT) From: "Jordan K. Hubbard" Message-Id: <199610051044.DAA07780@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-user, cvs-sys Subject: cvs commit: src/sys/conf newvers.sh src/sys/i386/conf options.i386 src/sys/i386/i386 locore.s machdep.c userconfig.c src/release dumpnlist.c Makefile src/release/sysinstall Makefile install.c uc_main.c dumpnlist.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 96/10/05 03:44:10 Modified: release Makefile release/sysinstall Makefile install.c uc_main.c sys/conf newvers.sh sys/i386/conf options.i386 sys/i386/i386 locore.s machdep.c userconfig.c Added: release dumpnlist.c Removed: release/sysinstall dumpnlist.c Log: Multiple changes stacked as one commit since they all depend on one another. First, change sysinstall and the Makefile rules to not build the kernel nlist directly into sysinstall now. Instead, spit it out as an ascii file in /stand and parse it from sysinstall later. This solves the chicken-n- egg problem of building sysinstall into the fsimage before BOOTMFS is built and can have its symbols extracted. Now we generate the symbol file in release.8. Second, add Poul-Henning's USERCONFIG_BOOT changes. These have two effects: 1. Userconfig is always entered, rather than only after a -c (don't scream yet, it's not as bad as it sounds). 2. Userconfig reads a message string which can optionally be written just past the boot blocks. This string "preloads" the userconfig input buffer and is parsed as user input. If the first command is not "USERCONFIG", userconfig will treat this as an implied "quit" (which is why you don't need to scream - you never even know you went through userconfig and back out again if you don't specifically ask for it), otherwise it will read and execute the following commands until a "quit" is seen or the end is reached, in which case the normal userconfig command prompt will then be presented. How to create your own startup sequences, using any boot.flp image from the next snap forward (not yet, but soon): % dd of=/dev/rfd0 seek=1 bs=512 count=1 conv=sync < Subject: Re: cvs commit: src/sys/conf newvers.sh src/sys/i386/conf options.i386 src/sys/i386/i386 locore.s machdep.c userconfig.c src/releas To: jkh@freefall.freebsd.org (Jordan K. Hubbard) Date: Sat, 5 Oct 1996 12:54:37 +0200 (MET DST) From: "Soren Schmidt" Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-user@freefall.freebsd.org, cvs-sys@freefall.freebsd.org In-Reply-To: <199610051044.DAA07780@freefall.freebsd.org> from "Jordan K. Hubbard" at Oct 5, 96 03:44:11 am From: sos@FreeBSD.org Reply-to: sos@FreeBSD.org X-Mailer: ELM [version 2.4 PL25 ME8b] MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk In reply to Jordan K. Hubbard who wrote: > > > jkh 96/10/05 03:44:10 > > Modified: release Makefile > release/sysinstall Makefile install.c uc_main.c > sys/conf newvers.sh > sys/i386/conf options.i386 > sys/i386/i386 locore.s machdep.c userconfig.c > Added: release dumpnlist.c > Removed: release/sysinstall dumpnlist.c > Log: > Multiple changes stacked as one commit since they all depend on one another. Great stuff !! (but then I knew it would be coming :) ) -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Søren Schmidt (sos@FreeBSD.org) FreeBSD Core Team Even more code to hack -- will it ever end .. From owner-cvs-sys Sat Oct 5 04:01:53 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id EAA08389 for cvs-sys-outgoing; Sat, 5 Oct 1996 04:01:53 -0700 (PDT) Received: (from jkh@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id EAA08362; Sat, 5 Oct 1996 04:01:34 -0700 (PDT) Date: Sat, 5 Oct 1996 04:01:34 -0700 (PDT) From: "Jordan K. Hubbard" Message-Id: <199610051101.EAA08362@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/i386/conf LINT Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 96/10/05 04:01:32 Modified: sys/i386/conf LINT Log: Document USERCONFIG_BOOT, even though it doesn't belong where it is. ;-) Revision Changes Path 1.282 +2 -1 src/sys/i386/conf/LINT From owner-cvs-sys Sat Oct 5 12:34:22 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id MAA04147 for cvs-sys-outgoing; Sat, 5 Oct 1996 12:34:22 -0700 (PDT) Received: from alpo.whistle.com (s204m38.isp.whistle.com [207.76.204.38]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id MAA04141; Sat, 5 Oct 1996 12:34:13 -0700 (PDT) Received: from current1.whistle.com (current1.whistle.com [207.76.205.22]) by alpo.whistle.com (8.7.5/8.7.3) with SMTP id MAA01094; Sat, 5 Oct 1996 12:32:41 -0700 (PDT) Date: Sat, 5 Oct 1996 12:30:42 -0700 (PDT) From: Julian Elischer To: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= cc: Julian Elischer , CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/kern kern_exit.c In-Reply-To: <199610050814.MAA00616@nagual.ru> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Content-Transfer-Encoding: QUOTED-PRINTABLE Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk when you have no serial cards and no video cards and nop keyboard you still want /dev/console to work do that xterm -C will work but you have only a 'virtuall' console works now.. julian On Sat, 5 Oct 1996, [KOI8-R] =E1=CE=C4=D2=C5=CA =FE=C5=D2=CE=CF=D7 wrote: > > julian 96/10/04 16:43:14 > >=20 > > Modified: sys/kern kern_exit.c > > Log: > > If we have no console device it is possible to be > > 1/ session leader > > 2/ Have a console device vnode (/dev/console) > > 3/ have NULL pointer for a consoel tty struct. > > =20 > > fix the only case where the tty struct is referenced without a prior > > check for existance. >=20 > In which situations this bug hits? >=20 > --=20 > Andrey A. Chernov > > http://www.nagual.ru/~ache/ >=20 From owner-cvs-sys Sat Oct 5 18:34:40 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id SAA26336 for cvs-sys-outgoing; Sat, 5 Oct 1996 18:34:40 -0700 (PDT) Received: (from gibbs@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id SAA26316; Sat, 5 Oct 1996 18:34:29 -0700 (PDT) Date: Sat, 5 Oct 1996 18:34:29 -0700 (PDT) From: "Justin T. Gibbs" Message-Id: <199610060134.SAA26316@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/dev/aic7xxx aic7xxx.seq aic7xxx_reg.h src/sys/i386/scsi aic7xxx.c aic7xxx.h src/sys/pci aic7870.c src/sys/scsi scsi_message.h scsiconf.h Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk gibbs 96/10/05 18:34:29 Branch: sys/dev/aic7xxx SCSI Modified: sys/dev/aic7xxx aic7xxx.seq aic7xxx_reg.h Log: Remove intrinsic knowledge about SDTR and WDTR messages and replace it with a generic message system that allows the kernel driver to handle SDTR, WDTR and any other type of extended message it chooses too. This makes the sequencer code much simpler, makes extended message handling debuggable since the bulk of the work is in the kernel driver, and saves lots of instruction space. Revision Changes Path 1.42.2.2 +40 -127 src/sys/dev/aic7xxx/aic7xxx.seq 1.12.2.2 +17 -8 src/sys/dev/aic7xxx/aic7xxx_reg.h Branch: sys/i386/scsi SCSI Modified: sys/i386/scsi aic7xxx.c aic7xxx.h Log: Add code to handle WDTR and SDTR negotiation in light of the changes in the message interface to the sequencer. Don't reject targets that negotiate async by sending an SDTR with a 0 offset. Use an sdtr message with 0,0 to negotiate async when a target suggests a period that is too long for us to handle. Some tape and cdrom drives don't like us doing the message reject that we did in the past. Fix a problem with handing the QUEUE FULL condition. This is a stop gap solution until the remainder of the generic SCSI layer's tag support is in place. Fix a race condition (most likely the cause of the SCB paging problems) that might allow the sequencer to get unpaused before the condition that caused it to be paused (a SEQINT) was handled. Race condition pointed out by Doug Ledford and by "Dan Willis" . Revision Changes Path 1.75.2.2 +1036 -932 src/sys/i386/scsi/aic7xxx.c 1.28.2.2 +16 -13 src/sys/i386/scsi/aic7xxx.h Modified: sys/pci aic7870.c Log: Add support for the 2940AU, an aic7860 based controller. Patches for this where supplied by lots of people from FreeBSD and NetBSD, but I did it a little differently. Revision Changes Path 1.37.2.2 +11 -2 src/sys/pci/aic7870.c Branch: sys/scsi SCSI Modified: sys/scsi scsi_message.h scsiconf.h Log: scsi_message.h: Add MSG_EXT_SDTR_LEN and MSG_EXT_WDTR_LEN - the length of bytes in these extended messages. scsiconf.h: The status byte is a byte, not a u_int32_t. Revision Changes Path 1.1.2.2 +5 -2 src/sys/scsi/Attic/scsi_message.h 1.44.2.3 +2 -2 src/sys/scsi/scsiconf.h From owner-cvs-sys Sat Oct 5 19:14:45 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id TAA28467 for cvs-sys-outgoing; Sat, 5 Oct 1996 19:14:45 -0700 (PDT) Received: (from gibbs@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id TAA28446; Sat, 5 Oct 1996 19:14:34 -0700 (PDT) Date: Sat, 5 Oct 1996 19:14:34 -0700 (PDT) From: "Justin T. Gibbs" Message-Id: <199610060214.TAA28446@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys Subject: cvs commit: src/sys/scsi scsi_message.h Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk gibbs 96/10/05 19:14:33 Added: sys/scsi scsi_message.h Log: Bring this over from the SCSI branch. I need it to bring in the fixes to the aic7xxx driver.