From owner-cvs-usrbin Sun Nov 17 03:03:33 1996 Return-Path: owner-cvs-usrbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA12527 for cvs-usrbin-outgoing; Sun, 17 Nov 1996 03:03:33 -0800 (PST) Received: (from ache@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA12504; Sun, 17 Nov 1996 03:03:10 -0800 (PST) Date: Sun, 17 Nov 1996 03:03:10 -0800 (PST) From: "Andrey A. Chernov" Message-Id: <199611171103.DAA12504@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrbin Subject: cvs commit: src/usr.bin/file/Magdir audio Sender: owner-cvs-usrbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 96/11/17 03:03:09 Modified: usr.bin/file/Magdir audio Log: Detect GUS patches now Revision Changes Path 1.2 +60 -24 src/usr.bin/file/Magdir/audio From owner-cvs-usrbin Sun Nov 17 04:43:24 1996 Return-Path: owner-cvs-usrbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id EAA17510 for cvs-usrbin-outgoing; Sun, 17 Nov 1996 04:43:24 -0800 (PST) Received: from mail.cs.tu-berlin.de (mail.cs.tu-berlin.de [130.149.17.13]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id EAA17469; Sun, 17 Nov 1996 04:42:43 -0800 (PST) Received: from campa.panke.de (anonymous214.ppp.cs.tu-berlin.de [130.149.17.214]) by mail.cs.tu-berlin.de (8.6.13/8.6.12) with ESMTP id NAA23591; Sun, 17 Nov 1996 13:32:32 +0100 Received: (from wosch@localhost) by campa.panke.de (8.6.12/8.6.12) id NAA00423; Sun, 17 Nov 1996 13:29:19 +0100 Date: Sun, 17 Nov 1996 13:29:19 +0100 From: Wolfram Schneider Message-Id: <199611171229.NAA00423@campa.panke.de> To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) Cc: bde@zeta.org.au, cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org, joerg@freefall.freebsd.org Subject: Re: cvs commit: src/usr.bin/sed main.c In-Reply-To: <199611170748.IAA11061@uriah.heep.sax.de> References: <199611170350.EAA02826@campa.panke.de> <199611170748.IAA11061@uriah.heep.sax.de> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: owner-cvs-usrbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk J. Wunsch writes: >Nope, my question was which standard claims that feof() could return >wrong results after a successful fopen() but before reaching the EOF >of the stream. comp.lang.c Answers to Frequently Asked Questions Section 12. Stdio 12.1: What's wrong with this code? char c; while((c = getchar()) != EOF) ... A: For one thing, the variable to hold getchar's return value must be an int. getchar() can return all possible character values, as well as EOF. By passing getchar's return value through a char, either a normal character might be misinterpreted as EOF, or the EOF might be altered (particularly if type char is unsigned) and so never seen. References: K&R1 Sec. 1.5 p. 14; K&R2 Sec. 1.5.1 p. 16; ANSI Sec. 3.1.2.5, Sec. 4.9.1, Sec. 4.9.7.5; ISO Sec. 6.1.2.5, Sec. 7.9.1, Sec. 7.9.7.5; H&S Sec. 5.1.3 p. 116, Sec. 15.1, Sec. 15.6; CT&P Sec. 5.1 p. 70; PCS Sec. 11 p. 157. 12.2: Why does the code while(!feof(infp)) { fgets(buf, MAXLINE, infp); fputs(buf, outfp); } copy the last line twice? A: In C, EOF is only indicated *after* an input routine has tried to read, and has reached end-of-file. (In other words, C's I/O is not like Pascal's.) Usually, you should just check the return value of the input routine (fgets() in this case); often, you don't need to use feof() at all. References: K&R2 Sec. 7.6 p. 164; ANSI Sec. 4.9.3, Sec. 4.9.7.1, Sec. 4.9.10.2; ISO Sec. 7.9.3, Sec. 7.9.7.1, Sec. 7.9.10.2; H&S Sec. 15.14 p. 382. From owner-cvs-usrbin Sun Nov 17 06:01:49 1996 Return-Path: owner-cvs-usrbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id GAA20089 for cvs-usrbin-outgoing; Sun, 17 Nov 1996 06:01:49 -0800 (PST) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id GAA20076; Sun, 17 Nov 1996 06:01:33 -0800 (PST) Received: (from bde@localhost) by godzilla.zeta.org.au (8.7.6/8.6.9) id AAA19233; Mon, 18 Nov 1996 00:58:54 +1100 Date: Mon, 18 Nov 1996 00:58:54 +1100 From: Bruce Evans Message-Id: <199611171358.AAA19233@godzilla.zeta.org.au> To: j@uriah.heep.sax.de, wosch@cs.tu-berlin.de Subject: Re: cvs commit: src/usr.bin/sed main.c Cc: bde@zeta.org.au, cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org, joerg@freefall.freebsd.org, joerg_wunsch@uriah.heep.sax.de Sender: owner-cvs-usrbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >> >> Erm, as I told the submitter, this introduces C programmer's bug >> >> #: feof() is not valid until EOF has been read. >> > >> >Huh? I can't find any reference claiming this. >> >> The reference is in my private mail box, as Bruce wrote. > >Nope, my question was which standard claims that feof() could return >wrong results after a successful fopen() but before reaching the EOF >of the stream. It returns correct but uninteresting results (always 0) from after fopen() until EOF has been read from the stream. ANSI standard. Bruce From owner-cvs-usrbin Mon Nov 18 11:16:29 1996 Return-Path: owner-cvs-usrbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA05579 for cvs-usrbin-outgoing; Mon, 18 Nov 1996 11:16:29 -0800 (PST) Received: (from phk@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA05412; Mon, 18 Nov 1996 11:14:59 -0800 (PST) Date: Mon, 18 Nov 1996 11:14:59 -0800 (PST) From: Poul-Henning Kamp Message-Id: <199611181914.LAA05412@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrbin Subject: cvs commit: src/usr.bin/systat vmstat.c Sender: owner-cvs-usrbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk phk 96/11/18 11:14:58 Branch: usr.bin/systat RELENG_2_2 Modified: usr.bin/systat vmstat.c Log: YAMFC Revision Changes Path 1.19.2.2 +14 -14 src/usr.bin/systat/vmstat.c From owner-cvs-usrbin Mon Nov 18 11:39:52 1996 Return-Path: owner-cvs-usrbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA07300 for cvs-usrbin-outgoing; Mon, 18 Nov 1996 11:39:52 -0800 (PST) Received: (from fenner@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA07211; Mon, 18 Nov 1996 11:37:57 -0800 (PST) Date: Mon, 18 Nov 1996 11:37:57 -0800 (PST) From: Bill Fenner Message-Id: <199611181937.LAA07211@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrbin Subject: cvs commit: src/usr.bin/kdump kdump.c Sender: owner-cvs-usrbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk fenner 96/11/18 11:37:55 Modified: usr.bin/kdump kdump.c Log: Fix arg parsing. kdump used to allow a single argument, which it silently ignored. Revision Changes Path 1.8 +1 -3 src/usr.bin/kdump/kdump.c From owner-cvs-usrbin Thu Nov 21 02:14:44 1996 Return-Path: owner-cvs-usrbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id CAA15838 for cvs-usrbin-outgoing; Thu, 21 Nov 1996 02:14:44 -0800 (PST) Received: (from ache@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id CAA15794; Thu, 21 Nov 1996 02:13:41 -0800 (PST) Date: Thu, 21 Nov 1996 02:13:41 -0800 (PST) From: "Andrey A. Chernov" Message-Id: <199611211013.CAA15794@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrbin Subject: cvs commit: src/usr.bin/vi Makefile Sender: owner-cvs-usrbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 96/11/21 02:13:30 Modified: usr.bin/vi Makefile Log: Add ru_RU as alias to ru_SU Revision Changes Path 1.9 +2 -1 src/usr.bin/vi/Makefile From owner-cvs-usrbin Thu Nov 21 08:47:54 1996 Return-Path: owner-cvs-usrbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id IAA04696 for cvs-usrbin-outgoing; Thu, 21 Nov 1996 08:47:54 -0800 (PST) Received: (from phk@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id IAA04610; Thu, 21 Nov 1996 08:47:33 -0800 (PST) Date: Thu, 21 Nov 1996 08:47:33 -0800 (PST) From: Poul-Henning Kamp Message-Id: <199611211647.IAA04610@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrbin Subject: cvs commit: src/usr.bin/file/Magdir audio Sender: owner-cvs-usrbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk phk 96/11/21 08:47:32 Branch: usr.bin/file/Magdir RELENG_2_2 Modified: usr.bin/file/Magdir audio Log: YAMFC Revision Changes Path 1.1.1.2.2.1 +6 -0 src/usr.bin/file/Magdir/audio From owner-cvs-usrbin Thu Nov 21 08:47:55 1996 Return-Path: owner-cvs-usrbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id IAA04705 for cvs-usrbin-outgoing; Thu, 21 Nov 1996 08:47:55 -0800 (PST) Received: (from phk@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id IAA04666; Thu, 21 Nov 1996 08:47:48 -0800 (PST) Date: Thu, 21 Nov 1996 08:47:48 -0800 (PST) From: Poul-Henning Kamp Message-Id: <199611211647.IAA04666@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrbin Subject: cvs commit: src/usr.bin/kdump kdump.c Sender: owner-cvs-usrbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk phk 96/11/21 08:47:47 Branch: usr.bin/kdump RELENG_2_2 Modified: usr.bin/kdump kdump.c Log: YAMFC Revision Changes Path 1.7.2.1 +1 -3 src/usr.bin/kdump/kdump.c From owner-cvs-usrbin Thu Nov 21 08:48:17 1996 Return-Path: owner-cvs-usrbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id IAA04806 for cvs-usrbin-outgoing; Thu, 21 Nov 1996 08:48:17 -0800 (PST) Received: (from phk@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id IAA04785; Thu, 21 Nov 1996 08:48:05 -0800 (PST) Date: Thu, 21 Nov 1996 08:48:05 -0800 (PST) From: Poul-Henning Kamp Message-Id: <199611211648.IAA04785@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrbin Subject: cvs commit: src/usr.bin/sed main.c Sender: owner-cvs-usrbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk phk 96/11/21 08:48:05 Branch: usr.bin/sed RELENG_2_2 Modified: usr.bin/sed main.c Log: YAMFC Revision Changes Path 1.3.2.1 +2 -1 src/usr.bin/sed/main.c From owner-cvs-usrbin Sat Nov 23 00:33:29 1996 Return-Path: owner-cvs-usrbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA15686 for cvs-usrbin-outgoing; Sat, 23 Nov 1996 00:33:29 -0800 (PST) Received: (from phk@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA15672; Sat, 23 Nov 1996 00:33:21 -0800 (PST) Date: Sat, 23 Nov 1996 00:33:21 -0800 (PST) From: Poul-Henning Kamp Message-Id: <199611230833.AAA15672@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrbin Subject: cvs commit: src/usr.bin/vi Makefile Sender: owner-cvs-usrbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk phk 96/11/23 00:33:20 Branch: usr.bin/vi RELENG_2_2 Modified: usr.bin/vi Makefile Log: YAMFC Revision Changes Path 1.3.2.4 +2 -1 src/usr.bin/vi/Makefile From owner-cvs-usrbin Sat Nov 23 01:57:16 1996 Return-Path: owner-cvs-usrbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id BAA17975 for cvs-usrbin-outgoing; Sat, 23 Nov 1996 01:57:16 -0800 (PST) Received: (from asami@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id BAA17953; Sat, 23 Nov 1996 01:56:58 -0800 (PST) Date: Sat, 23 Nov 1996 01:56:58 -0800 (PST) From: Satoshi Asami Message-Id: <199611230956.BAA17953@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrbin Subject: cvs commit: src/usr.bin/make var.c Sender: owner-cvs-usrbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk asami 96/11/23 01:56:56 Branch: usr.bin/make RELENG_2_1_0 Modified: usr.bin/make var.c Log: Merge 1.4->1.5 diff from -current. Fixes g flag of :S modifier, courtesy of Adam David. We need this for the latest bsd.port.mk to have any chance working. Approved by: jkh Revision Changes Path 1.3.4.2 +6 -16 src/usr.bin/make/var.c