From owner-cvs-games Wed Jan 29 17:29:32 1997
Return-Path: <owner-cvs-games>
Received: (from root@localhost)
by freefall.freebsd.org (8.8.5/8.8.5) id RAA08070
for cvs-games-outgoing; Wed, 29 Jan 1997 17:29:32 -0800 (PST)
Received: (from max@localhost)
by freefall.freebsd.org (8.8.5/8.8.5) id RAA08061;
Wed, 29 Jan 1997 17:29:30 -0800 (PST)
Date: Wed, 29 Jan 1997 17:29:30 -0800 (PST)
From: Masafumi NAKANE <max>
Message-Id: <199701300129.RAA08061@freefall.freebsd.org>
To: CVS-committers, cvs-all, cvs-games
Subject: cvs commit: src/games/backgammon/common_source save.c
Sender: owner-cvs-games@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk
max 97/01/29 17:29:29
Modified: games/backgammon/common_source save.c
Log:
Do getreuid(geteuid(), getuid()) before opening file to save the game and
after closing it.
This fixes bug that user couldn't save the game in progress.
2.2 candidate.
Revision Changes Path
1.2 +2 -0 src/games/backgammon/common_source/save.c
From owner-cvs-games Wed Jan 29 17:51:48 1997
Return-Path: <owner-cvs-games>
Received: (from root@localhost)
by freefall.freebsd.org (8.8.5/8.8.5) id RAA09305
for cvs-games-outgoing; Wed, 29 Jan 1997 17:51:48 -0800 (PST)
Received: (from max@localhost)
by freefall.freebsd.org (8.8.5/8.8.5) id RAA09297;
Wed, 29 Jan 1997 17:51:46 -0800 (PST)
Date: Wed, 29 Jan 1997 17:51:46 -0800 (PST)
From: Masafumi NAKANE <max>
Message-Id: <199701300151.RAA09297@freefall.freebsd.org>
To: CVS-committers, cvs-all, cvs-games
Subject: cvs commit: src/games/backgammon/common_source save.c
Sender: owner-cvs-games@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk
max 97/01/29 17:51:46
Modified: games/backgammon/common_source save.c
Log:
Oops, setreuid() also needed before and after opening/closing the recover file
in recover().
2.2 candidate.
Revision Changes Path
1.3 +2 -0 src/games/backgammon/common_source/save.c
From owner-cvs-games Wed Jan 29 23:13:06 1997
Return-Path: <owner-cvs-games>
Received: (from root@localhost)
by freefall.freebsd.org (8.8.5/8.8.5) id XAA25141
for cvs-games-outgoing; Wed, 29 Jan 1997 23:13:06 -0800 (PST)
Received: (from max@localhost)
by freefall.freebsd.org (8.8.5/8.8.5) id XAA25130;
Wed, 29 Jan 1997 23:13:01 -0800 (PST)
Date: Wed, 29 Jan 1997 23:13:01 -0800 (PST)
From: Masafumi NAKANE <max>
Message-Id: <199701300713.XAA25130@freefall.freebsd.org>
To: CVS-committers, cvs-all, cvs-games
Subject: cvs commit: src/games/backgammon/backgammon main.c src/games/backgammon/teachgammon teach.c src/games/backgammon/common_source back.h init.c subs.c
Sender: owner-cvs-games@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk
max 97/01/29 23:13:00
Modified: games/backgammon/backgammon main.c
games/backgammon/common_source back.h init.c subs.c
games/backgammon/teachgammon teach.c
Log:
Better handling of command-line argument:
1. Pass argc and argv to getarg and process them with getopt().
2. Instead of using an array to save arg characters, use array of
pointers and call backgammon/teachgammon with execv, instead of execl.
This should fix problems with calling teachgammon.
2.2 candidate.
Revision Changes Path
1.2 +9 -8 src/games/backgammon/backgammon/main.c
1.2 +2 -2 src/games/backgammon/common_source/back.h
1.2 +1 -1 src/games/backgammon/common_source/init.c
1.4 +26 -27 src/games/backgammon/common_source/subs.c
1.3 +10 -7 src/games/backgammon/teachgammon/teach.c
From owner-cvs-games Fri Jan 31 07:04:29 1997
Return-Path: <owner-cvs-games>
Received: (from root@localhost)
by freefall.freebsd.org (8.8.5/8.8.5) id HAA26144
for cvs-games-outgoing; Fri, 31 Jan 1997 07:04:29 -0800 (PST)
Received: (from max@localhost)
by freefall.freebsd.org (8.8.5/8.8.5) id HAA26135;
Fri, 31 Jan 1997 07:04:25 -0800 (PST)
Date: Fri, 31 Jan 1997 07:04:25 -0800 (PST)
From: Masafumi NAKANE <max>
Message-Id: <199701311504.HAA26135@freefall.freebsd.org>
To: CVS-committers, cvs-all, cvs-games
Subject: cvs commit: src/games/backgammon/backgammon main.c src/games/backgammon/teachgammon teach.c src/games/backgammon/common_source subs.c
Sender: owner-cvs-games@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk
max 97/01/31 07:04:24
Modified: games/backgammon/backgammon main.c
games/backgammon/teachgammon teach.c
games/backgammon/common_source subs.c
Log:
Style police:
- Indentation corrections
- Spaces -> tabs.
- func() -> func () (To be consistent with the original code.)
- Check if getopt() returns -1, not EOF.
Suggested by: bde
Revision Changes Path
1.3 +3 -3 src/games/backgammon/backgammon/main.c
1.4 +2 -2 src/games/backgammon/teachgammon/teach.c
1.5 +6 -6 src/games/backgammon/common_source/subs.c
From owner-cvs-games Fri Jan 31 18:54:15 1997
Return-Path: <owner-cvs-games>
Received: (from root@localhost)
by freefall.freebsd.org (8.8.5/8.8.5) id SAA00389
for cvs-games-outgoing; Fri, 31 Jan 1997 18:54:15 -0800 (PST)
Received: (from max@localhost)
by freefall.freebsd.org (8.8.5/8.8.5) id SAA00380;
Fri, 31 Jan 1997 18:54:13 -0800 (PST)
Date: Fri, 31 Jan 1997 18:54:13 -0800 (PST)
From: Masafumi NAKANE <max>
Message-Id: <199702010254.SAA00380@freefall.freebsd.org>
To: CVS-committers, cvs-all, cvs-games
Subject: cvs commit: src/games/backgammon/backgammon main.c src/games/backgammon/common_source subs.c
Sender: owner-cvs-games@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk
max 97/01/31 18:54:13
Modified: games/backgammon/common_source subs.c
games/backgammon/backgammon main.c
Log:
Include string.h for prototype of strdup().
Revision Changes Path
1.6 +1 -0 src/games/backgammon/common_source/subs.c
1.4 +1 -0 src/games/backgammon/backgammon/main.c
From owner-cvs-games Sat Feb 1 13:30:54 1997
Return-Path: <owner-cvs-games>
Received: (from root@localhost)
by freefall.freebsd.org (8.8.5/8.8.5) id NAA10383
for cvs-games-outgoing; Sat, 1 Feb 1997 13:30:54 -0800 (PST)
Received: (from max@localhost)
by freefall.freebsd.org (8.8.5/8.8.5) id NAA10374;
Sat, 1 Feb 1997 13:30:52 -0800 (PST)
Date: Sat, 1 Feb 1997 13:30:52 -0800 (PST)
From: Masafumi NAKANE <max>
Message-Id: <199702012130.NAA10374@freefall.freebsd.org>
To: CVS-committers, cvs-all, cvs-games
Subject: cvs commit: src/games/backgammon/backgammon main.c src/games/backgammon/teachgammon teach.c src/games/backgammon/common_source save.c
Sender: owner-cvs-games@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk
max 97/02/01 13:30:52
Modified: games/backgammon/backgammon main.c
games/backgammon/common_source save.c
games/backgammon/teachgammon teach.c
Log:
Instead of swapping ruid and euid before and after touching user's file,
simply drop the privilege right after the program is started.
Thanks to bde for giving me good suggestion about this problem.
Revision Changes Path
1.5 +5 -0 src/games/backgammon/backgammon/main.c
1.4 +0 -4 src/games/backgammon/common_source/save.c
1.5 +7 -0 src/games/backgammon/teachgammon/teach.c
From owner-cvs-games Sat Feb 1 13:56:34 1997
Return-Path: <owner-cvs-games>
Received: (from root@localhost)
by freefall.freebsd.org (8.8.5/8.8.5) id NAA11076
for cvs-games-outgoing; Sat, 1 Feb 1997 13:56:34 -0800 (PST)
Received: from rayearth.rim.or.jp (uucp@rayearth.rim.or.jp [202.247.130.242])
by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id NAA11070;
Sat, 1 Feb 1997 13:56:28 -0800 (PST)
Received: (from uucp@localhost) by rayearth.rim.or.jp (8.8.5/3.4W3-uucp1) with UUCP
id GAA24349; Sun, 2 Feb 1997 06:56:21 +0900 (JST)
Received: from tky007.tth.expo96.ad.jp (localhost [127.0.0.1]) by mail.aslm.rim.or.jp (8.8.5/3.4W4-SMTP) with ESMTP id GAA04072; Sun, 2 Feb 1997 06:48:34 +0900 (JST)
Message-Id: <199702012148.GAA04072@mail.aslm.rim.or.jp>
To: max@freefall.freebsd.org
Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org,
cvs-games@freefall.freebsd.org
Cc: max@wide.ad.jp
Subject: Re: cvs commit: src/games/backgammon/backgammon main.c src/games/backgammon/teachgammon
teach.c src/games/backgammon/common_source save.c
From: Masafumi NAKANE/=?ISO-2022-JP?B?GyRCQ2Y6LDJtSjgbKEI=?= <max@wide.ad.jp>
In-Reply-To: Your message of "Sat, 1 Feb 1997 13:30:52 -0800 (PST)"
References: <199702012130.NAA10374@freefall.freebsd.org>
X-Mailer: Mew version 1.54 on Emacs 19.28.1, Mule 2.3
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Date: Sun, 02 Feb 1997 06:48:32 +0900
Sender: owner-cvs-games@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk
> max 97/02/01 13:30:52
> Modified: games/backgammon/backgammon main.c
> games/backgammon/common_source save.c
> games/backgammon/teachgammon teach.c
> Log:
> Instead of swapping ruid and euid before and after touching user's file,
> simply drop the privilege right after the program is started.
> Thanks to bde for giving me good suggestion about this problem.
>
> Revision Changes Path
> 1.5 +5 -0 src/games/backgammon/backgammon/main.c
> 1.4 +0 -4 src/games/backgammon/common_source/save.c
> 1.5 +7 -0 src/games/backgammon/teachgammon/teach.c
This should go into 2.2 together with all other recent changes I made
to backgammon.
Max