From owner-cvs-sbin Sun Mar 30 01:22:46 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id BAA16958 for cvs-sbin-outgoing; Sun, 30 Mar 1997 01:22:46 -0800 (PST) Received: (from phk@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id BAA16951; Sun, 30 Mar 1997 01:22:44 -0800 (PST) Date: Sun, 30 Mar 1997 01:22:44 -0800 (PST) From: Poul-Henning Kamp Message-Id: <199703300922.BAA16951@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/init init.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk phk 97/03/30 01:22:43 Modified: sbin/init init.c Log: Fix mount call for devfs. Submitted by: bde Revision Changes Path 1.16 +1 -2 src/sbin/init/init.c From owner-cvs-sbin Sun Mar 30 04:12:34 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id EAA22009 for cvs-sbin-outgoing; Sun, 30 Mar 1997 04:12:34 -0800 (PST) Received: (from brian@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id EAA21994; Sun, 30 Mar 1997 04:12:26 -0800 (PST) Date: Sun, 30 Mar 1997 04:12:26 -0800 (PST) From: Brian Somers Message-Id: <199703301212.EAA21994@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib, cvs-usrbin, cvs-sbin, cvs-usrsbin Subject: cvs commit: src/sbin/slattach Makefile src/usr.bin/tip/tip Makefile src/usr.sbin/ppp Makefile src/lib/libutil uucplock.3 uucplock.c Makefile libutil.h src/sbin/startslip Makefile uucplock.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk brian 97/03/30 04:12:24 Modified: lib/libutil Makefile libutil.h sbin/slattach Makefile sbin/startslip Makefile usr.bin/tip/tip Makefile usr.sbin/ppp Makefile Added: lib/libutil uucplock.3 uucplock.c Removed: sbin/startslip uucplock.c Log: Move uucplock into libutil and create a manual page. Revision Changes Path 1.8 +4 -2 src/lib/libutil/Makefile 1.5 +3 -1 src/lib/libutil/libutil.h 1.7 +2 -4 src/sbin/slattach/Makefile 1.4 +2 -1 src/sbin/startslip/Makefile 1.7 +2 -4 src/usr.bin/tip/tip/Makefile 1.17 +2 -4 src/usr.sbin/ppp/Makefile From owner-cvs-sbin Sun Mar 30 13:30:08 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id NAA14012 for cvs-sbin-outgoing; Sun, 30 Mar 1997 13:30:08 -0800 (PST) Received: from sovcom.kiae.su (sovcom.kiae.su [193.125.152.1]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id NAA13963; Sun, 30 Mar 1997 13:29:59 -0800 (PST) Received: by sovcom.kiae.su id AA12768 (5.65.kiae-1 ); Mon, 31 Mar 1997 00:20:37 +0300 Received: by sovcom.KIAE.su (UUMAIL/2.0); Mon, 31 Mar 97 00:20:36 +0300 Received: (from ache@localhost) by nagual.ru (8.8.5/8.8.5) id BAA00348; Mon, 31 Mar 1997 01:18:17 +0400 (MSD) Date: Mon, 31 Mar 1997 01:18:09 +0400 (MSD) From: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= To: Brian Somers Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/slattach Makefile src/usr.bin/tip/tip Makefile src/usr.sbin/ppp Makefile src/lib/libutil uucplock.3 uucplock.c Makefile libutil.h src/sbin/startslip Makefile uucplock.c In-Reply-To: <199703301212.EAA21994@freefall.freebsd.org> Message-Id: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Sun, 30 Mar 1997, Brian Somers wrote: > Added: lib/libutil uucplock.3 uucplock.c > Removed: sbin/startslip uucplock.c > Log: > Move uucplock into libutil and create a manual page. What you do with USE_PERROR define which switch uucplock error loging from perror to syslog? Startslip uses syslog and ppp not use it. It seems that you just broke ppp since you left USE_PERROR define in its Makefile which unused now. Moreover, having library function with syslog report is bad idea in any case. To fix it properly you need to change return from uucplock functions from int to char *, i.e. return NULL for no errors or static error string if error happens. Then you need to change upper level programs to pass this error string to perror/syslog/whatever. -- Andrey A. Chernov http://www.nagual.ru/~ache/ From owner-cvs-sbin Mon Mar 31 05:37:59 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id FAA17848 for cvs-sbin-outgoing; Mon, 31 Mar 1997 05:37:59 -0800 (PST) Received: from awfulhak.demon.co.uk (awfulhak.demon.co.uk [158.152.17.1]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id FAA17810; Mon, 31 Mar 1997 05:37:34 -0800 (PST) Received: from awfulhak.demon.co.uk (localhost.lan.awfulhak.org [127.0.0.1]) by awfulhak.demon.co.uk (8.8.5/8.8.5) with ESMTP id OAA02346; Mon, 31 Mar 1997 14:37:00 +0100 (BST) Message-Id: <199703311337.OAA02346@awfulhak.demon.co.uk> X-Mailer: exmh version 1.6.9 8/22/96 To: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= cc: Brian Somers , CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/slattach Makefile src/usr.bin/tip/tip Makefile src/usr.sbin/ppp Makefile src/lib/libutil uucplock.3 uucplock.c Makefile libutil.h src/sbin/startslip Makefile uucplock.c In-reply-to: Your message of "Mon, 31 Mar 1997 01:18:09 +0400." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 31 Mar 1997 14:36:59 +0100 From: Brian Somers Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > On Sun, 30 Mar 1997, Brian Somers wrote: > > > Added: lib/libutil uucplock.3 uucplock.c > > Removed: sbin/startslip uucplock.c > > Log: > > Move uucplock into libutil and create a manual page. > > What you do with USE_PERROR define which switch uucplock > error loging from perror to syslog? Startslip uses syslog > and ppp not use it. It seems that you just broke ppp since > you left USE_PERROR define in its Makefile which unused > now. Moreover, having library function with syslog report > is bad idea in any case. > > To fix it properly you need to change return from uucplock functions > from int to char *, i.e. return NULL for no errors or static error > string if error happens. Then you need to change upper level programs > to pass this error string to perror/syslog/whatever. > > -- > Andrey A. Chernov > > http://www.nagual.ru/~ache/ Oops, thanks. I'll do the char* thing. -- Brian , Don't _EVER_ lose your sense of humour.... From owner-cvs-sbin Mon Mar 31 06:28:22 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA19736 for cvs-sbin-outgoing; Mon, 31 Mar 1997 06:28:22 -0800 (PST) Received: from awfulhak.demon.co.uk (awfulhak.demon.co.uk [158.152.17.1]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id GAA19715; Mon, 31 Mar 1997 06:28:13 -0800 (PST) Received: from awfulhak.demon.co.uk (localhost.lan.awfulhak.org [127.0.0.1]) by awfulhak.demon.co.uk (8.8.5/8.8.5) with ESMTP id PAA04005; Mon, 31 Mar 1997 15:27:12 +0100 (BST) Message-Id: <199703311427.PAA04005@awfulhak.demon.co.uk> X-Mailer: exmh version 1.6.9 8/22/96 To: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= cc: Brian Somers , CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/slattach Makefile src/usr.bin/tip/tip Makefile src/usr.sbin/ppp Makefile src/lib/libutil uucplock.3 uucplock.c Makefile libutil.h src/sbin/startslip Makefile uucplock.c In-reply-to: Your message of "Mon, 31 Mar 1997 01:18:09 +0400." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 31 Mar 1997 15:27:12 +0100 From: Brian Somers Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > On Sun, 30 Mar 1997, Brian Somers wrote: > > > Added: lib/libutil uucplock.3 uucplock.c > > Removed: sbin/startslip uucplock.c > > Log: > > Move uucplock into libutil and create a manual page. > > What you do with USE_PERROR define which switch uucplock > error loging from perror to syslog? Startslip uses syslog > and ppp not use it. It seems that you just broke ppp since > you left USE_PERROR define in its Makefile which unused > now. Moreover, having library function with syslog report > is bad idea in any case. > > To fix it properly you need to change return from uucplock functions > from int to char *, i.e. return NULL for no errors or static error > string if error happens. Then you need to change upper level programs > to pass this error string to perror/syslog/whatever. > > -- > Andrey A. Chernov > > http://www.nagual.ru/~ache/ On second thoughts, a return value of UU_LOCK_OPEN_ERR, UU_LOCK_READ_ERR, UU_LOCK_SEEK_ERR, UU_LOCK_WRITE_ERR, UU_LOCK_INUSE_ERR or UU_LOCK_OK (#define'd in libutil.h) with errno set to the error would be more appropriate. -- Brian , Don't _EVER_ lose your sense of humour.... From owner-cvs-sbin Mon Mar 31 08:43:22 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id IAA26152 for cvs-sbin-outgoing; Mon, 31 Mar 1997 08:43:22 -0800 (PST) Received: (from peter@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id IAA26145; Mon, 31 Mar 1997 08:43:20 -0800 (PST) Date: Mon, 31 Mar 1997 08:43:20 -0800 (PST) From: Peter Wemm Message-Id: <199703311643.IAA26145@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/newfs mkfs.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 97/03/31 08:43:20 Modified: sbin/newfs mkfs.c Log: Fix the mount_mfs case from the last cleanup. The code was (ab)using it's internal malloc() implementation to try and avoid overstepping it's resource limits (yuk!). Remain using libc's malloc(), but check the resource limits right before trying to malloc the ramdisk space and leave some spare memory for libc. In Andrey's words, the internal malloc was "true evil".. Among it's sins is it's ability to allocate less memory than asked for and still return success. stdio would just love that. :-) Reviewed by: ache Revision Changes Path 1.17 +17 -1 src/sbin/newfs/mkfs.c From owner-cvs-sbin Mon Mar 31 08:56:50 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id IAA26958 for cvs-sbin-outgoing; Mon, 31 Mar 1997 08:56:50 -0800 (PST) Received: from sovcom.kiae.su (sovcom.kiae.su [193.125.152.1]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id IAA26880; Mon, 31 Mar 1997 08:55:11 -0800 (PST) Received: by sovcom.kiae.su id AA17785 (5.65.kiae-1 ); Mon, 31 Mar 1997 18:46:19 +0300 Received: by sovcom.KIAE.su (UUMAIL/2.0); Mon, 31 Mar 97 18:46:19 +0300 Received: (from ache@localhost) by nagual.ru (8.8.5/8.8.5) id TAA00626; Mon, 31 Mar 1997 19:45:40 +0400 (MSD) Date: Mon, 31 Mar 1997 19:45:38 +0400 (MSD) From: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= To: Brian Somers Cc: Brian Somers , CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/slattach Makefile src/usr.bin/tip/tip Makefile src/usr.sbin/ppp Makefile src/lib/libutil uucplock.3 uucplock.c Makefile libutil.h src/sbin/startslip Makefile uucplock.c In-Reply-To: <199703311427.PAA04005@awfulhak.demon.co.uk> Message-Id: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Mon, 31 Mar 1997, Brian Somers wrote: > On second thoughts, a return value of UU_LOCK_OPEN_ERR, > UU_LOCK_READ_ERR, UU_LOCK_SEEK_ERR, UU_LOCK_WRITE_ERR, > UU_LOCK_INUSE_ERR or UU_LOCK_OK (#define'd in libutil.h) > with errno set to the error would be more appropriate. Ok, but you need a wrapper which convert return error code to diagnostic string in any case. It can be done via something like uustrerror() or manually into each program. -- Andrey A. Chernov http://www.nagual.ru/~ache/ From owner-cvs-sbin Mon Mar 31 14:51:04 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id OAA15011 for cvs-sbin-outgoing; Mon, 31 Mar 1997 14:51:04 -0800 (PST) Received: (from brian@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id OAA14996; Mon, 31 Mar 1997 14:51:01 -0800 (PST) Date: Mon, 31 Mar 1997 14:51:01 -0800 (PST) From: Brian Somers Message-Id: <199703312251.OAA14996@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib, cvs-usrbin, cvs-sbin, cvs-usrsbin Subject: cvs commit: src/usr.bin/tip/tip Makefile hunt.c src/lib/libutil libutil.h uucplock.3 uucplock.c src/sbin/slattach slattach.c src/sbin/startslip startslip.c src/usr.sbin/ppp Makefile modem.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk brian 97/03/31 14:51:01 Modified: lib/libutil libutil.h uucplock.3 uucplock.c sbin/slattach slattach.c sbin/startslip startslip.c usr.bin/tip/tip Makefile hunt.c usr.sbin/ppp Makefile modem.c Log: Remove the syslog stuff, and allow various return values in uu_lock(). Add uu_lockerr() for turning the results of uu_lock into something printable. Remove bogus section in man page about race conditions allowing both processes to get the lock. Include libutil.h and use uu_lock() correctly where it should. Suggested by: ache@freebsd.org Revision Changes Path 1.6 +9 -1 src/lib/libutil/libutil.h 1.2 +77 -14 src/lib/libutil/uucplock.3 1.2 +59 -33 src/lib/libutil/uucplock.c 1.27 +10 -3 src/sbin/slattach/slattach.c 1.24 +6 -2 src/sbin/startslip/startslip.c 1.8 +0 -1 src/usr.bin/tip/tip/Makefile 1.2 +6 -1 src/usr.bin/tip/tip/hunt.c 1.18 +2 -2 src/usr.sbin/ppp/Makefile 1.32 +9 -4 src/usr.sbin/ppp/modem.c From owner-cvs-sbin Mon Mar 31 23:43:20 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id XAA16981 for cvs-sbin-outgoing; Mon, 31 Mar 1997 23:43:20 -0800 (PST) Received: (from bde@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id XAA16974; Mon, 31 Mar 1997 23:43:17 -0800 (PST) Date: Mon, 31 Mar 1997 23:43:17 -0800 (PST) From: Bruce Evans Message-Id: <199704010743.XAA16974@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/startslip Makefile Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk bde 97/03/31 23:43:16 Modified: sbin/startslip Makefile Log: Fixed missing DPADD. Removed now-redundant SRCS. Revision Changes Path 1.5 +1 -1 src/sbin/startslip/Makefile From owner-cvs-sbin Tue Apr 1 06:15:38 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA03202 for cvs-sbin-outgoing; Tue, 1 Apr 1997 06:15:38 -0800 (PST) Received: (from bde@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA03195; Tue, 1 Apr 1997 06:15:36 -0800 (PST) Date: Tue, 1 Apr 1997 06:15:36 -0800 (PST) From: Bruce Evans Message-Id: <199704011415.GAA03195@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/mountd mountd.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk bde 97/04/01 06:15:34 Modified: sbin/mountd mountd.c Log: Don't fail when the vfs.nfs.nfs_privport sysctl doesn't exist (presumably because the kernel is old). Moved the declaration of a variable realated to this sysctl outside of an unrelated ifdef. Not fixed: - this sysctl is badly named (nfs occurs twice). - it's silly to have for FreeBSD in FreeBSD code, especially when only half of the FreeBSD-dependent code is ifdefed. Revision Changes Path 1.17 +4 -4 src/sbin/mountd/mountd.c From owner-cvs-sbin Tue Apr 1 06:39:27 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA04414 for cvs-sbin-outgoing; Tue, 1 Apr 1997 06:39:27 -0800 (PST) Received: from nlsystems.com (nlsys.demon.co.uk [158.152.125.33]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id GAA04368; Tue, 1 Apr 1997 06:38:11 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by nlsystems.com (8.8.5/8.8.5) with SMTP id PAA03579; Tue, 1 Apr 1997 15:37:39 +0100 (BST) Date: Tue, 1 Apr 1997 15:37:38 +0100 (BST) From: Doug Rabson To: Bruce Evans cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/mountd mountd.c In-Reply-To: <199704011415.GAA03195@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Tue, 1 Apr 1997, Bruce Evans wrote: > bde 97/04/01 06:15:34 > > Modified: sbin/mountd mountd.c > Log: > Don't fail when the vfs.nfs.nfs_privport sysctl doesn't exist > (presumably because the kernel is old). Moved the declaration of a > variable realated to this sysctl outside of an unrelated ifdef. > > Not fixed: > - this sysctl is badly named (nfs occurs twice). Probably this should be named vfs.nfs.privport. Possibly, since the sysctl refers only to the NFS server, which isn't a VFS, the variable shouldn't be in the vfs tree at all. Maybe kern.nfs.privport. That would mean renaming vfs.nfs.async, since that is a server-only variable too. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 951 1891 From owner-cvs-sbin Tue Apr 1 07:03:37 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA05402 for cvs-sbin-outgoing; Tue, 1 Apr 1997 07:03:37 -0800 (PST) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id HAA05380; Tue, 1 Apr 1997 07:03:06 -0800 (PST) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id AAA25683; Wed, 2 Apr 1997 00:56:18 +1000 Date: Wed, 2 Apr 1997 00:56:18 +1000 From: Bruce Evans Message-Id: <199704011456.AAA25683@godzilla.zeta.org.au> To: bde@freefall.freebsd.org, dfr@nlsystems.com Subject: Re: cvs commit: src/sbin/mountd mountd.c Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >Probably this should be named vfs.nfs.privport. Possibly, since the >sysctl refers only to the NFS server, which isn't a VFS, the variable >shouldn't be in the vfs tree at all. Maybe kern.nfs.privport. That would >mean renaming vfs.nfs.async, since that is a server-only variable too. What about vfs.nfs.defect and vfs.nfs.diskless*? One of the advantages of hanging them all off vfs is that they used to work right automagically for LKMs. This is broken now that sysctl initialization is done too statically using linker sets. Bruce From owner-cvs-sbin Tue Apr 1 08:02:06 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id IAA08945 for cvs-sbin-outgoing; Tue, 1 Apr 1997 08:02:06 -0800 (PST) Received: from nlsystems.com (nlsys.demon.co.uk [158.152.125.33]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id IAA08925; Tue, 1 Apr 1997 08:01:25 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by nlsystems.com (8.8.5/8.8.5) with SMTP id RAA04069; Tue, 1 Apr 1997 17:00:17 +0100 (BST) Date: Tue, 1 Apr 1997 17:00:16 +0100 (BST) From: Doug Rabson To: Bruce Evans cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/mountd mountd.c In-Reply-To: <199704011456.AAA25683@godzilla.zeta.org.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Wed, 2 Apr 1997, Bruce Evans wrote: > >Probably this should be named vfs.nfs.privport. Possibly, since the > >sysctl refers only to the NFS server, which isn't a VFS, the variable > >shouldn't be in the vfs tree at all. Maybe kern.nfs.privport. That would > >mean renaming vfs.nfs.async, since that is a server-only variable too. > > What about vfs.nfs.defect and vfs.nfs.diskless*? One of the advantages of > hanging them all off vfs is that they used to work right automagically > for LKMs. This is broken now that sysctl initialization is done too > statically using linker sets. Only vfs.nfs.defect really affects the operation of the filesystem. You are right about the sysctl initialisation being bogus though. I want to be able to add and remove new sysctls dynamically from loadable modules. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 951 1891 From owner-cvs-sbin Tue Apr 1 09:20:21 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id JAA13527 for cvs-sbin-outgoing; Tue, 1 Apr 1997 09:20:21 -0800 (PST) Received: (from guido@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id JAA13518; Tue, 1 Apr 1997 09:20:19 -0800 (PST) Date: Tue, 1 Apr 1997 09:20:19 -0800 (PST) From: Guido van Rooij Message-Id: <199704011720.JAA13518@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/mount_nfs mount_nfs.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk guido 97/04/01 09:20:18 Modified: sbin/mount_nfs mount_nfs.c Log: Make mount_nfs use reserved ports by default.. Mounts already use a reserved port, so why not the nfs rpc's themselves? With user allowed mounts, this perhaps needs a closer look, but on the other hand, a user could already specify the flag. If normal users should not be able to use resserved ports, the kernel should check for the flag at mount time. Revision Changes Path 1.19 +2 -2 src/sbin/mount_nfs/mount_nfs.c From owner-cvs-sbin Tue Apr 1 09:53:52 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id JAA16077 for cvs-sbin-outgoing; Tue, 1 Apr 1997 09:53:52 -0800 (PST) Received: from nlsystems.com (nlsys.demon.co.uk [158.152.125.33]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id JAA16017; Tue, 1 Apr 1997 09:52:50 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by nlsystems.com (8.8.5/8.8.5) with SMTP id SAA04250; Tue, 1 Apr 1997 18:51:59 +0100 (BST) Date: Tue, 1 Apr 1997 18:51:59 +0100 (BST) From: Doug Rabson To: Guido van Rooij cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/mount_nfs mount_nfs.c In-Reply-To: <199704011720.JAA13518@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Tue, 1 Apr 1997, Guido van Rooij wrote: > guido 97/04/01 09:20:18 > > Modified: sbin/mount_nfs mount_nfs.c > Log: > Make mount_nfs use reserved ports by default.. Mounts already use > a reserved port, so why not the nfs rpc's themselves? > With user allowed mounts, this perhaps needs a closer look, but > on the other hand, a user could already specify the flag. > If normal users should not be able to use resserved ports, the kernel > should check for the flag at mount time. Did you leave a way to clear the NFSMNT_RESVPORT flag? The -P option sets it and so does -o resvport but -o noresvport won't work since the handling of the altflags passed to getmntopts by mount_nfs is bogus. It only handles setting flags and not clearing flags. It should be passing &nfsargsp->flags to getmntopts and the option table should use NFSMNT_* flags instead of ALTF_*. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 951 1891 From owner-cvs-sbin Tue Apr 1 10:07:21 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id KAA17239 for cvs-sbin-outgoing; Tue, 1 Apr 1997 10:07:21 -0800 (PST) Received: (from pst@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id KAA17221; Tue, 1 Apr 1997 10:07:17 -0800 (PST) Date: Tue, 1 Apr 1997 10:07:17 -0800 (PST) From: Paul Traina Message-Id: <199704011807.KAA17221@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/mountd mountd.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk pst 97/04/01 10:07:16 Branch: sbin/mountd RELENG_2_2 Modified: sbin/mountd mountd.c Log: Merge Bruce's changes from HEAD Revision Changes Path 1.11.2.2 +4 -4 src/sbin/mountd/mountd.c From owner-cvs-sbin Tue Apr 1 12:41:10 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id MAA28548 for cvs-sbin-outgoing; Tue, 1 Apr 1997 12:41:10 -0800 (PST) Received: (from mpp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id MAA28539; Tue, 1 Apr 1997 12:41:08 -0800 (PST) Date: Tue, 1 Apr 1997 12:41:08 -0800 (PST) From: Mike Pritchard Message-Id: <199704012041.MAA28539@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/init init.8 Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk mpp 97/04/01 12:41:07 Modified: sbin/init init.8 Log: Be more specific as to which flags may not be turned off when the system is running in secure mode. Obtained from: NetBSD PR# 3299 Revision Changes Path 1.9 +3 -2 src/sbin/init/init.8 From owner-cvs-sbin Tue Apr 1 12:42:29 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id MAA28719 for cvs-sbin-outgoing; Tue, 1 Apr 1997 12:42:29 -0800 (PST) Received: (from mpp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id MAA28711; Tue, 1 Apr 1997 12:42:26 -0800 (PST) Date: Tue, 1 Apr 1997 12:42:26 -0800 (PST) From: Mike Pritchard Message-Id: <199704012042.MAA28711@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/init init.8 Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk mpp 97/04/01 12:42:26 Branch: sbin/init RELENG_2_2 Modified: sbin/init init.8 Log: YAMFC: describe which flags can be changed in secure mode better. Revision Changes Path 1.4.2.2 +3 -2 src/sbin/init/init.8 From owner-cvs-sbin Tue Apr 1 23:21:43 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id XAA12129 for cvs-sbin-outgoing; Tue, 1 Apr 1997 23:21:43 -0800 (PST) Received: from gvr.win.tue.nl (root@gvr.win.tue.nl [131.155.210.19]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id XAA12122; Tue, 1 Apr 1997 23:21:34 -0800 (PST) Received: (from guido@localhost) by gvr.win.tue.nl (8.8.5/8.8.2) id JAA07167; Wed, 2 Apr 1997 09:21:27 +0200 (MET DST) From: Guido van Rooij Message-Id: <199704020721.JAA07167@gvr.win.tue.nl> Subject: Re: cvs commit: src/sbin/mount_nfs mount_nfs.c In-Reply-To: from Doug Rabson at "Apr 1, 97 06:51:59 pm" To: dfr@nlsystems.com (Doug Rabson) Date: Wed, 2 Apr 1997 09:21:27 +0200 (MET DST) Cc: guido@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org X-Mailer: ELM [version 2.4ME+ PL28 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Doug Rabson wrote: > On Tue, 1 Apr 1997, Guido van Rooij wrote: > > > guido 97/04/01 09:20:18 > > > > Modified: sbin/mount_nfs mount_nfs.c > > Log: > > Make mount_nfs use reserved ports by default.. Mounts already use > > a reserved port, so why not the nfs rpc's themselves? > > With user allowed mounts, this perhaps needs a closer look, but > > on the other hand, a user could already specify the flag. > > If normal users should not be able to use resserved ports, the kernel > > should check for the flag at mount time. > > Did you leave a way to clear the NFSMNT_RESVPORT flag? The -P option sets > it and so does -o resvport but -o noresvport won't work since the handling > of the altflags passed to getmntopts by mount_nfs is bogus. It only > handles setting flags and not clearing flags. It should be passing > &nfsargsp->flags to getmntopts and the option table should use NFSMNT_* > flags instead of ALTF_*. > It doesn't handle. But when you want to be able tomount with non reserved ports, also the mounts itsself should come form such a port. Currently that is not true. Perhaps we should just not offer non-resvports? Or only based on uid? -Guido From owner-cvs-sbin Tue Apr 1 23:50:15 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id XAA13398 for cvs-sbin-outgoing; Tue, 1 Apr 1997 23:50:15 -0800 (PST) Received: from nlsystems.com (nlsys.demon.co.uk [158.152.125.33]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id XAA13384; Tue, 1 Apr 1997 23:50:08 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by nlsystems.com (8.8.5/8.8.5) with SMTP id IAA05631; Wed, 2 Apr 1997 08:49:29 +0100 (BST) Date: Wed, 2 Apr 1997 08:49:29 +0100 (BST) From: Doug Rabson To: Guido van Rooij cc: guido@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/mount_nfs mount_nfs.c In-Reply-To: <199704020721.JAA07167@gvr.win.tue.nl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Wed, 2 Apr 1997, Guido van Rooij wrote: > > > > Did you leave a way to clear the NFSMNT_RESVPORT flag? The -P option sets > > it and so does -o resvport but -o noresvport won't work since the handling > > of the altflags passed to getmntopts by mount_nfs is bogus. It only > > handles setting flags and not clearing flags. It should be passing > > &nfsargsp->flags to getmntopts and the option table should use NFSMNT_* > > flags instead of ALTF_*. > > > > It doesn't handle. But when you want to be able tomount with non reserved > ports, also the mounts itsself should come form such a port. Currently that > is not true. Perhaps we should just not offer non-resvports? Or only based > on uid? I will probably fix the usage of getmntopts so that flag negation works. The issue of reserved or non-reserved ports is a red herring as far as security goes. The only reason for doing this is to improve interoperability with other NFS servers, such as Linux, which reject non-reserved ports. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 951 1891 From owner-cvs-sbin Wed Apr 2 03:30:53 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id DAA24077 for cvs-sbin-outgoing; Wed, 2 Apr 1997 03:30:53 -0800 (PST) Received: (from dfr@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id DAA24065; Wed, 2 Apr 1997 03:30:47 -0800 (PST) Date: Wed, 2 Apr 1997 03:30:47 -0800 (PST) From: Doug Rabson Message-Id: <199704021130.DAA24065@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/mount_nfs mount_nfs.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk dfr 97/04/02 03:30:46 Modified: sbin/mount_nfs mount_nfs.c Log: Make "-o noxxx" work properly, allowing the user to clean e.g. the resvport flag (which is now set by default). Revision Changes Path 1.20 +47 -22 src/sbin/mount_nfs/mount_nfs.c From owner-cvs-sbin Wed Apr 2 08:52:49 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id IAA09289 for cvs-sbin-outgoing; Wed, 2 Apr 1997 08:52:49 -0800 (PST) Received: (from phk@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id IAA09281; Wed, 2 Apr 1997 08:52:47 -0800 (PST) Date: Wed, 2 Apr 1997 08:52:47 -0800 (PST) From: Poul-Henning Kamp Message-Id: <199704021652.IAA09281@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/route Makefile route.c ccitt_addr.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk phk 97/04/02 08:52:46 Modified: sbin/route Makefile route.c Removed: sbin/route ccitt_addr.c Log: unifdef CCITT, ISO & CRUFT. Revision Changes Path 1.8 +1 -1 src/sbin/route/Makefile 1.23 +1 -127 src/sbin/route/route.c From owner-cvs-sbin Wed Apr 2 08:56:31 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id IAA09622 for cvs-sbin-outgoing; Wed, 2 Apr 1997 08:56:31 -0800 (PST) Received: (from phk@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id IAA09613; Wed, 2 Apr 1997 08:56:27 -0800 (PST) Date: Wed, 2 Apr 1997 08:56:27 -0800 (PST) From: Poul-Henning Kamp Message-Id: <199704021656.IAA09613@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/route route.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk phk 97/04/02 08:56:26 Branch: sbin/route RELENG_2_2 Modified: sbin/route route.c Log: YAMFC (unifdef CCITT, ISO & CRUFT) Revision Changes Path 1.16.2.3 +1 -127 src/sbin/route/route.c From owner-cvs-sbin Wed Apr 2 08:56:49 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id IAA09701 for cvs-sbin-outgoing; Wed, 2 Apr 1997 08:56:49 -0800 (PST) Received: (from phk@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id IAA09694; Wed, 2 Apr 1997 08:56:47 -0800 (PST) Date: Wed, 2 Apr 1997 08:56:47 -0800 (PST) From: Poul-Henning Kamp Message-Id: <199704021656.IAA09694@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/route Makefile ccitt_addr.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk phk 97/04/02 08:56:47 Branch: sbin/route RELENG_2_2 Modified: sbin/route Makefile Removed: sbin/route ccitt_addr.c Log: Remove ccitt_addr.c file. Revision Changes Path 1.7.2.1 +1 -1 src/sbin/route/Makefile From owner-cvs-sbin Wed Apr 2 09:05:36 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id JAA10272 for cvs-sbin-outgoing; Wed, 2 Apr 1997 09:05:36 -0800 (PST) Received: (from phk@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id JAA10264; Wed, 2 Apr 1997 09:05:34 -0800 (PST) Date: Wed, 2 Apr 1997 09:05:34 -0800 (PST) From: Poul-Henning Kamp Message-Id: <199704021705.JAA10264@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/route route.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk phk 97/04/02 09:05:33 Modified: sbin/route route.c Log: Allow "modern" syntax: route add -net 192.168.64.0/20 bla bla bla Revision Changes Path 1.24 +21 -5 src/sbin/route/route.c From owner-cvs-sbin Wed Apr 2 09:06:24 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id JAA10396 for cvs-sbin-outgoing; Wed, 2 Apr 1997 09:06:24 -0800 (PST) Received: (from phk@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id JAA10389; Wed, 2 Apr 1997 09:06:22 -0800 (PST) Date: Wed, 2 Apr 1997 09:06:22 -0800 (PST) From: Poul-Henning Kamp Message-Id: <199704021706.JAA10389@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/route route.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk phk 97/04/02 09:06:22 Branch: sbin/route RELENG_2_2 Modified: sbin/route route.c Log: YAMFC (allow net/mask syntax) Revision Changes Path 1.16.2.4 +21 -5 src/sbin/route/route.c From owner-cvs-sbin Wed Apr 2 09:37:45 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id JAA12067 for cvs-sbin-outgoing; Wed, 2 Apr 1997 09:37:45 -0800 (PST) Received: from alpha.xerox.com (alpha.Xerox.COM [13.1.64.93]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id JAA12032; Wed, 2 Apr 1997 09:37:18 -0800 (PST) Received: from crevenia.parc.xerox.com ([13.2.116.11]) by alpha.xerox.com with SMTP id <18031(3)>; Wed, 2 Apr 1997 09:35:36 PST Received: from localhost by crevenia.parc.xerox.com with SMTP id <177486>; Wed, 2 Apr 1997 09:34:39 -0800 To: Poul-Henning Kamp cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/route route.c In-reply-to: Your message of "Wed, 02 Apr 97 09:05:34 PST." <199704021705.JAA10264@freefall.freebsd.org> Date: Wed, 2 Apr 1997 09:34:36 PST From: Bill Fenner Message-Id: <97Apr2.093439pst.177486@crevenia.parc.xerox.com> Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Poul-Henning Kamp wrote: > Allow "modern" syntax: > route add -net 192.168.64.0/20 bla bla bla Do you allow "224/4", or does it have to be "224.0.0.0/4"? Bill From owner-cvs-sbin Wed Apr 2 09:59:45 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id JAA13039 for cvs-sbin-outgoing; Wed, 2 Apr 1997 09:59:45 -0800 (PST) Received: from critter.dk.tfs.com (phk.cybercity.dk [195.8.133.247]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id JAA13032; Wed, 2 Apr 1997 09:59:37 -0800 (PST) Received: from critter (localhost [127.0.0.1]) by critter.dk.tfs.com (8.8.5/8.8.5) with ESMTP id TAA00404; Wed, 2 Apr 1997 19:58:25 +0200 (CEST) To: Bill Fenner cc: Poul-Henning Kamp , CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/route route.c In-reply-to: Your message of "Wed, 02 Apr 1997 09:34:36 PST." <97Apr2.093439pst.177486@crevenia.parc.xerox.com> Date: Wed, 02 Apr 1997 19:58:24 +0200 Message-ID: <402.860003904@critter> From: Poul-Henning Kamp Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk In message <97Apr2.093439pst.177486@crevenia.parc.xerox.com>, Bill Fenner write s: >Poul-Henning Kamp wrote: >> Allow "modern" syntax: >> route add -net 192.168.64.0/20 bla bla bla > >Do you allow "224/4", or does it have to be "224.0.0.0/4"? Currently 224.0.0.0/4 as you can see from my other mail I've started lobbying (again) for fixing the broken return from inet_ntoa("10.23"); -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@tfs.com TRW Financial Systems, Inc. Power and ignorance is a disgusting cocktail.