From owner-cvs-games Thu Feb 26 13:15:21 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id NAA26232 for cvs-games-outgoing; Thu, 26 Feb 1998 13:15:21 -0800 (PST) (envelope-from owner-cvs-games) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA26047; Thu, 26 Feb 1998 13:13:51 -0800 (PST) (envelope-from steve@FreeBSD.org) From: Steve Price Received: (from steve@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id NAA27410; Thu, 26 Feb 1998 13:13:18 -0800 (PST) Date: Thu, 26 Feb 1998 13:13:18 -0800 (PST) Message-Id: <199802262113.NAA27410@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-games@FreeBSD.ORG Subject: cvs commit: src/games/number number.c Sender: owner-cvs-games@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk steve 1998/02/26 13:13:17 PST Modified files: games/number number.c Log: Fix a core dump caused by negative numbers. PR: 5858 Submitted by: Max Euston Revision Changes Path 1.6 +1 -0 src/games/number/number.c From owner-cvs-games Thu Feb 26 13:15:34 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id NAA26273 for cvs-games-outgoing; Thu, 26 Feb 1998 13:15:34 -0800 (PST) (envelope-from owner-cvs-games) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA26227; Thu, 26 Feb 1998 13:15:20 -0800 (PST) (envelope-from steve@FreeBSD.org) From: Steve Price Received: (from steve@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id NAA27469; Thu, 26 Feb 1998 13:14:46 -0800 (PST) Date: Thu, 26 Feb 1998 13:14:46 -0800 (PST) Message-Id: <199802262114.NAA27469@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-games@FreeBSD.ORG Subject: cvs commit: src/games/number number.c Sender: owner-cvs-games@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk steve 1998/02/26 13:14:46 PST Modified files: (Branch: RELENG_2_2) games/number number.c Log: MFC: allow a negative number without a core dump Revision Changes Path 1.2.6.2 +1 -0 src/games/number/number.c From owner-cvs-games Sat Feb 28 21:11:40 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA11259 for cvs-games-outgoing; Sat, 28 Feb 1998 21:11:40 -0800 (PST) (envelope-from owner-cvs-games) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA11203; Sat, 28 Feb 1998 21:11:21 -0800 (PST) (envelope-from jkh@FreeBSD.org) From: "Jordan K. Hubbard" Received: (from jkh@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id VAA05161; Sat, 28 Feb 1998 21:10:29 -0800 (PST) Date: Sat, 28 Feb 1998 21:10:29 -0800 (PST) Message-Id: <199803010510.VAA05161@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-games@FreeBSD.ORG Subject: cvs commit: src/games/arithmetic arithmetic.c src/games/cribbage crib.c src/games/factor factor.c src/games/fish fish.c src/games/morse morse.c src/games/number number.c src/games/phantasia setup.c src/games/piano piano.c src/games/pig ... Sender: owner-cvs-games@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 1998/02/28 21:10:29 PST Modified files: games/arithmetic arithmetic.c games/cribbage crib.c games/factor factor.c games/fish fish.c games/morse morse.c games/number number.c games/phantasia setup.c games/piano piano.c games/pig pig.c games/primes primes.c games/quiz quiz.c games/random random.c games/worms worms.c games/wump wump.c Log: Wargh! Who went and changed all the getopt() comparisons from -1 to EOF? The getopt(3) manpage clearly states that the return value is *-1*, not EOF! Besides, getopt(3) isn't reading from a file. :) Noticed-while: merging to 2.2 (where this is correct). Revision Changes Path 1.4 +1 -1 src/games/arithmetic/arithmetic.c 1.5 +1 -1 src/games/cribbage/crib.c 1.6 +1 -1 src/games/factor/factor.c 1.4 +1 -1 src/games/fish/fish.c 1.6 +1 -1 src/games/morse/morse.c 1.7 +1 -1 src/games/number/number.c 1.7 +1 -1 src/games/phantasia/setup.c 1.5 +2 -2 src/games/piano/piano.c 1.4 +1 -1 src/games/pig/pig.c 1.6 +1 -1 src/games/primes/primes.c 1.8 +1 -1 src/games/quiz/quiz.c 1.9 +1 -1 src/games/random/random.c 1.5 +1 -1 src/games/worms/worms.c 1.6 +2 -2 src/games/wump/wump.c From owner-cvs-games Sat Feb 28 21:46:38 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA18522 for cvs-games-outgoing; Sat, 28 Feb 1998 21:46:38 -0800 (PST) (envelope-from owner-cvs-games) Received: from rover.village.org (rover.village.org [204.144.255.49]) by hub.freebsd.org (8.8.8/8.8.8) with SMTP id VAA18458; Sat, 28 Feb 1998 21:46:18 -0800 (PST) (envelope-from imp@village.org) Received: from harmony [10.0.0.6] by rover.village.org with esmtp (Exim 1.71 #1) id 0y91Zc-00008b-00; Sat, 28 Feb 1998 22:46:04 -0700 Received: from harmony.village.org (localhost [127.0.0.1]) by harmony.village.org (8.8.8/8.8.3) with ESMTP id WAA00709; Sat, 28 Feb 1998 22:45:42 -0700 (MST) Message-Id: <199803010545.WAA00709@harmony.village.org> To: "Jordan K. Hubbard" Subject: Re: cvs commit: src/games/arithmetic arithmetic.c src/games/cribbage crib.c src/games/factor factor.c src/games/fish fish.c src/games/morse morse.c src/games/number number.c src/games/phantasia setup.c src/games/piano piano.c src/games/pig ... Cc: cvs-committers@freebsd.org, cvs-all@freebsd.org, cvs-games@freebsd.org In-reply-to: Your message of "Sat, 28 Feb 1998 21:10:29 PST." <199803010510.VAA05161@freefall.freebsd.org> References: <199803010510.VAA05161@freefall.freebsd.org> Date: Sat, 28 Feb 1998 22:45:42 -0700 From: Warner Losh Sender: owner-cvs-games@freebsd.org X-Loop: FreeBSD.org Precedence: bulk In message <199803010510.VAA05161@freefall.freebsd.org> "Jordan K. Hubbard" writes: : Wargh! Who went and changed all the getopt() comparisons from -1 to : EOF? The getopt(3) manpage clearly states that the return value is *-1*, : not EOF! Besides, getopt(3) isn't reading from a file. :) ooops. I thought that I had done this in -current, but looking at the logs it appears that I didn't... So this was the original code never changed. EOF was the original definition a long time ago... Warner From owner-cvs-games Sat Feb 28 22:55:24 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA01089 for cvs-games-outgoing; Sat, 28 Feb 1998 22:55:24 -0800 (PST) (envelope-from owner-cvs-games) Received: from time.cdrom.com (root@time.cdrom.com [204.216.27.226]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id WAA01081; Sat, 28 Feb 1998 22:55:19 -0800 (PST) (envelope-from jkh@time.cdrom.com) Received: from time.cdrom.com (jkh@localhost.cdrom.com [127.0.0.1]) by time.cdrom.com (8.8.8/8.6.9) with ESMTP id WAA16674; Sat, 28 Feb 1998 22:55:13 -0800 (PST) To: Warner Losh cc: "Jordan K. Hubbard" , cvs-committers@freebsd.org, cvs-all@freebsd.org, cvs-games@freebsd.org Subject: Re: cvs commit: src/games/arithmetic arithmetic.c src/games/cribbage crib.c src/games/factor factor.c src/games/fish fish.c src/games/morse morse.c src/games/number number.c src/games/phantasia setup.c src/games/piano piano.c src/games/pig ... In-reply-to: Your message of "Sat, 28 Feb 1998 22:45:42 MST." <199803010545.WAA00709@harmony.village.org> Date: Sat, 28 Feb 1998 22:55:13 -0800 Message-ID: <16671.888735313@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-games@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > ooops. I thought that I had done this in -current, but looking at the > logs it appears that I didn't... > > So this was the original code never changed. EOF was the original > definition a long time ago... Ah, thanks for clearing up this mystery. I remember the changes going in and just assumed that they'd gone to -current first and been merged afterwards. Seeing them not in -current made me think that they'd been changed back. Jordan