From owner-cvs-sys Sun Apr 12 05:12:05 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id FAA00355 for cvs-sys-outgoing; Sun, 12 Apr 1998 05:12:05 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA00292; Sun, 12 Apr 1998 05:11:54 -0700 (PDT) (envelope-from phk@FreeBSD.org) From: Poul-Henning Kamp Received: (from phk@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id FAA08765; Sun, 12 Apr 1998 05:11:32 -0700 (PDT) Date: Sun, 12 Apr 1998 05:11:32 -0700 (PDT) Message-Id: <199804121211.FAA08765@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/i386/isa aic6360.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk phk 1998/04/12 05:11:32 PDT Modified files: sys/i386/isa aic6360.c Log: Aic APM driver support for e.g. Toshiba T2400 notebook with internal Adaptec SCSI (aic6360/aha152x) controller. PR: 5382 Reviewed by: phk Submitted by: Oliver Breuninger Revision Changes Path 1.39 +59 -2 src/sys/i386/isa/aic6360.c From owner-cvs-sys Sun Apr 12 08:04:38 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id IAA15032 for cvs-sys-outgoing; Sun, 12 Apr 1998 08:04:38 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id IAA14995; Sun, 12 Apr 1998 08:04:27 -0700 (PDT) (envelope-from kato@FreeBSD.org) From: KATO Takenori Received: (from kato@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id IAA03249; Sun, 12 Apr 1998 08:04:04 -0700 (PDT) Date: Sun, 12 Apr 1998 08:04:04 -0700 (PDT) Message-Id: <199804121504.IAA03249@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pc98/conf GENERIC98 Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk kato 1998/04/12 08:04:04 PDT Modified files: (Branch: RELENG_2_2) sys/pc98/conf GENERIC98 Log: Sync with sys/i386/conf/GENERIC revision 1.77.2.21. Submitted by: NOKUBI Hirotaka Revision Changes Path 1.8.2.20 +8 -1 src/sys/pc98/conf/GENERIC98 From owner-cvs-sys Sun Apr 12 08:05:17 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id IAA15102 for cvs-sys-outgoing; Sun, 12 Apr 1998 08:05:17 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id IAA15058; Sun, 12 Apr 1998 08:05:10 -0700 (PDT) (envelope-from kato@FreeBSD.org) From: KATO Takenori Received: (from kato@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id IAA03276; Sun, 12 Apr 1998 08:04:47 -0700 (PDT) Date: Sun, 12 Apr 1998 08:04:47 -0700 (PDT) Message-Id: <199804121504.IAA03276@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pc98/i386 machdep.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk kato 1998/04/12 08:04:47 PDT Modified files: (Branch: RELENG_2_2) sys/pc98/i386 machdep.c Log: Sync with sys/i386/i386/machdep.c revision 1.209.2.22. Submitted by: NOKUBI Hirotaka Revision Changes Path 1.11.2.24 +1 -2 src/sys/pc98/i386/machdep.c From owner-cvs-sys Sun Apr 12 08:06:00 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id IAA15170 for cvs-sys-outgoing; Sun, 12 Apr 1998 08:06:00 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id IAA15135; Sun, 12 Apr 1998 08:05:52 -0700 (PDT) (envelope-from kato@FreeBSD.org) From: KATO Takenori Received: (from kato@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id IAA03306; Sun, 12 Apr 1998 08:05:29 -0700 (PDT) Date: Sun, 12 Apr 1998 08:05:29 -0700 (PDT) Message-Id: <199804121505.IAA03306@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pc98/conf files.pc98 Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk kato 1998/04/12 08:05:28 PDT Modified files: (Branch: RELENG_2_2) sys/pc98/conf files.pc98 Log: Sync with sys/i386/conf/files.i386 revision 1.141.2.20. Submitted by: NOKUBI Hirotaka Revision Changes Path 1.9.2.22 +3 -3 src/sys/pc98/conf/files.pc98 From owner-cvs-sys Sun Apr 12 08:06:43 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id IAA15330 for cvs-sys-outgoing; Sun, 12 Apr 1998 08:06:43 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id IAA15275; Sun, 12 Apr 1998 08:06:31 -0700 (PDT) (envelope-from kato@FreeBSD.org) From: KATO Takenori Received: (from kato@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id IAA03333; Sun, 12 Apr 1998 08:06:08 -0700 (PDT) Date: Sun, 12 Apr 1998 08:06:08 -0700 (PDT) Message-Id: <199804121506.IAA03333@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pc98/conf GENERIC98 Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk kato 1998/04/12 08:06:07 PDT Modified files: (Branch: RELENG_2_2) sys/pc98/conf GENERIC98 Log: Sync with sys/i386/conf/GENERIC revision 1.77.2.22. Submitted by: NOKUBI Hirotaka Revision Changes Path 1.8.2.21 +6 -6 src/sys/pc98/conf/GENERIC98 From owner-cvs-sys Mon Apr 13 01:36:17 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id BAA05085 for cvs-sys-outgoing; Mon, 13 Apr 1998 01:36:17 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA04996; Mon, 13 Apr 1998 01:36:08 -0700 (PDT) (envelope-from kato@FreeBSD.org) From: KATO Takenori Received: (from kato@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id BAA10652; Mon, 13 Apr 1998 01:35:39 -0700 (PDT) Date: Mon, 13 Apr 1998 01:35:39 -0700 (PDT) Message-Id: <199804130835.BAA10652@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pc98/pc98 wd.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk kato 1998/04/13 01:35:39 PDT Modified files: sys/pc98/pc98 wd.c Log: Sync with sys/i386/isa/wd.c revision 1.156. Revision Changes Path 1.47 +2 -2 src/sys/pc98/pc98/wd.c From owner-cvs-sys Mon Apr 13 07:16:18 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id HAA00661 for cvs-sys-outgoing; Mon, 13 Apr 1998 07:16:18 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id OAA00578; Mon, 13 Apr 1998 14:16:12 GMT (envelope-from semenu@FreeBSD.org) From: Ustimenko Semen Received: (from semenu@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id HAA07794; Mon, 13 Apr 1998 07:15:41 -0700 (PDT) Date: Mon, 13 Apr 1998 07:15:41 -0700 (PDT) Message-Id: <199804131415.HAA07794@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pci if_tx.c smc83c170.h Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk semenu 1998/04/13 07:15:41 PDT Modified files: sys/pci if_tx.c smc83c170.h Log: Fixed autonegotiation. Card registers are now accessed via memory not i/o space. Revision Changes Path 1.9 +218 -143 src/sys/pci/if_tx.c 1.6 +44 -29 src/sys/pci/smc83c170.h From owner-cvs-sys Mon Apr 13 10:28:29 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA11544 for cvs-sys-outgoing; Mon, 13 Apr 1998 10:28:29 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA11281; Mon, 13 Apr 1998 17:27:42 GMT (envelope-from phk@FreeBSD.org) From: Poul-Henning Kamp Received: (from phk@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id KAA09470; Mon, 13 Apr 1998 10:27:10 -0700 (PDT) Date: Mon, 13 Apr 1998 10:27:10 -0700 (PDT) Message-Id: <199804131727.KAA09470@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/netinet ip_input.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk phk 1998/04/13 10:27:09 PDT Modified files: sys/netinet ip_input.c Log: Wrong header length used for certain reassembled IP packets. PR: 6177 Reviewed by: phk, wollman Submitted by: Eric Sprinkle Revision Changes Path 1.82 +3 -1 src/sys/netinet/ip_input.c From owner-cvs-sys Mon Apr 13 10:47:30 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA15352 for cvs-sys-outgoing; Mon, 13 Apr 1998 10:47:30 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA15127; Mon, 13 Apr 1998 17:46:29 GMT (envelope-from msmith@FreeBSD.org) From: Michael Smith Received: (from msmith@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id KAA09774; Mon, 13 Apr 1998 10:45:58 -0700 (PDT) Date: Mon, 13 Apr 1998 10:45:58 -0700 (PDT) Message-Id: <199804131745.KAA09774@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/i386/isa atapi.c atapi.h Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk msmith 1998/04/13 10:45:57 PDT Modified files: sys/i386/isa atapi.c atapi.h Log: Don't use INTR when only one device supports it. Submitted by: Satoh Junichi Revision Changes Path 1.25 +10 -1 src/sys/i386/isa/atapi.c 1.13 +1 -0 src/sys/i386/isa/atapi.h From owner-cvs-sys Mon Apr 13 10:47:35 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA15362 for cvs-sys-outgoing; Mon, 13 Apr 1998 10:47:35 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA14924; Mon, 13 Apr 1998 17:45:33 GMT (envelope-from sos@FreeBSD.org) From: Søren Schmidt Received: (from sos@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id KAA09747; Mon, 13 Apr 1998 10:45:01 -0700 (PDT) Date: Mon, 13 Apr 1998 10:45:01 -0700 (PDT) Message-Id: <199804131745.KAA09747@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/sys errno.h Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk sos 1998/04/13 10:45:01 PDT Modified files: sys/sys errno.h Log: Add EIDRM errno (PR 176), ENOMSG errno (myself) for prober sysv_ipc. Revision Changes Path 1.9 +5 -2 src/sys/sys/errno.h From owner-cvs-sys Mon Apr 13 10:51:13 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA16172 for cvs-sys-outgoing; Mon, 13 Apr 1998 10:51:13 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA15768; Mon, 13 Apr 1998 17:50:05 GMT (envelope-from msmith@FreeBSD.org) From: Michael Smith Received: (from msmith@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id KAA09870; Mon, 13 Apr 1998 10:49:33 -0700 (PDT) Date: Mon, 13 Apr 1998 10:49:33 -0700 (PDT) Message-Id: <199804131749.KAA09870@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/i386/isa atapi.c atapi.h Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk msmith 1998/04/13 10:49:33 PDT Modified files: (Branch: RELENG_2_2) sys/i386/isa atapi.c atapi.h Log: MFC - don't use INTR mixed with ACCEL. Submitted by: Satoh Junichi Revision Changes Path 1.15.2.5 +10 -1 src/sys/i386/isa/atapi.c 1.8.2.2 +1 -0 src/sys/i386/isa/atapi.h From owner-cvs-sys Mon Apr 13 10:51:39 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA16256 for cvs-sys-outgoing; Mon, 13 Apr 1998 10:51:39 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA15894; Mon, 13 Apr 1998 17:50:25 GMT (envelope-from sos@FreeBSD.org) From: Søren Schmidt Received: (from sos@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id KAA09898; Mon, 13 Apr 1998 10:49:53 -0700 (PDT) Date: Mon, 13 Apr 1998 10:49:53 -0700 (PDT) Message-Id: <199804131749.KAA09898@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/i386/linux linux_sysvec.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk sos 1998/04/13 10:49:52 PDT Modified files: sys/i386/linux linux_sysvec.c Log: Added EIDRM & ENOMSG to errno translation table. Revision Changes Path 1.27 +2 -2 src/sys/i386/linux/linux_sysvec.c From owner-cvs-sys Mon Apr 13 10:54:04 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA16811 for cvs-sys-outgoing; Mon, 13 Apr 1998 10:54:04 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA16453; Mon, 13 Apr 1998 17:53:14 GMT (envelope-from sos@FreeBSD.org) From: Søren Schmidt Received: (from sos@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id KAA09938; Mon, 13 Apr 1998 10:52:42 -0700 (PDT) Date: Mon, 13 Apr 1998 10:52:42 -0700 (PDT) Message-Id: <199804131752.KAA09938@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/i386/ibcs2 ibcs2_errno.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk sos 1998/04/13 10:52:42 PDT Modified files: sys/i386/ibcs2 ibcs2_errno.c Log: Added EIDRM & ENOMSG errno in translation table. Revision Changes Path 1.3 +2 -0 src/sys/i386/ibcs2/ibcs2_errno.c From owner-cvs-sys Mon Apr 13 16:41:26 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id QAA25324 for cvs-sys-outgoing; Mon, 13 Apr 1998 16:41:26 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from frmug.org (frmug-gw.frmug.org [193.56.58.252]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA25010; Mon, 13 Apr 1998 23:40:12 GMT (envelope-from pb@fasterix.frmug.org) Received: (from uucp@localhost) by frmug.org (8.8.8/frmug-2.2/nospam) with UUCP id BAA09611; Tue, 14 Apr 1998 01:40:04 +0200 (CEST) (envelope-from pb@fasterix.frmug.org) Received: (from pb@localhost) by fasterix.frmug.org (8.8.8/8.8.5/pb-19970302) id BAA12684; Tue, 14 Apr 1998 01:38:25 +0200 (CEST) Message-ID: <19980414013825.TH38245@@> Date: Tue, 14 Apr 1998 01:38:25 +0200 From: pb@fasterix.freenix.org (Pierre Beyssac) To: phk@FreeBSD.ORG (Poul-Henning Kamp) Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern uipc_syscalls.c References: <199804112031.NAA01564@freefall.freebsd.org> X-Mailer: Mutt 0.59.1e Mime-Version: 1.0 In-Reply-To: <199804112031.NAA01564@freefall.freebsd.org>; from Poul-Henning Kamp on Apr 11, 1998 13:31:46 -0700 Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Poul-Henning Kamp writes: > setsockopt() transports user option data in an mbuf. if the user > data is greater than MLEN, setsockopt is unable to pass it onto > the protocol handler. Allocate a cluster in such case. Hum, there is a very similar patch in the INRIA IPv6 patches, except it does an additional m_free(m) before returning. Shouldn't the following patch be added to your code to avoid a mbuf leak ? --- uipc_syscalls.c.orig Mon Apr 13 02:01:29 1998 +++ uipc_syscalls.c Tue Apr 14 01:31:09 1998 @@ -992,10 +992,12 @@ if (m == NULL) return (ENOBUFS); if (uap->valsize > MLEN) { MCLGET(m, M_WAIT); - if(!(m->m_flags & M_EXT)) + if(!(m->m_flags & M_EXT)) { + m_free(m); return (ENOBUFS); + } } error = copyin(uap->val, mtod(m, caddr_t), (u_int)uap->valsize); if (error) { (void) m_free(m); -- Pierre Beyssac pb@fasterix.frmug.org pb@fasterix.freenix.org {Free,Net,Open}BSD, Linux : il y a moins bien, mais c'est plus cher Free domains: http://www.eu.org/ or mail dns-manager@EU.org From owner-cvs-sys Mon Apr 13 23:27:34 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id XAA04989 for cvs-sys-outgoing; Mon, 13 Apr 1998 23:27:34 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from critter.freebsd.dk (critter.freebsd.dk [195.8.129.14]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id GAA04864; Tue, 14 Apr 1998 06:26:52 GMT (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.8.7/8.8.5) with ESMTP id IAA22151; Tue, 14 Apr 1998 08:24:53 +0200 (CEST) To: pb@fasterix.freenix.org (Pierre Beyssac) cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern uipc_syscalls.c In-reply-to: Your message of "Tue, 14 Apr 1998 01:38:25 +0200." <19980414013825.TH38245@@> Date: Tue, 14 Apr 1998 08:24:53 +0200 Message-ID: <22149.892535093@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Committed, Thanks! Poul-Henning -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." "Drink MONO-tonic, it goes down but it will NEVER come back up!" From owner-cvs-sys Mon Apr 13 23:28:41 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id XAA05520 for cvs-sys-outgoing; Mon, 13 Apr 1998 23:28:41 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id GAA04517; Tue, 14 Apr 1998 06:25:21 GMT (envelope-from phk@FreeBSD.org) From: Poul-Henning Kamp Received: (from phk@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id XAA13347; Mon, 13 Apr 1998 23:24:45 -0700 (PDT) Date: Mon, 13 Apr 1998 23:24:45 -0700 (PDT) Message-Id: <199804140624.XAA13347@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/kern uipc_syscalls.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk phk 1998/04/13 23:24:45 PDT Modified files: sys/kern uipc_syscalls.c Log: Fix a minor mbuf leak created by the previous change. Reviewed by: phk Submitted by: pb@fasterix.freenix.org (Pierre Beyssac) Revision Changes Path 1.39 +4 -2 src/sys/kern/uipc_syscalls.c From owner-cvs-sys Tue Apr 14 06:53:42 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id GAA16453 for cvs-sys-outgoing; Tue, 14 Apr 1998 06:53:42 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA15935; Tue, 14 Apr 1998 13:52:01 GMT (envelope-from kato@FreeBSD.org) From: KATO Takenori Received: (from kato@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id GAA09295; Tue, 14 Apr 1998 06:51:22 -0700 (PDT) Date: Tue, 14 Apr 1998 06:51:22 -0700 (PDT) Message-Id: <199804141351.GAA09295@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pc98/pc98 if_ed.c if_ed98.h Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk kato 1998/04/14 06:51:22 PDT Modified files: sys/pc98/pc98 if_ed.c if_ed98.h Log: Fix page fault panic by probing NE200 compatible PCI card. Submitted by: chi@bd.mbn.or.jp (Chiharu Shibata) Revision Changes Path 1.45 +7 -12 src/sys/pc98/pc98/if_ed.c 1.14 +10 -3 src/sys/pc98/pc98/if_ed98.h From owner-cvs-sys Tue Apr 14 06:54:05 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id GAA16482 for cvs-sys-outgoing; Tue, 14 Apr 1998 06:54:05 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA16323; Tue, 14 Apr 1998 13:53:10 GMT (envelope-from kato@FreeBSD.org) From: KATO Takenori Received: (from kato@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id GAA09335; Tue, 14 Apr 1998 06:52:31 -0700 (PDT) Date: Tue, 14 Apr 1998 06:52:31 -0700 (PDT) Message-Id: <199804141352.GAA09335@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pc98/pc98 if_ed.c if_ed98.h Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk kato 1998/04/14 06:52:31 PDT Modified files: (Branch: RELENG_2_2) sys/pc98/pc98 if_ed.c if_ed98.h Log: MFC: Fix panic by probing NE2000 compatible PCI card. Revision Changes Path 1.11.2.13 +7 -12 src/sys/pc98/pc98/if_ed.c 1.6.2.8 +10 -3 src/sys/pc98/pc98/if_ed98.h From owner-cvs-sys Wed Apr 15 04:07:04 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id EAA28720 for cvs-sys-outgoing; Wed, 15 Apr 1998 04:07:04 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id LAA28289; Wed, 15 Apr 1998 11:05:40 GMT (envelope-from dt@FreeBSD.org) From: Dmitrij Tejblum Received: (from dt@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id EAA16583; Wed, 15 Apr 1998 04:04:54 -0700 (PDT) Date: Wed, 15 Apr 1998 04:04:54 -0700 (PDT) Message-Id: <199804151104.EAA16583@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/msdosfs msdosfs_vfsops.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk dt 1998/04/15 04:04:54 PDT Modified files: sys/msdosfs msdosfs_vfsops.c Log: Add a missing LK_RETRY. Noticed by: Bruce (almost 2 monts ago) Remove a debugging printf. Revision Changes Path 1.33 +3 -5 src/sys/msdosfs/msdosfs_vfsops.c From owner-cvs-sys Wed Apr 15 04:12:25 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id EAA00523 for cvs-sys-outgoing; Wed, 15 Apr 1998 04:12:25 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id LAA29925; Wed, 15 Apr 1998 11:11:14 GMT (envelope-from bde@FreeBSD.org) From: Bruce Evans Received: (from bde@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id EAA16630; Wed, 15 Apr 1998 04:10:29 -0700 (PDT) Date: Wed, 15 Apr 1998 04:10:29 -0700 (PDT) Message-Id: <199804151110.EAA16630@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/i386/i386 exception.s Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk bde 1998/04/15 04:10:29 PDT Modified files: sys/i386/i386 exception.s Log: Fixed breakage of fork accounting in previous commit. A fork benchmark reported about 15 times as much sys time as real time. getmicroruntime() is confusing name. Revision Changes Path 1.50 +2 -2 src/sys/i386/i386/exception.s From owner-cvs-sys Wed Apr 15 05:02:02 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id FAA08262 for cvs-sys-outgoing; Wed, 15 Apr 1998 05:02:02 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id MAA08041; Wed, 15 Apr 1998 12:01:01 GMT (envelope-from des@FreeBSD.org) From: "Dag-Erling C. Sm\xf8rgrav" Received: (from des@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id FAA16764; Wed, 15 Apr 1998 05:00:15 -0700 (PDT) Date: Wed, 15 Apr 1998 05:00:15 -0700 (PDT) Message-Id: <199804151200.FAA16764@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/i386/isa syscons.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk des 1998/04/15 05:00:15 PDT Modified files: (Branch: 1.182.2) sys/i386/isa syscons.c Log: Swapped "should we just return" and "should we stop the screensaver" in scrn_timer() to prevent deadlock when screensaver sets UNKNOWN_MODE. Revision Changes Path 1.182.2.32 +8 -8 src/sys/i386/isa/syscons.c From owner-cvs-sys Wed Apr 15 05:29:12 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id FAA14527 for cvs-sys-outgoing; Wed, 15 Apr 1998 05:29:12 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id MAA14319; Wed, 15 Apr 1998 12:28:19 GMT (envelope-from bde@FreeBSD.org) From: Bruce Evans Received: (from bde@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id FAA18164; Wed, 15 Apr 1998 05:27:33 -0700 (PDT) Date: Wed, 15 Apr 1998 05:27:33 -0700 (PDT) Message-Id: <199804151227.FAA18164@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/ufs/ufs ufs_lookup.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk bde 1998/04/15 05:27:33 PDT Modified files: sys/ufs/ufs ufs_lookup.c Log: Fixed bitrot in the non-softdep case of ufs_dirremove(): - restored async mount support. The first entry in a block is still always written synchronously, although it probably shouldn't be in the async case. - restored use of BWRITE() instead of bowrite() for the DOWHITEOUT case, although bowrite() is probably better. Broken by: merge of softdep changes (rev.1.22). Found by: lmbench2 delete-file benchmarks. Revision Changes Path 1.24 +9 -24 src/sys/ufs/ufs/ufs_lookup.c From owner-cvs-sys Wed Apr 15 10:12:26 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA13572 for cvs-sys-outgoing; Wed, 15 Apr 1998 10:12:26 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA12204; Wed, 15 Apr 1998 17:07:42 GMT (envelope-from phk@FreeBSD.org) From: Poul-Henning Kamp Received: (from phk@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id KAA17372; Wed, 15 Apr 1998 10:06:53 -0700 (PDT) Date: Wed, 15 Apr 1998 10:06:53 -0700 (PDT) Message-Id: <199804151706.KAA17372@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/i386/isa psm.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk phk 1998/04/15 10:06:53 PDT Modified files: sys/i386/isa psm.c Log: In pre-devfs days, /dev/psm0 had always been a non-blocking device. But with devfs, currently, /dev/psm0 is the blocking device and /dev/npsm0 is the non-blocking one. DEVFS must stay consistent with the older behaviour. PR: 6260 Reviewed by: phk Submitted by: Kapil Chowksey Revision Changes Path 1.52 +6 -6 src/sys/i386/isa/psm.c From owner-cvs-sys Wed Apr 15 10:29:31 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA19751 for cvs-sys-outgoing; Wed, 15 Apr 1998 10:29:31 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA18697; Wed, 15 Apr 1998 17:27:07 GMT (envelope-from bde@FreeBSD.org) From: Bruce Evans Received: (from bde@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id KAA17585; Wed, 15 Apr 1998 10:26:19 -0700 (PDT) Date: Wed, 15 Apr 1998 10:26:19 -0700 (PDT) Message-Id: <199804151726.KAA17585@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/i386/i386 in_cksum.c src/sys/i386/isa seagate.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk bde 1998/04/15 10:26:18 PDT Modified files: sys/i386/i386 in_cksum.c sys/i386/isa seagate.c Log: Support compiling with `gcc -ansi'. Fix missing `volatile's in __asm() statements while I'm here. Revision Changes Path 1.13 +9 -5 src/sys/i386/i386/in_cksum.c 1.28 +8 -8 src/sys/i386/isa/seagate.c From owner-cvs-sys Wed Apr 15 10:49:55 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA27011 for cvs-sys-outgoing; Wed, 15 Apr 1998 10:49:55 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA26346; Wed, 15 Apr 1998 17:48:29 GMT (envelope-from bde@FreeBSD.org) From: Bruce Evans Received: (from bde@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id KAA18484; Wed, 15 Apr 1998 10:47:41 -0700 (PDT) Date: Wed, 15 Apr 1998 10:47:41 -0700 (PDT) Message-Id: <199804151747.KAA18484@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/dev/en midway.c src/sys/dev/ppbus vpo.c src/sys/gnu/ext2fs ext2_linux_balloc.c i386-bitops.h src/sys/gnu/i386/isa dgb.c src/sys/i386/i386 identcpu.c pmap.c trap.c vm86.c src/sys/i386/isa aic6360.c if_ed.c if_el.c if_ie.c ... Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk bde 1998/04/15 10:47:41 PDT Modified files: sys/dev/en midway.c sys/dev/ppbus vpo.c sys/gnu/ext2fs ext2_linux_balloc.c i386-bitops.h sys/gnu/i386/isa dgb.c sys/i386/i386 identcpu.c pmap.c trap.c vm86.c sys/i386/isa aic6360.c if_ed.c if_el.c if_ie.c if_lnc.c if_ze.c istallion.c labpc.c lpt.c ncr5380.c pcaudio.c pcic.h prof_machdep.c random_machdep.c rp.c scd.c stallion.c wcd.c sys/i386/isa/ic i82586.h sys/i386/isa/pcvt pcvt_kbd.c sys/i386/isa/sound audio.c sys/i386/scsi aic7xxx.c sys/kern md5c.c subr_prof.c subr_rlist.c tty_subr.c vfs_bio.c sys/libkern qsort.c sys/msdosfs msdosfs_conv.c msdosfs_fat.c sys/net if_var.h ppp_tty.c sys/netinet ip_fw.c sys/pccard pcic.c sys/pci ide_pci.c if_fxp.c if_tx.c smc83c170.h sys/posix4 ksched.c sys/scsi cd.c od.c sd.c worm.c sys/sys dpt.h kernel.h sys/vm swap_pager.c vm_page.c vm_zone.c Log: Support compiling with `gcc -ansi'. Revision Changes Path 1.6 +1 -1 src/sys/dev/en/midway.c 1.5 +8 -8 src/sys/dev/ppbus/vpo.c 1.8 +5 -5 src/sys/gnu/ext2fs/ext2_linux_balloc.c 1.3 +4 -4 src/sys/gnu/ext2fs/i386-bitops.h 1.32 +9 -9 src/sys/gnu/i386/isa/dgb.c 1.44 +3 -3 src/sys/i386/i386/identcpu.c 1.192 +3 -3 src/sys/i386/i386/pmap.c 1.126 +4 -4 src/sys/i386/i386/trap.c 1.12 +8 -8 src/sys/i386/i386/vm86.c 1.40 +3 -3 src/sys/i386/isa/aic6360.c 1.139 +8 -8 src/sys/i386/isa/if_ed.c 1.35 +5 -5 src/sys/i386/isa/if_el.c 1.52 +10 -10 src/sys/i386/isa/if_ie.c 1.39 +22 -20 src/sys/i386/isa/if_lnc.c 1.52 +8 -7 src/sys/i386/isa/if_ze.c 1.18 +8 -7 src/sys/i386/isa/istallion.c 1.24 +4 -4 src/sys/i386/isa/labpc.c 1.68 +4 -4 src/sys/i386/isa/lpt.c 1.19 +2 -2 src/sys/i386/isa/ncr5380.c 1.40 +2 -2 src/sys/i386/isa/pcaudio.c 1.5 +4 -4 src/sys/i386/isa/pcic.h 1.9 +4 -4 src/sys/i386/isa/prof_machdep.c 1.25 +3 -3 src/sys/i386/isa/random_machdep.c 1.13 +1 -1 src/sys/i386/isa/rp.c 1.36 +3 -3 src/sys/i386/isa/scd.c 1.19 +7 -7 src/sys/i386/isa/stallion.c 1.52 +2 -2 src/sys/i386/isa/wcd.c 1.6 +4 -4 src/sys/i386/isa/ic/i82586.h 1.22 +1 -1 src/sys/i386/isa/pcvt/pcvt_kbd.c 1.17 +4 -4 src/sys/i386/isa/sound/audio.c 1.127 +8 -8 src/sys/i386/scsi/aic7xxx.c 1.13 +4 -3 src/sys/kern/md5c.c 1.25 +10 -10 src/sys/kern/subr_prof.c 1.26 +3 -3 src/sys/kern/subr_rlist.c 1.29 +3 -3 src/sys/kern/tty_subr.c 1.161 +2 -2 src/sys/kern/vfs_bio.c 1.8 +5 -5 src/sys/libkern/qsort.c 1.26 +3 -3 src/sys/msdosfs/msdosfs_conv.c 1.21 +7 -5 src/sys/msdosfs/msdosfs_fat.c 1.7 +3 -3 src/sys/net/if_var.h 1.34 +3 -3 src/sys/net/ppp_tty.c 1.81 +8 -4 src/sys/netinet/ip_fw.c 1.58 +7 -7 src/sys/pccard/pcic.c 1.10 +5 -5 src/sys/pci/ide_pci.c 1.51 +6 -6 src/sys/pci/if_fxp.c 1.10 +3 -3 src/sys/pci/if_tx.c 1.7 +3 -6 src/sys/pci/smc83c170.h 1.4 +1 -1 src/sys/posix4/ksched.c 1.90 +2 -2 src/sys/scsi/cd.c 1.36 +2 -2 src/sys/scsi/od.c 1.122 +2 -2 src/sys/scsi/sd.c 1.54 +2 -2 src/sys/scsi/worm.c 1.2 +2 -2 src/sys/sys/dpt.h 1.39 +6 -6 src/sys/sys/kernel.h 1.93 +7 -7 src/sys/vm/swap_pager.c 1.98 +4 -4 src/sys/vm/vm_page.c 1.20 +3 -3 src/sys/vm/vm_zone.c From owner-cvs-sys Wed Apr 15 10:56:13 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA29161 for cvs-sys-outgoing; Wed, 15 Apr 1998 10:56:13 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA28411; Wed, 15 Apr 1998 17:54:22 GMT (envelope-from dima@FreeBSD.org) From: Dima Ruban Received: (from dima@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id KAA18689; Wed, 15 Apr 1998 10:53:34 -0700 (PDT) Date: Wed, 15 Apr 1998 10:53:34 -0700 (PDT) Message-Id: <199804151753.KAA18689@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/i386/conf Makefile.i386 Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk dima 1998/04/15 10:53:33 PDT Modified files: sys/i386/conf Makefile.i386 Log: Use 0440 root.kmem kermissions on kernel instead of 0555 root.wheel. Reviewed by: freebsd-security Revision Changes Path 1.108 +2 -2 src/sys/i386/conf/Makefile.i386 From owner-cvs-sys Wed Apr 15 11:39:42 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id LAA08104 for cvs-sys-outgoing; Wed, 15 Apr 1998 11:39:42 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id SAA07834; Wed, 15 Apr 1998 18:38:38 GMT (envelope-from tegge@FreeBSD.org) From: Tor Egge Received: (from tegge@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id LAA19424; Wed, 15 Apr 1998 11:37:50 -0700 (PDT) Date: Wed, 15 Apr 1998 11:37:50 -0700 (PDT) Message-Id: <199804151837.LAA19424@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/kern vfs_subr.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk tegge 1998/04/15 11:37:50 PDT Modified files: sys/kern vfs_subr.c Log: Unlock mountlist_slock if the mount point was busy (unmount in progress) during the attempt at lazy fsync. Revision Changes Path 1.149 +4 -2 src/sys/kern/vfs_subr.c From owner-cvs-sys Wed Apr 15 12:00:17 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id MAA12323 for cvs-sys-outgoing; Wed, 15 Apr 1998 12:00:17 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id SAA12147; Wed, 15 Apr 1998 18:58:58 GMT (envelope-from bde@FreeBSD.org) From: Bruce Evans Received: (from bde@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id LAA19752; Wed, 15 Apr 1998 11:58:10 -0700 (PDT) Date: Wed, 15 Apr 1998 11:58:10 -0700 (PDT) Message-Id: <199804151858.LAA19752@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/i386/isa npx.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk bde 1998/04/15 11:58:10 PDT Modified files: sys/i386/isa npx.c Log: Finish supporting compiling with `gcc -ansi'. Fix missing `volatile's in __asm() statements while I'm here. Revision Changes Path 1.59 +6 -6 src/sys/i386/isa/npx.c From owner-cvs-sys Wed Apr 15 20:33:37 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id UAA15467 for cvs-sys-outgoing; Wed, 15 Apr 1998 20:33:37 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id UAA15184; Wed, 15 Apr 1998 20:31:28 -0700 (PDT) (envelope-from peter@FreeBSD.org) From: Peter Wemm Received: (from peter@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id UAA06311; Wed, 15 Apr 1998 20:31:27 -0700 (PDT) Date: Wed, 15 Apr 1998 20:31:27 -0700 (PDT) Message-Id: <199804160331.UAA06311@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/kern vfs_subr.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 1998/04/15 20:31:27 PDT Modified files: sys/kern vfs_subr.c Log: When the softdep conversion took place, the periodic vfs_msync() from update got lost. This is responsible for ensuring that dirty mmap() pages get periodically written to disk. Without it, long time mmap's might not have their dirty pages written out at all of the system crashes or isn't cleanly shut down. This could be nasty if you've got a long-running writing via mmap(), dirty pages used to get written to disk within 30 seconds or so. Revision Changes Path 1.150 +2 -1 src/sys/kern/vfs_subr.c From owner-cvs-sys Thu Apr 16 01:56:11 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id BAA20773 for cvs-sys-outgoing; Thu, 16 Apr 1998 01:56:11 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA20572; Thu, 16 Apr 1998 01:55:25 -0700 (PDT) (envelope-from bde@godzilla.zeta.org.au) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.8.7) id SAA04053; Thu, 16 Apr 1998 18:51:05 +1000 Date: Thu, 16 Apr 1998 18:51:05 +1000 From: Bruce Evans Message-Id: <199804160851.SAA04053@godzilla.zeta.org.au> To: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG, peter@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern vfs_subr.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > Modified files: > sys/kern vfs_subr.c > Log: > When the softdep conversion took place, the periodic vfs_msync() from > update got lost. This is responsible for ensuring that dirty mmap() pages > get periodically written to disk. Without it, long time mmap's might not > have their dirty pages written out at all of the system crashes or isn't > cleanly shut down. This could be nasty if you've got a long-running > writing via mmap(), dirty pages used to get written to disk within 30 > seconds or so. sync_fsync() seems to be called too often for this (approx. every 3 seconds on an idle system). vfs_msync() seems to do a lot every time it is called. We also lost control of the update interval. We also lost waking the sync daemon in vm_pageout_scan(). There is still a wakeup on vfs_update_wakeup, but nothing sleeps on it any more. A better quick fix for most of this is probably to resurrect the update daemon and only call vfs_msync() from it. Bruce From owner-cvs-sys Thu Apr 16 01:58:49 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id BAA21160 for cvs-sys-outgoing; Thu, 16 Apr 1998 01:58:49 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from ocean.campus.luth.se (ocean.campus.luth.se [130.240.194.116]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA21149; Thu, 16 Apr 1998 01:58:44 -0700 (PDT) (envelope-from karpen@ocean.campus.luth.se) Received: (from karpen@localhost) by ocean.campus.luth.se (8.8.8/8.8.8) id KAA10479; Thu, 16 Apr 1998 10:53:08 +0200 (CEST) (envelope-from karpen) From: Mikael Karpberg Message-Id: <199804160853.KAA10479@ocean.campus.luth.se> Subject: Re: cvs commit: src/sys/i386/isa syscons.c In-Reply-To: <199804151200.FAA16764@freefall.freebsd.org> from "Dag-Erling C. Smxf8rgrav" at "Apr 15, 98 05:00:15 am" To: des@FreeBSD.ORG (Dag-Erling C. Sm\xf8rgrav) Date: Thu, 16 Apr 1998 10:53:08 +0200 (CEST) Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL32 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk According to Dag-Erling C. Sm\xf8rgrav: > des 1998/04/15 05:00:15 PDT > > Modified files: (Branch: 1.182.2) WHAT!? Did I miss something? This branch looks weird! > sys/i386/isa syscons.c /Mikael From owner-cvs-sys Thu Apr 16 02:42:20 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id CAA25980 for cvs-sys-outgoing; Thu, 16 Apr 1998 02:42:20 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id CAA25892; Thu, 16 Apr 1998 02:42:01 -0700 (PDT) (envelope-from des@FreeBSD.org) From: "Dag-Erling C. Sm\xf8rgrav" Received: (from des@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id CAA07434; Thu, 16 Apr 1998 02:41:57 -0700 (PDT) Date: Thu, 16 Apr 1998 02:41:57 -0700 (PDT) Message-Id: <199804160941.CAA07434@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/i386/isa syscons.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk des 1998/04/16 02:41:57 PDT Modified files: sys/i386/isa syscons.c Log: Swapped "should we just return" and "should we stop the screensaver" in scrn_timer() to avoid deadlock with graphical screensavers. Revision Changes Path 1.259 +11 -8 src/sys/i386/isa/syscons.c From owner-cvs-sys Thu Apr 16 03:36:18 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id DAA04030 for cvs-sys-outgoing; Thu, 16 Apr 1998 03:36:18 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id DAA03935; Thu, 16 Apr 1998 03:35:56 -0700 (PDT) (envelope-from peter@FreeBSD.org) From: Peter Wemm Received: (from peter@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id DAA07923; Thu, 16 Apr 1998 03:35:52 -0700 (PDT) Date: Thu, 16 Apr 1998 03:35:52 -0700 (PDT) Message-Id: <199804161035.DAA07923@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/scsi st.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 1998/04/16 03:35:51 PDT Modified files: sys/scsi st.c Log: fix an obvious broken BOUNCE_BUFFER case. Revision Changes Path 1.86 +9 -1 src/sys/scsi/st.c From owner-cvs-sys Thu Apr 16 04:15:42 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id EAA11501 for cvs-sys-outgoing; Thu, 16 Apr 1998 04:15:42 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id EAA11464; Thu, 16 Apr 1998 04:15:28 -0700 (PDT) (envelope-from peter@FreeBSD.org) From: Peter Wemm Received: (from peter@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id EAA08056; Thu, 16 Apr 1998 04:15:24 -0700 (PDT) Date: Thu, 16 Apr 1998 04:15:24 -0700 (PDT) Message-Id: <199804161115.EAA08056@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/scsi scsi_base.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 1998/04/16 04:15:24 PDT Modified files: sys/scsi scsi_base.c Log: Attempt to get bounce_buffers working again for per-process kernel stack data targets. At least st0 works for me again.... Also, scsi_scsi_cmd() looks like it's been exiting without a biodone() on an attached buffer in a number of error cases, leading to locked buffers. Revision Changes Path 1.55 +40 -10 src/sys/scsi/scsi_base.c From owner-cvs-sys Thu Apr 16 05:28:42 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id FAA21648 for cvs-sys-outgoing; Thu, 16 Apr 1998 05:28:42 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA21603; Thu, 16 Apr 1998 05:28:36 -0700 (PDT) (envelope-from peter@FreeBSD.org) From: Peter Wemm Received: (from peter@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id FAA09580; Thu, 16 Apr 1998 05:28:32 -0700 (PDT) Date: Thu, 16 Apr 1998 05:28:32 -0700 (PDT) Message-Id: <199804161228.FAA09580@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/scsi ch.c worm.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 1998/04/16 05:28:31 PDT Modified files: sys/scsi ch.c worm.c Log: Attempt to fix BOUNCE_BUFFERS. I cannot test these drivers, but they seem to compile OK with the bounce buffer mods. I have only visually checked for missing bounce buffer support, I could have missed some. Revision Changes Path 1.44 +30 -1 src/sys/scsi/ch.c 1.55 +24 -1 src/sys/scsi/worm.c From owner-cvs-sys Thu Apr 16 06:03:00 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id GAA28164 for cvs-sys-outgoing; Thu, 16 Apr 1998 06:03:00 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from spinner.netplex.com.au (spinner.netplex.com.au [202.12.86.3]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id GAA28124; Thu, 16 Apr 1998 06:02:11 -0700 (PDT) (envelope-from peter@netplex.com.au) Received: from spinner.netplex.com.au (localhost [127.0.0.1]) by spinner.netplex.com.au (8.8.8/8.8.8/Spinner) with ESMTP id VAA16055; Thu, 16 Apr 1998 21:00:30 +0800 (WST) (envelope-from peter@spinner.netplex.com.au) Message-Id: <199804161300.VAA16055@spinner.netplex.com.au> X-Mailer: exmh version 2.0.2 2/24/98 To: Bruce Evans cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG, dyson@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern vfs_subr.c In-reply-to: Your message of "Thu, 16 Apr 1998 18:51:05 +1000." <199804160851.SAA04053@godzilla.zeta.org.au> Date: Thu, 16 Apr 1998 21:00:29 +0800 From: Peter Wemm Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Bruce Evans wrote: > > Modified files: > > sys/kern vfs_subr.c > > Log: > > When the softdep conversion took place, the periodic vfs_msync() from > > update got lost. This is responsible for ensuring that dirty mmap() pages > > get periodically written to disk. Without it, long time mmap's might not > > have their dirty pages written out at all of the system crashes or isn't > > cleanly shut down. This could be nasty if you've got a long-running > > writing via mmap(), dirty pages used to get written to disk within 30 > > seconds or so. > > sync_fsync() seems to be called too often for this (approx. every 3 > seconds on an idle system). Well, from what I could see, it's called however often it needs in order to sync each filesystem one-at-a-time over a 30 second period. The old update process called vfs_msync() n times (n = number of mountpoints) every 30 seconds. The way I understand things, it's now being called at exactly the same rate overall but at a more even spread. > vfs_msync() seems to do a lot every time it is called. Yes.. It walks through the vnodes attached to a given filesystem. From the look of it, there could be some optimizations there.. We could eliminate uninteresting vnodes before wasting time doing VOP's, getting simple_locks, etc. Index: vfs_subr.c =================================================================== RCS file: /home/ncvs/src/sys/kern/vfs_subr.c,v retrieving revision 1.150 diff -u -2 -r1.150 vfs_subr.c --- vfs_subr.c 1998/04/16 03:31:26 1.150 +++ vfs_subr.c 1998/04/16 12:57:05 @@ -2405,4 +2405,5 @@ vfs_msync(struct mount *mp, int flags) { struct vnode *vp, *nvp; + struct vm_object *obj; int anyio, tries; @@ -2417,4 +2418,9 @@ goto loop; } + + /* skip vnodes that are uninteresting before locking */ + obj = vp->v_object; + if (obj == NULL || (obj->flags & OBJ_MIGHTBEDIRTY) == 0) + continue; if ((vp->v_flag & VXLOCK) || With a few thousand vnodes, all those VOP_ISLOCKED() and simple_lock()/unlock calls have got to add up. It should be harmless to test these variables outside of any critical section protection. > We also lost control of the update interval. Yes, but it is compile-time tweakable, so those with a desperate need to tweak it can still do so, although on a power-of-two basis. > We also lost waking the sync daemon in vm_pageout_scan(). There is > still a wakeup on vfs_update_wakeup, but nothing sleeps on it any > more. > > A better quick fix for most of this is probably to resurrect the > update daemon and only call vfs_msync() from it. I don't think there's much gain to be had overall.. The old update called sync() every 30 seconds. sync does: simple_lock(&mountlist_slock); for (mp = mountlist.cqh_first; mp != (void *)&mountlist; mp = nmp) { [..] vfs_msync(mp, MNT_NOWAIT); [..] } simple_unlock(&mountlist_slock); So, if you have 10 filesystems, you get 20 vfs_msync's per minute under update, but you get a whole glut of disk writes in one major hit. Under syncer, you get 1 vfs_msync() every 3 seconds, stepping through each filesystem one at a time. You still have 20 vfs_msync's per minute. > Bruce > Cheers, -Peter -- Peter Wemm Netplex Consulting From owner-cvs-sys Thu Apr 16 06:57:06 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id GAA09353 for cvs-sys-outgoing; Thu, 16 Apr 1998 06:57:06 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from time.cdrom.com (root@time.cdrom.com [204.216.27.226]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id GAA09247; Thu, 16 Apr 1998 06:56:42 -0700 (PDT) (envelope-from jkh@time.cdrom.com) Received: from time.cdrom.com (jkh@localhost.cdrom.com [127.0.0.1]) by time.cdrom.com (8.8.8/8.8.8) with ESMTP id GAA03521; Thu, 16 Apr 1998 06:55:58 -0700 (PDT) (envelope-from jkh@time.cdrom.com) To: Peter Wemm cc: Bruce Evans , cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG, dyson@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern vfs_subr.c In-reply-to: Your message of "Thu, 16 Apr 1998 21:00:29 +0800." <199804161300.VAA16055@spinner.netplex.com.au> Date: Thu, 16 Apr 1998 06:55:58 -0700 Message-ID: <3518.892734958@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > > We also lost control of the update interval. > > Yes, but it is compile-time tweakable, so those with a desperate need to > tweak it can still do so, although on a power-of-two basis. I think it'd still be nice to have it be sysctl tweakable. If nothing else, it would give you a quick and easy way of saying "Hey! Stop waking up the suspended drive in my laptop, dammit!" without having to go recompile the kernel. Jordan From owner-cvs-sys Thu Apr 16 07:46:35 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id HAA16964 for cvs-sys-outgoing; Thu, 16 Apr 1998 07:46:35 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from spinner.netplex.com.au (spinner.netplex.com.au [202.12.86.3]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id HAA16491; Thu, 16 Apr 1998 07:45:11 -0700 (PDT) (envelope-from peter@netplex.com.au) Received: from spinner.netplex.com.au (localhost [127.0.0.1]) by spinner.netplex.com.au (8.8.8/8.8.8/Spinner) with ESMTP id WAA17178; Thu, 16 Apr 1998 22:42:15 +0800 (WST) (envelope-from peter@spinner.netplex.com.au) Message-Id: <199804161442.WAA17178@spinner.netplex.com.au> X-Mailer: exmh version 2.0.2 2/24/98 To: "Jordan K. Hubbard" cc: Bruce Evans , cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG, dyson@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern vfs_subr.c In-reply-to: Your message of "Thu, 16 Apr 1998 06:55:58 MST." <3518.892734958@time.cdrom.com> Date: Thu, 16 Apr 1998 22:42:14 +0800 From: Peter Wemm Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk "Jordan K. Hubbard" wrote: > > > We also lost control of the update interval. > > > > Yes, but it is compile-time tweakable, so those with a desperate need to > > tweak it can still do so, although on a power-of-two basis. > > I think it'd still be nice to have it be sysctl tweakable. If nothing > else, it would give you a quick and easy way of saying "Hey! Stop > waking up the suspended drive in my laptop, dammit!" without having > to go recompile the kernel. Given the present structures, it's not trivial or it'd have been done by now. The problem is that there's a compiled-in power-of-two sized table that represents work to do in 'n' seconds. Even if this were dynamically reallocated and the filesystem sync period was changeable, one would very quickly mess up the interleave of filesystems. Perhaps it'd be better to just have two syncer methods. One that does the interleaving, and the other that does a 'sync the whole damn universe every seconds'. One could switch from the gradual to the all-at-once method but there'd be no point going back. softdep will not run in that mode (not that softdep runs well at present in freebsd anyway...). > Jordan > Cheers, -Peter -- Peter Wemm Netplex Consulting From owner-cvs-sys Thu Apr 16 09:33:35 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id JAA10893 for cvs-sys-outgoing; Thu, 16 Apr 1998 09:33:35 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id QAA10337; Thu, 16 Apr 1998 16:31:43 GMT (envelope-from kato@FreeBSD.org) From: KATO Takenori Received: (from kato@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id JAA05073; Thu, 16 Apr 1998 09:31:37 -0700 (PDT) Date: Thu, 16 Apr 1998 09:31:37 -0700 (PDT) Message-Id: <199804161631.JAA05073@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pc98/i386 trap.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk kato 1998/04/16 09:31:37 PDT Modified files: sys/pc98/i386 trap.c Log: Sync with sys/i386/i386/trap.c revision 1.126. Revision Changes Path 1.49 +4 -4 src/sys/pc98/i386/trap.c From owner-cvs-sys Thu Apr 16 09:34:14 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id JAA11099 for cvs-sys-outgoing; Thu, 16 Apr 1998 09:34:14 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id QAA10568; Thu, 16 Apr 1998 16:32:22 GMT (envelope-from kato@FreeBSD.org) From: KATO Takenori Received: (from kato@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id JAA05103; Thu, 16 Apr 1998 09:32:16 -0700 (PDT) Date: Thu, 16 Apr 1998 09:32:16 -0700 (PDT) Message-Id: <199804161632.JAA05103@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pc98/pc98 if_ed.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk kato 1998/04/16 09:32:16 PDT Modified files: sys/pc98/pc98 if_ed.c Log: Sync with sys/i386/isa/if_ed.c revision 1.139. Revision Changes Path 1.46 +8 -8 src/sys/pc98/pc98/if_ed.c From owner-cvs-sys Thu Apr 16 09:34:49 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id JAA11251 for cvs-sys-outgoing; Thu, 16 Apr 1998 09:34:49 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id QAA10712; Thu, 16 Apr 1998 16:32:56 GMT (envelope-from kato@FreeBSD.org) From: KATO Takenori Received: (from kato@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id JAA05134; Thu, 16 Apr 1998 09:32:50 -0700 (PDT) Date: Thu, 16 Apr 1998 09:32:50 -0700 (PDT) Message-Id: <199804161632.JAA05134@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pc98/pc98 lpt.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk kato 1998/04/16 09:32:50 PDT Modified files: sys/pc98/pc98 lpt.c Log: Sync with sys/i386/isa/lpt.c revision 1.68. Revision Changes Path 1.19 +4 -4 src/sys/pc98/pc98/lpt.c From owner-cvs-sys Thu Apr 16 09:35:04 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id JAA11338 for cvs-sys-outgoing; Thu, 16 Apr 1998 09:35:04 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id QAA10839; Thu, 16 Apr 1998 16:33:27 GMT (envelope-from kato@FreeBSD.org) From: KATO Takenori Received: (from kato@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id JAA05164; Thu, 16 Apr 1998 09:33:21 -0700 (PDT) Date: Thu, 16 Apr 1998 09:33:21 -0700 (PDT) Message-Id: <199804161633.JAA05164@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pc98/pc98 pcaudio.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk kato 1998/04/16 09:33:21 PDT Modified files: sys/pc98/pc98 pcaudio.c Log: Sync with sys/i386/isa/pcaudio.c revision 1.40. Revision Changes Path 1.15 +2 -2 src/sys/pc98/pc98/pcaudio.c From owner-cvs-sys Thu Apr 16 09:36:14 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id JAA11647 for cvs-sys-outgoing; Thu, 16 Apr 1998 09:36:14 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id QAA11101; Thu, 16 Apr 1998 16:34:15 GMT (envelope-from kato@FreeBSD.org) From: KATO Takenori Received: (from kato@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id JAA05195; Thu, 16 Apr 1998 09:34:09 -0700 (PDT) Date: Thu, 16 Apr 1998 09:34:09 -0700 (PDT) Message-Id: <199804161634.JAA05195@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pc98/conf Makefile.pc98 Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk kato 1998/04/16 09:34:09 PDT Modified files: sys/pc98/conf Makefile.pc98 Log: Sync with sys/i386/conf/Makefile.i386 revision 1.108. Revision Changes Path 1.27 +2 -2 src/sys/pc98/conf/Makefile.pc98 From owner-cvs-sys Thu Apr 16 09:36:34 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id JAA11723 for cvs-sys-outgoing; Thu, 16 Apr 1998 09:36:34 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id QAA11255; Thu, 16 Apr 1998 16:34:52 GMT (envelope-from kato@FreeBSD.org) From: KATO Takenori Received: (from kato@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id JAA05225; Thu, 16 Apr 1998 09:34:46 -0700 (PDT) Date: Thu, 16 Apr 1998 09:34:46 -0700 (PDT) Message-Id: <199804161634.JAA05225@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pc98/pc98 npx.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk kato 1998/04/16 09:34:46 PDT Modified files: sys/pc98/pc98 npx.c Log: Sync with sys/i386/isa/npx.c revision 1.59. Revision Changes Path 1.35 +6 -6 src/sys/pc98/pc98/npx.c From owner-cvs-sys Thu Apr 16 09:38:24 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id JAA12161 for cvs-sys-outgoing; Thu, 16 Apr 1998 09:38:24 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id QAA11425; Thu, 16 Apr 1998 16:35:31 GMT (envelope-from kato@FreeBSD.org) From: KATO Takenori Received: (from kato@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id JAA05258; Thu, 16 Apr 1998 09:35:25 -0700 (PDT) Date: Thu, 16 Apr 1998 09:35:25 -0700 (PDT) Message-Id: <199804161635.JAA05258@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pc98/pc98 syscons.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk kato 1998/04/16 09:35:25 PDT Modified files: sys/pc98/pc98 syscons.c Log: Sync with sys/i386/isa/syscons.c revision 1.259. Revision Changes Path 1.83 +11 -8 src/sys/pc98/pc98/syscons.c From owner-cvs-sys Thu Apr 16 21:54:20 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA17025 for cvs-sys-outgoing; Thu, 16 Apr 1998 21:54:20 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id EAA16837; Fri, 17 Apr 1998 04:53:55 GMT (envelope-from bde@FreeBSD.org) From: Bruce Evans Received: (from bde@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id VAA07581; Thu, 16 Apr 1998 21:53:46 -0700 (PDT) Date: Thu, 16 Apr 1998 21:53:46 -0700 (PDT) Message-Id: <199804170453.VAA07581@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/kern kern_intr.c kern_lock.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk bde 1998/04/16 21:53:45 PDT Modified files: sys/kern kern_intr.c kern_lock.c Log: Really finish supporting compiling with `gcc -ansi'. Revision Changes Path 1.14 +2 -2 src/sys/kern/kern_intr.c 1.19 +2 -2 src/sys/kern/kern_lock.c From owner-cvs-sys Fri Apr 17 00:52:05 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id AAA00576 for cvs-sys-outgoing; Fri, 17 Apr 1998 00:52:05 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id HAA00495; Fri, 17 Apr 1998 07:51:49 GMT (envelope-from dima@FreeBSD.org) From: Dima Ruban Received: (from dima@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id AAA08987; Fri, 17 Apr 1998 00:51:38 -0700 (PDT) Date: Fri, 17 Apr 1998 00:51:38 -0700 (PDT) Message-Id: <199804170751.AAA08987@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/i386/conf Makefile.i386 Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk dima 1998/04/17 00:51:38 PDT Modified files: sys/i386/conf Makefile.i386 Log: Undo my last change. Revision Changes Path 1.109 +2 -2 src/sys/i386/conf/Makefile.i386 From owner-cvs-sys Fri Apr 17 03:03:35 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id DAA20453 for cvs-sys-outgoing; Fri, 17 Apr 1998 03:03:35 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA20404; Fri, 17 Apr 1998 10:03:26 GMT (envelope-from des@FreeBSD.org) From: "Dag-Erling C. Sm\xf8rgrav" Received: (from des@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id DAA09693; Fri, 17 Apr 1998 03:03:14 -0700 (PDT) Date: Fri, 17 Apr 1998 03:03:14 -0700 (PDT) Message-Id: <199804171003.DAA09693@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/i386/isa syscons.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk des 1998/04/17 03:03:14 PDT Modified files: sys/i386/isa syscons.c Log: Stop the screensaver before switching consoles. Revision Changes Path 1.260 +7 -1 src/sys/i386/isa/syscons.c From owner-cvs-sys Fri Apr 17 06:01:33 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id GAA15930 for cvs-sys-outgoing; Fri, 17 Apr 1998 06:01:33 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from outmail.utsunomiya-u.ac.jp (outmail.utsunomiya-u.ac.jp [160.12.196.3]) by hub.freebsd.org (8.8.8/8.8.8) with SMTP id NAA15895; Fri, 17 Apr 1998 13:01:05 GMT (envelope-from yokota@zodiac.mech.utsunomiya-u.ac.jp) Received: by outmail.utsunomiya-u.ac.jp id AA16151; Fri, 17 Apr 1998 22:01:03 +0900 Received: from zodiac.mech.utsunomiya-u.ac.jp (zodiac.mech.utsunomiya-u.ac.jp [160.12.42.1]) by zodiac.mech.utsunomiya-u.ac.jp (8.7.6+2.6Wbeta7/3.4W/zodiac-May96) with ESMTP id WAA00582; Fri, 17 Apr 1998 22:09:37 +0900 (JST) Message-Id: <199804171309.WAA00582@zodiac.mech.utsunomiya-u.ac.jp> To: "Dag-Erling C. Sm\xf8rgrav" Cc: cvs-sys@freebsd.org, sos@freebsd.org, msmith@freebsd.org, yokota@freebsd.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c In-Reply-To: Your message of "Fri, 17 Apr 1998 03:03:14 MST." <199804171003.DAA09693@freefall.freebsd.org> References: <199804171003.DAA09693@freefall.freebsd.org> Date: Fri, 17 Apr 1998 22:09:36 +0900 From: Kazutaka YOKOTA Sender: owner-cvs-sys@freebsd.org X-Loop: FreeBSD.org Precedence: bulk >des 1998/04/17 03:03:14 PDT > > Modified files: > sys/i386/isa syscons.c > Log: > Stop the screensaver before switching consoles. > > Revision Changes Path > 1.260 +7 -1 src/sys/i386/isa/syscons.c We had better coordinate things here. Back in February, I made a patch for syscons to accommodate both graphical screen saver and graphical splash screen. I never committed it to the source tree as it was more important to concentrate on the release of 2.2.6. My patch does the followings: 1. Makes the splash screen behave like a screen saver once the system has completely booted up. 2. Ensures the graphical screen saver is properly started and stopped from within scrn_timer(). 3. Tries to localize activation and deactivation of the screen saver to scrn_timer() as much as possible. switch_scr() does not call stop_screen_saver() directly, but rather it will let scrn_timer() to stop it and delays screen switch until the screen saver has completely stopped. 4. The graphical screen saver is expected to set the UNKNOWN_MODE bit when entering a graphics mode. (OK, it has been suggested that calling a known graphics mode UNKNOWN_MODE is arcane, but I think we had better keep it that way, because quite many parts of syscons currently relies on it anyway.) Many part of my patch has the same goal as you. But, it may employ slightly different code. I would like to see seamless integration and co-existance of your effort and mine. I will modify my patch for the latest syscons.c source and send it to you in a few days (sorry, I am pretty much tied up to my work tonight). Kazu yokota@freebsd.org From owner-cvs-sys Fri Apr 17 13:27:17 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id NAA20924 for cvs-sys-outgoing; Fri, 17 Apr 1998 13:27:17 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id UAA20883; Fri, 17 Apr 1998 20:26:59 GMT (envelope-from julian@FreeBSD.org) From: Julian Elischer Received: (from julian@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id NAA08944; Fri, 17 Apr 1998 13:26:44 -0700 (PDT) Date: Fri, 17 Apr 1998 13:26:44 -0700 (PDT) Message-Id: <199804172026.NAA08944@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/i386/conf majors.i386 Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk julian 1998/04/17 13:26:44 PDT Modified files: sys/i386/conf majors.i386 Log: Reserve a number for the ALTQ control devices (96) Revision Changes Path 1.37 +3 -1 src/sys/i386/conf/majors.i386 From owner-cvs-sys Fri Apr 17 13:31:32 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id NAA21586 for cvs-sys-outgoing; Fri, 17 Apr 1998 13:31:32 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id UAA21540; Fri, 17 Apr 1998 20:31:13 GMT (envelope-from julian@FreeBSD.org) From: Julian Elischer Received: (from julian@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id NAA08989; Fri, 17 Apr 1998 13:30:58 -0700 (PDT) Date: Fri, 17 Apr 1998 13:30:58 -0700 (PDT) Message-Id: <199804172030.NAA08989@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/i386/conf majors.i386 Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk julian 1998/04/17 13:30:58 PDT Modified files: (Branch: RELENG_2_2) sys/i386/conf majors.i386 Log: hold a number (that matches -current) for ALTQ remove duplicate DPT entry Revision Changes Path 1.9.2.10 +3 -3 src/sys/i386/conf/majors.i386 From owner-cvs-sys Fri Apr 17 15:38:32 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id PAA22237 for cvs-sys-outgoing; Fri, 17 Apr 1998 15:38:32 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id WAA21919; Fri, 17 Apr 1998 22:37:36 GMT (envelope-from des@FreeBSD.org) From: "Dag-Erling C. Sm\xf8rgrav" Received: (from des@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id PAA12467; Fri, 17 Apr 1998 15:37:21 -0700 (PDT) Date: Fri, 17 Apr 1998 15:37:21 -0700 (PDT) Message-Id: <199804172237.PAA12467@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/dev/dpt dpt_control.c src/sys/gnu/ext2fs COPYRIGHT.INFO ext2_alloc.c ext2_vnops.c src/sys/i386/eisa aha1742.c aic7770.c src/sys/i386/i386 busdma_machdep.c exception.s i386-gdbstub.c src/sys/i386/isa aha1542.c fd.c ft.c if_ar.c ... Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk des 1998/04/17 15:37:20 PDT Modified files: sys/dev/dpt dpt_control.c sys/gnu/ext2fs COPYRIGHT.INFO ext2_alloc.c ext2_vnops.c sys/i386/eisa aha1742.c aic7770.c sys/i386/i386 busdma_machdep.c exception.s i386-gdbstub.c sys/i386/isa aha1542.c fd.c ft.c if_ar.c if_ed.c if_epreg.h if_sr.c isa.c ppc.c rpreg.h ultra14f.c sys/i386/isa/pcvt pcvt_conf.h sys/i386/isa/snd ad1848.c sys/i386/isa/sound CHANGELOG Readme.v30 ad1848.c dmabuf.c mpu401.c sys/kern init_main.c kern_exec.c uipc_usrreq.c vfs_aio.c vfs_bio.c sys/miscfs/devfs README devfs_tree.c devfs_vfsops.c sys/miscfs/nullfs null_vnops.c sys/miscfs/procfs procfs_mem.c sys/miscfs/union union_vfsops.c sys/net if_tun.c if_tun.h route.c sys/netatalk at_control.c sys/netinet ip_mroute.c tcp_input.c sys/pc98/pc98 fd.c if_ed.c pc98.c sys/pci if_fxp.c ncr.c sys/scsi cd.c od.c scsi_base.c scsiconf.h sd.c st.c sys/sys snoop.h sys/ufs/ufs ufs_vnops.c Log: Seventy-odd "its" / "it's" typos in comments fixed as per kern/6108. Revision Changes Path 1.4 +2 -2 src/sys/dev/dpt/dpt_control.c 1.2 +1 -1 src/sys/gnu/ext2fs/COPYRIGHT.INFO 1.19 +1 -1 src/sys/gnu/ext2fs/ext2_alloc.c 1.37 +1 -1 src/sys/gnu/ext2fs/ext2_vnops.c 1.62 +3 -3 src/sys/i386/eisa/aha1742.c 1.43 +2 -2 src/sys/i386/eisa/aic7770.c 1.5 +2 -2 src/sys/i386/i386/busdma_machdep.c 1.51 +2 -2 src/sys/i386/i386/exception.s 1.6 +2 -2 src/sys/i386/i386/i386-gdbstub.c 1.76 +2 -2 src/sys/i386/isa/aha1542.c 1.108 +2 -2 src/sys/i386/isa/fd.c 1.37 +2 -2 src/sys/i386/isa/ft.c 1.18 +2 -2 src/sys/i386/isa/if_ar.c 1.140 +2 -2 src/sys/i386/isa/if_ed.c 1.23 +2 -2 src/sys/i386/isa/if_epreg.h 1.12 +3 -3 src/sys/i386/isa/if_sr.c 1.112 +3 -3 src/sys/i386/isa/isa.c 1.3 +2 -2 src/sys/i386/isa/ppc.c 1.2 +1 -1 src/sys/i386/isa/rpreg.h 1.59 +2 -2 src/sys/i386/isa/ultra14f.c 1.6 +1 -1 src/sys/i386/isa/pcvt/pcvt_conf.h 1.8 +1 -1 src/sys/i386/isa/snd/ad1848.c 1.7 +1 -1 src/sys/i386/isa/sound/CHANGELOG 1.4 +1 -1 src/sys/i386/isa/sound/Readme.v30 1.22 +1 -1 src/sys/i386/isa/sound/ad1848.c 1.32 +1 -1 src/sys/i386/isa/sound/dmabuf.c 1.18 +4 -4 src/sys/i386/isa/sound/mpu401.c 1.90 +2 -2 src/sys/kern/init_main.c 1.82 +2 -2 src/sys/kern/kern_exec.c 1.33 +2 -2 src/sys/kern/uipc_usrreq.c 1.28 +4 -4 src/sys/kern/vfs_aio.c 1.162 +2 -2 src/sys/kern/vfs_bio.c 1.6 +1 -1 src/sys/miscfs/devfs/README 1.51 +4 -4 src/sys/miscfs/devfs/devfs_tree.c 1.28 +2 -2 src/sys/miscfs/devfs/devfs_vfsops.c 1.27 +3 -3 src/sys/miscfs/nullfs/null_vnops.c 1.31 +2 -2 src/sys/miscfs/procfs/procfs_mem.c 1.28 +2 -2 src/sys/miscfs/union/union_vfsops.c 1.46 +1 -1 src/sys/net/if_tun.c 1.13 +2 -2 src/sys/net/if_tun.h 1.50 +3 -3 src/sys/net/route.c 1.23 +1 -1 src/sys/netatalk/at_control.c 1.46 +2 -2 src/sys/netinet/ip_mroute.c 1.73 +2 -2 src/sys/netinet/tcp_input.c 1.28 +2 -2 src/sys/pc98/pc98/fd.c 1.47 +2 -2 src/sys/pc98/pc98/if_ed.c 1.50 +3 -3 src/sys/pc98/pc98/pc98.c 1.52 +3 -3 src/sys/pci/if_fxp.c 1.117 +4 -4 src/sys/pci/ncr.c 1.91 +2 -2 src/sys/scsi/cd.c 1.37 +2 -2 src/sys/scsi/od.c 1.56 +4 -4 src/sys/scsi/scsi_base.c 1.59 +2 -2 src/sys/scsi/scsiconf.h 1.123 +2 -2 src/sys/scsi/sd.c 1.87 +2 -2 src/sys/scsi/st.c 1.13 +1 -1 src/sys/sys/snoop.h 1.83 +2 -2 src/sys/ufs/ufs/ufs_vnops.c From owner-cvs-sys Fri Apr 17 21:18:12 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA22998 for cvs-sys-outgoing; Fri, 17 Apr 1998 21:18:12 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from spinner.netplex.com.au ([202.12.86.3]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id EAA22797; Sat, 18 Apr 1998 04:12:11 GMT (envelope-from peter@netplex.com.au) Received: from spinner.netplex.com.au (localhost [127.0.0.1]) by spinner.netplex.com.au (8.8.8/8.8.8/Spinner) with ESMTP id MAA16043; Sat, 18 Apr 1998 12:11:21 +0800 (WST) (envelope-from peter@spinner.netplex.com.au) Message-Id: <199804180411.MAA16043@spinner.netplex.com.au> X-Mailer: exmh version 2.0.2 2/24/98 To: "Dag-Erling C. Sm\xf8rgrav" cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/dpt dpt_control.c src/sys/gnu/ext2fs... In-reply-to: Your message of "Fri, 17 Apr 1998 15:37:21 MST." <199804172237.PAA12467@freefall.freebsd.org> Date: Sat, 18 Apr 1998 12:11:20 +0800 From: Peter Wemm Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk "Dag-Erling C. Sm\xf8rgrav" wrote: > des 1998/04/17 15:37:20 PDT > > Modified files: > sys/dev/dpt dpt_control.c > sys/gnu/ext2fs COPYRIGHT.INFO ext2_alloc.c ext2_vnops.c [..] > sys/ufs/ufs ufs_vnops.c > Log: > Seventy-odd "its" / "it's" typos in comments fixed as per kern/6108. What the hell??? I don't call this "fixing typos", as far as I can tell, most of these changes have broken the correct usage. eg: here, we are talking about the device's softc: +++ dpt_control.c 1998/03/23 10:49:01 @@ -175,7 +175,7 @@ /** * Given a minor device number, - * return the pointer to it's softc structure + * return the pointer to its softc structure */ static INLINE dpt_softc_t * eg: here we are talking about the card's EEROM. +++ if_ed.c 1998/03/23 11:05:46 @@ -676,7 +676,7 @@ #endif DELAY(100); outb(sc->asic_addr + ED_WD_MSR, inb(sc->asic_addr + ED_WD_MSR) & ~ED_WD_ MSR_RST); - /* wait in the case this card is reading it's EEROM */ + /* wait in the case this card is reading its EEROM */ DELAY(5000); sc->vendor = ED_VENDOR_WD_SMC; And so on... Just because a PR is submitted, it doesn't mean it's right. If they were always right, there would be an automatic patch application process on PR submission. -Peter From owner-cvs-sys Fri Apr 17 21:35:38 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA26174 for cvs-sys-outgoing; Fri, 17 Apr 1998 21:35:38 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from conductor.synapse.net (conductor.synapse.net [199.84.54.18]) by hub.freebsd.org (8.8.8/8.8.8) with SMTP id EAA26129 for ; Sat, 18 Apr 1998 04:35:29 GMT (envelope-from evanc@synapse.net) Received: (qmail 12391 invoked from network); 18 Apr 1998 04:35:26 -0000 Received: from cpu1970.adsl.bellglobal.com (HELO cello) (206.47.37.201) by conductor.synapse.net with SMTP; 18 Apr 1998 04:35:26 -0000 Message-ID: <010401bd6a83$68bb3040$c9252fce@cello.synapse.net> From: "Evan Champion" To: "Dag-Erling C. Smxf8rgrav" , "Peter Wemm" Cc: , , Subject: Re: cvs commit: src/sys/dev/dpt dpt_control.c src/sys/gnu/ext2fs... Date: Sat, 18 Apr 1998 00:35:26 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 4.72.2106.4 X-MimeOLE: Produced By Microsoft MimeOLE V4.72.2106.4 Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >What the hell??? I don't call this "fixing typos", as far as I can tell, >most of these changes have broken the correct usage. The grammar in the patch is correct. > /** > * Given a minor device number, >- * return the pointer to it's softc structure >+ * return the pointer to its softc structure > */ Let's expand: - * return the pointer to it is softc structure + * return the pointer to its softc structure Remember, "its" is a posessive, "it's" is a contraction for it is. Evan From owner-cvs-sys Fri Apr 17 21:55:20 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA29747 for cvs-sys-outgoing; Fri, 17 Apr 1998 21:55:20 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from ns2.cetlink.net (root@ns2.cetlink.net [209.54.54.20]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id EAA29699; Sat, 18 Apr 1998 04:55:03 GMT (envelope-from jak@cetlink.net) Received: from EXIT10 (i485-gw.cetlink.net [209.198.15.97]) by ns2.cetlink.net (8.8.5/8.8.5) with SMTP id AAA19927; Sat, 18 Apr 1998 00:54:29 -0400 (EDT) From: jak@cetlink.net (John Kelly) To: Peter Wemm Cc: "Dag-Erling C. Sm\xf8rgrav" , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Correct English style Date: Sat, 18 Apr 1998 04:56:28 GMT Message-ID: <35382ed1.10137219@mail.cetlink.net> References: <199804180411.MAA16043@spinner.netplex.com.au> In-Reply-To: <199804180411.MAA16043@spinner.netplex.com.au> X-Mailer: Forte Agent 1.5/32.451 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by hub.freebsd.org id EAB29702 Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Sat, 18 Apr 1998 12:11:20 +0800, Peter Wemm wrote: >I don't call this "fixing typos", as far as I can tell, >most of these changes have broken the correct usage. The changes are correct. >eg: here, we are talking about the device's softc: >- * return the pointer to it's softc structure >+ * return the pointer to its softc structure An apostrophe is used to indicate the possessive case (as in Peter's computer) except in the special case of the word "its." In this special case, it's (with the apostrophe) is a contraction of "it is" while its (without the apostrophe) is the possessive adjective. The committer is correct. Consult a dictionary or manual of style. From owner-cvs-sys Fri Apr 17 21:59:10 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA00566 for cvs-sys-outgoing; Fri, 17 Apr 1998 21:59:10 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id EAA00525; Sat, 18 Apr 1998 04:58:54 GMT (envelope-from ahasty@FreeBSD.org) From: Amancio Hasty Received: (from ahasty@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id VAA14509; Fri, 17 Apr 1998 21:58:37 -0700 (PDT) Date: Fri, 17 Apr 1998 21:58:37 -0700 (PDT) Message-Id: <199804180458.VAA14509@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/i386/conf LINT options.i386 src/sys/pci brooktree848.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ahasty 1998/04/17 21:58:36 PDT Modified files: sys/i386/conf LINT options.i386 sys/pci brooktree848.c Log: Reviewed by: Amancio Submitted by: Roger Hardiman Roger Hardiman : Revised autodetection code to correctly handle both old and new VideoLogic Captivator PCI cards. Added tsleep of 2 seconds to initialistion code for PAL users. Corrected clock selection code on format change. --- Amancio Revision Changes Path 1.425 +5 -2 src/sys/i386/conf/LINT 1.77 +4 -1 src/sys/i386/conf/options.i386 1.35 +97 -21 src/sys/pci/brooktree848.c From owner-cvs-sys Fri Apr 17 22:01:55 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA00861 for cvs-sys-outgoing; Fri, 17 Apr 1998 22:01:55 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA00806; Sat, 18 Apr 1998 05:01:43 GMT (envelope-from kato@FreeBSD.org) From: KATO Takenori Received: (from kato@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id WAA14554; Fri, 17 Apr 1998 22:01:25 -0700 (PDT) Date: Fri, 17 Apr 1998 22:01:25 -0700 (PDT) Message-Id: <199804180501.WAA14554@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/i386/isa/bs bs.c bsvar.h Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk kato 1998/04/17 22:01:25 PDT Modified files: sys/i386/isa/bs bs.c bsvar.h Log: Support compiling with `gcc -ansi'. Revision Changes Path 1.5 +2 -2 src/sys/i386/isa/bs/bs.c 1.5 +4 -0 src/sys/i386/isa/bs/bsvar.h From owner-cvs-sys Fri Apr 17 22:08:10 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA01410 for cvs-sys-outgoing; Fri, 17 Apr 1998 22:08:10 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA01364; Sat, 18 Apr 1998 05:08:01 GMT (envelope-from kato@FreeBSD.org) From: KATO Takenori Received: (from kato@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id WAA14603; Fri, 17 Apr 1998 22:07:44 -0700 (PDT) Date: Fri, 17 Apr 1998 22:07:44 -0700 (PDT) Message-Id: <199804180507.WAA14603@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pc98/conf Makefile.pc98 Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk kato 1998/04/17 22:07:43 PDT Modified files: sys/pc98/conf Makefile.pc98 Log: Sync with sys/i386/conf/Makefile.i386 revision 1.109. Revision Changes Path 1.28 +2 -2 src/sys/pc98/conf/Makefile.pc98 From owner-cvs-sys Fri Apr 17 22:08:20 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA01427 for cvs-sys-outgoing; Fri, 17 Apr 1998 22:08:20 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA01416; Sat, 18 Apr 1998 05:08:12 GMT (envelope-from julian@whistle.com) Received: (from daemon@localhost) by alpo.whistle.com (8.8.5/8.8.5) id WAA01918; Fri, 17 Apr 1998 22:05:54 -0700 (PDT) Received: from current1.whistle.com(207.76.205.22) via SMTP by alpo.whistle.com, id smtpd001916; Sat Apr 18 05:05:47 1998 Message-ID: <3538336F.41C67EA6@whistle.com> Date: Fri, 17 Apr 1998 22:00:31 -0700 From: Julian Elischer Organization: Whistle Communications X-Mailer: Mozilla 3.0Gold (X11; I; FreeBSD 2.2.5-RELEASE i386) MIME-Version: 1.0 To: Peter Wemm CC: "Dag-Erling C. Smxf8rgrav" , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/dpt dpt_control.c src/sys/gnu/ext2fs... References: <199804180411.MAA16043@spinner.netplex.com.au> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Peter Wemm wrote: > > "Dag-Erling C. Sm\xf8rgrav" wrote: > > des 1998/04/17 15:37:20 PDT > > > > Modified files: > > sys/dev/dpt dpt_control.c > > sys/gnu/ext2fs COPYRIGHT.INFO ext2_alloc.c ext2_vnops.c > [..] > > sys/ufs/ufs ufs_vnops.c > > Log: > > Seventy-odd "its" / "it's" typos in comments fixed as per kern/6108. > > What the hell??? I don't call this "fixing typos", as far as I can tell, > most of these changes have broken the correct usage. > > eg: here, we are talking about the device's softc: > +++ dpt_control.c 1998/03/23 10:49:01 > @@ -175,7 +175,7 @@ > > /** > * Given a minor device number, > - * return the pointer to it's softc structure > + * return the pointer to its softc structure sorry to contradict you Peter but this is the trick.. "its" is a single word, the same as: "his" and "her" as in: his cat, her cat, its cat the other version, e.g. "Joh's crow" or "John's VM code", shouldn't be confused with this.. why schools never explain it in this way I'll never understand. it took me years till someone explained this to me so clearly.. Until then I'd assumed.. "Sue's cakes", "John's cat", "it's softc" but that's wrong. "it's" is soley for the contraction "it is". julian > */ > > static INLINE dpt_softc_t * > > eg: here we are talking about the card's EEROM. > +++ if_ed.c 1998/03/23 11:05:46 > @@ -676,7 +676,7 @@ > #endif > DELAY(100); > outb(sc->asic_addr + ED_WD_MSR, inb(sc->asic_addr + ED_WD_MSR) & ~ED_WD_ > MSR_RST); > - /* wait in the case this card is reading it's EEROM */ > + /* wait in the case this card is reading its EEROM */ > DELAY(5000); > > sc->vendor = ED_VENDOR_WD_SMC; > > And so on... > > Just because a PR is submitted, it doesn't mean it's right. If they were > always right, there would be an automatic patch application process on PR > submission. > > -Peter From owner-cvs-sys Fri Apr 17 22:09:35 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA01552 for cvs-sys-outgoing; Fri, 17 Apr 1998 22:09:35 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA01496; Sat, 18 Apr 1998 05:09:26 GMT (envelope-from kato@FreeBSD.org) From: KATO Takenori Received: (from kato@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id WAA14650; Fri, 17 Apr 1998 22:09:08 -0700 (PDT) Date: Fri, 17 Apr 1998 22:09:08 -0700 (PDT) Message-Id: <199804180509.WAA14650@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pc98/pc98 syscons.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk kato 1998/04/17 22:09:08 PDT Modified files: sys/pc98/pc98 syscons.c Log: Sync with sys/i386/isa/syscons.c revision 1.260. Revision Changes Path 1.84 +7 -1 src/sys/pc98/pc98/syscons.c From owner-cvs-sys Fri Apr 17 22:10:18 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA01813 for cvs-sys-outgoing; Fri, 17 Apr 1998 22:10:18 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA01783; Sat, 18 Apr 1998 05:10:08 GMT (envelope-from kato@FreeBSD.org) From: KATO Takenori Received: (from kato@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id WAA14682; Fri, 17 Apr 1998 22:09:51 -0700 (PDT) Date: Fri, 17 Apr 1998 22:09:51 -0700 (PDT) Message-Id: <199804180509.WAA14682@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pc98/conf majors.pc98 Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk kato 1998/04/17 22:09:50 PDT Modified files: sys/pc98/conf majors.pc98 Log: Sync with sys/i386/conf/majors.i386 revision 1.37. Revision Changes Path 1.29 +3 -1 src/sys/pc98/conf/majors.pc98 From owner-cvs-sys Fri Apr 17 22:30:21 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA05198 for cvs-sys-outgoing; Fri, 17 Apr 1998 22:30:21 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA05176; Sat, 18 Apr 1998 05:30:10 GMT (envelope-from bde@godzilla.zeta.org.au) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.8.7) id PAA08431; Sat, 18 Apr 1998 15:27:39 +1000 Date: Sat, 18 Apr 1998 15:27:39 +1000 From: Bruce Evans Message-Id: <199804180527.PAA08431@godzilla.zeta.org.au> To: des@FreeBSD.ORG, peter@netplex.com.au Subject: Re: cvs commit: src/sys/dev/dpt dpt_control.c src/sys/gnu/ext2fs... Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >"Dag-Erling C. Sm\xf8rgrav" wrote: >> des 1998/04/17 15:37:20 PDT >> >> Modified files: >> sys/dev/dpt dpt_control.c >> sys/gnu/ext2fs COPYRIGHT.INFO ext2_alloc.c ext2_vnops.c >[..] >> sys/ufs/ufs ufs_vnops.c >> Log: >> Seventy-odd "its" / "it's" typos in comments fixed as per kern/6108. > >What the hell??? I don't call this "fixing typos", as far as I can tell, >most of these changes have broken the correct usage. I didn't notice any incorrect ones. >eg: here, we are talking about the device's softc: >+++ dpt_control.c 1998/03/23 10:49:01 >@@ -175,7 +175,7 @@ > > /** > * Given a minor device number, >- * return the pointer to it's softc structure >+ * return the pointer to its softc structure > */ > > static INLINE dpt_softc_t * The change is correct. You get this wrong so often that I am tempted to reply with a spelling flame :-). >eg: here we are talking about the card's EEROM. >+++ if_ed.c 1998/03/23 11:05:46 >@@ -676,7 +676,7 @@ > #endif > DELAY(100); > outb(sc->asic_addr + ED_WD_MSR, inb(sc->asic_addr + ED_WD_MSR) & ~ED_WD_ >MSR_RST); >- /* wait in the case this card is reading it's EEROM */ >+ /* wait in the case this card is reading its EEROM */ > DELAY(5000); > > sc->vendor = ED_VENDOR_WD_SMC; > >And so on... This change is correct too. >Just because a PR is submitted, it doesn't mean it's right. If they were >always right, there would be an automatic patch application process on PR >submission. Most submissions in PRs (and elsehwere) have style and spelling bugs on almost every line, but this one seems to be an exception :-). Bruce From owner-cvs-sys Fri Apr 17 22:32:43 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA05453 for cvs-sys-outgoing; Fri, 17 Apr 1998 22:32:43 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from time.cdrom.com (root@time.cdrom.com [204.216.27.226]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA05431; Sat, 18 Apr 1998 05:32:33 GMT (envelope-from jkh@time.cdrom.com) Received: from time.cdrom.com (jkh@localhost.cdrom.com [127.0.0.1]) by time.cdrom.com (8.8.8/8.8.8) with ESMTP id WAA16357; Fri, 17 Apr 1998 22:31:43 -0700 (PDT) (envelope-from jkh@time.cdrom.com) To: Peter Wemm cc: "Dag-Erling C. Sm\xf8rgrav" , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/dpt dpt_control.c src/sys/gnu/ext2fs... In-reply-to: Your message of "Sat, 18 Apr 1998 12:11:20 +0800." <199804180411.MAA16043@spinner.netplex.com.au> Date: Fri, 17 Apr 1998 22:31:43 -0700 Message-ID: <16353.892877503@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > What the hell??? I don't call this "fixing typos", as far as I can tell, > most of these changes have broken the correct usage. How so? The two examples you cite seem to be arguments for rather than against this change. :) Jordan From owner-cvs-sys Fri Apr 17 22:42:54 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA06750 for cvs-sys-outgoing; Fri, 17 Apr 1998 22:42:54 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from spinner.netplex.com.au (spinner.netplex.com.au [202.12.86.3]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA06733; Sat, 18 Apr 1998 05:42:40 GMT (envelope-from peter@netplex.com.au) Received: from spinner.netplex.com.au (localhost [127.0.0.1]) by spinner.netplex.com.au (8.8.8/8.8.8/Spinner) with ESMTP id NAA17129; Sat, 18 Apr 1998 13:42:16 +0800 (WST) (envelope-from peter@spinner.netplex.com.au) Message-Id: <199804180542.NAA17129@spinner.netplex.com.au> X-Mailer: exmh version 2.0.2 2/24/98 To: Julian Elischer cc: "Dag-Erling C. Smxf8rgrav" , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/dpt dpt_control.c src/sys/gnu/ext2fs... In-reply-to: Your message of "Fri, 17 Apr 1998 22:00:31 MST." <3538336F.41C67EA6@whistle.com> Date: Sat, 18 Apr 1998 13:42:15 +0800 From: Peter Wemm Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Julian Elischer wrote: > Peter Wemm wrote: > > > > "Dag-Erling C. Sm\xf8rgrav" wrote: > > > des 1998/04/17 15:37:20 PDT > > > > > > Modified files: > > > sys/dev/dpt dpt_control.c > > > sys/gnu/ext2fs COPYRIGHT.INFO ext2_alloc.c ext2_vnops.c > > [..] > > > sys/ufs/ufs ufs_vnops.c > > > Log: > > > Seventy-odd "its" / "it's" typos in comments fixed as per kern/6108. > > > > What the hell??? I don't call this "fixing typos", as far as I can tell, > > most of these changes have broken the correct usage. > > > > eg: here, we are talking about the device's softc: > > +++ dpt_control.c 1998/03/23 10:49:01 > > @@ -175,7 +175,7 @@ > > > > /** > > * Given a minor device number, > > - * return the pointer to it's softc structure > > + * return the pointer to its softc structure > > > sorry to contradict you Peter but this is the trick.. > > "its" is a single word, the same as: > "his" and "her" > > as in: > > his cat, her cat, its cat > > > the other version, e.g. > "Joh's crow" or "John's VM code", > shouldn't be confused with this.. > > why schools never explain it in this way I'll never understand. > it took me years till someone explained this to me so clearly.. > > Until then I'd assumed.. > "Sue's cakes", "John's cat", "it's softc" > > but that's wrong. > "it's" is soley for the contraction "it is". > > julian Yes, I see that now. But I had to look at a dictionary first before I believed it... :-) Cheers, -Peter From owner-cvs-sys Fri Apr 17 22:47:57 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA07281 for cvs-sys-outgoing; Fri, 17 Apr 1998 22:47:57 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from spinner.netplex.com.au (spinner.netplex.com.au [202.12.86.3]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA07258; Sat, 18 Apr 1998 05:47:48 GMT (envelope-from peter@netplex.com.au) Received: from spinner.netplex.com.au (localhost [127.0.0.1]) by spinner.netplex.com.au (8.8.8/8.8.8/Spinner) with ESMTP id NAA17191; Sat, 18 Apr 1998 13:47:30 +0800 (WST) (envelope-from peter@spinner.netplex.com.au) Message-Id: <199804180547.NAA17191@spinner.netplex.com.au> X-Mailer: exmh version 2.0.2 2/24/98 To: "Jordan K. Hubbard" cc: "Dag-Erling C. Sm\xf8rgrav" , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/dpt dpt_control.c src/sys/gnu/ext2fs... In-reply-to: Your message of "Fri, 17 Apr 1998 22:31:43 MST." <16353.892877503@time.cdrom.com> Date: Sat, 18 Apr 1998 13:47:30 +0800 From: Peter Wemm Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk "Jordan K. Hubbard" wrote: > > What the hell??? I don't call this "fixing typos", as far as I can tell, > > most of these changes have broken the correct usage. > > How so? The two examples you cite seem to be arguments for rather > than against this change. :) Yes.. Oh well, it's^H^H has not been a good start to the day. I think I'll either go back to bed or go and find somewhere that there are no computers for the rest of the day... > Jordan > Cheers, -Peter -- Peter Wemm Netplex Consulting From owner-cvs-sys Fri Apr 17 23:26:41 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id XAA11276 for cvs-sys-outgoing; Fri, 17 Apr 1998 23:26:41 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id GAA11245; Sat, 18 Apr 1998 06:26:35 GMT (envelope-from peter@FreeBSD.org) From: Peter Wemm Received: (from peter@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id XAA14791; Fri, 17 Apr 1998 23:26:17 -0700 (PDT) Date: Fri, 17 Apr 1998 23:26:17 -0700 (PDT) Message-Id: <199804180626.XAA14791@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/kern vfs_subr.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 1998/04/17 23:26:17 PDT Modified files: sys/kern vfs_subr.c Log: In vfs_msync(), test to see if the vnode being examined is "interesting" (ie: it has a vm_object attached and is marked as OBJ_MIGHTBEDIRTY) before attempting to lock it. This should reduce the cpu hit that is incurred when doing a sync(2) and when the syncer process is doing the 30-second writeback of dirty mmap() data to disk. Skip this speedup if we are doing an unmount() to be sure to get everything - we can afford to occasionally miss a msync while the system is running, but not at unmount. I'm not sure about the VXLOCK and MNT_WAIT case, it seems a bit odd to skip doing a page_clean at unmount time just because a vnode is VXLOCKed, but that's what was being done before... Revision Changes Path 1.151 +10 -3 src/sys/kern/vfs_subr.c From owner-cvs-sys Sat Apr 18 00:14:43 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id AAA16056 for cvs-sys-outgoing; Sat, 18 Apr 1998 00:14:43 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from critter.freebsd.dk (critter.freebsd.dk [195.8.129.14]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id HAA16051; Sat, 18 Apr 1998 07:14:32 GMT (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.8.7/8.8.5) with ESMTP id JAA09106; Sat, 18 Apr 1998 09:13:10 +0200 (CEST) To: jak@cetlink.net (John Kelly) cc: Peter Wemm , "Dag-Erling C. Sm\xf8rgrav" , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: Correct English style In-reply-to: Your message of "Sat, 18 Apr 1998 04:56:28 GMT." <35382ed1.10137219@mail.cetlink.net> Date: Sat, 18 Apr 1998 09:13:10 +0200 Message-ID: <9104.892883590@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk In message <35382ed1.10137219@mail.cetlink.net>, John Kelly writes: >On Sat, 18 Apr 1998 12:11:20 +0800, Peter Wemm >wrote: > >>I don't call this "fixing typos", as far as I can tell, >>most of these changes have broken the correct usage. > >The changes are correct. > >>eg: here, we are talking about the device's softc: > >>- * return the pointer to it's softc structure >>+ * return the pointer to its softc structure > >An apostrophe is used to indicate the possessive case (as in Peter's >computer) except in the special case of the word "its." In this >special case, it's (with the apostrophe) is a contraction of "it is" >while its (without the apostrophe) is the possessive adjective. The >committer is correct. Consult a dictionary or manual of style. Search /usr/src/games/fortune/datfiles/fortunes for Tips for Writer's for some good introductory material to current usage :-) -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." "Drink MONO-tonic, it goes down but it will NEVER come back up!" From owner-cvs-sys Sat Apr 18 03:19:50 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id DAA04951 for cvs-sys-outgoing; Sat, 18 Apr 1998 03:19:50 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from isbalham.ist.co.uk (isbalham.ist.co.uk [192.31.26.1]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA04911; Sat, 18 Apr 1998 10:19:39 GMT (envelope-from rb@gid.co.uk) Received: from gid.co.uk (uucp@localhost) by isbalham.ist.co.uk (8.8.7/8.8.4) with UUCP id LAA13455; Sat, 18 Apr 1998 11:18:30 +0100 (BST) Received: from [194.32.164.2] by seagoon.gid.co.uk; Sat, 18 Apr 1998 11:12:32 +0100 (BST) X-Sender: rb@194.32.164.1 Message-Id: In-Reply-To: <3538336F.41C67EA6@whistle.com> References: <199804180411.MAA16043@spinner.netplex.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Date: Sat, 18 Apr 1998 11:15:38 +0100 To: Peter Wemm From: Bob Bishop Subject: Re: cvs commit: src/sys/dev/dpt dpt_control.c src/sys/gnu/ext2fs... Cc: "Julian Elischer ,Dag-Erling C. Smxf8rgrav" , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk At 6:00 am +0100 18/4/98, Julian Elischer wrote: >[...] >sorry to contradict you Peter but this is the trick.. > >"its" is a single word, the same as: >"his" and "her" > >as in: > >his cat, her cat, its cat > > >the other version, e.g. >"Joh's crow" or "John's VM code", >shouldn't be confused with this.. FWIW, the the trick with the apostrophe is that it indicates something has been left out. This is obvious in the case of can't <=> cannot. For "John's cat" you'd have to go back maybe 500 years to hear someone say "John his cat", but I believe that's more or less how the "'s" possessive originated. -- Bob Bishop (0118) 977 4017 international code +44 118 rb@gid.co.uk fax (0118) 989 4254 between 0800 and 1800 UK From owner-cvs-sys Sat Apr 18 06:26:37 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id GAA25500 for cvs-sys-outgoing; Sat, 18 Apr 1998 06:26:37 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA24437; Sat, 18 Apr 1998 13:26:12 GMT (envelope-from obrien@FreeBSD.org) From: "David E. O'Brien" Received: (from obrien@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id GAA20107; Sat, 18 Apr 1998 06:25:51 -0700 (PDT) Date: Sat, 18 Apr 1998 06:25:51 -0700 (PDT) Message-Id: <199804181325.GAA20107@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/i386/isa wd.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk obrien 1998/04/18 06:25:51 PDT Modified files: sys/i386/isa wd.c Log: MFC (reduce diff w/-CUR, with hopes of getting DMA support into -STABLE) 1.128 (FUNCTIONAL: better sleep handling) 1.131 (STYLE: labels w/o stmt) 1.132 (STYLE: remove unused #includes) 1.141 (FUNCTIONAL: devfs bug, 2nd controler not showing) 1.144 (STYLE: dont shadow other vars) 1.150 (FUNCTIONAL: fix search bug) Revision Changes Path 1.157 +98 -318 src/sys/i386/isa/wd.c From owner-cvs-sys Sat Apr 18 07:06:07 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id HAA14189 for cvs-sys-outgoing; Sat, 18 Apr 1998 07:06:07 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id OAA14148; Sat, 18 Apr 1998 14:05:59 GMT (envelope-from bde@godzilla.zeta.org.au) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.8.7) id AAA25276; Sun, 19 Apr 1998 00:05:20 +1000 Date: Sun, 19 Apr 1998 00:05:20 +1000 From: Bruce Evans Message-Id: <199804181405.AAA25276@godzilla.zeta.org.au> To: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG, obrien@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/isa wd.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >obrien 1998/04/18 06:25:51 PDT > > Modified files: > sys/i386/isa wd.c > Log: > MFC (reduce diff w/-CUR, with hopes of getting DMA support into -STABLE) ^^^ > 1.128 (FUNCTIONAL: better sleep handling) > 1.131 (STYLE: labels w/o stmt) > 1.132 (STYLE: remove unused #includes) > 1.141 (FUNCTIONAL: devfs bug, 2nd controler not showing) > 1.144 (STYLE: dont shadow other vars) > 1.150 (FUNCTIONAL: fix search bug) > > Revision Changes Path > 1.157 +98 -318 src/sys/i386/isa/wd.c ^^^^^oops ^^^^^^^^there aren't quite that many unused includes here :-) Bruce From owner-cvs-sys Sat Apr 18 08:36:06 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id IAA26667 for cvs-sys-outgoing; Sat, 18 Apr 1998 08:36:06 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from spinner.netplex.com.au (spinner.netplex.com.au [202.12.86.3]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id PAA26627; Sat, 18 Apr 1998 15:35:56 GMT (envelope-from peter@netplex.com.au) Received: from spinner.netplex.com.au (localhost [127.0.0.1]) by spinner.netplex.com.au (8.8.8/8.8.8/Spinner) with ESMTP id XAA00836; Sat, 18 Apr 1998 23:35:45 +0800 (WST) (envelope-from peter@spinner.netplex.com.au) Message-Id: <199804181535.XAA00836@spinner.netplex.com.au> X-Mailer: exmh version 2.0.2 2/24/98 To: Bruce Evans cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG, obrien@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/isa wd.c In-reply-to: Your message of "Sun, 19 Apr 1998 00:05:20 +1000." <199804181405.AAA25276@godzilla.zeta.org.au> Date: Sat, 18 Apr 1998 23:35:44 +0800 From: Peter Wemm Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Bruce Evans wrote: > >obrien 1998/04/18 06:25:51 PDT > > > > Modified files: > > sys/i386/isa wd.c > > Log: > > MFC (reduce diff w/-CUR, with hopes of getting DMA support into -STABLE) > ^^^ > > 1.128 (FUNCTIONAL: better sleep handling) > > 1.131 (STYLE: labels w/o stmt) > > 1.132 (STYLE: remove unused #includes) > > 1.141 (FUNCTIONAL: devfs bug, 2nd controler not showing) > > 1.144 (STYLE: dont shadow other vars) > > 1.150 (FUNCTIONAL: fix search bug) > > > > Revision Changes Path > > 1.157 +98 -318 src/sys/i386/isa/wd.c > ^^^^^oops ^^^^^^^^there aren't quite that many unused includes here :-) This looks horribly like the 2.2 version just got spammed over the -current version, doesn't it? :-/ > Bruce > Cheers, -Peter -- Peter Wemm Netplex Consulting From owner-cvs-sys Sat Apr 18 08:45:59 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id IAA27843 for cvs-sys-outgoing; Sat, 18 Apr 1998 08:45:59 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id PAA27788; Sat, 18 Apr 1998 15:45:51 GMT (envelope-from kato@FreeBSD.org) From: KATO Takenori Received: (from kato@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id IAA14379; Sat, 18 Apr 1998 08:45:30 -0700 (PDT) Date: Sat, 18 Apr 1998 08:45:30 -0700 (PDT) Message-Id: <199804181545.IAA14379@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pc98/i386 userconfig.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk kato 1998/04/18 08:45:30 PDT Modified files: (Branch: RELENG_2_2) sys/pc98/i386 userconfig.c Log: Sync with sys/i386/i386/userconfig.c revision 1.48. Submitted by: NOKUBI Hirotaka Revision Changes Path 1.10.2.19 +3 -3 src/sys/pc98/i386/userconfig.c From owner-cvs-sys Sat Apr 18 08:46:56 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id IAA28075 for cvs-sys-outgoing; Sat, 18 Apr 1998 08:46:56 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id PAA28011; Sat, 18 Apr 1998 15:46:50 GMT (envelope-from kato@FreeBSD.org) From: KATO Takenori Received: (from kato@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id IAA14411; Sat, 18 Apr 1998 08:46:29 -0700 (PDT) Date: Sat, 18 Apr 1998 08:46:29 -0700 (PDT) Message-Id: <199804181546.IAA14411@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pc98/pc98 syscons.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk kato 1998/04/18 08:46:29 PDT Modified files: (Branch: RELENG_2_2) sys/pc98/pc98 syscons.c Log: Sync with sys/i386/isa/syscons.c revision 1.182.2.32. Submitted by: NOKUBI Hirotaka Revision Changes Path 1.13.2.29 +8 -8 src/sys/pc98/pc98/syscons.c From owner-cvs-sys Sat Apr 18 12:25:41 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id MAA15307 for cvs-sys-outgoing; Sat, 18 Apr 1998 12:25:41 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA15160; Sat, 18 Apr 1998 19:25:07 GMT (envelope-from des@FreeBSD.org) From: "Dag-Erling C. Sm\xf8rgrav" Received: (from des@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id MAA15002; Sat, 18 Apr 1998 12:24:45 -0700 (PDT) Date: Sat, 18 Apr 1998 12:24:45 -0700 (PDT) Message-Id: <199804181924.MAA15002@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/lib/libc/sys lseek.2 src/sys/kern vfs_syscalls.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk des 1998/04/18 12:24:45 PDT Modified files: lib/libc/sys lseek.2 Log: Return EINVAL and do not changefile pointer if resulting offset is negative. PR: kern/6184 Revision Changes Path 1.7 +2 -2 src/lib/libc/sys/lseek.2 Modified files: sys/kern vfs_syscalls.c Log: Return EINVAL and do not change file pointer if resulting offset is negative. PR: kern/6184 Revision Changes Path 1.98 +7 -5 src/sys/kern/vfs_syscalls.c From owner-cvs-sys Sat Apr 18 16:25:51 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id QAA25305 for cvs-sys-outgoing; Sat, 18 Apr 1998 16:25:51 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA25211; Sat, 18 Apr 1998 23:25:42 GMT (envelope-from nate@FreeBSD.org) From: Nate Williams Received: (from nate@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id QAA16239; Sat, 18 Apr 1998 16:25:18 -0700 (PDT) Date: Sat, 18 Apr 1998 16:25:18 -0700 (PDT) Message-Id: <199804182325.QAA16239@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pccard cardinfo.h pccard.c pcic.c skel.c card.h src/sys/i386/isa aic6360.c if_ed.c if_ep.c if_fe.c sio.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk nate 1998/04/18 16:25:18 PDT Modified files: (Branch: RELENG_2_2) sys/pccard pccard.c pcic.c skel.c sys/i386/isa aic6360.c if_ed.c if_ep.c if_fe.c sio.c Added files: (Branch: RELENG_2_2) sys/pccard cardinfo.h Removed files: (Branch: RELENG_2_2) sys/pccard card.h Log: MFC: pccard/card.h -> pccard/cardinfo.h Revision Changes Path 1.27.2.7 +1 -1 src/sys/pccard/pccard.c 1.23.2.6 +1 -1 src/sys/pccard/pcic.c 1.1.6.3 +1 -1 src/sys/pccard/skel.c 1.24.2.3 +2 -2 src/sys/i386/isa/aic6360.c 1.107.2.7 +2 -2 src/sys/i386/isa/if_ed.c 1.53.2.5 +2 -2 src/sys/i386/isa/if_ep.c 1.20.2.5 +2 -2 src/sys/i386/isa/if_fe.c 1.147.2.14 +2 -2 src/sys/i386/isa/sio.c From owner-cvs-sys Sat Apr 18 16:27:41 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id QAA25619 for cvs-sys-outgoing; Sat, 18 Apr 1998 16:27:41 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA25547; Sat, 18 Apr 1998 23:27:32 GMT (envelope-from nate@FreeBSD.org) From: Nate Williams Received: (from nate@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id QAA16302; Sat, 18 Apr 1998 16:27:08 -0700 (PDT) Date: Sat, 18 Apr 1998 16:27:08 -0700 (PDT) Message-Id: <199804182327.QAA16302@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/pc98/pc98 if_ed.c if_fe.c sio.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk nate 1998/04/18 16:27:08 PDT Modified files: (Branch: RELENG_2_2) sys/pc98/pc98 if_ed.c if_fe.c sio.c Log: [ Whoops, forgot about non-x86 stuff] MFC: pccard/card.h -> pccard/cardinfo.h Revision Changes Path 1.11.2.14 +2 -2 src/sys/pc98/pc98/if_ed.c 1.10.2.8 +2 -2 src/sys/pc98/pc98/if_fe.c 1.8.2.17 +2 -2 src/sys/pc98/pc98/sio.c From owner-cvs-sys Sat Apr 18 20:05:45 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id UAA00961 for cvs-sys-outgoing; Sat, 18 Apr 1998 20:05:45 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id DAA00956; Sun, 19 Apr 1998 03:05:34 GMT (envelope-from bde@godzilla.zeta.org.au) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.8.7) id NAA15945; Sun, 19 Apr 1998 13:00:06 +1000 Date: Sun, 19 Apr 1998 13:00:06 +1000 From: Bruce Evans Message-Id: <199804190300.NAA15945@godzilla.zeta.org.au> To: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-lib@FreeBSD.ORG, cvs-sys@FreeBSD.ORG, des@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/sys lseek.2 src/sys/kern vfs_syscalls.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >des 1998/04/18 12:24:45 PDT > > Modified files: > lib/libc/sys lseek.2 > Log: > Return EINVAL and do not changefile pointer if resulting offset is negative. > PR: kern/6184 > > Revision Changes Path > 1.7 +2 -2 src/lib/libc/sys/lseek.2 > > Modified files: > sys/kern vfs_syscalls.c > Log: > Return EINVAL and do not change file pointer if resulting offset is negative. > PR: kern/6184 This is wrong. Please back it out. It breaks at least the ability to seek to high addresses in /dev/[k]mem on 64 bit systems. Not long ago when off_t was 32 bits, it was normal to seek to "negative" addresses in /dev/kmem, so portable programs should be able to handle such addresses at least if they actually request them. libkvm/kvm_proc.c:kvm_uread() shows how to handle them: errno = 0; if (lseek(fd, (off_t)uva, 0) == -1 && errno != 0) { /* Error. */ ... } /* No error. */ ... This allows seeking to (off_t)-1 provided the system supports it. I replied to the PR, but for some reason the followup didn't get attached to the PR. Bruce From owner-cvs-sys Sat Apr 18 20:26:41 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id UAA02531 for cvs-sys-outgoing; Sat, 18 Apr 1998 20:26:41 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id DAA02484; Sun, 19 Apr 1998 03:26:31 GMT (envelope-from peter@FreeBSD.org) From: Peter Wemm Received: (from peter@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id UAA20024; Sat, 18 Apr 1998 20:26:07 -0700 (PDT) Date: Sat, 18 Apr 1998 20:26:07 -0700 (PDT) Message-Id: <199804190326.UAA20024@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/i386/isa wd.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 1998/04/18 20:26:06 PDT Modified files: sys/i386/isa wd.c Log: Back out previous commit, obrien doesn't seem to be watching. The problem is that the previous commit spammed a hacked 2.2-stable onto -current, deleting the DMA support etc. (I guess that's one way of minimizing diffs between -current and -stable.. :-] ) Revision Changes Path 1.158 +318 -98 src/sys/i386/isa/wd.c From owner-cvs-sys Sat Apr 18 22:17:22 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA14367 for cvs-sys-outgoing; Sat, 18 Apr 1998 22:17:22 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA14288; Sun, 19 Apr 1998 05:17:13 GMT (envelope-from julian@whistle.com) Received: (from daemon@localhost) by alpo.whistle.com (8.8.5/8.8.5) id WAA23995; Sat, 18 Apr 1998 22:08:31 -0700 (PDT) Received: from current1.whistle.com(207.76.205.22) via SMTP by alpo.whistle.com, id smtpd023993; Sun Apr 19 05:08:30 1998 Date: Sat, 18 Apr 1998 22:03:14 -0700 (PDT) From: Julian Elischer To: Bruce Evans cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-lib@FreeBSD.ORG, cvs-sys@FreeBSD.ORG, des@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/sys lseek.2 src/sys/kern vfs_syscalls.c In-Reply-To: <199804190300.NAA15945@godzilla.zeta.org.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk If this is truely 'common' then that's unfortunate. what do POSIX and friends have to say about it? On Sun, 19 Apr 1998, Bruce Evans wrote: > >des 1998/04/18 12:24:45 PDT > > > > Modified files: > > lib/libc/sys lseek.2 > > Log: > > Return EINVAL and do not changefile pointer if resulting offset is negative. > > PR: kern/6184 > > > > Revision Changes Path > > 1.7 +2 -2 src/lib/libc/sys/lseek.2 > > > > Modified files: > > sys/kern vfs_syscalls.c > > Log: > > Return EINVAL and do not change file pointer if resulting offset is negative. > > PR: kern/6184 > > This is wrong. Please back it out. It breaks at least the ability to > seek to high addresses in /dev/[k]mem on 64 bit systems. Not long ago > when off_t was 32 bits, it was normal to seek to "negative" addresses in > /dev/kmem, so portable programs should be able to handle such addresses > at least if they actually request them. libkvm/kvm_proc.c:kvm_uread() > shows how to handle them: > > errno = 0; > if (lseek(fd, (off_t)uva, 0) == -1 && errno != 0) { > /* Error. */ > ... > } > /* No error. */ > ... > > This allows seeking to (off_t)-1 provided the system supports it. > > I replied to the PR, but for some reason the followup didn't get attached > to the PR. > > Bruce > From owner-cvs-sys Sat Apr 18 23:05:31 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id XAA20559 for cvs-sys-outgoing; Sat, 18 Apr 1998 23:05:31 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id GAA20546; Sun, 19 Apr 1998 06:05:20 GMT (envelope-from bde@godzilla.zeta.org.au) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.8.7) id QAA21960; Sun, 19 Apr 1998 16:03:28 +1000 Date: Sun, 19 Apr 1998 16:03:28 +1000 From: Bruce Evans Message-Id: <199804190603.QAA21960@godzilla.zeta.org.au> To: bde@zeta.org.au, julian@whistle.com Subject: Re: cvs commit: src/lib/libc/sys lseek.2 src/sys/kern vfs_syscalls.c Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-lib@FreeBSD.ORG, cvs-sys@FreeBSD.ORG, des@FreeBSD.ORG Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >If this is truely 'common' then that's unfortunate. >what do POSIX and friends have to say about it? Same as usual. On successful completion, the appropriate value is returned. Otherwise, -1 is returned and errno is set to indicate the error. For lseek() the appropriate value is the "offset location as measured in bytes from the beginning of the file". The implementation gets to decided what an error is. The rationale clarifies this in detail for lseek(): "An invalid file offset that would cause EINVAL to be returned may be both implementation defined and device dependent (for example, memory may have few invalid values). A negative file offset may be valid for some devices in some implementations". FreeBSD uses a simple implementation with all negative file offsets valid for all file types. OTOH, for fcntl(), the behaviour is completely undefined if the length of the locked region is negative, and FreeBSD rejects "negative" start and end offsets and negative lengths. This is reasonable because locking is not supported for special files. Bruce