From owner-freebsd-bugs Sun Nov 22 10:39:57 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id KAA00365
for freebsd-bugs-outgoing; Sun, 22 Nov 1998 10:39:57 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA00348
for ; Sun, 22 Nov 1998 10:39:56 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id KAA15460;
Sun, 22 Nov 1998 10:40:01 -0800 (PST)
Received: from post.mail.demon.net (post-11.mail.demon.net [194.217.242.40])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA29402
for ; Sun, 22 Nov 1998 10:31:00 -0800 (PST)
(envelope-from dmlb@ragnet.demon.co.uk)
Received: from [158.152.46.40] (helo=ragnet.demon.co.uk)
by post.mail.demon.net with smtp (Exim 2.053 #1)
id 0zheHA-0003YA-00
for FreeBSD-gnats-submit@freebsd.org; Sun, 22 Nov 1998 18:30:25 +0000
Received: from dmlb by ragnet.demon.co.uk with local (Exim 1.82 #1)
id 0zhc3E-0004BV-00; Sun, 22 Nov 1998 16:07:52 +0000
Message-Id:
Date: Sun, 22 Nov 1998 16:07:52 +0000
From: dmlb@ragnet.demon.co.uk
Reply-To: dmlb@ragnet.demon.co.uk
To: FreeBSD-gnats-submit@FreeBSD.ORG
Cc: dmlb@ragnet.demon.co.uk
X-Send-Pr-Version: 3.2
Subject: kern/8793: MFC, bug fix and addition to mount_portal
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
>Number: 8793
>Category: kern
>Synopsis: mount_portal update/bug fix/addition
>Confidential: no
>Severity: serious
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Nov 22 10:40:00 PST 1998
>Last-Modified:
>Originator: Duncan Barclay
>Organization:
>Release: FreeBSD 2.2.6-RELEASE i386
>Environment:
Stable
>Description:
mount_portal is broken, when run and an attempt is made to
open a socket with
$ cat /p/tcp/localhost/daytime
an error will occur. This is due to bugs in the call to sendmsg
in send_reply(), activate.c.
I will be doing the same for -current in the next day or so.
There is also a security issue in pt_tcp.c and opening
privilaged ports. I think the whole code is bogus but will
submit another pr dealing with it.
I am finishing off code to implement the tcplisten namespace.
This will be done today/tomorrow. A usr/share/examples directory
is also in prepartion. The manual page bogusly suggests I've
finsished it!
>How-To-Repeat:
$ mount_portal /etc/portal.conf /p
$ cat /p/tcp/localhost/daytime
Nov 22 11:07:54 computer portald[4459]: send: Invalid argument
>Fix:
Patches included below, diff'd against stable CVSup'd 06:30 22/11/98.
Index: Makefile
===================================================================
RCS file: /ide0.e/ncvs/src/sbin/mount_portal/Makefile,v
retrieving revision 1.4
diff -u -r1.4 Makefile
--- Makefile 1995/02/21 04:05:17 1.4
+++ Makefile 1998/11/22 14:42:03
@@ -3,7 +3,7 @@
PROG= mount_portal
SRCS= mount_portal.c activate.c conf.c getmntopts.c pt_conf.c \
- pt_exec.c pt_file.c pt_tcp.c
+ pt_exec.c pt_file.c pt_tcp.c
MAN8= mount_portal.8
MOUNT= ${.CURDIR}/../mount
Index: activate.c
===================================================================
RCS file: /ide0.e/ncvs/src/sbin/mount_portal/activate.c,v
retrieving revision 1.1.1.1.8.1
diff -u -r1.1.1.1.8.1 activate.c
--- activate.c 1998/07/17 20:13:32 1.1.1.1.8.1
+++ activate.c 1998/11/22 14:53:10
@@ -112,7 +112,7 @@
int error;
{
int n;
- struct iovec iov;
+ struct iovec iov[1];
struct msghdr msg;
struct {
struct cmsghdr cmsg;
@@ -123,15 +123,17 @@
* Line up error code. Don't worry about byte ordering
* because we must be sending to the local machine.
*/
- iov.iov_base = (caddr_t) &error;
- iov.iov_len = sizeof(error);
+ iov[0].iov_base = (caddr_t) &error;
+ iov[0].iov_len = sizeof(error);
/*
* Build a msghdr
*/
memset(&msg, 0, sizeof(msg));
- msg.msg_iov = &iov;
+ msg.msg_iov = iov;
msg.msg_iovlen = 1;
+ msg.msg_name = NULL;
+ msg.msg_namelen = 0;
/*
* If there is a file descriptor to send then
@@ -149,7 +151,7 @@
/*
* Send to kernel...
*/
- if ((n = sendmsg(so, &msg, MSG_EOR)) < 0)
+ if ((n = sendmsg(so, &msg, 0)) < 0)
syslog(LOG_ERR, "send: %s", strerror(errno));
#ifdef DEBUG
fprintf(stderr, "sent %d bytes\n", n);
@@ -207,6 +209,10 @@
error = ENOENT;
}
+#ifdef DEBUG
+ fprintf(stderr, "returning fd = %d\n", fd);
+ fprintf(stderr, " error = %d [%s]\n", error, strerror(error));
+#endif DEBUG
if (error >= 0)
send_reply(so, fd, error);
Index: conf.c
===================================================================
RCS file: /ide0.e/ncvs/src/sbin/mount_portal/conf.c,v
retrieving revision 1.3
diff -u -r1.3 conf.c
--- conf.c 1995/05/30 06:09:25 1.3
+++ conf.c 1998/11/22 14:21:28
@@ -203,7 +203,7 @@
if (val) {
char errbuf[_POSIX2_LINE_MAX];
regerror(val, &p->p_rx, errbuf, sizeof errbuf);
- syslog(LOG_ERR, "%s:%s: regcomp %s: %s",
+ syslog(LOG_ERR, "%s:%d: regcomp %s: %s",
conf_file, curp->p_lno, curp->p_key, errbuf);
regfree(&p->p_rx);
p->p_rxvalid = 0;
Index: mount_portal.8
===================================================================
RCS file: /ide0.e/ncvs/src/sbin/mount_portal/mount_portal.8,v
retrieving revision 1.2.2.1
diff -u -r1.2.2.1 mount_portal.8
--- mount_portal.8 1998/07/17 20:13:33 1.2.2.1
+++ mount_portal.8 1998/11/22 15:32:22
@@ -89,11 +89,22 @@
By convention, the portal daemon divides the namespace into sub-namespaces,
each of which handles objects of a particular type.
.Pp
-Currently, two sub-namespaces are implemented:
+Currently, three sub-namespaces are implemented:
+.Pa tcplisten ,
.Pa tcp
and
.Pa fs .
The
+.Pa tcplisten
+namespace takes a slash separated hostname and port and creates a TCP/IP
+socket bound to the given hostname-port pair. The hostname may be
+specified as "ANY" to allow any other host to connect to the socket. A
+port number of 0 will dynamically allocate a port, this can be
+discovered by calling
+.Xr getsockname 8
+with the returned file descriptor. Privilaged ports can only be bound to
+by the super-user.
+The
.Pa tcp
namespace takes a hostname and a port (slash separated) and
creates an open TCP/IP connection.
@@ -116,6 +127,7 @@
Subsequent fields are passed to the creation function.
.Bd -literal
# @(#)portal.conf 5.1 (Berkeley) 7/13/92
+tcplisten/ tcplisten tcplisten/
tcp/ tcp tcp/
fs/ file fs/
.Ed
Index: mount_portal.c
===================================================================
RCS file: /ide0.e/ncvs/src/sbin/mount_portal/mount_portal.c,v
retrieving revision 1.7.2.2
diff -u -r1.7.2.2 mount_portal.c
--- mount_portal.c 1997/12/04 07:36:13 1.7.2.2
+++ mount_portal.c 1998/11/22 14:50:27
@@ -93,7 +93,7 @@
;
/* wrtp - waitpid _doesn't_ return 0 when no children! */
#ifdef notdef
- if (pid < 0)
+ if (pid < 0 && errno != ECHILD)
syslog(LOG_WARNING, "waitpid: %s", strerror(errno));
#endif
}
@@ -122,7 +122,7 @@
*/
int ch;
- while ((ch = getopt(argc, argv, "o:")) != -1) {
+ while ((ch = getopt(argc, argv, "o:")) != -1) {
switch (ch) {
case 'o':
getmntopts(optarg, mopts, &mntflags, 0);
@@ -178,7 +178,7 @@
if(!vfc && vfsisloadable("portal")) {
if(vfsload("portal"))
err(EX_OSERR, "vfsload(portal)");
- endvfsent(); /* flush cache */
+ endvfsent();
vfc = getvfsbyname("portal");
}
if (!vfc)
@@ -188,10 +188,10 @@
if (rc < 0)
err(1, NULL);
-#ifdef notdef
/*
* Everything is ready to go - now is a good time to fork
*/
+#ifndef DEBUG
daemon(0, 0);
#endif
@@ -275,7 +275,7 @@
case 0:
(void) close(so);
activate(&q, so2);
- exit(0); /* stupid errors.... tidied up... wrtp*/
+ exit(0);
default:
(void) close(so2);
break;
Index: portald.h
===================================================================
RCS file: /ide0.e/ncvs/src/sbin/mount_portal/portald.h,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 portald.h
--- portald.h 1994/05/26 06:34:33 1.1.1.1
+++ portald.h 1998/11/22 14:40:08
@@ -73,6 +73,8 @@
char *key, char **v, int so, int *fdp));
extern int portal_tcp __P((struct portal_cred *,
char *key, char **v, int so, int *fdp));
/*
* Global functions
Index: pt_conf.c
===================================================================
RCS file: /ide0.e/ncvs/src/sbin/mount_portal/pt_conf.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 pt_conf.c
--- pt_conf.c 1994/05/26 06:34:33 1.1.1.1
+++ pt_conf.c 1998/11/22 14:39:36
@@ -47,5 +47,6 @@
{ "exec", portal_exec },
{ "file", portal_file },
{ "tcp", portal_tcp },
{ 0, 0 }
};
Index: pt_tcp.c
===================================================================
RCS file: /ide0.e/ncvs/src/sbin/mount_portal/pt_tcp.c,v
retrieving revision 1.2.6.1
diff -u -r1.2.6.1 pt_tcp.c
--- pt_tcp.c 1998/08/12 06:27:34 1.2.6.1
+++ pt_tcp.c 1998/11/22 15:20:52
@@ -62,11 +62,11 @@
* An unrecognized suffix is an error.
*/
int portal_tcp(pcr, key, v, kso, fdp)
-struct portal_cred *pcr;
-char *key;
-char **v;
-int kso;
-int *fdp;
+ struct portal_cred *pcr;
+ char *key;
+ char **v;
+ int kso;
+ int *fdp;
{
char host[MAXHOSTNAMELEN];
char port[MAXHOSTNAMELEN];
@@ -122,18 +122,19 @@
#endif
sp = getservbyname(port, "tcp");
- if (sp != NULL)
+ if (sp != NULL) {
s_port = (u_short)sp->s_port;
- else {
- s_port = htons ((u_short)strtol (port, (char**)NULL, 10));
- if (s_port == 0)
+ } else {
+ s_port = strtoul(port, &p, 0);
+ if (s_port == 0 || *p != '\0')
return (EINVAL);
+ s_port = htons(s_port);
}
#ifdef DEBUG
- printf ("port number for %s is %d\n", port, s_port);
+ printf ("port number for %s is %d\n", port, ntohs(s_port));
#endif
- bzero(&sain, sizeof(sain));
+ memset(&sain, 0, sizeof(sain));
sain.sin_len = sizeof(sain);
sain.sin_family = AF_INET;
sain.sin_port = s_port;
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Sun Nov 22 12:19:56 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id MAA08880
for freebsd-bugs-outgoing; Sun, 22 Nov 1998 12:19:56 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id MAA08875
for ; Sun, 22 Nov 1998 12:19:55 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id MAA23555;
Sun, 22 Nov 1998 12:20:00 -0800 (PST)
Date: Sun, 22 Nov 1998 12:20:00 -0800 (PST)
Message-Id: <199811222020.MAA23555@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.ORG
From: Alexander Viro
Subject: Re: bin/8790: [PATCH] Buffer overrun in nvi-1.79.
Reply-To: Alexander Viro
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
The following reply was made to PR bin/8790; it has been noted by GNATS.
From: Alexander Viro
To: David Greenman
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/8790: [PATCH] Buffer overrun in nvi-1.79.
Date: Sun, 22 Nov 1998 15:13:38 -0500 (EST)
On Sat, 21 Nov 1998, David Greenman wrote:
> > Regex used in nvi is vulnerable to the following exploit:
^^^^^
>
> I'm wondering what you mean by "exploitable buffer overrun"...? You make
> this sound like a security problem, but nvi isn't installed suid/sgid.
Erm... First of all, there is 'secure' flag. IIRC it isn't
supposed to be removable. I'm _not_ saying that it has real security
implications for vi (albeit it is possible in really weird setups).
But:
a) It is bug (SIGSEGVing vi by search for right pattern isn't
nice ;-/)
b) It is exploitable bug in regex. And regex is used in suid
beasts. Since GNU regex is GPLed... I suspect that Spencer's one is used
in most cases. So, yes, I'm afraid that it can be security problem. If
there is a regular way to submit bug reports against things like regex
(i.e. piece of code used in many packages) - my apologies for lack of
clues ;-(
Al
#include
--
There are no "civil aviation for dummies" books out there and most of
you would probably be scared and spend a lot of your time looking up
if there was one. :-) Jordan Hubbard in c.u.b.f.m
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Sun Nov 22 13:09:57 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id NAA12909
for freebsd-bugs-outgoing; Sun, 22 Nov 1998 13:09:57 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA12886
for ; Sun, 22 Nov 1998 13:09:55 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id NAA25601;
Sun, 22 Nov 1998 13:10:00 -0800 (PST)
Received: from post.mail.demon.net (post-20.mail.demon.net [194.217.242.27])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA12514
for ; Sun, 22 Nov 1998 13:05:57 -0800 (PST)
(envelope-from dmlb@ragnet.demon.co.uk)
Received: from [158.152.46.40] (helo=ragnet.demon.co.uk)
by post.mail.demon.net with smtp (Exim 2.053 #1)
id 0zhgh7-0001WG-00
for FreeBSD-gnats-submit@freebsd.org; Sun, 22 Nov 1998 21:05:21 +0000
Received: from dmlb by ragnet.demon.co.uk with local (Exim 1.82 #1)
id 0zhgf6-0000N0-00; Sun, 22 Nov 1998 21:03:16 +0000
Message-Id:
Date: Sun, 22 Nov 1998 21:03:16 +0000
From: dmlb@ragnet.demon.co.uk
Reply-To: dmlb@ragnet.demon.co.uk
To: FreeBSD-gnats-submit@FreeBSD.ORG
Cc: dmlb@ragnet.demon.co.uk
X-Send-Pr-Version: 3.2
Subject: misc/8796: Addition to /usr/share/examples
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
>Number: 8796
>Category: misc
>Synopsis: Additional example directory for /usr/share
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sun Nov 22 13:10:00 PST 1998
>Last-Modified:
>Originator: Duncan Barclay
>Organization:
>Release: FreeBSD 2.2.6-RELEASE i386
>Environment:
Examples documenting how to play with the portal filesystem.
>Description:
>How-To-Repeat:
>Fix:
Shar archive of /usr/share/examples/portal
# This is a shell archive. Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file". Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
# portal
# portal/portal.conf
# portal/README
#
echo c - portal
mkdir -p portal > /dev/null 2>&1
echo x - portal/portal.conf
sed 's/^X//' >portal/portal.conf << 'END-of-portal/portal.conf'
Xtcp/ tcp tcp/
Xtcplisten/ tcplisten tcplisten/
Xfs/ file fs/
END-of-portal/portal.conf
echo x - portal/README
sed 's/^X//' >portal/README << 'END-of-portal/README'
X
XThis contains a couple of examples for using the portal filing system.
X
XThe portal file system provides a way of obtaining a file descriptor
Xto a filesystem object (i.e. something that is accessed by open(2),
Xpipe(2), socket(2) or socketpair(2)) via the filesystem namespace.
XAt present the only file descriptor supported are TCP sockets and
Xfiles.
X
XFirst off mount the filesystem using something like:
X
X# mount_portal /usr/share/examples/portal/portal.conf /p
X
XThen you should be able to do things like
X# cat /p/tcp/localhost/daytime
XSun Nov 22 17:50:09 1998
X(assuming inetd is running the daytime service, by default it is off)
X
XOr, how about this security hole
X# cat /p/fs/etc/motd
XFreeBSD 2.2.6-RELEASE (COMPUTER) #0: Sat Aug 22 17:11:37 BST 1998
X
XWelcome to FreeBSD!
X
X# mkdir -p /tmp/root
X# cd /tmp/root
X# mkdir bin p
X# cp /bin/sh /bin/cat bin
X# mount_portal /usr/share/examples/portal/portal.conf /tmp/root/p
X# chroot /tmp/root
X# pwd
X/
X# echo *
Xbin p
X# cat /etc/motd
Xcat: /etc/motd: No such file or directory
X# cat /p/fs/etc/motd
XFreeBSD 2.2.6-RELEASE (COMPUTER) #0: Sat Aug 22 17:11:37 BST 1998
X
XWelcome to FreeBSD!
X
XFinally, a very simple example of the listening server is available,
Xfire up two xterms. In the first
X
Xxterm-1$ cat /p/tcplisten/ANY/6666
X(the ANY is a wildcard just like using INADDR_ANY, any resolvable host
Xcan be used).
X
XIn the second xterm
Xxterm-2$ echo "hello there" >/p/tcp/localhost/6666
X
XYou should see the "hello there" string appear on the first terminal.
X
XUnprivilged users can't create servers on privalged ports.
Xxterm-1$ cat /p/tcplisten/ANY/666
Xcat: /p/tcplisten/ANY/666: Operation not permitted
X
Xbut root can
Xxterm-1# cat /p/tcplisten/ANY/666
X
XIn the second
Xxterm-2$ echo "hello there" >/p/tcp/localhost/666
Xshould produce the expected response.
X
XYou can also swap the client/server read and write commands etc.
END-of-portal/README
exit
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Sun Nov 22 13:09:58 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id NAA12919
for freebsd-bugs-outgoing; Sun, 22 Nov 1998 13:09:58 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA12892
for ; Sun, 22 Nov 1998 13:09:55 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id NAA25610;
Sun, 22 Nov 1998 13:10:01 -0800 (PST)
Received: from post.mail.demon.net (post-20.mail.demon.net [194.217.242.27])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA12564
for ; Sun, 22 Nov 1998 13:06:02 -0800 (PST)
(envelope-from dmlb@ragnet.demon.co.uk)
Received: from [158.152.46.40] (helo=ragnet.demon.co.uk)
by post.mail.demon.net with smtp (Exim 2.053 #1)
id 0zhgh9-0001WQ-00
for FreeBSD-gnats-submit@freebsd.org; Sun, 22 Nov 1998 21:05:24 +0000
Received: from dmlb by ragnet.demon.co.uk with local (Exim 1.82 #1)
id 0zhgbg-0000Jz-00; Sun, 22 Nov 1998 20:59:44 +0000
Message-Id:
Date: Sun, 22 Nov 1998 20:59:44 +0000
From: dmlb@ragnet.demon.co.uk
Reply-To: dmlb@ragnet.demon.co.uk
To: FreeBSD-gnats-submit@FreeBSD.ORG
Cc: dmlb@ragnet.demon.co.uk
X-Send-Pr-Version: 3.2
Subject: kern/8797: Addition to mount_portal
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
>Number: 8797
>Category: kern
>Synopsis: addition of tcplisten namespace to portal FS
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sun Nov 22 13:10:00 PST 1998
>Last-Modified:
>Originator: Duncan Barclay
>Organization:
>Release: FreeBSD 2.2.6-RELEASE i386
>Environment:
-current and -stable
>Description:
Adds tcplisten namespace to the portal filesystem. Will
return a file descriptor to an accept'd socket.
Write servers with /bin/sh
>How-To-Repeat:
n/a
>Fix:
Three files included in shar archive. All taken from current,
but should applied to -stable as well.
I may have overlapped some of these with previous PRs, sorry!
Apply in src/sbin/mount_portal.
# This is a shell archive. Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file". Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
# Makefile
# portald.h
# pt_conf.c
# pt_tcplisten.c
#
echo x - Makefile
sed 's/^X//' >Makefile << 'END-of-Makefile'
X# From: @(#)Makefile 8.3 (Berkeley) 3/27/94
X# $Id: Makefile,v 1.8 1998/01/20 10:40:04 bde Exp $
X
XPROG= mount_portal
XSRCS= mount_portal.c activate.c conf.c getmntopts.c pt_conf.c \
X pt_exec.c pt_file.c pt_tcp.c pt_tcplisten.c
XMAN8= mount_portal.8
X
XMOUNT= ${.CURDIR}/../mount
XCFLAGS+= -I${.CURDIR}/../../sys -I${MOUNT}
X.PATH: ${MOUNT}
X
X.include
END-of-Makefile
echo x - portald.h
sed 's/^X//' >portald.h << 'END-of-portald.h'
X/*
X * Copyright (c) 1992, 1993
X * The Regents of the University of California. All rights reserved.
X * All rights reserved.
X *
X * This code is derived from software donated to Berkeley by
X * Jan-Simon Pendry.
X *
X * Redistribution and use in source and binary forms, with or without
X * modification, are permitted provided that the following conditions
X * are met:
X * 1. Redistributions of source code must retain the above copyright
X * notice, this list of conditions and the following disclaimer.
X * 2. Redistributions in binary form must reproduce the above copyright
X * notice, this list of conditions and the following disclaimer in the
X * documentation and/or other materials provided with the distribution.
X * 3. All advertising materials mentioning features or use of this software
X * must display the following acknowledgement:
X * This product includes software developed by the University of
X * California, Berkeley and its contributors.
X * 4. Neither the name of the University nor the names of its contributors
X * may be used to endorse or promote products derived from this software
X * without specific prior written permission.
X *
X * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
X * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
X * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
X * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
X * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
X * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
X * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
X * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
X * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
X * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
X * SUCH DAMAGE.
X *
X * @(#)portald.h 8.1 (Berkeley) 6/5/93
X *
X * $Id: portald.h,v 1.3 1997/02/22 14:32:55 peter Exp $
X */
X
X#include
X#include
X
X/*
X * Meta-chars in an RE. Paths in the config file containing
X * any of these characters will be matched using regexec, other
X * paths will be prefix-matched.
X */
X#define RE_CHARS ".|()[]*+?\\^$"
X
Xtypedef struct qelem qelem;
X
Xstruct qelem {
X qelem *q_forw;
X qelem *q_back;
X};
X
Xtypedef struct provider provider;
Xstruct provider {
X char *pr_match;
X int (*pr_func) __P((struct portal_cred *,
X char *key, char **v, int so, int *fdp));
X};
Xextern provider providers[];
X
X/*
X * Portal providers
X */
Xextern int portal_exec __P((struct portal_cred *,
X char *key, char **v, int so, int *fdp));
Xextern int portal_file __P((struct portal_cred *,
X char *key, char **v, int so, int *fdp));
Xextern int portal_tcp __P((struct portal_cred *,
X char *key, char **v, int so, int *fdp));
Xextern int portal_tcplisten __P((struct portal_cred *,
X char *key, char **v, int so, int *fdp));
X
X/*
X * Global functions
X */
Xextern void activate __P((qelem *q, int so));
Xextern char **conf_match __P((qelem *q, char *key));
Xextern void conf_read __P((qelem *q, char *conf));
END-of-portald.h
echo x - pt_conf.c
sed 's/^X//' >pt_conf.c << 'END-of-pt_conf.c'
X/*
X * Copyright (c) 1992, 1993
X * The Regents of the University of California. All rights reserved.
X * All rights reserved.
X *
X * This code is derived from software donated to Berkeley by
X * Jan-Simon Pendry.
X *
X * Redistribution and use in source and binary forms, with or without
X * modification, are permitted provided that the following conditions
X * are met:
X * 1. Redistributions of source code must retain the above copyright
X * notice, this list of conditions and the following disclaimer.
X * 2. Redistributions in binary form must reproduce the above copyright
X * notice, this list of conditions and the following disclaimer in the
X * documentation and/or other materials provided with the distribution.
X * 3. All advertising materials mentioning features or use of this software
X * must display the following acknowledgement:
X * This product includes software developed by the University of
X * California, Berkeley and its contributors.
X * 4. Neither the name of the University nor the names of its contributors
X * may be used to endorse or promote products derived from this software
X * without specific prior written permission.
X *
X * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
X * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
X * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
X * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
X * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
X * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
X * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
X * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
X * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
X * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
X * SUCH DAMAGE.
X *
X * @(#)pt_conf.c 8.1 (Berkeley) 6/5/93
X */
X
X#ifndef lint
Xstatic const char rcsid[] =
X "$Id: pt_conf.c,v 1.4 1998/07/06 07:19:25 charnier Exp $";
X#endif /* not lint */
X
X#include
X#include
X#include "portald.h"
X
Xprovider providers[] = {
X { "exec", portal_exec },
X { "file", portal_file },
X { "tcp", portal_tcp },
X { "tcplisten", portal_tcplisten },
X { 0, 0 }
X};
END-of-pt_conf.c
echo x - pt_tcplisten.c
sed 's/^X//' >pt_tcplisten.c << 'END-of-pt_tcplisten.c'
X/*
X * Copyright (c) 1992, 1993
X * The Regents of the University of California. All rights reserved.
X * All rights reserved.
X *
X * This code is derived from software donated to Berkeley by
X * Jan-Simon Pendry.
X *
X * Modified by Duncan Barclay.
X *
X * Redistribution and use in source and binary forms, with or without
X * modification, are permitted provided that the following conditions
X * are met:
X * 1. Redistributions of source code must retain the above copyright
X * notice, this list of conditions and the following disclaimer.
X * 2. Redistributions in binary form must reproduce the above copyright
X * notice, this list of conditions and the following disclaimer in the
X * documentation and/or other materials provided with the distribution.
X * 3. All advertising materials mentioning features or use of this software
X * must display the following acknowledgement:
X * This product includes software developed by the University of
X * California, Berkeley and its contributors.
X * 4. Neither the name of the University nor the names of its contributors
X * may be used to endorse or promote products derived from this software
X * without specific prior written permission.
X *
X * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
X * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
X * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
X * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
X * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
X * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
X * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
X * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
X * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
X * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
X * SUCH DAMAGE.
X *
X * @(#)pt_tcp.c 8.3 (Berkeley) 3/27/94
X *
X * pt_tcp.c,v 1.1.1.1 1994/05/26 06:34:34 rgrimes Exp
X */
X
X#include
X#include
X#include
X#include
X#include
X#include
X#include
X#include
X#include
X#include
X#include
X#include
X
X#include "portald.h"
X
X/*
X * Key will be tcplisten/host/port
X *
X * Create a TCP socket bound to the requested host and port.
X * If the host is "ANY" the receving address will be set to INADDR_ANY.
X * If the port is 0 the caller must find out the returned port number
X * using a call to getsockname.
X *
X */
Xint portal_tcplisten(pcr, key, v, kso, fdp)
X struct portal_cred *pcr;
X char *key;
X char **v;
X int kso;
X int *fdp;
X{
X char host[MAXHOSTNAMELEN];
X char port[MAXHOSTNAMELEN];
X char *p = key + (v[1] ? strlen(v[1]) : 0);
X char *q;
X struct hostent *hp;
X struct servent *sp;
X struct in_addr **ipp;
X struct in_addr *ip[2];
X struct in_addr ina;
X u_short s_port;
X int any = 0;
X struct sockaddr_in sain;
X
X q = strchr(p, '/');
X if (q == 0 || q - p >= sizeof(host))
X return (EINVAL);
X *q = '\0';
X strcpy(host, p);
X p = q + 1;
X
X q = strchr(p, '/');
X if (q)
X *q = '\0';
X if (strlen(p) >= sizeof(port))
X return (EINVAL);
X strcpy(port, p);
X
X if (strcmp(host, "ANY") == 0) {
X any = 1;
X } else {
X hp = gethostbyname(host);
X if (hp != 0) {
X ipp = (struct in_addr **) hp->h_addr_list;
X } else {
X ina.s_addr = inet_addr(host);
X if (ina.s_addr == INADDR_NONE)
X return (EINVAL);
X ip[0] = &ina;
X ip[1] = 0;
X ipp = ip;
X }
X }
X#ifdef DEBUG
X if (any)
X printf("INADDR_ANY to be used for hostname\n");
X else
X printf("inet address for %s is %s\n", host, inet_ntoa(*ipp[0]));
X#endif
X
X sp = getservbyname(port, "tcp");
X if (sp != NULL) {
X s_port = (u_short) sp->s_port;
X } else {
X s_port = strtoul(port, &p, 0);
X if (*p != '\0')
X return (EINVAL);
X s_port = htons(s_port);
X }
X if ((ntohs(s_port) != 0) &&
X (ntohs(s_port) <= IPPORT_RESERVED) &&
X (pcr->pcr_uid != 0))
X return (EPERM);
X#ifdef DEBUG
X printf("port number for %s is %d\n", port, ntohs(s_port));
X#endif
X
X memset(&sain, 0, sizeof(sain));
X sain.sin_len = sizeof(sain);
X sain.sin_family = AF_INET;
X sain.sin_port = s_port;
X
X if (any) {
X int so;
X int sock;
X
X so = socket(AF_INET, SOCK_STREAM, 0);
X if (so < 0) {
X syslog(LOG_ERR, "socket: %m");
X return (errno);
X }
X
X sain.sin_addr.s_addr = INADDR_ANY;
X if (bind(so, (struct sockaddr *) &sain, sizeof(sain)) == 0) {
X listen(so, 1);
X if ((sock = accept(so, (struct sockaddr *)0, (int *)0)) == -1) {
X syslog(LOG_ERR, "accept: %m");
X (void) close(so);
X return (errno);
X }
X *fdp = sock;
X (void) close(so);
X return (0);
X }
X syslog(LOG_ERR, "bind: %m");
X (void) close(so);
X return (errno);
X }
X
X while (ipp[0]) {
X int so;
X int sock;
X
X so = socket(AF_INET, SOCK_STREAM, 0);
X if (so < 0) {
X syslog(LOG_ERR, "socket: %m");
X return (errno);
X }
X
X sain.sin_addr = *ipp[0];
X if (bind(so, (struct sockaddr *) &sain, sizeof(sain)) == 0) {
X listen(so, 1);
X if ((sock = accept(so, (struct sockaddr *)0, (int *)0)) == -1) {
X syslog(LOG_ERR, "accept: %m");
X (void) close(so);
X return (errno);
X }
X *fdp = sock;
X (void) close(so);
X return (0);
X }
X (void) close(so);
X
X ipp++;
X }
X
X syslog(LOG_ERR, "bind: %m");
X return (errno);
X
X}
END-of-pt_tcplisten.c
exit
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Sun Nov 22 13:09:59 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id NAA12923
for freebsd-bugs-outgoing; Sun, 22 Nov 1998 13:09:59 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA12900
for ; Sun, 22 Nov 1998 13:09:56 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id NAA25619;
Sun, 22 Nov 1998 13:10:01 -0800 (PST)
Received: from post.mail.demon.net (post-11.mail.demon.net [194.217.242.40])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA12565
for ; Sun, 22 Nov 1998 13:06:03 -0800 (PST)
(envelope-from dmlb@ragnet.demon.co.uk)
Received: from [158.152.46.40] (helo=ragnet.demon.co.uk)
by post.mail.demon.net with smtp (Exim 2.053 #1)
id 0zhghD-0004ml-00
for FreeBSD-gnats-submit@freebsd.org; Sun, 22 Nov 1998 21:05:28 +0000
Received: from dmlb by ragnet.demon.co.uk with local (Exim 1.82 #1)
id 0zhgUw-0000CB-00; Sun, 22 Nov 1998 20:52:46 +0000
Message-Id:
Date: Sun, 22 Nov 1998 20:52:46 +0000
From: dmlb@ragnet.demon.co.uk
Reply-To: dmlb@ragnet.demon.co.uk
To: FreeBSD-gnats-submit@FreeBSD.ORG
Cc: dmlb@ragnet.demon.co.uk
X-Send-Pr-Version: 3.2
Subject: kern/8798: Patches to make mount_portal work.
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
>Number: 8798
>Category: kern
>Synopsis: Bug to to portal code.
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Nov 22 13:10:01 PST 1998
>Last-Modified:
>Originator: Duncan Barclay
>Organization:
>Release: FreeBSD 3.0-CURRENT i386
>Environment:
-current
>Description:
mount_portal is broken, when run and an attempt is made to
open a socket with
$ cat /p/tcp/localhost/daytime
an error will occur. This is due to bugs in the call to sendmsg
in send_reply(), activate.c.
There is also a security issue in pt_tcp.c and opening
privilaged ports. I think the whole code is bogus but will
submit another pr dealing with it.
>How-To-Repeat:
$ mount_portal /etc/portal.conf /p
$ cat /p/tcp/localhost/daytime
Nov 22 11:07:54 computer portald[4459]: send: Invalid argument
>Fix:
Patches included below, diff'd against current CVSup'd 06:30 22/11/98.
They may not link as I haven't included pt_tcplisten.c in this
pr. Will be following.
Index: Makefile
===================================================================
RCS file: /ide0.e/ncvs/src/sbin/mount_portal/Makefile,v
retrieving revision 1.8
diff -u -r1.8 Makefile
--- Makefile 1998/01/20 10:40:04 1.8
+++ Makefile 1998/11/22 16:59:32
@@ -3,7 +3,7 @@
PROG= mount_portal
SRCS= mount_portal.c activate.c conf.c getmntopts.c pt_conf.c \
- pt_exec.c pt_file.c pt_tcp.c
+ pt_exec.c pt_file.c pt_tcp.c
MAN8= mount_portal.8
MOUNT= ${.CURDIR}/../mount
Index: activate.c
===================================================================
RCS file: /ide0.e/ncvs/src/sbin/mount_portal/activate.c,v
retrieving revision 1.5
diff -u -r1.5 activate.c
--- activate.c 1998/07/06 07:19:23 1.5
+++ activate.c 1998/11/22 20:40:05
@@ -45,6 +45,9 @@
#include
#include
#include
+#ifdef DEBUG
+#include
+#endif /* DEBUG */
#include
#include
#include
@@ -111,7 +114,7 @@
int error;
{
int n;
- struct iovec iov;
+ struct iovec iov[1];
struct msghdr msg;
struct {
struct cmsghdr cmsg;
@@ -122,15 +125,17 @@
* Line up error code. Don't worry about byte ordering
* because we must be sending to the local machine.
*/
- iov.iov_base = (caddr_t) &error;
- iov.iov_len = sizeof(error);
+ iov[0].iov_base = (caddr_t) &error;
+ iov[0].iov_len = sizeof(error);
/*
* Build a msghdr
*/
memset(&msg, 0, sizeof(msg));
- msg.msg_iov = &iov;
+ msg.msg_iov = iov;
msg.msg_iovlen = 1;
+ msg.msg_name = NULL;
+ msg.msg_namelen = 0;
/*
* If there is a file descriptor to send then
@@ -148,7 +153,7 @@
/*
* Send to kernel...
*/
- if ((n = sendmsg(so, &msg, MSG_EOR)) < 0)
+ if ((n = sendmsg(so, &msg, 0)) < 0)
syslog(LOG_ERR, "send: %s", strerror(errno));
#ifdef DEBUG
fprintf(stderr, "sent %d bytes\n", n);
@@ -206,6 +211,10 @@
error = ENOENT;
}
+#ifdef DEBUG
+ fprintf(stderr, "returning fd = %d\n", fd);
+ fprintf(stderr, " error = %d [%s]\n", error, strerror(error));
+#endif DEBUG
if (error >= 0)
send_reply(so, fd, error);
Index: mount_portal.8
===================================================================
RCS file: /ide0.e/ncvs/src/sbin/mount_portal/mount_portal.8,v
retrieving revision 1.3
diff -u -r1.3 mount_portal.8
--- mount_portal.8 1998/07/06 07:19:25 1.3
+++ mount_portal.8 1998/11/22 17:05:05
@@ -89,11 +89,22 @@
By convention, the portal daemon divides the namespace into sub-namespaces,
each of which handles objects of a particular type.
.Pp
-Currently, two sub-namespaces are implemented:
+Currently, three sub-namespaces are implemented:
+.Pa tcplisten ,
.Pa tcp
and
.Pa fs .
The
+.Pa tcplisten
+namespace takes a slash separated hostname and port and creates a TCP/IP
+socket bound to the given hostname-port pair. The hostname may be
+specified as "ANY" to allow any other host to connect to the socket. A
+port number of 0 will dynamically allocate a port, this can be
+discovered by calling
+.Xr getsockname 8
+with the returned file descriptor. Privilaged ports can only be bound to
+by the super-user.
+The
.Pa tcp
namespace takes a hostname and a port (slash separated) and
creates an open TCP/IP connection.
@@ -116,6 +127,7 @@
Subsequent fields are passed to the creation function.
.Bd -literal
# @(#)portal.conf 5.1 (Berkeley) 7/13/92
+tcplisten/ tcplisten tcplisten/
tcp/ tcp tcp/
fs/ file fs/
.Ed
Index: mount_portal.c
===================================================================
RCS file: /ide0.e/ncvs/src/sbin/mount_portal/mount_portal.c,v
retrieving revision 1.13
diff -u -r1.13 mount_portal.c
--- mount_portal.c 1998/07/06 07:19:25 1.13
+++ mount_portal.c 1998/11/22 17:05:53
@@ -190,7 +190,9 @@
/*
* Everything is ready to go - now is a good time to fork
*/
+#ifndef DEBUG
daemon(0, 0);
+#endif
/*
* Start logging (and change name)
Index: portald.h
===================================================================
RCS file: /ide0.e/ncvs/src/sbin/mount_portal/portald.h,v
retrieving revision 1.3
diff -u -r1.3 portald.h
--- portald.h 1997/02/22 14:32:55 1.3
+++ portald.h 1998/11/22 17:06:52
@@ -73,6 +73,8 @@
char *key, char **v, int so, int *fdp));
extern int portal_tcp __P((struct portal_cred *,
char *key, char **v, int so, int *fdp));
+extern int portal_tcplisten __P((struct portal_cred *,
+ char *key, char **v, int so, int *fdp));
/*
* Global functions
Index: pt_conf.c
===================================================================
RCS file: /ide0.e/ncvs/src/sbin/mount_portal/pt_conf.c,v
retrieving revision 1.4
diff -u -r1.4 pt_conf.c
--- pt_conf.c 1998/07/06 07:19:25 1.4
+++ pt_conf.c 1998/11/22 17:07:19
@@ -50,5 +50,6 @@
{ "exec", portal_exec },
{ "file", portal_file },
{ "tcp", portal_tcp },
+ { "tcplisten", portal_tcplisten },
{ 0, 0 }
};
Index: pt_file.c
===================================================================
RCS file: /ide0.e/ncvs/src/sbin/mount_portal/pt_file.c,v
retrieving revision 1.7
diff -u -r1.7 pt_file.c
--- pt_file.c 1998/07/06 07:19:26 1.7
+++ pt_file.c 1998/11/22 20:39:51
@@ -46,6 +46,9 @@
#include
#include
#include
+#ifdef DEBUG
+#include
+#endif /* DEBUG */
#include
#include
#include
Index: pt_tcp.c
===================================================================
RCS file: /ide0.e/ncvs/src/sbin/mount_portal/pt_tcp.c,v
retrieving revision 1.7
diff -u -r1.7 pt_tcp.c
--- pt_tcp.c 1998/07/06 07:19:27 1.7
+++ pt_tcp.c 1998/11/22 17:08:14
@@ -124,9 +124,9 @@
#endif
sp = getservbyname(port, "tcp");
- if (sp != NULL)
+ if (sp != NULL) {
s_port = (u_short)sp->s_port;
- else {
+ } else {
s_port = strtoul(port, &p, 0);
if (s_port == 0 || *p != '\0')
return (EINVAL);
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Sun Nov 22 14:59:56 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id OAA23104
for freebsd-bugs-outgoing; Sun, 22 Nov 1998 14:59:56 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id OAA23097
for ; Sun, 22 Nov 1998 14:59:55 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id PAA00911;
Sun, 22 Nov 1998 15:00:01 -0800 (PST)
Received: from post.mail.demon.net (post-12.mail.demon.net [194.217.242.41])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id OAA22827
for ; Sun, 22 Nov 1998 14:55:30 -0800 (PST)
(envelope-from dmlb@ragnet.demon.co.uk)
Received: from [158.152.46.40] (helo=ragnet.demon.co.uk)
by post.mail.demon.net with smtp (Exim 2.053 #1)
id 0zhiOL-000104-00
for FreeBSD-gnats-submit@freebsd.org; Sun, 22 Nov 1998 22:54:18 +0000
Received: from dmlb by ragnet.demon.co.uk with local (Exim 1.82 #1)
id 0zhhG2-0000l4-00; Sun, 22 Nov 1998 21:41:27 +0000
Message-Id:
Date: Sun, 22 Nov 1998 21:41:27 +0000
From: dmlb@ragnet.demon.co.uk
Reply-To: dmlb@ragnet.demon.co.uk
To: FreeBSD-gnats-submit@FreeBSD.ORG
Cc: dmlb@ragnet.demon.co.uk
X-Send-Pr-Version: 3.2
Subject: kern/8802: Security fix to mount_portal/pt_tcp.c
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
>Number: 8802
>Category: kern
>Synopsis: Users can obtain a bound privaliged TCP port using portal
>Confidential: no
>Severity: critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Nov 22 15:00:00 PST 1998
>Last-Modified:
>Originator: Duncan Barclay
>Organization:
>Release: FreeBSD 2.2.6-RELEASE i386 and FreeBSD 3.0-CURRENT
>Environment:
Any FreeBSD box using the portal FS.
>Description:
The default configuration of the portal filesystem allows any
user to obtain a TCP socket bound to a privilaged port address.
Also, I give up root privs. around the connect, this may be
bogus though.
>How-To-Repeat:
# mount_portal /etc/portal.conf /p
# read
Fix:
Diff's below fix these problems. These are against the
version of sbin/mount_portal/pt_tcp.c I submitted in kern/8793
for -stable. The diff applies fine to the patches I sent in
against current too.
--- pt_tcp.c~ Sun Nov 22 15:20:52 1998
+++ pt_tcp.c Sun Nov 22 21:30:07 1998
@@ -55,11 +55,9 @@
#include "portald.h"
/*
- * Key will be tcp/host/port[/"priv"]
+ * Key will be tcp/host/port
* Create a TCP socket connected to the
* requested host and port.
- * Some trailing suffix values have special meanings.
- * An unrecognized suffix is an error.
*/
int portal_tcp(pcr, key, v, kso, fdp)
struct portal_cred *pcr;
@@ -78,7 +76,6 @@
struct in_addr *ip[2];
struct in_addr ina;
u_short s_port;
- int priv = 0;
struct sockaddr_in sain;
q = strchr(p, '/');
@@ -94,17 +91,6 @@
if (strlen(p) >= sizeof(port))
return (EINVAL);
strcpy(port, p);
- if (q) {
- p = q + 1;
- if (strcmp(p, "priv") == 0) {
- if (pcr->pcr_uid == 0)
- priv = 1;
- else
- return (EPERM);
- } else {
- return (EINVAL);
- }
- }
hp = gethostbyname(host);
if (hp != 0) {
@@ -142,20 +128,20 @@
while (ipp[0]) {
int so;
- if (priv)
- so = rresvport((int *) 0);
- else
- so = socket(AF_INET, SOCK_STREAM, 0);
+ so = socket(AF_INET, SOCK_STREAM, 0);
if (so < 0) {
syslog(LOG_ERR, "socket: %m");
return (errno);
}
sain.sin_addr = *ipp[0];
+ setuid(pcr->pcr_uid);
if (connect(so, (struct sockaddr *) &sain, sizeof(sain)) == 0) {
+ setuid(geteuid()); /* XXX getuid? */
*fdp = so;
return (0);
}
+ setuid(geteuid()); /* XXX getuid? */
(void) close(so);
ipp++;
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Sun Nov 22 19:25:55 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id TAA17184
for freebsd-bugs-outgoing; Sun, 22 Nov 1998 19:25:55 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA17165;
Sun, 22 Nov 1998 19:25:18 -0800 (PST)
(envelope-from jkoshy@FreeBSD.org)
From: Joseph Koshy
Received: (from jkoshy@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id TAA11756;
Sun, 22 Nov 1998 19:25:23 -0800 (PST)
Date: Sun, 22 Nov 1998 19:25:23 -0800 (PST)
Message-Id: <199811230325.TAA11756@freefall.freebsd.org>
To: zerium@zerium.dyn.ml.org, jkoshy@FreeBSD.ORG, freebsd-bugs@FreeBSD.ORG
Subject: Re: bin/8252
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
Synopsis: popen/pclose leaks
State-Changed-From-To: open-closed
State-Changed-By: jkoshy
State-Changed-When: Sun Nov 22 19:24:23 PST 1998
State-Changed-Why:
Fixed in rev 1.11 of "src/lib/libc/gen/popen.c" by peter.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Sun Nov 22 19:39:57 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id TAA18964
for freebsd-bugs-outgoing; Sun, 22 Nov 1998 19:39:57 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA18958
for ; Sun, 22 Nov 1998 19:39:55 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id TAA12882;
Sun, 22 Nov 1998 19:40:00 -0800 (PST)
Received: from ibm.net. (slip166-72-224-194.pa.us.ibm.net [166.72.224.194])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA18133
for ; Sun, 22 Nov 1998 19:32:25 -0800 (PST)
(envelope-from placej@ibm.net)
Received: (from placej@localhost)
by ibm.net. (8.8.8/8.8.8) id WAA00537;
Sun, 22 Nov 1998 22:32:10 -0500 (EST)
(envelope-from placej)
Message-Id: <199811230332.WAA00537@ibm.net.>
Date: Sun, 22 Nov 1998 22:32:10 -0500 (EST)
From: jcplace@ibm.net
Reply-To: jcplace@ibm.net
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: bin/8809: fdisk calls QNX-4 partitions unknown
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
>Number: 8809
>Category: bin
>Synopsis: fdisk calls QNX-4 partitions unknown
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sun Nov 22 19:40:00 PST 1998
>Last-Modified:
>Originator: John C. Place
>Organization:
>Release: FreeBSD 2.2.7-RELEASE i386
>Environment:
>Description:
fdisk does not recognize QNX (current version 4.25) disk partitions. It is just annoying and far be it for me to complain :-)
>How-To-Repeat:
>Fix:
changes to fdisk.c below.
--- fdisk.org Fri Jul 17 16:13:17 1998
+++ fdisk.c Sun Nov 22 13:45:45 1998
@@ -171,7 +171,7 @@
,{0x04, "Primary DOS with 16 bit FAT (<= 32MB)"}
,{0x05, "Extended DOS"}
,{0x06, "Primary 'big' DOS (> 32MB)"}
- ,{0x07, "OS/2 HPFS, NTFS, QNX or Advanced UNIX"}
+ ,{0x07, "OS/2 HPFS, NTFS, QNX-2(16Bit) or Advanced UNIX"}
,{0x08, "AIX filesystem"}
,{0x09, "AIX boot partition or Coherent"}
,{0x0A, "OS/2 Boot Manager or OPUS"}
@@ -181,6 +181,9 @@
,{0x0F, "Extended DOS, LBA"}
,{0x10, "OPUS"}
,{0x40, "VENIX 286"}
+ ,{0x4D, "QNX 4.2 Primary"}
+ ,{0x4E, "QNX 4.2 Secondary"}
+ ,{0x4E, "QNX 4.2 Tertiary"}
,{0x50, "DM"}
,{0x51, "DM"}
,{0x52, "CP/M or Microport SysV/AT"}
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Sun Nov 22 19:59:58 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id TAA20618
for freebsd-bugs-outgoing; Sun, 22 Nov 1998 19:59:58 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA20602
for ; Sun, 22 Nov 1998 19:59:56 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id UAA13961;
Sun, 22 Nov 1998 20:00:01 -0800 (PST)
Received: from floop.interq.net (floop.interq.net [210.157.0.12])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA20551
for ; Sun, 22 Nov 1998 19:58:44 -0800 (PST)
(envelope-from yakisoba@osaka.interq.or.jp)
Received: from albert.einstein (sakai-ppp-210-172-177-208.interq.or.jp [210.172.177.208])
by floop.interq.net (8.9.0/8.9.1/matt89-pop) with ESMTP id MAA24184
for ; Mon, 23 Nov 1998 12:58:04 +0900 (JST)
Received: from osaka.interq.or.jp (localhost.einstein [127.0.0.1])
by albert.einstein (8.8.8/8.8.8) with ESMTP id MAA01940
for ; Mon, 23 Nov 1998 12:57:49 +0900 (JST)
(envelope-from yakisoba@osaka.interq.or.jp)
Message-Id: <3658DD37.645E25C9@osaka.interq.or.jp>
Date: Mon, 23 Nov 1998 12:57:43 +0900
From: Naohiko Tsuji
To: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: bin/8811: bsd.own.mk fix
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
>Number: 8811
>Category: bin
>Synopsis: Problem to use 'NLSMODE' variable in Makefile
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sun Nov 22 20:00:01 PST 1998
>Last-Modified:
>Originator: Naohiko Tsuji
>Organization:
None
>Release: FreeBSD 2.2.7-STABLE i386
>Environment:
>Description:
'NLSMODE' is added in bsd.own.mk revision 1.5 1996/03/31 from
NetBSD.
NetBSD uses 'NONBINMODE' for NLSMODE, but FreeBSD is not
defined.
So, NLSMODE should be defined as 'NOBINMODE'.
However, this problem will not affect the current source tree.
>How-To-Repeat:
>Fix:
*** bsd.own.mk.orig Sun Nov 22 13:07:42 1998
--- bsd.own.mk Sun Nov 22 13:07:42 1998
***************
*** 161,167 ****
NLSDIR?= ${SHAREDIR}/nls
NLSGRP?= ${SHAREOWN}
NLSOWN?= ${SHAREGRP}
! NLSMODE?= ${NONBINMODE}
INCLUDEDIR?= /usr/include
--- 161,167 ----
NLSDIR?= ${SHAREDIR}/nls
NLSGRP?= ${SHAREOWN}
NLSOWN?= ${SHAREGRP}
! NLSMODE?= ${NOBINMODE}
INCLUDEDIR?= /usr/include
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Sun Nov 22 20:49:56 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id UAA25066
for freebsd-bugs-outgoing; Sun, 22 Nov 1998 20:49:56 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id UAA25054
for ; Sun, 22 Nov 1998 20:49:55 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id UAA15802;
Sun, 22 Nov 1998 20:50:00 -0800 (PST)
Date: Sun, 22 Nov 1998 20:50:00 -0800 (PST)
Message-Id: <199811230450.UAA15802@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.ORG
From: "John C. Place"
Subject: Re: bin/8809: fdisk calls QNX-4 partitions unknown
Reply-To: "John C. Place"
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
The following reply was made to PR bin/8809; it has been noted by GNATS.
From: "John C. Place"
To: FreeBSD-gnats-submit@FreeBSD.ORG
Cc: Subject: Re: bin/8809: fdisk calls QNX-4 partitions unknown
Date: Sun, 22 Nov 1998 23:41:01 -0500
On Sun, Nov 22, 1998 at 07:40:00PM -0800, FreeBSD-gnats-submit@FreeBSD.ORG wrote:
> Thank you very much for your problem report.
> It has the internal identification `bin/8809'.
> The individual assigned to look at your
> report is: freebsd-bugs.
>
> >Category: bin
> >Responsible: freebsd-bugs
> >Synopsis: fdisk calls QNX-4 partitions unknown
> >Arrival-Date: Sun Nov 22 19:40:00 PST 1998
Arrrgghhh I found a mistake... copying lines will get you in trouble every
time :-)
changes to fdisk.c should read:
--- fdisk.org Fri Jul 17 16:13:17 1998
+++ fdisk.c Sun Nov 22 23:36:04 1998
@@ -171,7 +171,7 @@
,{0x04, "Primary DOS with 16 bit FAT (<= 32MB)"}
,{0x05, "Extended DOS"}
,{0x06, "Primary 'big' DOS (> 32MB)"}
- ,{0x07, "OS/2 HPFS, NTFS, QNX or Advanced UNIX"}
+ ,{0x07, "OS/2 HPFS, NTFS, QNX-2(16Bit) or Advanced UNIX"}
,{0x08, "AIX filesystem"}
,{0x09, "AIX boot partition or Coherent"}
,{0x0A, "OS/2 Boot Manager or OPUS"}
@@ -181,6 +181,9 @@
,{0x0F, "Extended DOS, LBA"}
,{0x10, "OPUS"}
,{0x40, "VENIX 286"}
+ ,{0x4D, "QNX 4.2 Primary"}
+ ,{0x4E, "QNX 4.2 Secondary"}
+ ,{0x4F, "QNX 4.2 Tertiary"}
,{0x50, "DM"}
,{0x51, "DM"}
,{0x52, "CP/M or Microport SysV/AT"}
Thanks
John
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Sun Nov 22 22:39:58 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id WAA03481
for freebsd-bugs-outgoing; Sun, 22 Nov 1998 22:39:58 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id WAA03476
for ; Sun, 22 Nov 1998 22:39:55 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id WAA20531;
Sun, 22 Nov 1998 22:40:01 -0800 (PST)
Date: Sun, 22 Nov 1998 22:40:01 -0800 (PST)
Message-Id: <199811230640.WAA20531@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.ORG
From: Duncan Barclay
Subject: Re: kern/8793: mount_portal update/bug fix/additioN
Reply-To: Duncan Barclay
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
The following reply was made to PR kern/8793; it has been noted by GNATS.
From: Duncan Barclay
To: freebsd-gnats-submit@freebsd.org
Cc: Subject: Re: kern/8793: mount_portal update/bug fix/additioN
Date: Sun, 22 Nov 1998 23:05:20 -0000 (GMT)
This PR should be read in conjunction with
o [1998/11/22] kern/8793 mount_portal update/bug fix/addition
o [1998/11/22] misc/8796: Addition to /usr/share/examples
o [1998/11/22] kern/8797 addition of tcplisten namespace to portal FS
o [1998/11/22] kern/8798 Bug to to portal code.
This fixes
o [1998/09/25] kern/8050 Portal Filesystem (mount_portal) does not operate
correctly.
s [1998/05/25] kern/6758 mount_portal fails because kernal refuses to accept
MSG_EOR flag in sendmsg
And doesn't do anything with
o [1997/09/13] kern/4528 processes hang if the mount_portal process dies.
Duncan
---
________________________________________________________________________
Duncan Barclay | God smiles upon the little children,
dmlb@ragnet.demon.co.uk | the alcoholics, and the permanently stoned.
________________________________________________________________________
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Mon Nov 23 00:40:46 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id AAA15568
for freebsd-bugs-outgoing; Mon, 23 Nov 1998 00:40:46 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.40.131])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA15559
for ; Mon, 23 Nov 1998 00:40:43 -0800 (PST)
(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
by critter.freebsd.dk (8.9.1/8.8.5) with ESMTP id JAA05150;
Mon, 23 Nov 1998 09:40:04 +0100 (CET)
To: "John C. Place"
cc: freebsd-bugs@FreeBSD.ORG
Subject: Re: bin/8809: fdisk calls QNX-4 partitions unknown
In-reply-to: Your message of "Sun, 22 Nov 1998 20:50:00 PST."
<199811230450.UAA15802@freefall.freebsd.org>
Date: Mon, 23 Nov 1998 09:40:03 +0100
Message-ID: <5148.911810403@critter.freebsd.dk>
From: Poul-Henning Kamp
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
Isn't it about time this table moved into /usr/share/misc/fdisk.types and
fdisk could read it from there ?
--
Poul-Henning Kamp FreeBSD coreteam member
phk@FreeBSD.ORG "Real hackers run -current on their laptop."
"ttyv0" -- What UNIX calls a $20K state-of-the-art, 3D, hi-res color terminal
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Mon Nov 23 01:48:17 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id BAA22354
for freebsd-bugs-outgoing; Mon, 23 Nov 1998 01:48:17 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from ceia.nordier.com (m2-52-dbn.dial-up.net [196.34.155.116])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA22271
for ; Mon, 23 Nov 1998 01:48:00 -0800 (PST)
(envelope-from rnordier@nordier.com)
Received: (from rnordier@localhost) by ceia.nordier.com (8.8.7/8.6.12) id LAA12756; Mon, 23 Nov 1998 11:31:47 +0200 (SAT)
From: Robert Nordier
Message-Id: <199811230931.LAA12756@ceia.nordier.com>
Subject: Re: bin/8809: fdisk calls QNX-4 partitions unknown
In-Reply-To: <5148.911810403@critter.freebsd.dk> from Poul-Henning Kamp at "Nov 23, 98 09:40:03 am"
To: phk@critter.freebsd.dk (Poul-Henning Kamp)
Date: Mon, 23 Nov 1998 11:31:33 +0200 (SAT)
Cc: jcplace@ibm.net, freebsd-bugs@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL31 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
Poul-Henning Kamp wrote:
> Isn't it about time this table moved into /usr/share/misc/fdisk.types and
> fdisk could read it from there ?
I was just about to suggest something similar. And if fdisk.types is
not found, it can just default to "non-FreeBSD disk", which is about
all the Microsoft version does.
Presumably libdisk could be made to use the same table.
--
Robert Nordier
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Mon Nov 23 01:49:58 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id BAA22623
for freebsd-bugs-outgoing; Mon, 23 Nov 1998 01:49:58 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA22608
for ; Mon, 23 Nov 1998 01:49:57 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id BAA29215;
Mon, 23 Nov 1998 01:50:02 -0800 (PST)
Received: from dunn.org (kyoto-5.slip.uiuc.edu [130.126.26.81])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA22373
for ; Mon, 23 Nov 1998 01:48:21 -0800 (PST)
(envelope-from bradley@dunn.org)
Received: (from root@localhost)
by magnate.dunn.org (8.9.1/8.9.1) id DAA05732;
Mon, 23 Nov 1998 03:42:55 -0600 (CST)
(envelope-from bradley)
Message-Id: <199811230942.DAA05732@magnate.dunn.org>
Date: Mon, 23 Nov 1998 03:42:55 -0600 (CST)
From: bradley@dunn.org
Reply-To: bradley@dunn.org
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: kern/8817: -Wtrigraphs cleanup
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
>Number: 8817
>Category: kern
>Synopsis: Patches to silence -Wtrigraphs
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Nov 23 01:50:01 PST 1998
>Last-Modified:
>Originator: Bradley Dunn
>Organization:
>Release: FreeBSD 3.0-CURRENT i386
>Environment:
>Description:
The attached patches silence -Wtrigraphs.
>How-To-Repeat:
>Fix:
--- src/sys/kern/vfs_bio.c.old Mon Nov 23 03:15:36 1998
+++ src/sys/kern/vfs_bio.c Mon Nov 23 03:16:40 1998
@@ -1739,7 +1739,7 @@
m = bp->b_pages[pageindex];
#ifdef VFS_BIO_DIAG
if (m->pindex != objoff)
- panic("allocbuf: page changed offset??!!!?");
+ panic("allocbuf: page changed offset?!!!?");
#endif
bytesinpage = tinc;
if (tinc > (newbsize - toff))
--- src/sys/nfs/nfs_socket.c.old Mon Nov 23 03:17:21 1998
+++ src/sys/nfs/nfs_socket.c Mon Nov 23 03:18:04 1998
@@ -404,11 +404,11 @@
* For the client side:
* - return EINTR if the RPC is terminated, 0 otherwise
* - set R_MUSTRESEND if the send fails for any reason
- * - do any cleanup required by recoverable socket errors (???)
+ * - do any cleanup required by recoverable socket errors (?)
* For the server side:
* - return EINTR or ERESTART if interrupted by a signal
* - return EPIPE if a connection is lost for connection based sockets (TCP...)
- * - do any cleanup required by recoverable socket errors (???)
+ * - do any cleanup required by recoverable socket errors (?)
*/
int
nfs_send(so, nam, top, rep)
@@ -470,7 +470,7 @@
log(LOG_INFO, "nfsd send error %d\n", error);
/*
- * Handle any recoverable (soft) socket errors here. (???)
+ * Handle any recoverable (soft) socket errors here. (?)
*/
if (error != EINTR && error != ERESTART &&
error != EWOULDBLOCK && error != EPIPE)
--- src/sys/pci/if_de.c.old Mon Nov 23 03:19:05 1998
+++ src/sys/pci/if_de.c Mon Nov 23 03:19:13 1998
@@ -2860,7 +2860,7 @@
* Some folks don't use the standard ethernet rom format
* but instead just put the address in the first 6 bytes
* of the rom and let the rest be all 0xffs. (Can we say
- * ZNYX???) (well sometimes they put in a checksum so we'll
+ * ZNYX?) (well sometimes they put in a checksum so we'll
* start at 8).
*/
for (idx = 8; idx < 32; idx++) {
--- src/sys/pci/ncr.c.old Mon Nov 23 03:19:36 1998
+++ src/sys/pci/ncr.c Mon Nov 23 03:20:19 1998
@@ -7116,7 +7116,7 @@
#define TKR_ADPT_ACTNEG 0x08
#define TKR_ADPT_NOSEEK 0x10
#define TKR_ADPT_MORLUN 0x20
- u_char delay; /* unit ? (table ???) */
+ u_char delay; /* unit ? (table ?) */
u_char tags; /* use 4 times as many ... */
u_char filler[60];
};
--- src/sys/i386/isa/if_le.c.old Mon Nov 23 03:20:59 1998
+++ src/sys/i386/isa/if_le.c Mon Nov 23 03:21:13 1998
@@ -1126,7 +1126,7 @@
/*
* The first four bytes of each transmit buffer are for
* control information. The first byte is the control
- * byte, then the length (why not word aligned??), then
+ * byte, then the length (why not word aligned?), then
* the off to the buffer.
*/
--- src/sys/i386/isa/pcvt/pcvt_kbd.c.old Mon Nov 23 03:21:57 1998
+++ src/sys/i386/isa/pcvt/pcvt_kbd.c Mon Nov 23 03:22:53 1998
@@ -2392,7 +2392,7 @@
{
if(vsp->vt_pure_mode == M_PUREVT
|| (vsp->which_fkl == USR_FKL))
- more_chars = (u_char *)"\033[35~"; /* F21 ??!! */
+ more_chars = (u_char *)"\033[35~"; /* F21 ?!?! */
}
}
--- src/sys/i386/isa/ppc.c.old Mon Nov 23 03:23:30 1998
+++ src/sys/i386/isa/ppc.c Mon Nov 23 03:23:47 1998
@@ -1288,7 +1288,7 @@
* Semantics of clearing EPP timeout bit.
* PC87332 - reading SPP_STR does it...
* SMC - write 1 to EPP timeout bit XXX
- * Others - (???) write 0 to EPP timeout bit
+ * Others - (?) write 0 to EPP timeout bit
*/
static void
ppc_reset_epp_timeout(int unit)
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Mon Nov 23 04:39:59 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id EAA09805
for freebsd-bugs-outgoing; Mon, 23 Nov 1998 04:39:59 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id EAA09796
for ; Mon, 23 Nov 1998 04:39:56 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id EAA07292;
Mon, 23 Nov 1998 04:40:01 -0800 (PST)
Received: from dunn.org (rochester-65.slip.uiuc.edu [130.126.25.65])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id EAA09688
for ; Mon, 23 Nov 1998 04:36:19 -0800 (PST)
(envelope-from bradley@dunn.org)
Received: (from root@localhost)
by magnate.dunn.org (8.9.1/8.9.1) id GAA11844;
Mon, 23 Nov 1998 06:03:10 -0600 (CST)
(envelope-from bradley)
Message-Id: <199811231203.GAA11844@magnate.dunn.org>
Date: Mon, 23 Nov 1998 06:03:10 -0600 (CST)
From: bradley@dunn.org
Reply-To: bradley@dunn.org
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: kern/8819: Patch to avoid redefinition of DEBUG
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
>Number: 8819
>Category: kern
>Synopsis: Patch to avoid redefinition of DEBUG
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Nov 23 04:40:01 PST 1998
>Last-Modified:
>Originator: Bradley Dunn
>Organization:
>Release: FreeBSD 3.0-CURRENT i386
>Environment:
>Description:
The attached patch avoids the redefinition of DEBUG in
src/sys/gnu/i386/isa/sound/awe_wave.c
when
options DEBUG
is in the kernel config file.
>How-To-Repeat:
>Fix:
--- src/sys/gnu/i386/isa/sound/awe_wave.c.old Mon Nov 23 05:48:56 1998
+++ src/sys/gnu/i386/isa/sound/awe_wave.c Mon Nov 23 05:51:25 1998
@@ -74,11 +74,11 @@
static int debug_mode = 0;
#ifdef AWE_DEBUG_ON
-#define DEBUG(LVL,XXX) {if (debug_mode > LVL) { XXX; }}
+#define AWE_DEBUG(LVL,XXX) {if (debug_mode > LVL) { XXX; }}
#define ERRMSG(XXX) {if (debug_mode) { XXX; }}
#define FATALERR(XXX) XXX
#else
-#define DEBUG(LVL,XXX) /**/
+#define AWE_DEBUG(LVL,XXX) /**/
#define ERRMSG(XXX) XXX
#define FATALERR(XXX) XXX
#endif
@@ -806,7 +806,7 @@
static void
awe_initialize(void)
{
- DEBUG(0,printk("AWE32: initializing..\n"));
+ AWE_DEBUG(0,printk("AWE32: initializing..\n"));
/* initialize hardware configuration */
awe_poke(AWE_HWCF1, 0x0059);
@@ -1300,7 +1300,7 @@
temp = FX_BYTE(fx, fx_lay, AWE_FX_CHORUS, vp->parm.chorus);
temp = (temp <<24) | (unsigned int)addr;
awe_poke_dw(AWE_CSL(voice), temp);
- DEBUG(4,printk("AWE32: [-- loopend=%x/%x]\n", vp->loopend, addr));
+ AWE_DEBUG(4,printk("AWE32: [-- loopend=%x/%x]\n", vp->loopend, addr));
/* Q & current address (Q 4bit value, MSB) */
addr = vp->start - 1;
@@ -1309,7 +1309,7 @@
temp = FX_BYTE(fx, fx_lay, AWE_FX_FILTERQ, vp->parm.filterQ);
temp = (temp<<28) | (unsigned int)addr;
awe_poke_dw(AWE_CCCA(voice), temp);
- DEBUG(4,printk("AWE32: [-- startaddr=%x/%x]\n", vp->start, addr));
+ AWE_DEBUG(4,printk("AWE32: [-- startaddr=%x/%x]\n", vp->start, addr));
/* reset volume */
awe_poke_dw(AWE_VTFT(voice), 0x0000FFFF);
@@ -1385,7 +1385,7 @@
if (i != voice && IS_PLAYING(i) &&
voices[i].sample && voices[i].ch == voices[voice].ch &&
voices[i].sample->exclusiveClass == exclass) {
- DEBUG(4,printk("AWE32: [exoff(%d)]\n", i));
+ AWE_DEBUG(4,printk("AWE32: [exoff(%d)]\n", i));
awe_terminate(i);
awe_voice_init(i, TRUE);
}
@@ -1403,7 +1403,7 @@
{
if (IS_NO_EFFECT(voice) && !forced) return;
awe_poke(AWE_IP(voice), voices[voice].apitch);
- DEBUG(3,printk("AWE32: [-- pitch=%x]\n", voices[voice].apitch));
+ AWE_DEBUG(3,printk("AWE32: [-- pitch=%x]\n", voices[voice].apitch));
}
/* calculate & change pitch */
@@ -1486,7 +1486,7 @@
temp = (temp<<24) | (unsigned int)addr;
awe_poke_dw(AWE_PSST(voice), temp);
voices[voice].apan = temp;
- DEBUG(4,printk("AWE32: [-- loopstart=%x/%x]\n", vp->loopstart, addr));
+ AWE_DEBUG(4,printk("AWE32: [-- loopstart=%x/%x]\n", vp->loopstart, addr));
}
}
@@ -1584,26 +1584,26 @@
if ((ap = vp->sample) == NULL)
return;
if (ap->index < 0) {
- DEBUG(3,printk("AWE32: set sample (%d)\n", ap->sample));
+ AWE_DEBUG(3,printk("AWE32: set sample (%d)\n", ap->sample));
if (awe_set_sample(ap) < 0)
return;
}
/* calculate offset */
if (ap->fixkey >= 0) {
- DEBUG(3,printk("AWE32: p-> fixkey(%d) tune(%d)\n", ap->fixkey, ap->tune));
+ AWE_DEBUG(3,printk("AWE32: p-> fixkey(%d) tune(%d)\n", ap->fixkey, ap->tune));
offset = (ap->fixkey - ap->root) * 4096 / 12;
} else {
- DEBUG(3,printk("AWE32: p(%d)-> root(%d) tune(%d)\n", vp->note, ap->root, ap->tune));
+ AWE_DEBUG(3,printk("AWE32: p(%d)-> root(%d) tune(%d)\n", vp->note, ap->root, ap->tune));
offset = (vp->note - ap->root) * 4096 / 12;
- DEBUG(4,printk("AWE32: p-> ofs=%d\n", offset));
+ AWE_DEBUG(4,printk("AWE32: p-> ofs=%d\n", offset));
}
offset = (offset * ap->scaleTuning) / 100;
- DEBUG(4,printk("AWE32: p-> scale* ofs=%d\n", offset));
+ AWE_DEBUG(4,printk("AWE32: p-> scale* ofs=%d\n", offset));
offset += ap->tune * 4096 / 1200;
- DEBUG(4,printk("AWE32: p-> tune+ ofs=%d\n", offset));
+ AWE_DEBUG(4,printk("AWE32: p-> tune+ ofs=%d\n", offset));
if (cp->bender != 0) {
- DEBUG(3,printk("AWE32: p-> bend(%d) %d\n", voice, cp->bender));
+ AWE_DEBUG(3,printk("AWE32: p-> bend(%d) %d\n", voice, cp->bender));
/* (819200: 1 semitone) ==> (4096: 12 semitones) */
offset += cp->bender * cp->bender_range / 2400;
}
@@ -1616,7 +1616,7 @@
/* 0xe000: root pitch */
vp->apitch = 0xe000 + ap->rate_offset + offset;
- DEBUG(4,printk("AWE32: p-> sum aofs=%x, rate_ofs=%d\n", vp->apitch, ap->rate_offset));
+ AWE_DEBUG(4,printk("AWE32: p-> sum aofs=%x, rate_ofs=%d\n", vp->apitch, ap->rate_offset));
if (vp->apitch > 0xffff)
vp->apitch = 0xffff;
if (vp->apitch < 0)
@@ -1643,7 +1643,7 @@
if ((ap = vp->sample) == NULL)
return;
if (ap->index < 0) {
- DEBUG(3,printk("AWE32: set sample (%d)\n", ap->sample));
+ AWE_DEBUG(3,printk("AWE32: set sample (%d)\n", ap->sample));
if (awe_set_sample(ap) < 0)
return;
}
@@ -1696,7 +1696,7 @@
ap = vp->sample;
if (ap->index < 0) {
- DEBUG(3,printk("AWE32: set sample (%d)\n", ap->sample));
+ AWE_DEBUG(3,printk("AWE32: set sample (%d)\n", ap->sample));
if (awe_set_sample(ap) < 0)
return;
}
@@ -1714,7 +1714,7 @@
if (vol > 255) vol = 255;
vp->avol = vol;
- DEBUG(3,printk("AWE32: [-- voice(%d) vol=%x]\n", voice, vol));
+ AWE_DEBUG(3,printk("AWE32: [-- voice(%d) vol=%x]\n", voice, vol));
}
@@ -1985,7 +1985,7 @@
{
int i, v2, key;
- DEBUG(2,printk("AWE32: [off(%d) nt=%d vl=%d]\n", voice, note, velocity));
+ AWE_DEBUG(2,printk("AWE32: [off(%d) nt=%d vl=%d]\n", voice, note, velocity));
if (! voice_in_range(voice))
return RET_ERROR(EINVAL);
@@ -2044,7 +2044,7 @@
{
int i, key, state, volonly;
- DEBUG(2,printk("AWE32: [on(%d) nt=%d vl=%d]\n", voice, note, velocity));
+ AWE_DEBUG(2,printk("AWE32: [on(%d) nt=%d vl=%d]\n", voice, note, velocity));
if (! voice_in_range(voice))
return RET_ERROR(EINVAL);
@@ -2171,7 +2171,7 @@
cinfo->def_vrec = awe_search_instr(misc_modes[AWE_MD_DEF_BANK], instr_no);
if (cinfo->vrec < 0 && cinfo->def_vrec < 0) {
- DEBUG(1,printk("AWE32 Warning: can't find instrument %d\n", instr_no));
+ AWE_DEBUG(1,printk("AWE32 Warning: can't find instrument %d\n", instr_no));
}
cinfo->instr = instr_no;
@@ -2346,7 +2346,7 @@
break;
case _AWE_REMOVE_LAST_SAMPLES:
- DEBUG(0,printk("AWE32: remove last samples\n"));
+ AWE_DEBUG(0,printk("AWE32: remove last samples\n"));
if (locked_sf_id > 0)
awe_remove_samples(locked_sf_id);
break;
@@ -2368,7 +2368,7 @@
if (p1 & 0x80) i = FX_FLAG_ADD;
p1 &= 0x3f;
if (p1 < AWE_FX_END) {
- DEBUG(0,printk("AWE32: effects (%d) %d %d\n", voice, p1, p2));
+ AWE_DEBUG(0,printk("AWE32: effects (%d) %d %d\n", voice, p1, p2));
if (i == FX_FLAG_SET)
FX_SET(fx, p1, p2);
else if (i == FX_FLAG_ADD)
@@ -2376,7 +2376,7 @@
else
FX_UNSET(fx, p1);
if (i != FX_FLAG_OFF && parm_defs[p1].realtime) {
- DEBUG(0,printk("AWE32: fx_realtime (%d)\n", voice));
+ AWE_DEBUG(0,printk("AWE32: fx_realtime (%d)\n", voice));
awe_voice_change(voice, parm_defs[p1].realtime);
}
}
@@ -2402,7 +2402,7 @@
break;
case _AWE_INITIAL_VOLUME:
- DEBUG(0,printk("AWE32: init attenuation %d\n", p1));
+ AWE_DEBUG(0,printk("AWE32: init attenuation %d\n", p1));
if (p2 == 0) /* absolute value */
init_atten = (short)p1;
else /* relative value */
@@ -2422,18 +2422,18 @@
break;
case _AWE_CHANNEL_MODE:
- DEBUG(0,printk("AWE32: channel mode = %d\n", p1));
+ AWE_DEBUG(0,printk("AWE32: channel mode = %d\n", p1));
playing_mode = p1;
awe_reset(0);
break;
case _AWE_DRUM_CHANNELS:
- DEBUG(0,printk("AWE32: drum flags = %x\n", p1));
+ AWE_DEBUG(0,printk("AWE32: drum flags = %x\n", p1));
drum_flags = *(unsigned int*)&event[4];
break;
case _AWE_MISC_MODE:
- DEBUG(0,printk("AWE32: misc mode = %d %d\n", p1, p2));
+ AWE_DEBUG(0,printk("AWE32: misc mode = %d %d\n", p1, p2));
if (p1 > AWE_MD_VERSION && p1 < AWE_MD_END)
misc_modes[p1] = p2;
break;
@@ -2443,7 +2443,7 @@
break;
default:
- DEBUG(0,printk("AWE32: hw control cmd=%d voice=%d\n", cmd, voice));
+ AWE_DEBUG(0,printk("AWE32: hw control cmd=%d voice=%d\n", cmd, voice));
break;
}
}
@@ -2455,7 +2455,7 @@
{
int note;
- DEBUG(2,printk("AWE32: [after(%d) %d]\n", voice, pressure));
+ AWE_DEBUG(2,printk("AWE32: [after(%d) %d]\n", voice, pressure));
if (! voice_in_range(voice))
return;
@@ -2492,7 +2492,7 @@
switch (ctrl_num) {
case CTL_BANK_SELECT: /* MIDI control #0 */
- DEBUG(2,printk("AWE32: [bank(%d) %d]\n", voice, value));
+ AWE_DEBUG(2,printk("AWE32: [bank(%d) %d]\n", voice, value));
if (MULTI_LAYER_MODE() && IS_DRUM_CHANNEL(voice) &&
!misc_modes[AWE_MD_TOGGLE_DRUM_BANK])
break;
@@ -2505,7 +2505,7 @@
break;
case CTL_MODWHEEL: /* MIDI control #1 */
- DEBUG(2,printk("AWE32: [modwheel(%d) %d]\n", voice, value));
+ AWE_DEBUG(2,printk("AWE32: [modwheel(%d) %d]\n", voice, value));
i = value * misc_modes[AWE_MD_MOD_SENSE] / 1200;
FX_ADD(&cinfo->fx, AWE_FX_LFO1_PITCH, i);
awe_voice_change(voice, awe_fx_fmmod);
@@ -2514,14 +2514,14 @@
break;
case CTRL_PITCH_BENDER: /* SEQ1 V2 contorl */
- DEBUG(2,printk("AWE32: [bend(%d) %d]\n", voice, value));
+ AWE_DEBUG(2,printk("AWE32: [bend(%d) %d]\n", voice, value));
/* zero centered */
cinfo->bender = value;
awe_voice_change(voice, awe_set_voice_pitch);
break;
case CTRL_PITCH_BENDER_RANGE: /* SEQ1 V2 control */
- DEBUG(2,printk("AWE32: [range(%d) %d]\n", voice, value));
+ AWE_DEBUG(2,printk("AWE32: [range(%d) %d]\n", voice, value));
/* value = sense x 100 */
cinfo->bender_range = value;
/* no audible pitch change yet.. */
@@ -2531,14 +2531,14 @@
if (SINGLE_LAYER_MODE())
value /= 128;
case CTRL_EXPRESSION: /* SEQ1 V2 control */
- DEBUG(2,printk("AWE32: [expr(%d) %d]\n", voice, value));
+ AWE_DEBUG(2,printk("AWE32: [expr(%d) %d]\n", voice, value));
/* 0 - 127 */
cinfo->expression_vol = value;
awe_voice_change(voice, awe_set_voice_vol);
break;
case CTL_PAN: /* MIDI control #10 */
- DEBUG(2,printk("AWE32: [pan(%d) %d]\n", voice, value));
+ AWE_DEBUG(2,printk("AWE32: [pan(%d) %d]\n", voice, value));
/* (0-127) -> signed 8bit */
cinfo->panning = value * 2 - 128;
if (misc_modes[AWE_MD_REALTIME_PAN])
@@ -2549,19 +2549,19 @@
if (SINGLE_LAYER_MODE())
value = (value * 100) / 16383;
case CTRL_MAIN_VOLUME: /* SEQ1 V2 control */
- DEBUG(2,printk("AWE32: [mainvol(%d) %d]\n", voice, value));
+ AWE_DEBUG(2,printk("AWE32: [mainvol(%d) %d]\n", voice, value));
/* 0 - 127 */
cinfo->main_vol = value;
awe_voice_change(voice, awe_set_voice_vol);
break;
case CTL_EXT_EFF_DEPTH: /* reverb effects: 0-127 */
- DEBUG(2,printk("AWE32: [reverb(%d) %d]\n", voice, value));
+ AWE_DEBUG(2,printk("AWE32: [reverb(%d) %d]\n", voice, value));
FX_SET(&cinfo->fx, AWE_FX_REVERB, value * 2);
break;
case CTL_CHORUS_DEPTH: /* chorus effects: 0-127 */
- DEBUG(2,printk("AWE32: [chorus(%d) %d]\n", voice, value));
+ AWE_DEBUG(2,printk("AWE32: [chorus(%d) %d]\n", voice, value));
FX_SET(&cinfo->fx, AWE_FX_CHORUS, value * 2);
break;
@@ -2588,7 +2588,7 @@
break;
default:
- DEBUG(0,printk("AWE32: [control(%d) ctrl=%d val=%d]\n",
+ AWE_DEBUG(0,printk("AWE32: [control(%d) ctrl=%d val=%d]\n",
voice, ctrl_num, value));
break;
}
@@ -2612,7 +2612,7 @@
cinfo = &channels[voice];
cinfo->panning = value;
- DEBUG(2,printk("AWE32: [pan(%d) %d]\n", voice, cinfo->panning));
+ AWE_DEBUG(2,printk("AWE32: [pan(%d) %d]\n", voice, cinfo->panning));
if (misc_modes[AWE_MD_REALTIME_PAN])
awe_voice_change(voice, awe_set_pan);
}
@@ -2623,7 +2623,7 @@
awe_volume_method(int dev, int mode)
{
/* not impremented */
- DEBUG(0,printk("AWE32: [volmethod mode=%d]\n", mode));
+ AWE_DEBUG(0,printk("AWE32: [volmethod mode=%d]\n", mode));
}
@@ -2656,7 +2656,7 @@
/* convert to zero centered value */
cinfo = &channels[voice];
cinfo->bender = value - 8192;
- DEBUG(2,printk("AWE32: [bend(%d) %d]\n", voice, cinfo->bender));
+ AWE_DEBUG(2,printk("AWE32: [bend(%d) %d]\n", voice, cinfo->bender));
awe_voice_change(voice, awe_set_voice_pitch);
}
@@ -3341,7 +3341,7 @@
if (patch.mode & WAVE_LOOP_BACK)
smp->mode_flags |= AWE_SAMPLE_REVERSE_LOOP;
- DEBUG(0,printk("AWE32: [sample %d mode %x]\n", patch.instr_no, smp->mode_flags));
+ AWE_DEBUG(0,printk("AWE32: [sample %d mode %x]\n", patch.instr_no, smp->mode_flags));
if (patch.mode & WAVE_16_BITS) {
/* convert to word offsets */
smp->size /= 2;
@@ -3369,7 +3369,7 @@
rec->tune = -(note % 100);
rec->low = freq_to_note(patch.low_note) / 100;
rec->high = freq_to_note(patch.high_note) / 100;
- DEBUG(1,printk("AWE32: [gus base offset=%d, note=%d, range=%d-%d(%lu-%lu)]\n",
+ AWE_DEBUG(1,printk("AWE32: [gus base offset=%d, note=%d, range=%d-%d(%lu-%lu)]\n",
rec->rate_offset, note,
rec->low, rec->high,
patch.low_note, patch.high_note));
@@ -3402,7 +3402,7 @@
rec->parm.voldcysus = (calc_gus_sustain(patch.env_offset[2]) << 8) |
calc_parm_decay(decay);
rec->parm.volrelease = 0x8000 | calc_parm_decay(release);
- DEBUG(2,printk("AWE32: [gusenv atk=%d, hld=%d, dcy=%d, rel=%d]\n", attack, hold, decay, release));
+ AWE_DEBUG(2,printk("AWE32: [gusenv atk=%d, hld=%d, dcy=%d, rel=%d]\n", attack, hold, decay, release));
rec->attenuation = calc_gus_attenuation(patch.env_offset[0]);
}
@@ -3410,7 +3410,7 @@
if (patch.mode & WAVE_TREMOLO) {
int rate = (patch.tremolo_rate * 1000 / 38) / 42;
rec->parm.tremfrq = ((patch.tremolo_depth / 2) << 8) | rate;
- DEBUG(2,printk("AWE32: [gusenv tremolo rate=%d, dep=%d, tremfrq=%x]\n",
+ AWE_DEBUG(2,printk("AWE32: [gusenv tremolo rate=%d, dep=%d, tremfrq=%x]\n",
patch.tremolo_rate, patch.tremolo_depth,
rec->parm.tremfrq));
}
@@ -3418,7 +3418,7 @@
if (patch.mode & WAVE_VIBRATO) {
int rate = (patch.vibrato_rate * 1000 / 38) / 42;
rec->parm.fm2frq2 = ((patch.vibrato_depth / 6) << 8) | rate;
- DEBUG(2,printk("AWE32: [gusenv vibrato rate=%d, dep=%d, tremfrq=%x]\n",
+ AWE_DEBUG(2,printk("AWE32: [gusenv vibrato rate=%d, dep=%d, tremfrq=%x]\n",
patch.tremolo_rate, patch.tremolo_depth,
rec->parm.tremfrq));
}
@@ -3806,7 +3806,7 @@
if (voice < 0 || voice >= awe_max_voices)
return;
- DEBUG(2,printk("AWE32: [setup(%d) ch=%d]\n", voice, chn));
+ AWE_DEBUG(2,printk("AWE32: [setup(%d) ch=%d]\n", voice, chn));
channels[chn].expression_vol = info->controllers[CTL_EXPRESSION];
channels[chn].main_vol = info->controllers[CTL_MAIN_VOLUME];
channels[chn].panning =
@@ -3841,7 +3841,7 @@
level = (int)IOCTL_IN(arg);
level = ((level & 0xff) + (level >> 8)) / 2;
- DEBUG(0,printk("AWEMix: cmd=%x val=%d\n", cmd & 0xff, level));
+ AWE_DEBUG(0,printk("AWEMix: cmd=%x val=%d\n", cmd & 0xff, level));
if (IO_WRITE_CHECK(cmd)) {
switch (cmd & 0xff) {
@@ -4121,7 +4121,7 @@
if (awe_mem_size <= 0)
return;
#endif
- DEBUG(3,printk("AWE32: initializing FM\n"));
+ AWE_DEBUG(3,printk("AWE32: initializing FM\n"));
/* Initialize the last two channels for DRAM refresh and producing
the reverb and chorus effects for Yamaha OPL-3 synthesizer */
@@ -4280,7 +4280,7 @@
return 0;
if ((awe_peek(AWE_HWCF2) & 0x0003) != 0x0003)
return 0;
- DEBUG(0,printk("AWE32 found at %x\n", awe_base));
+ AWE_DEBUG(0,printk("AWE32 found at %x\n", awe_base));
return 1;
}
@@ -4292,7 +4292,7 @@
for (base = 0x620; base <= 0x680; base += 0x20)
if (awe_detect_base(base))
return 1;
- DEBUG(0,printk("AWE32 not found\n"));
+ AWE_DEBUG(0,printk("AWE32 not found\n"));
return 0;
}
return 1;
@@ -4351,7 +4351,7 @@
}
awe_close_dram();
- DEBUG(0,printk("AWE32: %d Kbytes memory detected\n", awe_mem_size));
+ AWE_DEBUG(0,printk("AWE32: %d Kbytes memory detected\n", awe_mem_size));
/* convert to Kbytes */
awe_mem_size *= 1024;
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Mon Nov 23 05:39:56 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id FAA15298
for freebsd-bugs-outgoing; Mon, 23 Nov 1998 05:39:56 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA15291
for ; Mon, 23 Nov 1998 05:39:55 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id FAA10012;
Mon, 23 Nov 1998 05:40:00 -0800 (PST)
Received: from dunn.org (london-7.slip.uiuc.edu [130.126.26.67])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA15264
for ; Mon, 23 Nov 1998 05:38:56 -0800 (PST)
(envelope-from bradley@dunn.org)
Received: (from root@localhost)
by magnate.dunn.org (8.9.1/8.9.1) id HAA12196;
Mon, 23 Nov 1998 07:36:13 -0600 (CST)
(envelope-from bradley)
Message-Id: <199811231336.HAA12196@magnate.dunn.org>
Date: Mon, 23 Nov 1998 07:36:13 -0600 (CST)
From: bradley@dunn.org
Reply-To: bradley@dunn.org
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: kern/8821: "warning: suggest parentheses" fixes
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
>Number: 8821
>Category: kern
>Synopsis: "warning: suggest parentheses" fixes
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Nov 23 05:40:00 PST 1998
>Last-Modified:
>Originator: Bradley Dunn
>Organization:
>Release: FreeBSD 3.0-CURRENT i386
>Environment:
>Description:
The attached patches fix all "warning: suggest parentheses"
in src/sys/dev
>How-To-Repeat:
>Fix:
--- src/sys/dev/ccd/ccd.c.old Mon Nov 23 06:41:47 1998
+++ src/sys/dev/ccd/ccd.c Mon Nov 23 06:48:26 1998
@@ -316,8 +316,8 @@
* Copy in the pathname of the component.
*/
bzero(tmppath, sizeof(tmppath)); /* sanity */
- if (error = copyinstr(cpaths[ix], tmppath,
- MAXPATHLEN, &ci->ci_pathlen)) {
+ if ((error = copyinstr(cpaths[ix], tmppath,
+ MAXPATHLEN, &ci->ci_pathlen))) {
#ifdef DEBUG
if (ccddebug & (CCDB_FOLLOW|CCDB_INIT))
printf("ccd%d: can't copy path, error = %d\n",
@@ -336,7 +336,7 @@
/*
* XXX: Cache the component's dev_t.
*/
- if (error = VOP_GETATTR(vp, &va, p->p_ucred, p)) {
+ if ((error = VOP_GETATTR(vp, &va, p->p_ucred, p))) {
#ifdef DEBUG
if (ccddebug & (CCDB_FOLLOW|CCDB_INIT))
printf("ccd%d: %s: getattr failed %s = %d\n",
@@ -355,8 +355,8 @@
/*
* Get partition information for the component.
*/
- if (error = VOP_IOCTL(vp, DIOCGPART, (caddr_t)&dpart,
- FREAD, p->p_ucred, p)) {
+ if ((error = VOP_IOCTL(vp, DIOCGPART, (caddr_t)&dpart,
+ FREAD, p->p_ucred, p))) {
#ifdef DEBUG
if (ccddebug & (CCDB_FOLLOW|CCDB_INIT))
printf("ccd%d: %s: ioctl failed, error = %d\n",
@@ -616,7 +616,7 @@
return (ENXIO);
cs = &ccd_softc[unit];
- if (error = ccdlock(cs))
+ if ((error = ccdlock(cs)))
return (error);
lp = &cs->sc_dkdev.dk_label;
@@ -677,7 +677,7 @@
return (ENXIO);
cs = &ccd_softc[unit];
- if (error = ccdlock(cs))
+ if ((error = ccdlock(cs)))
return (error);
part = ccdpart(dev);
@@ -1060,7 +1060,7 @@
if ((flag & FWRITE) == 0)
return (EBADF);
- if (error = ccdlock(cs))
+ if ((error = ccdlock(cs)))
return (error);
/* Fill in some important bits. */
@@ -1115,7 +1115,7 @@
if (ccddebug & CCDB_INIT)
printf("ccdioctl: lookedup = %d\n", lookedup);
#endif
- if (error = ccdlookup(cpp[i], p, &vpp[i])) {
+ if ((error = ccdlookup(cpp[i], p, &vpp[i]))) {
for (j = 0; j < lookedup; ++j)
(void)vn_close(vpp[j], FREAD|FWRITE,
p->p_ucred, p);
@@ -1133,7 +1133,7 @@
/*
* Initialize the ccd. Fills in the softc for us.
*/
- if (error = ccdinit(&ccd, cpp, p)) {
+ if ((error = ccdinit(&ccd, cpp, p))) {
for (j = 0; j < lookedup; ++j)
(void)vn_close(vpp[j], FREAD|FWRITE,
p->p_ucred, p);
@@ -1164,7 +1164,7 @@
if ((flag & FWRITE) == 0)
return (EBADF);
- if (error = ccdlock(cs))
+ if ((error = ccdlock(cs)))
return (error);
/*
@@ -1251,7 +1251,7 @@
if ((flag & FWRITE) == 0)
return (EBADF);
- if (error = ccdlock(cs))
+ if ((error = ccdlock(cs)))
return (error);
cs->sc_flags |= CCDF_LABELLING;
@@ -1347,7 +1347,7 @@
int error;
NDINIT(&nd, LOOKUP, FOLLOW, UIO_USERSPACE, path, p);
- if (error = vn_open(&nd, FREAD|FWRITE, 0)) {
+ if ((error = vn_open(&nd, FREAD|FWRITE, 0))) {
#ifdef DEBUG
if (ccddebug & CCDB_FOLLOW|CCDB_INIT)
printf("ccdlookup: vn_open error = %d\n", error);
@@ -1362,7 +1362,7 @@
return (EBUSY);
}
- if (error = VOP_GETATTR(vp, &va, p->p_ucred, p)) {
+ if ((error = VOP_GETATTR(vp, &va, p->p_ucred, p))) {
#ifdef DEBUG
if (ccddebug & CCDB_FOLLOW|CCDB_INIT)
printf("ccdlookup: getattr error = %d\n", error);
@@ -1434,8 +1434,8 @@
/*
* Call the generic disklabel extraction routine.
*/
- if (errstring = readdisklabel(CCDLABELDEV(dev), ccdstrategy,
- &cs->sc_dkdev.dk_label))
+ if ((errstring = readdisklabel(CCDLABELDEV(dev), ccdstrategy,
+ &cs->sc_dkdev.dk_label)))
ccdmakedisklabel(cs);
#ifdef DEBUG
--- src/sys/dev/en/midway.c.old Mon Nov 23 06:48:53 1998
+++ src/sys/dev/en/midway.c Mon Nov 23 06:49:55 1998
@@ -1274,7 +1274,7 @@
do {
struct ifnet *shadow;
- if (error = suser(curproc->p_ucred, &curproc->p_acflag))
+ if ((error = suser(curproc->p_ucred, &curproc->p_acflag)))
break;
if ((shadow = pvc_attach(ifp)) != NULL) {
--- src/sys/dev/hea/eni_if.c.old Mon Nov 23 06:50:30 1998
+++ src/sys/dev/hea/eni_if.c Mon Nov 23 06:53:21 1998
@@ -215,7 +215,7 @@
/*
* Copy interface name into response structure
*/
- if ( err = copyout ( ifname, avr->avsp_intf, IFNAMSIZ ) )
+ if ( (err = copyout ( ifname, avr->avsp_intf, IFNAMSIZ )) )
break;
/*
@@ -238,8 +238,8 @@
* Copy stats into user's buffer. Return value is
* amount of data copied.
*/
- if ( err = copyout ((void *)&eup->eu_stats, buf,
- count))
+ if ( (err = copyout ((void *)&eup->eu_stats, buf,
+ count)))
break;
buf += count;
buf_len -= count;
@@ -249,7 +249,7 @@
/*
* Record amount we're returning as vendor info...
*/
- if (err = copyout(&count, &avr->avsp_len, sizeof(int)))
+ if ((err = copyout(&count, &avr->avsp_len, sizeof(int))))
break;
/*
--- src/sys/dev/hea/eni_receive.c.old Mon Nov 23 06:53:51 1998
+++ src/sys/dev/hea/eni_receive.c Mon Nov 23 07:20:39 1998
@@ -114,8 +114,8 @@
* VCC into TRASH mode.
*/
if ( ( vci_hdr & VCI_IN_SERVICE ) == 0 ||
- ( vci_hdr & ~VCI_MODE_MASK ==
- VCI_MODE_TRASH << VCI_MODE_SHIFT ) )
+ ( vci_hdr & (~VCI_MODE_MASK ==
+ VCI_MODE_TRASH << VCI_MODE_SHIFT) ) )
goto next_vcc;
/*
--- src/sys/dev/hea/eni_transmit.c.old Mon Nov 23 06:56:03 1998
+++ src/sys/dev/hea/eni_transmit.c Mon Nov 23 06:57:45 1998
@@ -463,7 +463,7 @@
* Get start of data onto full-word alignment
*/
KB_DATASTART ( m, cp, caddr_t );
- if ( align = ((u_int)cp) & (sizeof(u_long)-1)) {
+ if ( (align = ((u_int)cp) & (sizeof(u_long)-1))) {
/*
* Gotta slide the data up
*/
@@ -622,7 +622,7 @@
* AAL5 PDUs need an extra two words for control/length and
* CRC. Check for AAL5 and add requirements here.
*/
- if (aal5 = (evp->ev_connvc->cvc_attr.aal.type == ATM_AAL5))
+ if ((aal5 = (evp->ev_connvc->cvc_attr.aal.type == ATM_AAL5)))
size = pdulen + 2 * sizeof(long);
else
size = pdulen;
--- src/sys/dev/hfa/fore_buffer.c.old Mon Nov 23 06:58:20 1998
+++ src/sys/dev/hfa/fore_buffer.c Mon Nov 23 06:59:19 1998
@@ -690,7 +690,7 @@
/*
* Run through Strategy 1 Small queue
*/
- while (bhp = Q_HEAD(fup->fu_buf1s_bq, Buf_handle)) {
+ while ((bhp = Q_HEAD(fup->fu_buf1s_bq, Buf_handle))) {
caddr_t cp;
/*
@@ -712,7 +712,7 @@
/*
* Run through Strategy 1 Large queue
*/
- while (bhp = Q_HEAD(fup->fu_buf1l_bq, Buf_handle)) {
+ while ((bhp = Q_HEAD(fup->fu_buf1l_bq, Buf_handle))) {
caddr_t cp;
/*
--- src/sys/dev/hfa/fore_if.c.old Mon Nov 23 06:59:58 1998
+++ src/sys/dev/hfa/fore_if.c Mon Nov 23 07:01:19 1998
@@ -106,7 +106,7 @@
/*
* Copy interface name into response structure
*/
- if ( err = copyout ( ifname, avr->avsp_intf, IFNAMSIZ ) )
+ if ( (err = copyout ( ifname, avr->avsp_intf, IFNAMSIZ )) )
break;
/*
@@ -131,7 +131,7 @@
* Copy stats into user's buffer. Return value is
* amount of data copied.
*/
- if (err = copyout((caddr_t)fup->fu_stats, buf, count))
+ if ((err = copyout((caddr_t)fup->fu_stats, buf, count)))
break;
buf += count;
buf_len -= count;
@@ -142,7 +142,7 @@
/*
* Record amount we're returning as vendor info...
*/
- if (err = copyout(&count, &avr->avsp_len, sizeof(int)))
+ if ((err = copyout(&count, &avr->avsp_len, sizeof(int))))
break;
/*
--- src/sys/dev/hfa/fore_output.c.old Mon Nov 23 07:01:43 1998
+++ src/sys/dev/hfa/fore_output.c Mon Nov 23 07:02:15 1998
@@ -301,7 +301,7 @@
* Get start of data onto full-word alignment
*/
KB_DATASTART(m, cp, caddr_t);
- if (align = ((u_int)cp) & (XMIT_SEG_ALIGN - 1)) {
+ if ((align = ((u_int)cp) & (XMIT_SEG_ALIGN - 1))) {
/*
* Gotta slide the data up
*/
--- src/sys/dev/pdq/pdq.c.old Mon Nov 23 07:02:38 1998
+++ src/sys/dev/pdq/pdq.c Mon Nov 23 07:05:54 1998
@@ -764,7 +764,7 @@
dataptr[PDQ_RX_FC_OFFSET+5],
dataptr[PDQ_RX_FC_OFFSET+6]);
/* rx->rx_badcrc++; */
- } else if (status.rxs_fsc == 0 | status.rxs_fsb_e == 1) {
+ } else if ((status.rxs_fsc == 0) | (status.rxs_fsb_e == 1)) {
/* rx->rx_frame_status_errors++; */
} else {
/* hardware fault */
--- src/sys/dev/ppbus/ppb_base.c.old Mon Nov 23 07:06:42 1998
+++ src/sys/dev/ppbus/ppb_base.c Mon Nov 23 07:07:29 1998
@@ -87,7 +87,7 @@
case PPB_INTR:
default:
/* wait 10 ms */
- if ((error = tsleep((caddr_t)dev, PPBPRI | PCATCH,
+ if ((error = tsleep((caddr_t)dev, (PPBPRI | PCATCH),
"ppbpoll", hz/100)))
return (error);
break;
--- src/sys/dev/ppbus/ppbconf.c.old Mon Nov 23 07:08:15 1998
+++ src/sys/dev/ppbus/ppbconf.c Mon Nov 23 07:08:53 1998
@@ -390,7 +390,7 @@
switch (how) {
case (PPB_WAIT | PPB_INTR):
- error = tsleep(ppb, PPBPRI|PCATCH, "ppbreq", 0);
+ error = tsleep(ppb, (PPBPRI|PCATCH), "ppbreq", 0);
break;
case (PPB_WAIT | PPB_NOINTR):
--- src/sys/dev/smbus/smbconf.c.old Mon Nov 23 07:09:35 1998
+++ src/sys/dev/smbus/smbconf.c Mon Nov 23 07:10:03 1998
@@ -78,7 +78,7 @@
switch (how) {
case (SMB_WAIT | SMB_INTR):
- error = tsleep(sc, SMBPRI|PCATCH, "smbreq", 0);
+ error = tsleep(sc, (SMBPRI|PCATCH), "smbreq", 0);
break;
case (SMB_WAIT | SMB_NOINTR):
--- src/sys/dev/iicbus/iiconf.c.old Mon Nov 23 07:10:51 1998
+++ src/sys/dev/iicbus/iiconf.c Mon Nov 23 07:11:07 1998
@@ -78,7 +78,7 @@
switch (how) {
case (IIC_WAIT | IIC_INTR):
- error = tsleep(sc, IICPRI|PCATCH, "iicreq", 0);
+ error = tsleep(sc, (IICPRI|PCATCH), "iicreq", 0);
break;
case (IIC_WAIT | IIC_NOINTR):
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Mon Nov 23 08:03:41 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id IAA28734
for freebsd-bugs-outgoing; Mon, 23 Nov 1998 08:03:41 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from sam.networx.ie (ts05-105.dublin.indigo.ie [194.125.220.115])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id IAA28729
for ; Mon, 23 Nov 1998 08:03:38 -0800 (PST)
(envelope-from mike@NetworX.ie)
Received: from mike (mike.NetworX.ie [194.9.12.33])
by sam.networx.ie (8.8.5/8.8.5) with SMTP id OAA08768
for ; Mon, 23 Nov 1998 14:56:19 GMT
X-Organisation: I.T. NetworX Ltd
X-Business: Network Applications, Consultancy and Training
X-Address: Stonebridge House, Shankill, Co. Dublin, Ireland
X-Voice: +353-1-28-27-233
X-Fax: +353-1-28-27-230
Date: Mon, 23 Nov 1998 15:02:07 PST
From: Michael Ryan
Subject: Y2K
To: freebsd-bugs@FreeBSD.ORG
Message-ID:
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
Hi,
I read your page regarding Y2K compliance
(http://www.freebsd.org/y2kbug.html) and am asking a
question, as invited to do so on that page.
The page says that FreeBSD is Y2K compliant but doesn't
give a list of the system releases that are so. I know
the inference here is that all releases are compliant,
but I need to know for sure that 2.2.2R, 2.2.5R and
2.2.6R are compliant. Can you please confirm this.
Thanks in advance.
Bye,
Mike
mike@NetworX.ie
www.NetworX.ie
---
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Mon Nov 23 09:29:10 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id JAA09363
for freebsd-bugs-outgoing; Mon, 23 Nov 1998 09:29:10 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from ctcdist.com. ([199.3.192.1])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id JAA09358
for ; Mon, 23 Nov 1998 09:29:08 -0800 (PST)
(envelope-from placej@ctcdist.com)
Received: (from placej@localhost)
by ctcdist.com. (8.8.8/8.8.7) id MAA15408;
Mon, 23 Nov 1998 12:27:04 -0500 (EST)
(envelope-from placej)
Message-ID: <19981123122703.A15398@ctcdist.com>
Date: Mon, 23 Nov 1998 12:27:03 -0500
From: "John C. Place"
To: Robert Nordier ,
Poul-Henning Kamp
Cc: freebsd-bugs@FreeBSD.ORG
Subject: Re: bin/8809: fdisk calls QNX-4 partitions unknown
Reply-To: "John C. Place"
References: <5148.911810403@critter.freebsd.dk> <199811230931.LAA12756@ceia.nordier.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.91.1i
In-Reply-To: <199811230931.LAA12756@ceia.nordier.com>; from Robert Nordier on Mon, Nov 23, 1998 at 11:31:33AM +0200
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
On Mon, Nov 23, 1998 at 11:31:33AM +0200, Robert Nordier wrote:
> Poul-Henning Kamp wrote:
>
> > Isn't it about time this table moved into /usr/share/misc/fdisk.types and
> > fdisk could read it from there ?
>
I had no idea that this was perfered, sory about that. I did not the stuff in
the /usr/share tree was used for lowlevel stuff.
> I was just about to suggest something similar. And if fdisk.types is
> not found, it can just default to "non-FreeBSD disk", which is about
> all the Microsoft version does.
>
As long at it still works without the file I guess I agree. But it could be a
little confusing to users that are running it and don't know the various
partition id's like from a floppy.
whatever the decision, If you are looking for a volenteer I think I can handle
it.
L8er
John
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Mon Nov 23 09:43:02 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id JAA11189
for freebsd-bugs-outgoing; Mon, 23 Nov 1998 09:43:02 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [18.24.4.193])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id JAA11180
for ; Mon, 23 Nov 1998 09:43:00 -0800 (PST)
(envelope-from wollman@khavrinen.lcs.mit.edu)
Received: (from wollman@localhost)
by khavrinen.lcs.mit.edu (8.9.1/8.9.1) id MAA22530;
Mon, 23 Nov 1998 12:42:19 -0500 (EST)
(envelope-from wollman)
Date: Mon, 23 Nov 1998 12:42:19 -0500 (EST)
From: Garrett Wollman
Message-Id: <199811231742.MAA22530@khavrinen.lcs.mit.edu>
To: Michael Ryan
Cc: freebsd-bugs@FreeBSD.ORG
Subject: Y2K
In-Reply-To:
References:
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
< said:
> give a list of the system releases that are so. I know
> the inference here is that all releases are compliant,
> but I need to know for sure that 2.2.2R, 2.2.5R and
> 2.2.6R are compliant. Can you please confirm this.
> Thanks in advance.
As a general rule, we're unlikely to make any sort of assurances about
outdated releases. The current releases (2.2.7 and 3.0) are believed
to be compliant, and we will do our utmost to ensure that future
releases remain so.
-GAWollman
--
Garrett A. Wollman | O Siem / We are all family / O Siem / We're all the same
wollman@lcs.mit.edu | O Siem / The fires of freedom
Opinions not those of| Dance in the burning flame
MIT, LCS, CRS, or NSA| - Susan Aglukark and Chad Irschick
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Mon Nov 23 09:59:56 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id JAA12826
for freebsd-bugs-outgoing; Mon, 23 Nov 1998 09:59:56 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id JAA12821
for ; Mon, 23 Nov 1998 09:59:55 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id KAA10433;
Mon, 23 Nov 1998 10:00:01 -0800 (PST)
Date: Mon, 23 Nov 1998 10:00:01 -0800 (PST)
Message-Id: <199811231800.KAA10433@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.ORG
From: Robert Nordier
Subject: Re: kern/8821: "warning: suggest parentheses" fixes
Reply-To: Robert Nordier
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
The following reply was made to PR kern/8821; it has been noted by GNATS.
From: Robert Nordier
To: bradley@dunn.org
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: kern/8821: "warning: suggest parentheses" fixes
Date: Mon, 23 Nov 1998 19:49:24 +0200 (SAT)
bradley@dunn.org wrote:
> >Number: 8821
> >Category: kern
> >Synopsis: "warning: suggest parentheses" fixes
> The attached patches fix all "warning: suggest parentheses"
> in src/sys/dev
Of the various warnings issued by gcc, these are probably the most
questionable because (being purely stylistic suggestions) they may be
issued against code which is technically correct in every respect.
As applied to FreeBSD, the stylistic issue is not really whether the
gcc-suggested style is superior to the present one (it is certainly
arguable that it is). Rather, it is a matter of consistency with
existing practice.
The man page style(9) is an attempt to describe the preferred form
for FreeBSD kernel source files. An extract says:
| No spaces after function names. Commas have a space after them.
| No spaces after `(' or `[' or preceding `]' or `)' characters.
|
| if (error = function(a1, a2))
| exit(error);
|
| Unary operators don't require spaces, binary operators do.
| Don't use parentheses unless they're required for precedence,
| or the statement is really confusing without them.
The majority of the supplied fixes are, in fact, applied to
statements very similar to the quoted style(9) example; and are
therefore clearly not in accordance with the guidelines.
In other cases, an extra level of parentheses is added to '&' and
'|' operands. For example, one of the more complex cases has the
logical form
p & ~q == r << s
which is changed to
p & (~q == r << s)
It is doubtful that such as statement, in either form, qualifies
as "really confusing"; and this essentially disposes of the
other suggested changes.
Unfortunately, in a few cases, you have missed instances where
the warning may have prompted a worthwhile fix.
One example:
> --- src/sys/dev/ppbus/ppb_base.c.old Mon Nov 23 07:06:42 1998
> +++ src/sys/dev/ppbus/ppb_base.c Mon Nov 23 07:07:29 1998
> @@ -87,7 +87,7 @@
> case PPB_INTR:
> default:
> /* wait 10 ms */
> - if ((error = tsleep((caddr_t)dev, PPBPRI | PCATCH,
> + if ((error = tsleep((caddr_t)dev, (PPBPRI | PCATCH),
> "ppbpoll", hz/100)))
> return (error);
> break;
The real "problem" here is in src/sys/dev/ppbus/ppbconf.h, where
#define PPBPRI PZERO+8
should probably be changed to
#define PPBPRI (PZERO + 8)
since #defines in header files are almost always better off
fully-parenthesized.
But just sliding an extra layer of parentheses around the '|' (as in
the patch) achieves nothing, and should not even inhibit the compiler
from continuing to make its original "suggestion".
Apologies if this seems unduly negative. You just happen to have
chosen a category of warnings where it is almost certainly better to
ignore the compiler, rather than make substantial non-functional
source changes to quiet it.
--
Robert Nordier
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Mon Nov 23 10:42:54 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id KAA00531
for freebsd-bugs-outgoing; Mon, 23 Nov 1998 10:42:54 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from ceia.nordier.com (m1-25-dbn.dial-up.net [196.34.155.25])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA00399
for ; Mon, 23 Nov 1998 10:42:22 -0800 (PST)
(envelope-from rnordier@nordier.com)
Received: (from rnordier@localhost) by ceia.nordier.com (8.8.7/8.6.12) id UAA04715; Mon, 23 Nov 1998 20:13:32 +0200 (SAT)
From: Robert Nordier
Message-Id: <199811231813.UAA04715@ceia.nordier.com>
Subject: Re: bin/8809: fdisk calls QNX-4 partitions unknown
In-Reply-To: <19981123122703.A15398@ctcdist.com> from "John C. Place" at "Nov 23, 98 12:27:03 pm"
To: placej@ctcdist.com
Date: Mon, 23 Nov 1998 20:13:29 +0200 (SAT)
Cc: rnordier@nordier.com, phk@critter.freebsd.dk, freebsd-bugs@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL31 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
John C. Place wrote:
> On Mon, Nov 23, 1998 at 11:31:33AM +0200, Robert Nordier wrote:
> > Poul-Henning Kamp wrote:
> >
> > > Isn't it about time this table moved into /usr/share/misc/fdisk.types and
> > > fdisk could read it from there ?
> >
> I had no idea that this was perfered, sory about that. I did not the stuff in
> the /usr/share tree was used for lowlevel stuff.
I think your original submission was fine. This just seems an easier
way to cope with future changes.
> > I was just about to suggest something similar. And if fdisk.types is
> > not found, it can just default to "non-FreeBSD disk", which is about
> > all the Microsoft version does.
> >
> As long at it still works without the file I guess I agree. But it could be a
> little confusing to users that are running it and don't know the various
> partition id's like from a floppy.
>
> whatever the decision, If you are looking for a volenteer I think I can handle
> it.
No need to volunteer particularly: if you like, send diffs. :-)
--
Robert Nordier
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Mon Nov 23 12:29:25 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id MAA12510
for freebsd-bugs-outgoing; Mon, 23 Nov 1998 12:29:25 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id MAA12401
for ; Mon, 23 Nov 1998 12:29:23 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id MAA18990;
Mon, 23 Nov 1998 12:30:01 -0800 (PST)
Received: from storage.delta.odessa.ua (maxa01.TM.Odessa.UA [195.66.192.61])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id MAA11565
for ; Mon, 23 Nov 1998 12:22:59 -0800 (PST)
(envelope-from vns@delta.odessa.ua)
Received: (from vns@localhost)
by storage.delta.odessa.ua (8.9.1/8.8.8) id WAA00995;
Mon, 23 Nov 1998 22:22:37 +0200 (EET)
(envelope-from vns)
Message-Id: <199811232022.WAA00995@storage.delta.odessa.ua>
Date: Mon, 23 Nov 1998 22:22:37 +0200 (EET)
From: "Vladimir N.Silyaev"
Reply-To: vns@delta.odessa.ua
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: kern/8824: IDE BusMaster and driver unit number
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
>Number: 8824
>Category: kern
>Synopsis: Incorrect driver unit number in IDE BusMaster code
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Nov 23 12:30:00 PST 1998
>Last-Modified:
>Originator: Vladimir N.Silyaev
>Organization:
JSC INT
>Release: FreeBSD 3.0-CURRENT i386
>Environment:
FreeBSD 3.0-Current CVSupped last evening
Motherboard with Intel VX chipset
HDD QUANTUM FIREBALL TM2550A
>Description:
When detecting support BusMaster modes and for stage configuring
IDE controller incorrect determine drive unit number. Actualy
for IDE bus this is a Master/Slave device.
This incorrect unit number may lead to incorrect configuring
the IDE controller or don't detecting posibility BusMaster
devices and etc.
The reason it is next: at the time of PCI IDE controller
detection in pci/ide_pci.c module for every enabled channel
Primary and Secondary are created two ide_pci_cookie structure,
one for Master device and one for Secondary device. This structure
has a fields for controller number ctrl - (0-Primary, 1-Secondary),
IO base port iobase_wd, and unit number (0-Master, 1-Secondary).
The code for specific IDE controller use this fields for controller
detection/configuring. The create structures ide_pci_cookie after
its creating are added to softc.cookies list. This module has
a function ide_pci_candma which find ide_pci_cookie for pair
iobase_wd(IO base port) and unit (actualy it is a controller
number, not a drive unit number) and return a pointer to a
ide_pci_cookie structure.
When function ide_pci_candme called from i386/isa/wd.c module via
the function pointer candma in wddma array, it's return same pointer
for a master and slave devices. Because of the ide_pci_cookie items
are added into the head of list, always returned pointer for a slave
device.
>How-To-Repeat:
Enabled support DMA for ide controller (0x2000 bit in flags)
Any motherboard with IDE BusMaster support, supported now in FreeBSD
Any HDD with MultiWord DMA or Ultra DMA support as Master device
at the IDE connector.
Booting in the verbose (-v at a boot prompt) mode.
You can see:
...
ide_pci0: rev 0x00 on pci0.7.1
intel_piix_status: primary master/slave sample = 3, master/slave recovery = 3
intel_piix_status: primary master fastDMAonly disabled, pre/post enabled,
intel_piix_status: IORDY sampling enabled,
intel_piix_status: fast PIO enabled
intel_piix_status: primary master/slave sample = 3, master/slave recovery = 3
intel_piix_status: primary slave fastDMAonly disabled, pre/post disabled,
intel_piix_status: IORDY sampling disabled,
intel_piix_status: fast PIO disabled
ide_pci: busmaster 0 status: 04 from port: 0000f002
....
wdc0 at 0x1f0-0x1f7 irq 14 flags 0xa0ffa0ff on isa
intel_piix_dmainit: setting multiword DMA mode 2
wd0: wdsetmode() setting transfer mode to 22
intel_piix_status: primary slave sample = 3, slave recovery = 1
intel_piix_status: primary slave fastDMAonly disabled, pre/post enabled,
intel_piix_status: IORDY sampling enabled,
intel_piix_status: fast PIO enabled
wdc0: unit 0 (wd0): , DMA, 32-bit, multi-block-16
wd0: 2445MB (5008752 sectors), 4969 cyls, 16 heads, 63 S/T, 512 B/S
wd0: ATA INQUIRE valid = 0003, dmamword = 0407, apio = 0003, udma = 0000
wdc1 at 0x170-0x177 irq 15 flags 0xa0ffa0ff on isa
In this example BusMaster drive is a Master device, but transfer mode setting
was changed for a Slave device.
>Fix:
Don't use DMA if master and slave devices has differnt parameters.
Often it may work, but if detection/configuring code depend from
unit number BusMaster will be not detecting (at least for Intel PIIX)
or set incorrect mode for slave device.
For fixing this problem need add new parameter to candma family
function/function pointer - the paramter wdd_unit. And
ide_pci_candma must scna for a three paramters IO Base, controller
number, and the device number.
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Mon Nov 23 13:29:25 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id NAA19346
for freebsd-bugs-outgoing; Mon, 23 Nov 1998 13:29:25 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA19341
for ; Mon, 23 Nov 1998 13:29:23 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id NAA22638;
Mon, 23 Nov 1998 13:30:01 -0800 (PST)
Date: Mon, 23 Nov 1998 13:30:01 -0800 (PST)
Message-Id: <199811232130.NAA22638@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.ORG
From: Peter Jeremy
Subject: Re: i386/5698: LPIP causes spurious reboots
Reply-To: Peter Jeremy
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
The following reply was made to PR i386/5698; it has been noted by GNATS.
From: Peter Jeremy
To: freebsd-gnats-submit@FreeBSD.ORG
Cc: Subject: Re: i386/5698: LPIP causes spurious reboots
Date: Tue, 24 Nov 1998 08:28:32 +1100
See also kern/6099
Peter
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Mon Nov 23 14:39:24 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id OAA27249
for freebsd-bugs-outgoing; Mon, 23 Nov 1998 14:39:24 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id OAA27243
for ; Mon, 23 Nov 1998 14:39:22 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id OAA27441;
Mon, 23 Nov 1998 14:40:00 -0800 (PST)
Date: Mon, 23 Nov 1998 14:40:00 -0800 (PST)
Message-Id: <199811232240.OAA27441@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.ORG
From: David Gilbert
Subject: Re: kern/8763
Reply-To: David Gilbert
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
The following reply was made to PR kern/8763; it has been noted by GNATS.
From: David Gilbert
To: freebsd-gnats-submit@freebsd.org
Cc: Subject: Re: kern/8763
Date: Mon, 23 Nov 1998 17:32:41 -0500 (EST)
Additional information:
I finally got a crack at ddb because I happend to have the console up
when a crash occured. It had dropped to ddb at:
type 12 trap, code 0
_pmap_remove_pages +0xb3 pmap.c:3025
The stack was:
_pmap_remove_pages(pmap=f64d05a0, xva=0,eva=0) +0xb3 pmap.c:3025
_exit1(p=f64edd00, rv=0) +0x1cf kern_exit.c:214
_exit(p=f64edd00, uap=f656af84) 0x14 kern_exit.c:104
_syscall(frame=27) +0x196 trap.c:1031
_Xsyscall 0x35
syscall 0x1 eip=0c100d72dd, esp=0xefbfd380, ebp=0xefbfd394
Dave.
--
============================================================================
|David Gilbert, Velocet Communications. | Two things can only be |
|Mail: dgilbert@velocet.net | equal if and only if they |
|http://www.velocet.net/~dgilbert | are precisely opposite. |
=========================================================GLO================
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Mon Nov 23 14:47:29 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id OAA28044
for freebsd-bugs-outgoing; Mon, 23 Nov 1998 14:47:29 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id OAA28035;
Mon, 23 Nov 1998 14:47:11 -0800 (PST)
(envelope-from imp@FreeBSD.org)
From: Warner Losh
Received: (from imp@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id OAA27854;
Mon, 23 Nov 1998 14:47:49 -0800 (PST)
Date: Mon, 23 Nov 1998 14:47:49 -0800 (PST)
Message-Id: <199811232247.OAA27854@freefall.freebsd.org>
To: jchristi@vt.edu, imp@FreeBSD.ORG, freebsd-bugs@FreeBSD.ORG,
imp@FreeBSD.ORG
Subject: Re: kern/8743
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
Synopsis: 3.0 boot disk will not probe for Adaptec AHA 1542B SCSI controller
State-Changed-From-To: open-feedback
State-Changed-By: imp
State-Changed-When: Mon Nov 23 15:47:21 MST 1998
State-Changed-Why:
I think this has been fixed
Responsible-Changed-From-To: freebsd-bugs->imp
Responsible-Changed-By: imp
Responsible-Changed-When: Mon Nov 23 15:47:21 MST 1998
Responsible-Changed-Why:
I think this is fixed
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Mon Nov 23 17:49:25 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id RAA17379
for freebsd-bugs-outgoing; Mon, 23 Nov 1998 17:49:25 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA17370
for ; Mon, 23 Nov 1998 17:49:23 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id RAA07309;
Mon, 23 Nov 1998 17:50:01 -0800 (PST)
Received: from nina.pagesz.net (nina.pagesz.net [208.194.157.3])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA16912
for ; Mon, 23 Nov 1998 17:43:28 -0800 (PST)
(envelope-from rhh@pagesz.net)
Received: from stealth.dummynet. (isabella-61.pagesz.net [208.194.157.61])
by nina.pagesz.net (8.8.7/8.8.7) with ESMTP id UAA06274;
Mon, 23 Nov 1998 20:43:23 -0500
Received: (from rhh@localhost)
by stealth.dummynet. (8.9.1/8.8.8) id UAA06410;
Mon, 23 Nov 1998 20:43:57 -0500 (EST)
(envelope-from rhh)
Message-Id: <199811240143.UAA06410@stealth.dummynet.>
Date: Mon, 23 Nov 1998 20:43:57 -0500 (EST)
From: aa8vb@pagesz.net
To: FreeBSD-gnats-submit@FreeBSD.ORG
Cc: aa8vb@pagesz.net
X-Send-Pr-Version: 3.2
Subject: kern/8826: pass(4) syntax bug with CAM pass devices
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
>Number: 8826
>Category: kern
>Synopsis: LINT bug with CAM pass devices
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: doc-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Nov 23 17:50:00 PST 1998
>Last-Modified:
>Originator: Randall Hopper
>Organization:
self
>Release: FreeBSD 3.0-RELEASE i386
>Environment:
Stock 3.0-RELEASE.
>Description:
device pass0 at scbus0 target 6 lun 0 # CAM passthrough = Scanner
consistent with pass(4) generates:
config: line 72: syntax error
replacing "lun" with "unit" like other SCSI devices gets rid of the config
error.
>How-To-Repeat:
See above.
>Fix:
Replace "lun" with "unit" in the pass(4) man page.
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Mon Nov 23 22:11:23 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id WAA12040
for freebsd-bugs-outgoing; Mon, 23 Nov 1998 22:11:23 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from hexonxonx.obfuscation.org (hexonxonx.obfuscation.org [209.183.198.135])
by hub.freebsd.org (8.8.8/8.8.8) with SMTP id WAA12033
for ; Mon, 23 Nov 1998 22:11:19 -0800 (PST)
(envelope-from techs@obfuscation.org)
From: techs@obfuscation.org
Received: (qmail 3690 invoked from network); 24 Nov 1998 06:11:04 -0000
Received: from 3jane.obfuscation.org (p1214@209.183.198.138)
by hexonxonx.obfuscation.org with SMTP; 24 Nov 1998 06:11:04 -0000
Received: (qmail 3265 invoked by uid 10); 24 Nov 1998 06:11:01 -0000
Message-ID: <19981124061101.3264.qmail@3jane.obfuscation.org>
Subject: Re: kern/4859: SMP kernel panics with timeout table full msg when running two cpu intensive programs
To: freebsd-bugs@FreeBSD.ORG
Date: Tue, 24 Nov 1998 01:11:01 -0500 (EST)
Cc: techs@obfuscation.org
Reply-To: techs@obfuscation.org
Organization: little tiny brain pan full of baked apricots, inc.
X-Mailer: ELM [version 2.4 PL25]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
Kenneth Merry wrote:
ivar@hosteng.org wrote...
>
> >Number: 4859
> >Category: kern
> >Synopsis: SMP kernel panics with timeout table full msg when
running
two cpu intensive programs
> >Confidential: no
> >Severity: serious
> >Priority: medium
> >Responsible: freebsd-bugs
> >State: open
> >Class: sw-bug
> >Submitter-Id: current-users
> >Arrival-Date: Sun Oct 26 11:10:00 PST 1997
> >Last-Modified:
> >Originator: Ivar E. Hosteng
> >Organization:
> Merkantildata ASA
> >Release: 3.0-971002-SNAP
> >Environment:
> FreeBSD romulus.hosteng.org 3.0-971002-SNAP FreeBSD 3.0-971002-SNAP #0:
Sun
Oct 26 18:22:38 CET 1997 root@romulus.hosteng.org:/usr/src/sys/compile/erik
i386
> >Description:
> The kernel is bulilt with SMP enabled and is running on a 2 CPU 200Mhz
PPRo system (Intel Providence motherboard) with 128 MB ram.
>
> When i run the rc5 key cracking program for the rc5 cracking contest
(ftp://ftp.distributed.net/pub/rc5-64/v2.6401/rc56401-freebsd-x86-cli.tar.gz) the
system panics with a 'timeout table full' followed by a 'page fault' panic.
>
> Othervise the system have been solid.
> >How-To-Repeat:
> > Just let two copies of the above mentioned program run concurrently for a
period of time. My record (3 trys) is 5 minutes until it panics)
> I tried to reproduce your problem with a -current SMP kernel from
> October 26th. I ran two processes simultaneously for about 20 minutes or
> so without problems.
>
> Try upgrading your kernel to something current, and see if that
> makes any difference.
>
> In case it matters, I'm running:
> ASUS P/I-P65UP5 w/ C-P6ND cpu card with 2 Pentium Pro 200's (256K cache)
> 128MB parity RAM
For what it's worth, the distributed.net RC5DES Client v2.7100.416 running
two instances of itself hangs my system completely. no panic message. no
dump. no nothing. just hang. one instance runs for hours and hours.
adding a second instance hangs the system anywhere from 15 minutes to an
hour later.
FreeBSD hologram-rose.obfuscation.org 3.0-RELEASE FreeBSD 3.0-RELEASE #3:
Thu Nov 19 21:02:49 EST 1998
techs@hologram-rose.obfuscation.org:/usr/src/sys/compile/HOLOGRAM-ROSE
i386
the system is a Micronics W6LI Lightning with two stepping 9 Pentium Pro
180's and 160mb of edo ram.
If someone can tell me what further diagnostic steps would be useful in
getting this tracked down, I'm more than happy to do it. Like Ivar noted,
the system has been stable otherwise.
Is this a PPro only issue?
--
Erik Fichtner; Warrior SysAdmin (emf|techs)
http://www.obfuscation.org/~techs N 39 10.409' W 77 11.750'
"Any attempt to brew coffee with a teapot should result in the error code
"418 I'm a teapot". The resulting entity body MAY be short and stout."
- Sec 2.3.2, RFC 2324
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Mon Nov 23 22:29:24 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id WAA13957
for freebsd-bugs-outgoing; Mon, 23 Nov 1998 22:29:24 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id WAA13949
for ; Mon, 23 Nov 1998 22:29:23 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id WAA19965;
Mon, 23 Nov 1998 22:30:01 -0800 (PST)
Date: Mon, 23 Nov 1998 22:30:01 -0800 (PST)
Message-Id: <199811240630.WAA19965@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.ORG
From: Subject: Re:kern/8824:Incorrect.driver.unit.number.in.IDE.BusMaster.code@FreeBSD.ORG
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
The following reply was made to PR kern/8824; it has been noted by GNATS.
From: To: freebsd-gnats-submit@freebsd.org, vns@delta.odessa.ua
Cc: Subject: Re:kern/8824:Incorrect driver unit number in IDE BusMaster code
Date: Tue, 24 Nov 1998 08:22:57 +0200 (EET)
In the FreeBSD 2.2.7 kernel sources the function xxx_candma has two
arguments: controller number and unit number.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Mon Nov 23 23:49:26 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id XAA18983
for freebsd-bugs-outgoing; Mon, 23 Nov 1998 23:49:26 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA18978
for ; Mon, 23 Nov 1998 23:49:25 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id XAA24188;
Mon, 23 Nov 1998 23:50:02 -0800 (PST)
Date: Mon, 23 Nov 1998 23:50:02 -0800 (PST)
Message-Id: <199811240750.XAA24188@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.ORG
From: Andre Albsmeier
Subject: Re: bin/8122: -current fails to build in INFODIR is set
Reply-To: Andre Albsmeier
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
The following reply was made to PR bin/8122; it has been noted by GNATS.
From: Andre Albsmeier
To: freebsd-gnats-submit@freebsd.org
Cc: Subject: Re: bin/8122: -current fails to build in INFODIR is set
Date: Tue, 24 Nov 1998 08:43:31 +0100
Close me, I am fixed...
-Andre
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 00:08:53 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id AAA20786
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 00:08:53 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA20769;
Tue, 24 Nov 1998 00:08:11 -0800 (PST)
(envelope-from ken@FreeBSD.org)
From: Kenneth Merry
Received: (from ken@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id AAA25814;
Tue, 24 Nov 1998 00:08:49 -0800 (PST)
Date: Tue, 24 Nov 1998 00:08:49 -0800 (PST)
Message-Id: <199811240808.AAA25814@freefall.freebsd.org>
To: andre.albsmeier@mchp.siemens.de, ken@FreeBSD.ORG, freebsd-bugs@FreeBSD.ORG
Subject: Re: bin/8122
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
Synopsis: -current fails to build in INFODIR is set
State-Changed-From-To: open-closed
State-Changed-By: ken
State-Changed-When: Tue Nov 24 00:07:13 PST 1998
State-Changed-Why:
The PR author reports that his problem is fixed, and requested that the PR
be closed.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 02:09:26 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id CAA01522
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 02:09:26 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id CAA01514
for ; Tue, 24 Nov 1998 02:09:23 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id CAA03551;
Tue, 24 Nov 1998 02:10:01 -0800 (PST)
Received: from home.dragondata.com (home.dragondata.com [204.137.237.2])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id CAA01371
for ; Tue, 24 Nov 1998 02:06:13 -0800 (PST)
(envelope-from toasty@home.dragondata.com)
Received: (from root@localhost)
by home.dragondata.com (8.8.8/8.8.5) id EAA10685;
Tue, 24 Nov 1998 04:06:11 -0600 (CST)
Message-Id: <199811241006.EAA10685@home.dragondata.com>
Date: Tue, 24 Nov 1998 04:06:11 -0600 (CST)
From: toasty@dragondata.com
Reply-To: toasty@dragondata.com
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: kern/8834: NFS can corrupt local file cache
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
>Number: 8834
>Category: kern
>Synopsis: NFS can corrupt local file cache
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Nov 24 02:10:01 PST 1998
>Last-Modified:
>Originator: Kevin Day
>Organization:
DragonData Internet Services
>Release: FreeBSD 2.2.7-STABLE i386
>Environment:
2.2.5 NFS server, 2.2.7 NFS client.
dmesg from client:
Copyright (c) 1992-1998 FreeBSD Inc.
Copyright (c) 1982, 1986, 1989, 1991, 1993
The Regents of the University of California. All rights reserved.
FreeBSD 2.2.7-RELEASE #0: Thu Jul 30 16:42:02 CDT 1998
root@shell1.dragondata.com:/usr/src/sys/compile/SHELL1
CPU: Pentium II (quarter-micron) (398.27-MHz 686-class CPU)
Origin = "GenuineIntel" Id = 0x651 Stepping=1
Features=0x183f9ff,,MMX,>
real memory = 402653184 (393216K bytes)
avail memory = 391720960 (382540K bytes)
Probing for devices on PCI bus 0:
chip0 rev 2 on pci0:0:0
chip1 rev 2 on pci0:1:0
chip2 rev 2 on pci0:7:0
chip3 rev 1 on pci0:7:1
chip4 rev 1 int d irq 9 on pci0:7:2
chip5 rev 2 on pci0:7:3
de0 rev 34 int a irq 11 on pci0:14:0
de0: 21140A [10-100Mb/s] pass 2.2
de0: address 00:40:05:43:a3:a3
de1 rev 34 int a irq 10 on pci0:15:0
de1: 21140A [10-100Mb/s] pass 2.2
de1: address 00:40:05:42:dd:26
Probing for devices on PCI bus 1:
vga0 rev 92 on pci1:0:0
Probing for devices on the ISA bus:
sc0 at 0x60-0x6f irq 1 on motherboard
sc0: VGA color <16 virtual consoles, flags=0x0>
sio0 at 0x3f8-0x3ff irq 4 on isa
sio0: type 16550A
sio1: configured irq 3 not in bitmap of probed irqs 0
sio1 not found at 0x2f8
lpt0 at 0x378-0x37f irq 7 on isa
lpt0: Interrupt-driven port
lp0: TCP/IP capable interface
lpt1 not found at 0xffffffff
psm0 not found at 0x60
fdc0 at 0x3f0-0x3f7 irq 6 drq 2 on isa
fdc0: FIFO enabled, 8 bytes threshold
fd0: 1.44MB 3.5in
wdc0 at 0x1f0-0x1f7 irq 14 on isa
wdc0: unit 0 (wd0):
wd0: 8063MB (16514064 sectors), 16383 cyls, 16 heads, 63 S/T, 512 B/S
wdc1 at 0x170-0x177 irq 15 on isa
wdc1: unit 0 (atapi): , removable, dma, iordy
wcd0: 2412/5512Kb/sec, 128Kb cache, audio play, 256 volume levels, ejectable tray
wcd0: no disc inside, unlocked
npx0 flags 0x1 on motherboard
npx0: INT 16 interface
de0: enabling Full Duplex 100baseTX port
de1: enabling 100baseTX port
>Description:
Heavy NFS activity on the client can corrupt local files in use
>How-To-Repeat:
dd if=/mnt/nfsserver/verylargefile of=/tmp/somefile bs=32k &
Then, I started doing a kernel config, then compile.
vers.c started getting bits and pieces of 'verylargefile' mixed in with it.
Until I rebooted, every time vers.c was recreated by config, it had the same
garbage in it.
As a test, I tried copying the corrupted vers.c back to the nfs server.
/kernel: short receive (0/4) from nfs server home.internal:/home
/kernel: nfs server home.internal:/home: not responding
last message repeated 61 times
/kernel: short receive (0/4) from nfs server home.internal:/home
/kernel: nfs server home.internal:/home: not responding
last message repeated 25 times
/kernel: /kernel: vm_fault: pager input (probably hardware) error, PID 15822 failure
last message repeated 33297 times
last message repeated 128988 times
last message repeated 632240 times
last message repeated 639222 times
/kernel: pid 1328 (inetd), uid 0, was killed: exceeded maximum CPU limit
/kernel: pid 15822 (cp), uid 0: exited on signal 11 (core dumped)
At this point, the system locked up... ddb showed it in nfs_bwrite, or some
function under it, apparently stuck in a loop. It wouldn't do a core dump.
Also, if this helps... it seems somewhat related.... If an executable is ran
from an nfs mount, and gets killed for exceeding it's CPU limit, it'll start
doing the never-ending vm_fault: pager input (probably hardware) error over
and over again, too.
Why inetd died there makes no since, it has no cpu limit.
>Fix:
>Audit-Trail:
>Unformatted:
Kevin Day
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 04:09:51 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id EAA13423
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 04:09:51 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from sam.networx.ie (ts03-065.dublin.indigo.ie [194.125.148.75])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id EAA13415
for ; Tue, 24 Nov 1998 04:09:47 -0800 (PST)
(envelope-from mike@NetworX.ie)
Received: from mike (mike.NetworX.ie [194.9.12.33])
by sam.networx.ie (8.8.5/8.8.5) with SMTP id LAA16168;
Tue, 24 Nov 1998 11:24:14 GMT
X-Organisation: I.T. NetworX Ltd
X-Business: Network Applications, Consultancy and Training
X-Address: Stonebridge House, Shankill, Co. Dublin, Ireland
X-Voice: +353-1-28-27-233
X-Fax: +353-1-28-27-230
Date: Tue, 24 Nov 1998 11:30:07 PST
From: Michael Ryan
Subject: Re: Y2K
To: Garrett Wollman
cc: freebsd-bugs@FreeBSD.ORG
Message-ID:
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
On Mon, 23 Nov 1998 12:42:19 -0500 (EST) Garrett Wollman wrote:
> > but I need to know for sure that 2.2.2R, 2.2.5R and
> > 2.2.6R are compliant. Can you please confirm this.
>
> As a general rule, we're unlikely to make any sort of assurances about
> outdated releases.
I know FreeBSD is free but the time taken to install the latest
version, as well as re-install and test all the system and
application software (and, more likely, end up upgrading to the
near-latest versions of several packages because that's what comes
with the latest version of FreeBSD) is going to cost me at least
one week in time. I'm a consultant and charge my customer by the
hour. Surely he's entitled to know whether the FreeBSD 2.2.5R he
has in production is Y2K compliant or not instead of being forced
to shell out a large amount of money for an upgrade, as would be
warranted by acceptance of the above policy position?
Bye,
Mike
mike@NetworX.ie
www.NetworX.ie
---
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 04:41:28 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id EAA16337
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 04:41:28 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.40.131])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id EAA16331
for ; Tue, 24 Nov 1998 04:41:26 -0800 (PST)
(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
by critter.freebsd.dk (8.9.1/8.8.5) with ESMTP id NAA08288;
Tue, 24 Nov 1998 13:39:24 +0100 (CET)
To: Michael Ryan
cc: Garrett Wollman , freebsd-bugs@FreeBSD.ORG
Subject: Re: Y2K
In-reply-to: Your message of "Tue, 24 Nov 1998 11:30:07 PST."
Date: Tue, 24 Nov 1998 13:39:22 +0100
Message-ID: <8286.911911162@critter.freebsd.dk>
From: Poul-Henning Kamp
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
In message , Michael Ryan writes:
>I'm a consultant and charge my customer by the
>hour. Surely he's entitled to know whether the FreeBSD 2.2.5R he
>has in production is Y2K compliant or not instead of being forced
>to shell out a large amount of money for an upgrade, as would be
>warranted by acceptance of the above policy position?
1. The upgrade itself would be equally costly if he used a paid for
UNIX version, and he would have to pay for the new release on
top of that, so FreeBSD is cheaper, right ?
2. Any use of the concept "entitled to" in the context of free
software is sloppy thinking or at least sloppy analysis of the
relationship.
3. Who will pay for the time >we< spend trying to comprehensively
answer the y2k question, when nobody pays for the software in
the first place ?
4. An upgrade from 2.2.5 to 2.2.7 (or soon 2.2.8) can be done a
hole lot faster than a week, if the installation is documented
in the first place.
--
Poul-Henning Kamp FreeBSD coreteam member
phk@FreeBSD.ORG "Real hackers run -current on their laptop."
"ttyv0" -- What UNIX calls a $20K state-of-the-art, 3D, hi-res color terminal
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 05:59:24 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id FAA25013
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 05:59:24 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA25005
for ; Tue, 24 Nov 1998 05:59:23 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id GAA15836;
Tue, 24 Nov 1998 06:00:01 -0800 (PST)
Received: (from nobody@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id FAA24576;
Tue, 24 Nov 1998 05:52:40 -0800 (PST)
(envelope-from nobody)
Message-Id: <199811241352.FAA24576@hub.freebsd.org>
Date: Tue, 24 Nov 1998 05:52:40 -0800 (PST)
From: sdunn@npc.net
To: freebsd-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: www-1.0
Subject: i386/8843: panic: isa_dmacheck: no physical page present (mount_msdos /dev/fd0..)
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
>Number: 8843
>Category: i386
>Synopsis: panic: isa_dmacheck: no physical page present (mount_msdos /dev/fd0..)
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Nov 24 06:00:01 PST 1998
>Last-Modified:
>Originator: Scott Dunn
>Organization:
National Processing Company (NPC)
>Release: 3.0-19989804-SNAP (GENERIC) #0
>Environment:
FreeBSD year2000.y2k.net 3.0-19980804-SNAP FreeBSD 3.0-19980804-SNAP #0:
Tue Aug 4 10:23:17 GMT 1998
root@make.ican.net:/usr/src/sys/compile/GENERIC i386
>Description:
After formating, labeling, creating a new Unix file system and mounting
/dev/fd0, then doing the same for a msdos file system BSD 3.0 initiates
an auto reboot, with the following message:
panic: isa_dmacheck: no physical page present
syncing disks...111111111111111111 giving up Automatic reboot in 15 seconds
>How-To-Repeat:
1. fdformat /dev/fd0
2. disklabel -rw /dev/fd0 fd1440
3. newfs /dev/fd0
4. mount /dev/fd0 /mnt
5. umount /dev/fd0
6. fdformat /dev/fd0
7. disklabel -rw /dev/fd0 fd1440
8. newfs_msdos /dev/fd0
9. mount_msdos /dev/fd0 /mnt
Result: panic: isa_dmacheck: no physical page present ....see above
>Fix:
Nothing I know to fix the problem. This occurs on my Compaq Deskpro,
EN series 6266/3.2 DOM.
BSD reports the CPU like this at bootup:
CPU: Pentium II (266.62 Mhz 686 class CPU)
Feel free to contact me if I may be of assistance:
Scott Dunn, WAN Analyst
National Processing Company
(502) 315-4030
sdunn@npc.net
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 06:09:25 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id GAA26152
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 06:09:25 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id GAA26147
for ; Tue, 24 Nov 1998 06:09:24 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id GAA16321;
Tue, 24 Nov 1998 06:10:02 -0800 (PST)
Date: Tue, 24 Nov 1998 06:10:02 -0800 (PST)
Message-Id: <199811241410.GAA16321@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.ORG
From: Barry Tigner
Subject: Re: i386/8608: wdc1 is not detected on motherboards with Aladdin V chipsets
Reply-To: Barry Tigner
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
The following reply was made to PR i386/8608; it has been noted by GNATS.
From: Barry Tigner
To: freebsd-gnats-submit@freebsd.org, dgies@yikes.com
Cc: Subject: Re: i386/8608: wdc1 is not detected on motherboards with Aladdin V chipsets
Date: Tue, 24 Nov 1998 09:06:47 -0500
I can verify this happens with an ASUS P5A with an Aladdin chipset. The
probe can not find wdc1.
ASUS P5A (ATX) Mainboard with BIOS version 1005
AMD K6-2/350 cpu 192MB PC100 SDRAM
wdc0 master is Maxtor 10GB UDMA HD (jumpered as master)
wdc0 slave is Maxtor 4.3GB UDMA HD (jumpered as master)
wdc1 master is 24X EIDE CDROM (jumpered as master) (wdc1 not found so
this doesn't show up )
wdc1 slave -none-
The BIOS, W95, and WinNT all find all IDE devices and controllers ok.
FreeBSD 3.0 probe can't find
the wdc1 controller . I've heard that if you boot to the 2.2.7 install
floppy, that it's probe finds both
controllers, and that you can then boot to FreeBSD 3.0 ok.
This looks like a problem with /usr/src/sys/i386/isa/wd.c but I haven't
really go the faintest clue at this
time where it might be.
This system was working fine on a FIC PA2012 (ATX) mainboard with a VIA
chipset.
Barry
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 06:59:24 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id GAA00702
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 06:59:24 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id GAA00697
for ; Tue, 24 Nov 1998 06:59:23 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id HAA05260;
Tue, 24 Nov 1998 07:00:01 -0800 (PST)
Date: Tue, 24 Nov 1998 07:00:01 -0800 (PST)
Message-Id: <199811241500.HAA05260@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.ORG
From: Johan Karlsson
Subject: Re: misc/8761: [Please close]
Reply-To: Johan Karlsson
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
The following reply was made to PR misc/8761; it has been noted by GNATS.
From: Johan Karlsson
To: freebsd-gnats-submit@FreeBSD.ORG
Cc: Subject: Re: misc/8761: [Please close]
Date: Tue, 24 Nov 1998 15:59:05 +0100
Please close me, I'm fixed.
--
Johan Karlsson mailto:k@numeri.campus.luth.se
SWEDEN
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 08:19:33 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id IAA07004
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 08:19:33 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from sam.networx.ie (ts05-103.dublin.indigo.ie [194.125.220.113])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id IAA06986
for ; Tue, 24 Nov 1998 08:19:29 -0800 (PST)
(envelope-from mike@NetworX.ie)
Received: from mike (mike.NetworX.ie [194.9.12.33])
by sam.networx.ie (8.8.5/8.8.5) with SMTP id QAA20819;
Tue, 24 Nov 1998 16:06:36 GMT
X-Organisation: I.T. NetworX Ltd
X-Business: Network Applications, Consultancy and Training
X-Address: Stonebridge House, Shankill, Co. Dublin, Ireland
X-Voice: +353-1-28-27-233
X-Fax: +353-1-28-27-230
Date: Tue, 24 Nov 1998 16:12:29 PST
From: Michael Ryan
Subject: Re: Y2K
To: Poul-Henning Kamp
cc: Garrett Wollman , freebsd-bugs@FreeBSD.ORG
Message-ID:
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
On Tue, 24 Nov 1998 13:39:22 +0100 Poul-Henning Kamp wrote:
> 1. The upgrade itself would be equally costly if he used a paid for
> UNIX version, and he would have to pay for the new release on
> top of that, so FreeBSD is cheaper, right ?
Right, but you miss my point: inquire of any commercial Unix
vendor whether a particular release is Y2K compliant or not
and you'll get a straight answer. Based on this answer, the
customer mightn't need to do the upgrade, as his existing
product may be compliant.
> 2. Any use of the concept "entitled to" in the context of free
> software is sloppy thinking or at least sloppy analysis of the
> relationship.
I agree with you entirely on one level but disagree on another.
The FreeBSD Project encourages people and organisations to use
the FreeBSD operating system. Given this encouragement, the
user is 'entitled' to expect some things. For example, the
software should do its intended function most of the time.
Another thing he might reasonably expect (i.e. be entitled to) is
a statement of Y2K compliance, given that Y2K is a critical issue
when the box has been deployed in a production situation.
While there is certainly not the same onus on the FreeBSD Project
to support the product as there would be on a commercial supplier,
I would have thought that the Y2K issue would have been on the
minds of the developers for a release as recent as 2.2.5R and,
therefore, they would be aware of its Y2K compliance status.
Even if information as basic as "yes", "no" or "don't know" was
available for any particular release, this would help enormously.
But not providing any information other than the non-release
specific info on the web site is, I think, less than the user
is reasonably 'entitled to'. In the absence of any useful
information, any responsible user must assume the worst and
suffer the cost of an upgrade.
> 3. Who will pay for the time >we< spend trying to comprehensively
> answer the y2k question, when nobody pays for the software in
> the first place ?
I empathise with you but, as I said above, I would have thought
this was a current (going back two years) issue and thus, the
information would have been known for releases that have been
produced in that time-frame.
> 4. An upgrade from 2.2.5 to 2.2.7 (or soon 2.2.8) can be done a
> hole lot faster than a week, if the installation is documented
> in the first place.
I would reasonably expect (be entitled to think) that the upgrade
of the OS could be done in a few hours (this entitlement being
based on the assumption that the product hasn't changed completely
since the installation of 2.2.5R. But that's the easy part. The
hard part is verifying that all of the non-bundled systems and
applications software that makes this a useful production system
still works, and upgrading to and testing any component that is
seen not to work. Not to mention the down-time of a production
box while this is going on.
Bye,
Mike
mike@NetworX.ie
www.NetworX.ie
---
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 08:44:05 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id IAA09952
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 08:44:05 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.40.131])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id IAA09841
for ; Tue, 24 Nov 1998 08:43:57 -0800 (PST)
(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
by critter.freebsd.dk (8.9.1/8.8.5) with ESMTP id RAA09234;
Tue, 24 Nov 1998 17:42:19 +0100 (CET)
To: Michael Ryan
cc: Garrett Wollman , freebsd-bugs@FreeBSD.ORG
Subject: Re: Y2K
In-reply-to: Your message of "Tue, 24 Nov 1998 16:12:29 PST."
Date: Tue, 24 Nov 1998 17:42:18 +0100
Message-ID: <9232.911925738@critter.freebsd.dk>
From: Poul-Henning Kamp
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
Well, lets just say that I disagree a lot with you. The difference
clearly originating from the fact that you are getting paid whereas
I use my spare time.
First of, you should notice that 2.2.5R will be at least five
releases and 25 months old by the time we get to 31121999. We
already have three relases out (2.2.6, 2.2.7 & 3.0) with 2.2.8
scheduled and 3.0.1 sort of scheduled (jan 99), so we might even
manage to make it seven or eight releases old before the big party.
Second, we have released as comprehensive information as we have,
which, in my own dead-pan interpretation, says:
"UNIX doesn't care about y2k in general, but a few programs
have to take humanized dates as I/O, and they could have
a few soft spots, although what we have found is minimal,
but we'll continue to look".
Third, you have the source. If you can imagine any soft spots,
why don't you go look? That is the main difference from a bin-only
UNIX where you have to rely on the vendor to tell you what's under
the hood, you can go look for your self! You can even install
a test machine and try it out for yourself, there are no licenses
which restrict your freedom in any respect.
Fourth, if you had paid for a service contract, or even for the
product you use in the first place, I could understand some of your
reasoning, in particular if the source was not availble to you,
but considering the circumstances, I find your demands completely
unreasonable, your arguments inflated and pompous and your reason
in doubt.
Sincerely,
Poul-Henning
--
Poul-Henning Kamp FreeBSD coreteam member
phk@FreeBSD.ORG "Real hackers run -current on their laptop."
"ttyv0" -- What UNIX calls a $20K state-of-the-art, 3D, hi-res color terminal
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 08:49:28 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id IAA10747
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 08:49:28 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id IAA10590
for ; Tue, 24 Nov 1998 08:49:24 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id IAA10752;
Tue, 24 Nov 1998 08:50:02 -0800 (PST)
Received: (from nobody@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id IAA10187;
Tue, 24 Nov 1998 08:45:00 -0800 (PST)
(envelope-from nobody)
Message-Id: <199811241645.IAA10187@hub.freebsd.org>
Date: Tue, 24 Nov 1998 08:45:00 -0800 (PST)
From: support@uunet.ca
To: freebsd-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: www-1.0
Subject: i386/8847: /usr/sbin/syslogd stops logging
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
>Number: 8847
>Category: i386
>Synopsis: /usr/sbin/syslogd stops logging
>Confidential: no
>Severity: serious
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Nov 24 08:50:01 PST 1998
>Last-Modified:
>Originator: Support
>Organization:
Support
>Release: 2.2.6-RELEASE
>Environment:
FreeBSD machine.name 2.2.6-RELEASE FreeBSD 2.2.6-RELEASE #0: Wed Mar 25
02:2:49 GMT 1998 jkh@time.cdrom.com:/usr/src/sys/compile/GENERIC i386
>Description:
After a random period of time, syslog will stop logging but will
not exit. It must be killed and restarted manually. Oddly enough,
it *will* log itself being killed, but otherwise it logs nothing.
>How-To-Repeat:
Simply wait and log a whole *pile* of stuff. We're logging a lot
of stuff on one of these machines and syslogd seems to not handle
it very well. Considering upgrading machine to 3.0-RELEASE if no
workaround or patch information becomes available.
>Fix:
None, unless you consider restarting it manually a 'fix'.
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 09:49:41 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id JAA17878
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 09:49:41 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: (from jmb@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id JAA17842;
Tue, 24 Nov 1998 09:49:20 -0800 (PST)
(envelope-from jmb)
From: "Jonathan M. Bresler"
Message-Id: <199811241749.JAA17842@hub.freebsd.org>
Subject: Re: Y2K
In-Reply-To: <8286.911911162@critter.freebsd.dk> from Poul-Henning Kamp at "Nov 24, 98 01:39:22 pm"
To: phk@critter.freebsd.dk (Poul-Henning Kamp)
Date: Tue, 24 Nov 1998 09:49:20 -0800 (PST)
Cc: mike@NetworX.ie, wollman@khavrinen.lcs.mit.edu, freebsd-bugs@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL32 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
Poul-Henning Kamp wrote:
> In message , Michael Ryan writes:
>
> >I'm a consultant and charge my customer by the
> >hour. Surely he's entitled to know whether the FreeBSD 2.2.5R he
> >has in production is Y2K compliant or not instead of being forced
> >to shell out a large amount of money for an upgrade, as would be
> >warranted by acceptance of the above policy position?
>
> 1. The upgrade itself would be equally costly if he used a paid for
> UNIX version, and he would have to pay for the new release on
> top of that, so FreeBSD is cheaper, right ?
>
> 2. Any use of the concept "entitled to" in the context of free
> software is sloppy thinking or at least sloppy analysis of the
> relationship.
>
> 3. Who will pay for the time >we< spend trying to comprehensively
> answer the y2k question, when nobody pays for the software in
> the first place ?
>
> 4. An upgrade from 2.2.5 to 2.2.7 (or soon 2.2.8) can be done a
> hole lot faster than a week, if the installation is documented
> in the first place.
since FreeBSD-2.2.5, there have been a number of bug fixes.
These are available in FreeBSD-2.2.7 and soon to be
released (Nov 30th) FreeBSD-2.2.8.
Your customer is "entitled" to these bug fixes, is he not?
When you upgrade to fix those bugs, our Y2K statement
will apply to the resulting installtion of FreeBSD-2.2.[78]
jmb
--
Jonathan M. Bresler FreeBSD Core Team, Postmaster jmb@FreeBSD.ORG
FreeBSD--The Power to Serve JMB193 http://www.freebsd.org/
PGP 2.6.2 Fingerprint: 31 57 41 56 06 C1 40 13 C5 1C E3 E5 DC 62 0E FB
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 10:59:24 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id KAA23749
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 10:59:24 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA23742
for ; Tue, 24 Nov 1998 10:59:23 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id LAA18164;
Tue, 24 Nov 1998 11:00:01 -0800 (PST)
Date: Tue, 24 Nov 1998 11:00:01 -0800 (PST)
Message-Id: <199811241900.LAA18164@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.ORG
From: Alexander Viro
Subject: Re: bin/8790: [PATCH] Buffer overrun in nvi-1.79.
Reply-To: Alexander Viro
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
The following reply was made to PR bin/8790; it has been noted by GNATS.
From: Alexander Viro
To: David Greenman
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/8790: [PATCH] Buffer overrun in nvi-1.79.
Date: Tue, 24 Nov 1998 13:55:29 -0500 (EST)
Sorry for followup to myself, but:
*** lib/libc/regex/regcomp.c.old Tue Nov 24 13:45:54 1998
--- lib/libc/regex/regcomp.c Tue Nov 24 13:47:16 1998
***************
*** 613,619 ****
(void)REQUIRE(starordinary, REG_BADRPT);
/* FALLTHROUGH */
default:
! ordinary(p, c &~ BACKSL);
break;
}
--- 613,619 ----
(void)REQUIRE(starordinary, REG_BADRPT);
/* FALLTHROUGH */
default:
! ordinary(p, (char)c);
break;
}
That is, regex in libc has the same vulnerability. And libc _is_ used in
suid programs.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 11:42:15 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id LAA28229
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 11:42:15 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id LAA28121;
Tue, 24 Nov 1998 11:41:51 -0800 (PST)
(envelope-from ken@FreeBSD.org)
From: Kenneth Merry
Received: (from ken@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id LAA20861;
Tue, 24 Nov 1998 11:42:30 -0800 (PST)
Date: Tue, 24 Nov 1998 11:42:30 -0800 (PST)
Message-Id: <199811241942.LAA20861@freefall.freebsd.org>
To: k@numeri.campus.luth.se, ken@FreeBSD.ORG, freebsd-bugs@FreeBSD.ORG
Subject: Re: misc/8761
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
Synopsis: installworld fails for stable as of 981119
State-Changed-From-To: open-closed
State-Changed-By: ken
State-Changed-When: Tue Nov 24 11:41:34 PST 1998
State-Changed-Why:
The PR submitter requested that this bug report be closed, since his problem
has been fixed.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 14:58:55 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id OAA19040
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 14:58:55 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id OAA19033;
Tue, 24 Nov 1998 14:58:47 -0800 (PST)
(envelope-from ken@FreeBSD.org)
From: Kenneth Merry
Received: (from ken@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id OAA02047;
Tue, 24 Nov 1998 14:59:26 -0800 (PST)
Date: Tue, 24 Nov 1998 14:59:26 -0800 (PST)
Message-Id: <199811242259.OAA02047@freefall.freebsd.org>
To: aa8vb@pagesz.net, ken@FreeBSD.ORG, freebsd-bugs@FreeBSD.ORG,
ken@FreeBSD.ORG
Subject: Re: kern/8826
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
Synopsis: LINT bug with CAM pass devices
State-Changed-From-To: open-analyzed
State-Changed-By: ken
State-Changed-When: Tue Nov 24 14:58:20 PST 1998
State-Changed-Why:
I've looked at it, and it appears to be a bug. Don't have time to fix it
at the moment.
Responsible-Changed-From-To: freebsd-bugs->ken
Responsible-Changed-By: ken
Responsible-Changed-When: Tue Nov 24 14:58:20 PST 1998
Responsible-Changed-Why:
To remind me to fix this.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 15:09:24 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id PAA20275
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 15:09:24 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id PAA20267
for ; Tue, 24 Nov 1998 15:09:22 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id PAA02583;
Tue, 24 Nov 1998 15:10:00 -0800 (PST)
Received: from emmi.physik.TU-Berlin.DE (emmi.physik.TU-Berlin.DE [130.149.160.103])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id PAA20212
for ; Tue, 24 Nov 1998 15:08:05 -0800 (PST)
(envelope-from ibex@emmi.physik.TU-Berlin.DE)
Received: (from ibex@localhost)
by emmi.physik.TU-Berlin.DE (8.9.1/8.9.1) id AAA06642;
Wed, 25 Nov 1998 00:08:00 +0100 (CET)
(envelope-from ibex)
Message-Id: <199811242308.AAA06642@emmi.physik.TU-Berlin.DE>
Date: Wed, 25 Nov 1998 00:08:00 +0100 (CET)
From: Dirk Froemberg
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: kern/8851: mounting an unconfigured device causes a panic
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
>Number: 8851
>Category: kern
>Synopsis: mounting an unconfigured device causes a panic
>Confidential: no
>Severity: critical
>Priority: high
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Nov 24 15:10:00 PST 1998
>Last-Modified:
>Originator: Dirk Froemberg
>Organization:
>Release: FreeBSD 3.0-RELEASE i386
>Environment:
FreeBSD 3.0-RELEASE i386
>Description:
Mounting an unconfigured device (e. g. /dev/scd0a, /dev/wcd0a,
/dev/wfd0a) causes a panic.
>How-To-Repeat:
hal ROOT dirk 1003 (~): cat /dev/wfd0a
cat: /dev/wfd0a: Device not configured
hal ROOT dirk 1004 (~): mount /dev/wfd0a /mnt
Fatal trap 12: page fault while in kernel mode
fault virtual address = 0x42
fault code = supervisor read, page not present
instruction pointer = 0x8:0xf0190c2a
stack pointer = 0x10:0xf41f1db0
frame pointer = 0x10:0xf41f1e54
code segment = base 0x0, limit 0xfffff, type 0x1b
= DPL 0, pres 1, def32 1, gran 1
processor eflags = interrupt enabled, resume, IOPL = 0
current process = 250 (mount)
interrupt mask =
trap number = 12
panic: page fault
>Fix:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 16:27:08 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id QAA29979
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 16:27:08 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from varmail.net (varmail.net [203.46.50.11] (may be forged))
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id QAA29508;
Tue, 24 Nov 1998 16:24:25 -0800 (PST)
(envelope-from offer@varmail.net)
Received: from localhost (root@localhost)
by varmail.net (8.8.8/8.8.8) with SMTP id KAA08558;
Wed, 25 Nov 1998 10:22:43 +1000 (EST)
(envelope-from offer@varmail.net)
Date: Wed, 25 Nov 1998 10:22:43 +1000 (EST)
Received: by varmail.net (bulk_mailer v1.11); Wed, 25 Nov 1998 02:07:25 +1000
From: melanie@varmail.net
To: members@wetmelanie.com
Subject: A Great Selection of FREE Adult Sites!
Message-ID:
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
We have put together a list of 4 Great Adult sites
for your viewing pleasure, all FREE and exclusive.
Just click on http://www.varmail.net/1011/ to browse
the great, FREE content on offer.
Click Here
------------------------------------------------
You are receiving this message because you, or
someone pretending to be you, added your
contact address to our list.
To remove yourself from this mailing list
please reply to this message with "Remove"
in the subject field.
------------------------------------------------
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 19:39:23 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id TAA17508
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 19:39:23 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA17503
for ; Tue, 24 Nov 1998 19:39:23 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id TAA14186;
Tue, 24 Nov 1998 19:40:01 -0800 (PST)
Received: (from nobody@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id TAA17429;
Tue, 24 Nov 1998 19:38:34 -0800 (PST)
(envelope-from nobody)
Message-Id: <199811250338.TAA17429@hub.freebsd.org>
Date: Tue, 24 Nov 1998 19:38:34 -0800 (PST)
From: ser@intranet.ca
To: freebsd-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: www-1.0
Subject: conf/8854: boot.flp does not probe atapi cdrom
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
>Number: 8854
>Category: conf
>Synopsis: boot.flp does not probe atapi cdrom
>Confidential: no
>Severity: serious
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Nov 24 19:40:00 PST 1998
>Last-Modified:
>Originator: Gerard Ser
>Organization:
>Release: 3.0 Releas
>Environment:
p133 Intel (ide/isa)64mb ram, Hitachi cdr-7930 and Matshita CD-R cw-7582
>Description:
unlike its predecessor, the boot.flp of 3.0 release does not probe the
atapi cd rom. I HAD the 2.2.6RELEASE on my machine, I lost it and I can't
install the new one.
The message:'no CDROM...' while it's the same cdrom drive I used to install
the 2.2.6 release.
>How-To-Repeat:
>Fix:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 19:49:25 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id TAA18385
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 19:49:25 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA18376
for ; Tue, 24 Nov 1998 19:49:23 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id TAA14609;
Tue, 24 Nov 1998 19:50:01 -0800 (PST)
Received: from sax.sax.de (sax.sax.de [193.175.26.33])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA17569
for ; Tue, 24 Nov 1998 19:39:55 -0800 (PST)
(envelope-from hohmuth@olymp.sax.de)
Received: (from uucp@localhost)
by sax.sax.de (8.8.8/8.8.8) with UUCP id EAA04650
for FreeBSD-gnats-submit@freebsd.org; Wed, 25 Nov 1998 04:39:50 +0100 (CET)
(envelope-from hohmuth@olymp.sax.de)
Received: (from hohmuth@localhost)
by olymp.sax.de (8.8.8/8.8.8) id EAA00689;
Wed, 25 Nov 1998 04:33:25 +0100 (CET)
(envelope-from hohmuth)
Message-Id: <199811250333.EAA00689@olymp.sax.de>
Date: Wed, 25 Nov 1998 04:33:25 +0100 (CET)
From: hohmuth@inf.tu-dresden.de
Reply-To: hohmuth@inf.tu-dresden.de
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: i386/8855: can't mount CD in ATAPI drive after eject/reload
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
>Number: 8855
>Category: i386
>Synopsis: can't mount CD in ATAPI drive after eject/reload
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Nov 24 19:50:01 PST 1998
>Last-Modified:
>Originator: Michael Hohmuth
>Organization:
none
>Release: FreeBSD 2.2.7-STABLE i386
>Environment:
"uname -a" says:
FreeBSD olymp.sax.de 2.2.7-STABLE FreeBSD 2.2.7-STABLE #1:
Wed Nov 25 03:45:12 CET 1998
root@olymp.sax.de:/usr/src/sys/compile/OLYMPISDN i386
I've updated the atapi.c driver with some changes from
FreeBSD-current. This doesn't change the behaviour, though.
/var/log/dmesg.today contains:
wdc0 at 0x1f0-0x1f7 irq 14 on isa
wdc0: unit 0 (atapi): , removable
atapi0.0: unknown phase
/etc/fstab contains:
/dev/wcd0c /cdrom cd9660 ro,noauto 0 0
>Description:
I can't mount a CD-ROM inserted after the system has been booted:
# mount /cdrom
cd9660: /dev/cdrom: Input/output error
A CD-ROM which has been loaded before booting FreeBSD can be mounted
just fine.
Below I include some kernel output which shows a first "mount /cdrom"
which succeeds, an "umount", an eject/reload, and another "mount /cdrom"
which fails with an I/O error.
The "error=20" messages at the end of the output or the "atapi0.0:
unknown phase" message which appears at boot time maybe are connected
to the problem in some way?
# cdcontrol -f /dev/cdrom debug on
atapi0.0: req w 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd PREVENT_ALLOW 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
# mount /cdrom
atapi0.0: req w 0-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd TEST_UNIT_READY 0-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 43-0-0-0-0-0-0-0-c-0-0-0-0-0-0-0 len=12
atapi0.0: start
atapi0.0: send cmd READ_TOC 43-0-0-0-0-0-0-0-c-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x2, len=12, status=58, error=0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 43-0-0-0-0-0-0-0-c-0-0-0-0-0-0-0 len=12
atapi0.0: start
atapi0.0: send cmd READ_TOC 43-0-0-0-0-0-0-0-c-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x2, len=12, status=58, error=0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 25-0-0-0-0-0-0-0-8-0-0-0-0-0-0-0 len=8
atapi0.0: start
atapi0.0: send cmd READ_CAPACITY 25-0-0-0-0-0-0-0-8-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x2, len=8, status=58, error=0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 1e-0-0-0-1-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd PREVENT_ALLOW 1e-0-0-0-1-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd PREVENT_ALLOW 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 0-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd TEST_UNIT_READY 0-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 43-0-0-0-0-0-0-0-c-0-0-0-0-0-0-0 len=12
atapi0.0: start
atapi0.0: send cmd READ_TOC 43-0-0-0-0-0-0-0-c-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x2, len=12, status=58, error=0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 43-0-0-0-0-0-0-0-c-0-0-0-0-0-0-0 len=12
atapi0.0: start
atapi0.0: send cmd READ_TOC 43-0-0-0-0-0-0-0-c-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x2, len=12, status=58, error=0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 25-0-0-0-0-0-0-0-8-0-0-0-0-0-0-0 len=8
atapi0.0: start
atapi0.0: send cmd READ_CAPACITY 25-0-0-0-0-0-0-0-8-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x2, len=8, status=58, error=0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 1e-0-0-0-1-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd PREVENT_ALLOW 1e-0-0-0-1-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req cb 28-0-0-0-0-10-0-0-1-0-0-0-0-0-0-0 len=2048
atapi0.0: start
atapi0.0: send cmd READ_BIG 28-0-0-0-0-10-0-0-1-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x2, len=2048, status=58, error=0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req cb 28-0-0-0-0-26-0-0-1-0-0-0-0-0-0-0 len=2048
atapi0.0: start
atapi0.0: send cmd READ_BIG 28-0-0-0-0-26-0-0-1-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x2, len=2048, status=58, error=0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
# umount /cdrom
atapi0.0: req cb 28-0-0-0-0-26-0-0-1-0-0-0-0-0-0-0 len=2048
atapi0.0: start
atapi0.0: send cmd READ_BIG 28-0-0-0-0-26-0-0-1-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x2, len=2048, status=58, error=0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd PREVENT_ALLOW 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
# cdcontrol -f /dev/cdrom eject
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd PREVENT_ALLOW 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 0-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd TEST_UNIT_READY 0-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 43-0-0-0-0-0-0-0-c-0-0-0-0-0-0-0 len=12
atapi0.0: start
atapi0.0: send cmd READ_TOC 43-0-0-0-0-0-0-0-c-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x2, len=12, status=58, error=0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 43-0-0-0-0-0-0-0-c-0-0-0-0-0-0-0 len=12
atapi0.0: start
atapi0.0: send cmd READ_TOC 43-0-0-0-0-0-0-0-c-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x2, len=12, status=58, error=0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 25-0-0-0-0-0-0-0-8-0-0-0-0-0-0-0 len=8
atapi0.0: start
atapi0.0: send cmd READ_CAPACITY 25-0-0-0-0-0-0-0-8-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x2, len=8, status=58, error=0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 1e-0-0-0-1-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd PREVENT_ALLOW 1e-0-0-0-1-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd PREVENT_ALLOW 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 1b-1-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd START_STOP 1b-1-0-0-0-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd PREVENT_ALLOW 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 1b-0-0-0-2-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd START_STOP 1b-0-0-0-2-0-0-0-0-0-0-0-0-0-0-0
# cdcontrol -f /dev/cdrom close
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd PREVENT_ALLOW 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=50, error=0
atapi0.0: req w 0-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd TEST_UNIT_READY 0-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=51, error=20
atapi0.0: req w 1e-0-0-0-1-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd PREVENT_ALLOW 1e-0-0-0-1-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=51, error=20
atapi0.0: req w 0-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd TEST_UNIT_READY 0-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=51, error=20
atapi0.0: req w 1e-0-0-0-1-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd PREVENT_ALLOW 1e-0-0-0-1-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=51, error=20
atapi0.0: req w 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd PREVENT_ALLOW 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=51, error=20
atapi0.0: req w 0-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd TEST_UNIT_READY 0-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=51, error=20
atapi0.0: req w 1e-0-0-0-1-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd PREVENT_ALLOW 1e-0-0-0-1-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=51, error=20
atapi0.0: req w 1b-1-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd START_STOP 1b-1-0-0-0-0-0-0-0-0-0-0-0-0-0-0
# mount /cdrom
cd9660: /dev/cdrom: Input/output error
atapi0.0: req w 0-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd TEST_UNIT_READY 0-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=51, error=20
atapi0.0: req w 1e-0-0-0-1-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd PREVENT_ALLOW 1e-0-0-0-1-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=51, error=20
atapi0.0: req w 0-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd TEST_UNIT_READY 0-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=51, error=20
atapi0.0: req w 1e-0-0-0-1-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd PREVENT_ALLOW 1e-0-0-0-1-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=51, error=20
atapi0.0: req w 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd PREVENT_ALLOW 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=51, error=20
atapi0.0: req w 0-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd TEST_UNIT_READY 0-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=51, error=20
atapi0.0: req w 1e-0-0-0-1-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd PREVENT_ALLOW 1e-0-0-0-1-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=51, error=20
atapi0.0: req w 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
atapi0.0: start
atapi0.0: send cmd PREVENT_ALLOW 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0
atapi0.0: intr ireason=0x3, len=0, status=51, error=20
>How-To-Repeat:
The "mount" commands shown below assume that /etc/fstab contains
something like:
/dev/wcd0c /cdrom cd9660 ro,noauto 0 0
# cdcontrol -f /dev/cdrom debug on
# mount /cdrom
# umount /cdrom
# cdcontrol -f /dev/cdrom eject
# cdcontrol -f /dev/cdrom close
# mount /cdrom
cd9660: /dev/cdrom: Input/output error
>Fix:
Fix not known
Workaround: Reboot every time you want to mount a new CD-ROM :-(
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 20:46:42 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id UAA23408
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 20:46:42 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id UAA23396;
Tue, 24 Nov 1998 20:46:35 -0800 (PST)
(envelope-from jkoshy@FreeBSD.org)
From: Joseph Koshy
Received: (from jkoshy@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id UAA21333;
Tue, 24 Nov 1998 20:47:13 -0800 (PST)
Date: Tue, 24 Nov 1998 20:47:13 -0800 (PST)
Message-Id: <199811250447.UAA21333@freefall.freebsd.org>
To: andre.albsmeier@mchp.siemens.de, jkoshy@FreeBSD.ORG,
freebsd-bugs@FreeBSD.ORG
Subject: Re: bin/7803
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
Synopsis: timeout in scsiformat to small
State-Changed-From-To: open-closed
State-Changed-By: jkoshy
State-Changed-When: Tue Nov 24 20:45:29 PST 1998
State-Changed-Why:
Patch committed to rev 1.1.4.5 of "src/sbin/scsiformat/scsiformat.sh", thanks!
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 21:18:30 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id VAA26060
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 21:18:30 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from websmtp1.bellsouth.bigfoot.com (websmtp1.bellsouth.bigfoot.com [208.156.60.91])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA26054
for ; Tue, 24 Nov 1998 21:18:28 -0800 (PST)
(envelope-from publish007@webmail.bellsouth.com)
From: publish007@webmail.bellsouth.com
Received: from default (171-210-58.ipt.aol.com [152.171.210.58])
by websmtp1.bellsouth.bigfoot.com (8.9.1/8.8.5) with SMTP id AAA14063;
Wed, 25 Nov 1998 00:18:31 -0500 (EST)
Date: Wed, 25 Nov 1998 00:18:31 -0500 (EST)
Subject: New Book: "Brothers Beware: Games Black Women Play"
Message-Id:
Content-Type: TEXT/PLAIN charset=US-ASCII
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
To: undisclosed-recipients:;
Sisters are saying: "Burn This Book"
Brothers are saying: "Free at Last!"
You decide . . .
Call Today To Order This Book - (800) 830-2047
It will make a great Christmas Gift
Brothers Beware:
Games Black Women Play
by
A. Marshall
ISBN:0-9658299-3-6
Price: $12.00
$3 Shipping - COD Charges are FREE for a limited time.
____________________________
Brothers Beware: Games Black Women Play is a book that
pulls no punches when it details the many tricks and
manipulative games for which black women are notorious.
This book is an honest, no holds barred, uncensored
discussion about dating in the African American community.
The number of eligible black men is constantly decreasing.
Therefore, black women are doing whatever is necessary to
find and keep a good black man. Many of her secrets are
exposed in this book.
The author interviewed several black women who revealed
many of the techniques used by Sisters to get what they
want, and who they want, any time they want. These women
were especially helpful on the hilarious chapter entitled:
"Games Women Play On Each Other."
The author had no need whatsoever to embellish -
The TRUTH was definitely sensational enough.
____________________________
Chapters
"Was She Born This Way?"
"What He Has Have To Be With Her"
"What Have You Done For Me Lately?"
"Lies Women Tell Men"
"She's Got The Power"
"The Dating Game"
"The Sympathy Game"
"The Suicide Game"
"Honey, I'm Pregnant"
"She Loves Me . . . She Loves Me Not"
"Games Church Women Play"
"Young Women and Old Fools"
"Games Women Play on Each Other"
"Was It Really Worth It?"
_______________________________
Ordering Information
Brothers Beware:
Games Black Women Play
ISBN:0-9658299-3-6
Price: $12.00
$3.00 Shipping - COD Charges are free for a limited time.
Wholesale Discounts Available
______________________________
Order by Phone
800-830-2047 - 24 hrs
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 23:29:24 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id XAA05505
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 23:29:24 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA05493
for ; Tue, 24 Nov 1998 23:29:23 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id XAA28261;
Tue, 24 Nov 1998 23:30:01 -0800 (PST)
Date: Tue, 24 Nov 1998 23:30:01 -0800 (PST)
Message-Id: <199811250730.XAA28261@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.ORG
From: Andre Albsmeier
Subject: Re: bin/8730: repquota output needs new formatting (diffs included)
Reply-To: Andre Albsmeier
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
The following reply was made to PR bin/8730; it has been noted by GNATS.
From: Andre Albsmeier
To: freebsd-gnats-submit@freebsd.org
Cc: Subject: Re: bin/8730: repquota output needs new formatting (diffs included)
Date: Wed, 25 Nov 1998 08:19:40 +0100
The following patch is much better. It assures that the output
remains easily parseable by shell scripts even if the formatting
overflows. Thanks to Joseph Koshy for pointing me to this!
--- repquota.c.ORI Mon Mar 9 20:07:46 1998
+++ repquota.c Wed Nov 25 08:07:24 1998
@@ -216,8 +216,8 @@
fup->fu_dqblk = dqbuf;
}
fclose(qf);
- printf(" Block limits File limits\n");
- printf("User used soft hard grace used soft hard grace\n");
+ printf(" Block limits File limits\n");
+ printf("User used soft hard grace used soft hard grace\n");
for (id = 0; id <= highid[type]; id++) {
fup = lookup(id, type);
if (fup == 0)
@@ -226,7 +226,7 @@
fup->fu_dqblk.dqb_curblocks == 0)
continue;
printf("%-10s", fup->fu_name);
- printf("%c%c%8lu%8lu%8lu%7s",
+ printf("%c%c %8lu %8lu %8lu %6s",
fup->fu_dqblk.dqb_bsoftlimit &&
fup->fu_dqblk.dqb_curblocks >=
fup->fu_dqblk.dqb_bsoftlimit ? '+' : '-',
@@ -240,7 +240,7 @@
fup->fu_dqblk.dqb_curblocks >=
fup->fu_dqblk.dqb_bsoftlimit ?
timeprt(fup->fu_dqblk.dqb_btime) : "");
- printf(" %6lu%6lu%6lu%7s\n",
+ printf(" %7lu %7lu %7lu %6s\n",
fup->fu_dqblk.dqb_curinodes,
fup->fu_dqblk.dqb_isoftlimit,
fup->fu_dqblk.dqb_ihardlimit,
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 23:29:25 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id XAA05509
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 23:29:25 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA05498
for ; Tue, 24 Nov 1998 23:29:23 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id XAA28272;
Tue, 24 Nov 1998 23:30:01 -0800 (PST)
Received: (from nobody@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id XAA05439;
Tue, 24 Nov 1998 23:27:14 -0800 (PST)
(envelope-from nobody)
Message-Id: <199811250727.XAA05439@hub.freebsd.org>
Date: Tue, 24 Nov 1998 23:27:14 -0800 (PST)
From: info@highwind.com
To: freebsd-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: www-1.0
Subject: kern/8858: man page for accept() is flawed
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
>Number: 8858
>Category: kern
>Synopsis: man page for accept() is flawed
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Nov 24 23:30:01 PST 1998
>Last-Modified:
>Originator: Robert Fleischman
>Organization:
HighWind Software, Inc.
>Release: 3.0
>Environment:
>Description:
The accept() man page doesn't say it can return EINTR, however,
the libc_r source code (uthread_accept.c) can (and does) return
EINTR.
>How-To-Repeat:
>Fix:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
From owner-freebsd-bugs Tue Nov 24 23:59:25 1998
Return-Path:
Received: (from majordom@localhost)
by hub.freebsd.org (8.8.8/8.8.8) id XAA07800
for freebsd-bugs-outgoing; Tue, 24 Nov 1998 23:59:25 -0800 (PST)
(envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA07795
for ; Tue, 24 Nov 1998 23:59:23 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.8.8/8.8.5) id AAA29806;
Wed, 25 Nov 1998 00:00:01 -0800 (PST)
Date: Wed, 25 Nov 1998 00:00:01 -0800 (PST)
Message-Id: <199811250800.AAA29806@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.ORG
From: Søren Schmidt
Subject: Re: i386/8855: can't mount CD in ATAPI drive after eject/reload
Reply-To: Søren Schmidt
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org
The following reply was made to PR i386/8855; it has been noted by GNATS.
From: Søren Schmidt
To: hohmuth@inf.tu-dresden.de
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: i386/8855: can't mount CD in ATAPI drive after eject/reload
Date: Wed, 25 Nov 1998 08:53:53 +0100 (CET)
It seems hohmuth@inf.tu-dresden.de wrote:
Try this patch see if it helps:
Index: atapi.c
===================================================================
RCS file: /home/ncvs/src/sys/i386/isa/atapi.c,v
retrieving revision 1.27
diff -u -r1.27 atapi.c
--- atapi.c 1998/09/24 10:41:13 1.27
+++ atapi.c 1998/11/25 07:53:12
@@ -664,8 +664,8 @@
*/
int atapi_wait_cmd (struct atapi *ata, struct atapicmd *ac)
{
- /* Wait for DRQ from 50 usec to 3 msec for slow devices */
- int cnt = ata->intrcmd ? 10000 : ata->slow ? 3000 : 50;
+ /* Wait for DRQ from 100 usec to 3 msec for slow devices */
+ int cnt = ata->intrcmd ? 10000 : ata->slow ? 3000 : 100;
int ireason = 0, phase = 0;
/* Wait for command phase. */
>
> >Number: 8855
> >Category: i386
> >Synopsis: can't mount CD in ATAPI drive after eject/reload
> >Confidential: no
> >Severity: serious
> >Priority: medium
> >Responsible: freebsd-bugs
> >State: open
> >Quarter:
> >Keywords:
> >Date-Required:
> >Class: sw-bug
> >Submitter-Id: current-users
> >Arrival-Date: Tue Nov 24 19:50:01 PST 1998
> >Last-Modified:
> >Originator: Michael Hohmuth
> >Organization:
> none
> >Release: FreeBSD 2.2.7-STABLE i386
> >Environment:
>
> "uname -a" says:
>
> FreeBSD olymp.sax.de 2.2.7-STABLE FreeBSD 2.2.7-STABLE #1:
> Wed Nov 25 03:45:12 CET 1998
> root@olymp.sax.de:/usr/src/sys/compile/OLYMPISDN i386
>
> I've updated the atapi.c driver with some changes from
> FreeBSD-current. This doesn't change the behaviour, though.
>
> /var/log/dmesg.today contains:
>
> wdc0 at 0x1f0-0x1f7 irq 14 on isa
> wdc0: unit 0 (atapi): , removable
> atapi0.0: unknown phase
>
> /etc/fstab contains:
> /dev/wcd0c /cdrom cd9660 ro,noauto 0 0
>
>
> >Description:
>
> I can't mount a CD-ROM inserted after the system has been booted:
>
> # mount /cdrom
> cd9660: /dev/cdrom: Input/output error
>
> A CD-ROM which has been loaded before booting FreeBSD can be mounted
> just fine.
>
> Below I include some kernel output which shows a first "mount /cdrom"
> which succeeds, an "umount", an eject/reload, and another "mount /cdrom"
> which fails with an I/O error.
>
> The "error=20" messages at the end of the output or the "atapi0.0:
> unknown phase" message which appears at boot time maybe are connected
> to the problem in some way?
>
>
> # cdcontrol -f /dev/cdrom debug on
>
> atapi0.0: req w 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
> atapi0.0: start
> atapi0.0: send cmd PREVENT_ALLOW 1e-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0
> atapi0.0: intr ireason=0x3, len=0, status=50, error=0
>
> # mount /cdrom
>
> atapi0.0: req w 0-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0 len=0
> atapi0.0: start
> atapi0.0: send cmd TEST_UNIT_READY 0-0-0-0-0-0-0-0-0-0-0-0-0-0-0-0
> atapi0.0: intr ireason=0x3, len=0, status=50, error=0
> atapi0.0: req w 43-0-0-0-0-0-0-0-c-0-0-0-0-0-0-0 len=12
> atapi0.0: start
> atapi0.0: send cmd READ_TOC 43-0-0-0-0-0-0-0-c-0-0-0-0-0-0-0
> atapi0.0: intr ireason=0x2, len=12, status=58, error=0
> atapi0.0: intr ireason=0x3, len=0, status=50, error=0
> atapi0.0: req w 43-0-0-0-0-0-0-0-c-0-0-0-0-0-0-0 len=12
> atapi0.0: start
> atapi0.0: send cmd READ_TOC 43-0-0-0-0-0-0-0-c-0-0-0-0-0-0-0
> atapi0.0: intr ireason=0x2, len=12, status=58