From owner-freebsd-current Sun Feb 15 00:18:43 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id AAA20631 for freebsd-current-outgoing; Sun, 15 Feb 1998 00:18:43 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from time.cdrom.com (root@time.cdrom.com [204.216.27.226]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA20624 for ; Sun, 15 Feb 1998 00:18:41 -0800 (PST) (envelope-from jkh@time.cdrom.com) Received: from time.cdrom.com (jkh@localhost.cdrom.com [127.0.0.1]) by time.cdrom.com (8.8.8/8.6.9) with ESMTP id AAA20249; Sun, 15 Feb 1998 00:18:45 -0800 (PST) To: Chris Csanady cc: freebsd-current@FreeBSD.ORG Subject: Re: CCD missing spl() call.. In-reply-to: Your message of "Sat, 14 Feb 1998 22:31:08 CST." <199802150431.WAA00428@friley585.res.iastate.edu> Date: Sun, 15 Feb 1998 00:18:45 -0800 Message-ID: <20245.887530725@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > There is also a off by one error in the handling of the > partitions. Credit goes to OpenBSD for these. There are > numerous other changes that would be worth integrating > as well.. [Not just to you, but also to Terry and those others who still see some merit in submitting changes this way] These would go best as PRs since stuff sent to the -current mailing list often go into the bit-bucket. Stuff sent to the PR database often goes into the bit-bucket as well, admittedly but at least: A) It's easier to search the PR database than it is through thousands of -current mails for the occasional forgotten fix. B) There's an active PR-meister to handle the untended PRs whereas noone is signed up to perform such a function for the mailing lists. C) It's easier for me and others to close a PR and let the PR system tell the submitter that it's been attended to than it is for us to play cut-and-paste with email messages so that the same function can be done manually. Both of your submitted fixes have been applied, thanks! Jordan > > Chris > > *** ccd.c.old Sat Feb 14 22:27:17 1998 > --- ccd.c Sat Feb 14 20:27:12 1998 > *************** > *** 631,637 **** > ccdgetdisklabel(dev); > > /* Check that the partition exists. */ > ! if (part != RAW_PART && ((part > lp->d_npartitions) || > (lp->d_partitions[part].p_fstype == FS_UNUSED))) { > error = ENXIO; > goto done; > --- 631,637 ---- > ccdgetdisklabel(dev); > > /* Check that the partition exists. */ > ! if (part != RAW_PART && ((part >= lp->d_npartitions) || > (lp->d_partitions[part].p_fstype == FS_UNUSED))) { > error = ENXIO; > goto done; > *************** > *** 973,978 **** > --- 973,979 ---- > register int unit = cbp->cb_unit; > int count, s; > > + s = splbio(); > #ifdef DEBUG > if (ccddebug & CCDB_FOLLOW) > printf("ccdiodone(%x)\n", cbp); > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message