From owner-freebsd-ports Thu Jan 1 08:45:30 1998 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id IAA20119 for ports-outgoing; Thu, 1 Jan 1998 08:45:30 -0800 (PST) (envelope-from owner-freebsd-ports) Received: from limbo.rtfm.net (nathan@rtfm.net [204.141.125.38]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id IAA20097; Thu, 1 Jan 1998 08:45:14 -0800 (PST) (envelope-from nathan@limbo.rtfm.net) Received: (from nathan@localhost) by limbo.rtfm.net (8.8.8/8.8.6) id LAA13712; Thu, 1 Jan 1998 11:44:52 -0500 (EST) Message-ID: <19980101114452.44816@rtfm.net> Date: Thu, 1 Jan 1998 11:44:52 -0500 From: Nathan Dorfman To: Bruce Evans Cc: freebsd-bugs@FreeBSD.ORG, jmg@FreeBSD.ORG, freebsd-ports@FreeBSD.ORG Subject: Re: misc/5403 References: <199801010711.SAA09791@godzilla.zeta.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.88 In-Reply-To: <199801010711.SAA09791@godzilla.zeta.org.au>; from Bruce Evans on Thu, Jan 01, 1998 at 06:11:23PM +1100 Sender: owner-freebsd-ports@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Thu, Jan 01, 1998 at 06:11:23PM +1100, Bruce Evans wrote: > >Synopsis: is now broken > > > >State-Changed-From-To: open-closed > >State-Changed-By: jmg > >State-Changed-When: Wed Dec 31 14:01:33 PST 1997 > >State-Changed-Why: > >the program's buggy... have it include net/slcompress.h before > >net/if_slvar.h > > It should include neither of these private kernel headers. > > >I actually just checked the logs... if_slvar.h NEVER included > >net/slcompress.h, so it was never broken... > > It was broken in another way - a struct was declared wrong unless > INET was #defined. if_slvar.h is a prerequisite if INET is #defined. > Applications (slstart, startslip and now trafshow) know nothing of this > and didn't even notice the problem since they don't actually use > anything in if_slvar.h. Yeah, this port's #include list is very broken. All of these (incompatible?) headers that it includes need a certain order and shuffling them around fixes one compiler error and generates another. Someone really should take a look at /usr/ports/net/trafshow. > Bruce -- ________________ _______________________________ / Nathan Dorfman V PGP: finger nathan@rtfm.net / / nathan@rtfm.net | http://www.rtfm.net /