From owner-freebsd-hackers Sun Jul 25 0:33:10 1999 Delivered-To: freebsd-hackers@freebsd.org Received: from apollo.backplane.com (apollo.backplane.com [209.157.86.2]) by hub.freebsd.org (Postfix) with ESMTP id 98689150A6 for ; Sun, 25 Jul 1999 00:33:08 -0700 (PDT) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.9.3/8.9.1) id AAA37426; Sun, 25 Jul 1999 00:30:44 -0700 (PDT) (envelope-from dillon) Date: Sun, 25 Jul 1999 00:30:44 -0700 (PDT) From: Matthew Dillon Message-Id: <199907250730.AAA37426@apollo.backplane.com> To: "David E. Cross" Cc: freebsd-hackers@FreeBSD.ORG, crossd@cs.rpi.edu Subject: Re: mbuf leak found... for real this time. References: <199907241935.PAA13884@cs.rpi.edu> Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG :> between NFSv2 and NFSv3. :Yes, I concur with your patch whole-heartedly. Apparently last night I :was too-tired, and not intoxicated enough to understand the nfs_serv.c code :) : :I alas will not be able to test it. The machine is up and stable with 3k :mbufs in reserve.. maybe later :) : :As an aside, what about getting rid of that mbuf leak if a nfs-service :routine returns with error!=0? : :-- :David Cross | email: crossd@cs.rpi.edu Well, theoretically we just free the mbuf in the error case within nfs_syscalls.c/nfssvc_nfsd(), around line 661 (STABLE), or 650 (CURRENT). Realistically every single nfs server procedure would need to be audited to make sure that a non-NULL *mreq is valid in all error cases - not something I particularly want to do without commit privs from a crediting point of view. -Matt Matthew Dillon To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message