Date: Sat, 30 Jan 1999 23:57:31 -0800 (PST) From: Julian Elischer <julian@whistle.com> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: Archie Cobbs <archie@whistle.com>, net@FreeBSD.ORG Subject: Re: netgraph... Message-ID: <Pine.BSF.4.05.9901302347110.348-100000@s204m82.isp.whistle.com> In-Reply-To: <12974.917768494@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
The key I think poul is that NGM_ASCII_CTRL_MSG can be implemented in the Generic code, using NGM_ENCODE_ASCII and will be about as efficient as implementing NGM_ASCII_CTRL_MSG in each node. In fact I think archie has a point there.. it can probably be implemented more efficiently, because the binary interface is the only one that does any work, and the code that takes the translated message and turns it around to be fed back into the node is in the generic code and doesn't need to be duplicated. I think it may be easier to do NGM_TEXT_STATUS using a few sprintf() but for the othe rdirection text -> binary, archies scheme has some merrit. As an asside, I've completed patches to turn any ethernet interface into a netgraph node. you can feed a binary ethernet frame onto the wire by sending it to the node, and you can recieve one of two things depending on what has been set up.. 1/ packets that are not calmed by any standard protocol or 2/ all packets. This is "just for fun"but may be useful for something.. On Sun, 31 Jan 1999, Poul-Henning Kamp wrote: > In message <199901302121.NAA10729@bubba.whistle.com>, Archie Cobbs writes: > >Poul-Henning Kamp writes: > >> Yeah, I saw it, and I'm convince that no matter how smart we do it, > >> it will end up being almost enough, and take up just as much space > >> to code. > > > >That's what I said too. Also, why invent a new language for > >specifying the translation? That's another step away from KISS. > > > >Anyway, I think we almost all agree :-) See how this sounds. > > > >We add three new control messages: > > > > NGM_ASCII_CTRL_MSG > > NGM_ENCODE_ASCII > > NGM_DECODE_ASCII > > > >NGM_ASCII_CTRL_MSG takes an ASCII formatted control message as argument. > >The node parses it and takes the corresponding action. > > Agree. > > >NGM_ENCODE_ASCII and NGM_DECODE_ASCII convert between ASCII and > >binary formats for a control message. > > Still not sure about these. I think debugging decoding belongs > in userspace. > > -- > Poul-Henning Kamp FreeBSD coreteam member > phk@FreeBSD.ORG "Real hackers run -current on their laptop." > FreeBSD -- It will take a long time before progress goes too far! > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.05.9901302347110.348-100000>